clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ic16d6d63213bbdd91fcb8f5aa986b66865efda2f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-tidy: Enable readability-redundant-string-cstr check

This check finds unnecessary calls to std::string::c_str() and
std::string::data().

Change-Id: I43e747b95eb042650668da7dd57a8d4b8463426a
S

clang-tidy: Enable readability-redundant-string-cstr check

This check finds unnecessary calls to std::string::c_str() and
std::string::data().

Change-Id: I43e747b95eb042650668da7dd57a8d4b8463426a
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable readability-simplify-boolean-expr check

This checks for boolean expressions involving boolean constants
and simplifies them to use the appropriate boolean expression
directly.

Ch

clang-tidy: Enable readability-simplify-boolean-expr check

This checks for boolean expressions involving boolean constants
and simplifies them to use the appropriate boolean expression
directly.

Change-Id: I4ad7ec4ddfa4cfe9a0cf0d569d3d81c478c1776a
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable clang-analyzer-deadcode.DeadStores check

This checks for values stored to variables that are never
read afterwards.
The change is made to avoid flagging this error when a unique_p

clang-tidy: Enable clang-analyzer-deadcode.DeadStores check

This checks for values stored to variables that are never
read afterwards.
The change is made to avoid flagging this error when a unique_ptr
is used rather make it a stack variable. The clang-tidy don't like
the unused unique_ptr specifically rather than the unused class
instance.

Change-Id: I1c5a6b4032de75b7c8586467425f6fdacace5f31
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable modernize-use-override check

This check adds override (introduced in C++11) to overridden
virtual functions and removes virtual from those functions as it
is not required.

Change

clang-tidy: Enable modernize-use-override check

This check adds override (introduced in C++11) to overridden
virtual functions and removes virtual from those functions as it
is not required.

Change-Id: I156fc5796ed1cf451491e446c211172f62316ecc
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

use fs.copyfile instead of deprecated copy

copy arg in configure_file API is deprecated since meson
version 0.64.0. As we moved to meson version 1.1.1 we can
leverage the filesystem module copyfile(

use fs.copyfile instead of deprecated copy

copy arg in configure_file API is deprecated since meson
version 0.64.0. As we moved to meson version 1.1.1 we can
leverage the filesystem module copyfile() to achieve the
same result.

Tested by: Built the repo without any warning.

Change-Id: Ib4f44b535f8912ba53dcb5911a43569f2edbb8ef
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

phosphor-host-condition-gpio: enable multi-host support

The current implementation fails with:

```
[ 18.664351] systemd[1]: phosphor-host-condition-gpio@1.service: Two services allocated for the

phosphor-host-condition-gpio: enable multi-host support

The current implementation fails with:

```
[ 18.664351] systemd[1]: phosphor-host-condition-gpio@1.service: Two services allocated for the same bus name xyz.openbmc_project.State.HostCondition.Gpio, refusing operation.
```

Add the host id into the reserved bus name to avoid collisions.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia4f291d20df913d3f506d976a961a770a81724fc

show more ...

remove unnecessary boost calls

There were two references to boost in the codebase:
- An unused header included.
- A 'reverse' operation that now exists in std.

Update them accordingly to make t

remove unnecessary boost calls

There were two references to boost in the codebase:
- An unused header included.
- A 'reverse' operation that now exists in std.

Update them accordingly to make the boost dependency unnecessary.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie30d889e965885fecf804cdead34b27b090216e5

show more ...

sdbus++: use non-deprecated namespaces

The sdbusplus repository has deprecated some namespaces and they are
currently only enabled with the SDBUSPP_REMOVE_DEPRECATED_NAMESPACE
guard. Switch to the

sdbus++: use non-deprecated namespaces

The sdbusplus repository has deprecated some namespaces and they are
currently only enabled with the SDBUSPP_REMOVE_DEPRECATED_NAMESPACE
guard. Switch to the new namespace names.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9f67e74a02616d8ea2241c18758308f2b669672d

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I41103c892db258a85640aa1442acd9a295c8a847

show more ...

Support checking host status via GPIO pins

Currently, openBmc supports checking host status via ipmi and PLDM
method. However, not all of platforms support IPMI and PLDM. Some
platforms, like Ampere

Support checking host status via GPIO pins

Currently, openBmc supports checking host status via ipmi and PLDM
method. However, not all of platforms support IPMI and PLDM. Some
platforms, like Ampere Mt.Jade checks input GPIO to detect Host
firmware boot status. This commit supports Dbus method to check host
status via GPIO pins, it checks the value of "host0-ready/-n" pin to
detect HOST is ready or not.

Tested:
1. Update GPIO pin to detect host0 ready to "host0-ready"
in the device tree.
2. Enable host-gpios option and add executable and service
files to openBmc software then flash to the board.
3. In the BMC console, check host-gpio-condition via command
"busctl tree xyz.openbmc_project.State.HostCondition.Gpio"
Result as below:
`-/xyz
`-/xyz/openbmc_project
`-/xyz/openbmc_project/Gpios
`-/xyz/openbmc_project/Gpios/host0
4. Turn on/off the HOST0 then check the host status via
command
"busctl get-property \
xyz.openbmc_project.State.HostCondition.Gpio \
/xyz/openbmc_project/Gpios/host0 \
xyz.openbmc_project.Condition.HostFirmware \
CurrentFirmwareCondition"
Result as below:
"xyz.openbmc_project.Condition.HostFirmware.\
FirmwareCondition.<Running/Off>"

Signed-off-by: Thang Tran <thuutran@amperecomputing.com>
Change-Id: I20e38e76c5b70119f0c86e5b497d47453d7c5a6c

show more ...