clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers readability-static-accessed-through
-instance check as we are trying to access a static member
function through an instance.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I6c06c61e8f199247e74aca3443741683e3853274

show more ...

clang-tidy: Enable readability-string-compare check

This check finds string comparisons using the compare method.
A common mistake is to use the string’s compare method instead of
using the equality

clang-tidy: Enable readability-string-compare check

This check finds string comparisons using the compare method.
A common mistake is to use the string’s compare method instead of
using the equality or inequality operators.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I9d4b8aad27fa34345d08d2ba326b8a31cd3d99c6

show more ...

clang-tidy: Enable readability-uppercase-literal-suffix check

cert-dcl16-c redirects here as an alias for this check. By default,
only the suffixes that begin with l (l, ll, lu, llu, but not u, ul,

clang-tidy: Enable readability-uppercase-literal-suffix check

cert-dcl16-c redirects here as an alias for this check. By default,
only the suffixes that begin with l (l, ll, lu, llu, but not u, ul,
ull) are diagnosed by that alias.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I180ee3e3274899c63181f69a14f158319f178f0c

show more ...

clang-tidy: Enable readability-make-member-function-const check

Finds non-static member functions that can be made const because the
functions don’t use this in a non-const way.

Signed-off-by: Geor

clang-tidy: Enable readability-make-member-function-const check

Finds non-static member functions that can be made const because the
functions don’t use this in a non-const way.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Iff3a367401d571f9fcff90539aaab59e2c66e627

show more ...

clang-tidy: Enable readability checks on repo

The readability-* checks in Clang-Tidy focus on improving code
readability by enforcing guidelines and suggesting improvements
that can enhance the clar

clang-tidy: Enable readability checks on repo

The readability-* checks in Clang-Tidy focus on improving code
readability by enforcing guidelines and suggesting improvements
that can enhance the clarity and maintainability of C++ code.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: If69d468f6303df4ec782a3b7c7453a60ddae1e4e

show more ...

clang-tidy: Enable performance-unnecessary-value-param check

This check flags value parameter declarations of expensive to copy
types that are copied for each invocation but it would suffice to
pass

clang-tidy: Enable performance-unnecessary-value-param check

This check flags value parameter declarations of expensive to copy
types that are copied for each invocation but it would suffice to
pass them by const reference.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia287488c3bbe1a64e05760cbece119456d8f82f3

show more ...

clang-tidy: Enable performance-inefficient-vector-operation check

Finds possible inefficient std::vector operations (e.g. push_back,
emplace_back) that may cause unnecessary memory reallocations.

I

clang-tidy: Enable performance-inefficient-vector-operation check

Finds possible inefficient std::vector operations (e.g. push_back,
emplace_back) that may cause unnecessary memory reallocations.

It can also find calls that add element to protobuf repeated field in
a loop without calling Reserve() before the loop. Calling Reserve()
first can avoid unnecessary memory reallocations.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I442c3aac7e3c71abbb125ae6bcdbe3f8995d14e9

show more ...

clang-tidy: Enable performance-faster-string-find check

This check optimizes the calls to std::string::find() when the
input passed is a single character string literal. The character
literal overlo

clang-tidy: Enable performance-faster-string-find check

This check optimizes the calls to std::string::find() when the
input passed is a single character string literal. The character
literal overload is more efficient.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I72ae6f1506d2298a067e6463bd3718d64d23fdb2

show more ...

clang-tidy: Add performance checks

The checks are valuable for improving the runtime efficiency and
resource utilization of your programs.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-

clang-tidy: Add performance checks

The checks are valuable for improving the runtime efficiency and
resource utilization of your programs.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: If3750c67d40ce482e3f68bad384395b166ed07c9

show more ...

clang-tidy: clang-tidy: Add few misc checks

Checks that encompass various miscellaneous guidelines and rules
that don't fall into more specific categories like readability,
performance, or correctne

clang-tidy: clang-tidy: Add few misc checks

Checks that encompass various miscellaneous guidelines and rules
that don't fall into more specific categories like readability,
performance, or correctness. These checks often focus on code
quality, stylistic preferences, or potential pitfalls that are
not covered by other specific checks.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I4074c495a61e0804ed375e402756ac84abdfc598

show more ...

clang-tidy: Enable cppcoreguidelines-special-member-functions

The check finds classes where some but not all of the special member
functions are defined.

By default the compiler defines a copy cons

clang-tidy: Enable cppcoreguidelines-special-member-functions

The check finds classes where some but not all of the special member
functions are defined.

By default the compiler defines a copy constructor, copy assignment
operator, move constructor, move assignment operator and destructor.
The default can be suppressed by explicit user-definitions. The
relationship between which functions will be suppressed by
definitions of other functions is complicated and it is advised that
all five are defaulted or explicitly defined.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Icbfd448b2bf78ebf99ec07b55220871e093cb899

show more ...

clang-tidy: Enable cppcoreguidelines-explicit-virtual-functions

Adds override (introduced in C++11) to overridden virtual functions
and removes virtual from those functions as it is not required.

v

clang-tidy: Enable cppcoreguidelines-explicit-virtual-functions

Adds override (introduced in C++11) to overridden virtual functions
and removes virtual from those functions as it is not required.

virtual on non base class implementations was used to help indicate
to the user that a function was virtual. C++ compilers did not use
the presence of this to signify an overridden function.

In C++11 override and final keywords were introduced to allow
overridden functions to be marked appropriately. Their presence
allows compilers to verify that an overridden function correctly
overrides a base class implementation.

This can be useful as compilers can generate a compile time error
when:
- The base class implementation function signature changes.
- The user has not created the override with the correct signature.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I428f69c11b071a1a50e7f93f7bcc29c8300dcddb

show more ...

clang-tidy: Add few cppcoreguidelines check

These checks cover a wide range of best practices and
recommendations aimed at improving the safety, readability,
maintainability, and performance of our

clang-tidy: Add few cppcoreguidelines check

These checks cover a wide range of best practices and
recommendations aimed at improving the safety, readability,
maintainability, and performance of our C++ codebase according
to the C++ Core Guidelines.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I605971bfa0c8126e9b5f7bfa9591e26b09f27460

show more ...

clang-tidy: Add clang-analyzer checks

This checks primary purpose is to identify potential bugs,security
vulnerabilities, and adherence to coding standards by examining
the source code without execu

clang-tidy: Add clang-analyzer checks

This checks primary purpose is to identify potential bugs,security
vulnerabilities, and adherence to coding standards by examining
the source code without executing it.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I20e57618262f337886d191d092d8f3606fe70641

show more ...

clang-tidy: Add cert checks

clang-tidy provides a wide range of checks, including those that
cover CERT guidelines, through various modules and checks
specifically designed to catch potential securi

clang-tidy: Add cert checks

clang-tidy provides a wide range of checks, including those that
cover CERT guidelines, through various modules and checks
specifically designed to catch potential security vulnerabilities and
non-compliance with secure coding standards.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: If349a29226649524cfef0123f8e306ab22e63e67

show more ...

clang-tidy: Add clang-tidy to phosphor-psu-code-mgmt

This commit enables clang-tidy and adds few tidy checks.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I27e675411b172482a12de45c

clang-tidy: Add clang-tidy to phosphor-psu-code-mgmt

This commit enables clang-tidy and adds few tidy checks.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I27e675411b172482a12de45c7bc3f352f9b3a038

show more ...