regulators: Create ConfigFileParserError class

Create the ConfigFileParserError exception class. This exception
describes an error that occurred while parsing the JSON configuration
file that contr

regulators: Create ConfigFileParserError class

Create the ConfigFileParserError exception class. This exception
describes an error that occurred while parsing the JSON configuration
file that controls the phosphor-regulators application.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I0ef9db7c011d2aa3520634b810108ee0adb27783

show more ...

regulators: Add test cases for action.

Add test cases for action:
* Valid: Comments property not specified
* Valid: Comments property specified
* Valid: and action type specified
* Valid: co

regulators: Add test cases for action.

Add test cases for action:
* Valid: Comments property not specified
* Valid: Comments property specified
* Valid: and action type specified
* Valid: compare_presence action type specified
* Valid: compare_vpd action type specified
* Valid: i2c_compare_bit action type specified
* Valid: i2c_compare_byte action type specified
* Valid: i2c_compare_bytes action type specified
* Valid: i2c_write_bit action type specified
* Valid: i2c_write_byte action type specified
* Valid: i2c_write_bytes action type specified
* Valid: if action type specified
* Valid: not action type specified
* Valid: or action type specified
* Valid: pmbus_read_sensor and pmbus_write_vout_command action type specified
* Valid: run_rule action type specified
* Valid: set_device action type specified
* Invalid: Wrong data type for comments (should be array of string)
* Invalid: Wrong data type for action type
* Invalid: Empty comments array
* Invalid: Comments array has wrong element type (should be string)
* Invalid: No action type specified
* Invalid: Multiple action types specified
* Invalid: Unexpected property specified

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I81dfb50cf46a3091753f43266af8dc01527d621d

show more ...

regulators: Add test cases for entire config file.

Add test cases for entire config file:
*Valid: Only required properties specified
*Valid: All properties specified
*Invalid: Required chassis

regulators: Add test cases for entire config file.

Add test cases for entire config file:
*Valid: Only required properties specified
*Valid: All properties specified
*Invalid: Required chassis property not specified
*Invalid: Wrong data type for comments
*Invalid: Wrong data type for rules
*Invalid: Wrong data type for chassis
*Invalid: Empty comments array
*Invalid: Empty rules array
*Invalid: Empty chassis array
*Invalid: Comments array has wrong element type
*Invalid: Rules array has wrong element type
*Invalid: Chassis array has wrong element type
*Invalid: Unexpected property specified

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I0e3e7b58de0318d306d5bdfe0bc5588720e9cf05

show more ...

regulators: Add test cases for check_duplicate_object_id.

Add test cases for check_duplicate_object_id function in validate tool.
*Invalid: test duplicate object ID in device and rail.
*Invalid:

regulators: Add test cases for check_duplicate_object_id.

Add test cases for check_duplicate_object_id function in validate tool.
*Invalid: test duplicate object ID in device and rail.
*Invalid: test duplicate object ID in device and rule.
*Invalid: test duplicate object ID in rule and rail.
Modify test case for comments property with multiple array elements.
Add comments property with multiple array elements in test case Configuration.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I900083ed88617b227af138c880f1a3280d44ad47

show more ...

regulators: Increase timeout for validator tests

The phosphor-regulators-tests executable currently has a timeout of 90
seconds. This is due to the testcases for the Python config file
validation t

regulators: Increase timeout for validator tests

The phosphor-regulators-tests executable currently has a timeout of 90
seconds. This is due to the testcases for the Python config file
validation tool. These testcases run the validation tool many times.
The test executable can take 30-60 seconds to run, especially under
valgrind.

I experienced a CI failure today because the executable took more than
90 seconds to run. This could be related to the recent move to python3.

Increased the timeout to 120 seconds.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I94e2a70da71332563928913c8cd96237dea409b3

show more ...

regulators: Create Chassis class

Create C++ class that implements the 'chassis' element from the JSON
config file. See chassis.md for more information.

Signed-off-by: Shawn McCarney <shawnmm@us.ib

regulators: Create Chassis class

Create C++ class that implements the 'chassis' element from the JSON
config file. See chassis.md for more information.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I00544ad00fb810bc5d25896c83f2d7dd1221937d

show more ...

regulators: Update validator testcases for python3

The validate-regulators-config.py tool uses jsonschema.

When run using python3, the error messages from jsonschema have a
slightly different forma

regulators: Update validator testcases for python3

The validate-regulators-config.py tool uses jsonschema.

When run using python3, the error messages from jsonschema have a
slightly different format.

Update the validator tool testcases to adapt to the python3
error message format.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: Ifb5aafcc3194b165fd3a9c6e3ae4388da91c2586

show more ...

regulators: Add remaining props to Device class

Enhance the C++ Device class by adding the remaining properties from the
JSON config file:
* presence_detection
* configuration
* rails

See device.md

regulators: Add remaining props to Device class

Enhance the C++ Device class by adding the remaining properties from the
JSON config file:
* presence_detection
* configuration
* rails

See device.md for more information.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Id5973da1e0f4f73145f0eb0d34a4c157e828b06e

show more ...

Use python3

python2 is EOL, specify the python scripts to use python3.

Tested: Verify it builds fine in local CI. With bitbake recipe changes,
verify it builds OK with python3native.

Signe

Use python3

python2 is EOL, specify the python scripts to use python3.

Tested: Verify it builds fine in local CI. With bitbake recipe changes,
verify it builds OK with python3native.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: Icd5d10193e9323bbdbcd854e9027e014e01a1829

show more ...

regulators: Modify file path and timeout for CI.

meson.build:
Add validate-regulators-config_tests.cpp in the meson.build for CI.
Set timeout to 90 seconds for phosphor-regulators-tests.
The default

regulators: Modify file path and timeout for CI.

meson.build:
Add validate-regulators-config_tests.cpp in the meson.build for CI.
Set timeout to 90 seconds for phosphor-regulators-tests.
The default is 30 seconds, and this test can run longer than that
under valgrind in CI.

validate-regulators-config_tests.cpp:
Modify the file path in validate-regulators-config_tests.cpp for CI.
Modify runToolForOutput function to call validate tool once with both
standard output and standard error.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I8ad4727a17bd07b918a28936f097f0c9201a1d31

show more ...

regulators: Add remaining properties to Rail class

Enhance the C++ Rail class by adding the remaining properties from the
JSON config file:
* configuration
* sensor_monitoring

See rail.md for more

regulators: Add remaining properties to Rail class

Enhance the C++ Rail class by adding the remaining properties from the
JSON config file:
* configuration
* sensor_monitoring

See rail.md for more information.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I9c2e46fe8bec39454b0ad3f703eee3b497efd82a

show more ...

regulators: Create SensorMonitoring class

Create C++ class that implements the 'sensor_monitoring' element from
the JSON config file. See sensor_monitoring.md for more information.

The execute() m

regulators: Create SensorMonitoring class

Create C++ class that implements the 'sensor_monitoring' element from
the JSON config file. See sensor_monitoring.md for more information.

The execute() method of this class will be implemented in a future
commit.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Ifd0530e54d71a5292e8f4e5cad0a13195e801ed8

show more ...

regulators: Create PresenceDetection class

Create C++ class that implements the 'presence_detection' element from
the JSON config file. See presence_detection.md for more information.

The execute(

regulators: Create PresenceDetection class

Create C++ class that implements the 'presence_detection' element from
the JSON config file. See presence_detection.md for more information.

The execute() method of this class will be implemented in a future
commit.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Id6e1d66afe9179c92455d3f7b8f15bb54745f3eb

show more ...

regulators: Create Configuration class

Create C++ class that implements the 'configuration' element from the
JSON config file. See configuration.md for more information.

The execute() method of th

regulators: Create Configuration class

Create C++ class that implements the 'configuration' element from the
JSON config file. See configuration.md for more information.

The execute() method of this class will be implemented in a future
commit.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I9a8e2774e110ef56b2e23c46be6830a6e1275cc6

show more ...

regulators: Use std::optional in ActionEnvironment

Use the std::optional data type in the ActionEnvironment class to
represent an optional volts value setting.

Signed-off-by: Shawn McCarney <shawnm

regulators: Use std::optional in ActionEnvironment

Use the std::optional data type in the ActionEnvironment class to
represent an optional volts value setting.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Ib66f7586a49d78d8e0241fb8e7e4ecd881d1ac01

show more ...

regulators: Add check_number_of_elements_in_masks function.

Add check_number_of_elements_in_masks function to the config file
validation tool.
It checks if the number of bit masks in the 'masks' pro

regulators: Add check_number_of_elements_in_masks function.

Add check_number_of_elements_in_masks function to the config file
validation tool.
It checks if the number of bit masks in the 'masks' property matches
the number of byte values in the 'values' property.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: Ie33d78867b0c3ba508ff3693fe5969596d70e95a

show more ...

regulators: Add check_rule_id_exists function.

Add check_rule_id_exists function to the config file validation tool.
It checks if a rule_id property specifies a rule ID that does not
exist.

Signed-

regulators: Add check_rule_id_exists function.

Add check_rule_id_exists function to the config file validation tool.
It checks if a rule_id property specifies a rule ID that does not
exist.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I960a1b27a74b89b3bfb89ec18ad54dbd25c9388e

show more ...

regulators: Add check_set_device_value_exists function.

Add check_set_device_value_exists function to the config file validation
tool.
It checks if a set_device action specifies a device ID that doe

regulators: Add check_set_device_value_exists function.

Add check_set_device_value_exists function to the config file validation
tool.
It checks if a set_device action specifies a device ID that does not
exist.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I95e6f9b51cb2c75c3d95b3ca1c4377f4b6e0171c

show more ...

regulators: Add test cases for command line syntax

Test cases for testing command line syntax of the validation tool.
*Valid: -s specified
*Valid: --schema-file specified
*Valid: -c specified
*Valid

regulators: Add test cases for command line syntax

Test cases for testing command line syntax of the validation tool.
*Valid: -s specified
*Valid: --schema-file specified
*Valid: -c specified
*Valid: --configuration-file specified
*Valid: -h specified
*Valid: --help specified
*Invalid: -c/--configuration-file not specified
*Invalid: -s/--schema-file not specified
*Invalid: -s specified more than once
*Invalid: -c specified more than once
*Invalid: No file name specified after -c
*Invalid: No file name specified after -s
*Invalid: File specified after -c does not exist
*Invalid: File specified after -s does not exist
*Invalid: File specified after -s is not right data format
*Invalid: File specified after -c is not readable
*Invalid: File specified after -s is not readable
*Invalid: Unexpected parameter specified

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I922c3b5810e5c9f98b318f0a44ae78e4b0c8525a

show more ...

regulators: Add check_run_rule_value_exists function.

Add check_run_rule_value_exists function to the config file validation tool.
It checks if any run_rule actions specify a rule ID that does not e

regulators: Add check_run_rule_value_exists function.

Add check_run_rule_value_exists function to the config file validation tool.
It checks if any run_rule actions specify a rule ID that does not exist.
Add get_values function.
It finds all occurrences of a key within the config file and returns the
associated values.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I165426f10fcda052340a7a979228365bb7f1602d

show more ...

regulators: Add test cases for check_number_of_elements_in_masks

*Invalid: test number of elements in masks not equal to number in
values in i2c_compare_bytes.
*Invalid: test number of elements in m

regulators: Add test cases for check_number_of_elements_in_masks

*Invalid: test number of elements in masks not equal to number in
values in i2c_compare_bytes.
*Invalid: test number of elements in masks not equal to number in
values in i2c_write_bytes.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I523782a46c2b52035bfa2b6b4531ce79c37a62f9

show more ...

regulators: Add test cases for check_rule_id_exists

*Invalid: test rule_id property in configuration specifies a rule ID that does not exist.
*Invalid: test rule_id property in presence_detection sp

regulators: Add test cases for check_rule_id_exists

*Invalid: test rule_id property in configuration specifies a rule ID that does not exist.
*Invalid: test rule_id property in presence_detection specifies a rule ID that does not exist.
*Invalid: test rule_id property in sensor_monitoring specifies a rule ID that does not exist.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I55e2d81b89b96164b9774e59d9487047943945fa

show more ...

regulators: Add test cases for check_set_device_value_exists

*Invalid: test set_device actions specify a device ID that does not exist.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I7f

regulators: Add test cases for check_set_device_value_exists

*Invalid: test set_device actions specify a device ID that does not exist.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I7f279b9ea3177acdc09f37c83cbf82631805de38

show more ...

regulators: Add test cases for check_run_rule_value_exists

*Invalid: test run_rule actions specify a rule ID that does not exist.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: Idec5938e

regulators: Add test cases for check_run_rule_value_exists

*Invalid: test run_rule actions specify a rule ID that does not exist.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: Idec5938eb1e510d977833eb50721d78d84af37ed

show more ...

regulators: Add pmbus_write_vout_command action

Implement the pmbus_write_vout_command action in the JSON config file.
See pmbus_write_vout_command.md for more information about this action.

Signed

regulators: Add pmbus_write_vout_command action

Implement the pmbus_write_vout_command action in the JSON config file.
See pmbus_write_vout_command.md for more information about this action.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Idef8da56d19df8a416efec068ffa9fb9493100cc

show more ...