clang-tidy: Suppress unused private field warning

Addressed warnings reported during clang-tidy enablement by marking
unused private fields with the [[maybe_unused]] keyword in multiple
instances. T

clang-tidy: Suppress unused private field warning

Addressed warnings reported during clang-tidy enablement by marking
unused private fields with the [[maybe_unused]] keyword in multiple
instances. This temporarily suppresses the warnings until a permanent
solution is implemented.

'''
./phosphor-regulators/src/manager.hpp:199:31: error: private field 'eventLoop' is not used [-Werror
./phosphor-regulators/src/dbus_sensor.hpp:316:23: error: private field 'bus' is not used [-Werror
'''

Tested: Verified build and unit testing.

Change-Id: I5c4424deaee8440c619f8d541ee6203c4d9d738b
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I7b90380845efee6bf6a1fe342a793d71aa9ff181
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

regs: Use new compatible interface

Enhance the phosphor-regulators application to use the new D-Bus
interface xyz.openbmc_project.Inventory.Decorator.Compatible.

The list of compatible system type

regs: Use new compatible interface

Enhance the phosphor-regulators application to use the new D-Bus
interface xyz.openbmc_project.Inventory.Decorator.Compatible.

The list of compatible system type names from this interface is used to
find the configuration file for the current system.

Rename the configuration files to match the system type names in the new
D-Bus interface.

Tested:
* Verified phosphor-regulators loaded correct config file
* When interface was available before app started
* When interface was available after app started
* When interface was available after configure action started
* When interface was never available but default config file exists
* On Rainier, Everest, and Fuji systems
* Verified system could be powered on and off without error
* Verified app waited up to 5 minutes during configure action for
interface to become available. Verified critical error logged and
power on failed if interface not found within 5 minutes.

Change-Id: Icee0c59566c68730ca318fc4521f05af2546eed1
Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>

show more ...

Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
phosphor-power-sequencer/docs/README.md:1 MD041/first-line-heading/first-line-h1 First line in a file shou

Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
phosphor-power-sequencer/docs/README.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## Overview"]
phosphor-power-sequencer/docs/testing.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## Overview"]
phosphor-power-sequencer/README.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## Overview"]
phosphor-power-supply/README.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "OpenBMC power supply monitoring..."]
phosphor-regulators/README.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## Overview"]
README.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## Overview"]
```
Refer to markdown-lint [1] to fix MD041
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/041-first-line-h1.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia96bbcb17800cdccfd7de2a85da1dc01cef87303

show more ...

Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer

Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer to markdown-lint [1] to fix MD040
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I456b41fe5f368798cd1d1e78cd83d29b5bb7e236

show more ...

regs: Document usage of new compatible intf

Update the phosphor-regulators configuration file documentation.
Explain how the new xyz.openbmc_project.Inventory.Decorator.Compatible
D-Bus interface is

regs: Document usage of new compatible intf

Update the phosphor-regulators configuration file documentation.
Explain how the new xyz.openbmc_project.Inventory.Decorator.Compatible
D-Bus interface is used to find the config file name.

The C++ changes to use the new D-Bus interface will be done in a
subsequent commit.

Change-Id: If93272a5b69c9e5bd877a4ebf461b2439aa42b2e
Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>

show more ...

gcc14: continue dangling-reference workaround

The latest yocto is moving to gcc14 and the workaround to ignore
dangling references is still needed with gcc14.

Tested:
- Confirmed phosphor-power bui

gcc14: continue dangling-reference workaround

The latest yocto is moving to gcc14 and the workaround to ignore
dangling references is still needed with gcc14.

Tested:
- Confirmed phosphor-power builds with latest yocto rebase

Change-Id: I900cb11d66730a74bb5860769214dfa93f83a40d
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

regulators: Initial BlueRidge config file

Create the initial voltage regulator JSON configuration file for
BlueRidge systems.

Tested:
* Ran JSON validation tool
* Set up BlueRidge simulation enviro

regulators: Initial BlueRidge config file

Create the initial voltage regulator JSON configuration file for
BlueRidge systems.

Tested:
* Ran JSON validation tool
* Set up BlueRidge simulation environment
* Verified regulators application found and loaded the file
* Powered chassis on and off and verified no errors were logged

Change-Id: I05a868f7656f76de8543683e9c9e14eaa3d4b70b
Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>

show more ...

regulators: Initial Fuji config file

Create the initial voltage regulator JSON configuration file for Fuji
systems.

Tested:
* Ran JSON validation tool
* Set up Fuji simulation environment
* Verifie

regulators: Initial Fuji config file

Create the initial voltage regulator JSON configuration file for Fuji
systems.

Tested:
* Ran JSON validation tool
* Set up Fuji simulation environment
* Verified regulators application found and loaded the file
* Powered chassis on and off and verified no errors were logged

Change-Id: I34c22e365f084836c66e8b30df4612b0d5fb2bb8
Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>

show more ...

Move TemporaryFile class to root directory

Source code that is shared across applications is located in the root
directory of the phosphor-power repository.

The TemporaryFile class was originally c

Move TemporaryFile class to root directory

Source code that is shared across applications is located in the root
directory of the phosphor-power repository.

The TemporaryFile class was originally created for the
phosphor-regulators application. However it is general purpose and is
now needed by the phosphor-power-sequencer application.

Move the TemporaryFile class to the root directory. Update C++ files
that use the TemporaryFile class since it is now in a different
namespace. Update affected meson.build files.

Change-Id: I6d18080d2436a5da87b7ab51ac003c503caa36a3
Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: I37fcb391dcb215a86a60c26f7512f6ccb8312dc4
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

phosphor-regulators: squash warning on GCC-13 only

The change to squash the warning for dangling-reference can only be
applied to GCC-13. On GCC-12, the compiler doesn't know about this
warning and

phosphor-regulators: squash warning on GCC-13 only

The change to squash the warning for dangling-reference can only be
applied to GCC-13. On GCC-12, the compiler doesn't know about this
warning and fails when it comes across the unknown warning parameter.

Hopefully the false positives present here will be resolved in a future
version of GCC so we are being specific about GCC-13 instead of
exempting for GCC 13 and higher so that we are forced to revisit
this later.

Fixes 974a794021c1c7430f17a9dfcf5d7b9cebf582a9

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iee3d0d8da3cec57d2199de2511d277c3bf4b33f3

show more ...

meson: add necessary subprojects

Add subprojects for all the direct dependencies of the project such
that the project can be built outside of a Yocto SDK on a typical
Linux development system.

-

meson: add necessary subprojects

Add subprojects for all the direct dependencies of the project such
that the project can be built outside of a Yocto SDK on a typical
Linux development system.

- Update the .gitignore to ignore the subproject source directories.
- Update the .gitignore to ignore alternative build subdirectory
names as is typical with most projects in the openbmc organization.
- Add wrap files for direct dependencies, copied from other
repositories that already have the same dependencies.
- Modify the meson.build dependency for libgpiod so that the C++
bindings are included.
- Add many missing dependencies throughout.
- Sort all dependencies alphabetically for consistency.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0feb6f0f175e6dba0b00a2c2b666eb0801575734

show more ...

tests: adjust self-copy tests

There are a couple tests which attempt to copy an object onto itself via
a `std::move`. GCC 13 catches this as a "move onto self" and flags it
as an error. Rather tha

tests: adjust self-copy tests

There are a couple tests which attempt to copy an object onto itself via
a `std::move`. GCC 13 catches this as a "move onto self" and flags it
as an error. Rather than use the `std::move`, perform a static_cast
into an r-value reference so that the same copy-constructor is called
as if the std::move were successfully used.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I097889578492b1a3ab456e8cb21a668aa0855be4

show more ...

remove unnecessary std::move calls

GCC 13 now flags a std::move of an returned temporary as unnecessary and
likely preventing RVO. Remove the unnecessary std::move.

Signed-off-by: Patrick Williams

remove unnecessary std::move calls

GCC 13 now flags a std::move of an returned temporary as unnecessary and
likely preventing RVO. Remove the unnecessary std::move.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibde052b5a4efd84bdbbac2f2f6e673729b32e6cd

show more ...

phosphor-regulators: squash GCC dangling-reference warning

GCC 13 now includes a warning for possible dangling-references but the
warning currently has a good number of false positives. This is
dis

phosphor-regulators: squash GCC dangling-reference warning

GCC 13 now includes a warning for possible dangling-references but the
warning currently has a good number of false positives. This is
discussed upstream in the GCC bugzilla[1,2] but the author seems to have
currently punted on handling many of these false positives and
recommends a pragma-disable. Do that for the time being so that the
code compiles on GCC 13.

[1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108165
[2]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107532

Fixes openbmc/phosphor-power#10.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie4ab428dcc8230645ee6ea3c331d8f3bbe47b9c8

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: If66f68c96df4baf8dc07abf8729a3cb7657e932d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

phosphor-regulators: journal: Fix some warnings by cppcheck

Warning message:
phosphor-regulators/src/journal.cpp:46:5: style: Class
'JournalCloser' has a constructor with 1 argument that is not
expl

phosphor-regulators: journal: Fix some warnings by cppcheck

Warning message:
phosphor-regulators/src/journal.cpp:46:5: style: Class
'JournalCloser' has a constructor with 1 argument that is not
explicit. [noExplicitConstructor]
JournalCloser(sd_journal* journal) : journal{journal}
^

Tested: Verify that there are no such warnings in local CI.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I051ffc4905b64ef579b1eb58eac351967a5c6af1

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: I53dc3bb17d5dcbb9b33fa3d0db62138f37cc8c0b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: If2be5279a

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: If2be5279a84f72f4b8d58a978305b7c650d4f5be
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

regulators: Update test cases for new jsonschema

The validate-regulators-config.py tool validates regulator configuration
files. It uses the jsonschema Python package to perform much of the
validat

regulators: Update test cases for new jsonschema

The validate-regulators-config.py tool validates regulator configuration
files. It uses the jsonschema Python package to perform much of the
validation.

The automated test cases for this tool run the tool against various
invalid configuration files and verify the resulting error messages.

The latest version of jsonschema changed the error messages that are
emitted in some error cases. Update the test cases to expect the new
error messages.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I369f32705c64c19d521c4624188ebbc98522cff2

show more ...

python: fix flake8 warnings and format with black

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I90fe7f4eccb9014245225b6bc61183d7455b0fae

regulators: Initial Bonnell config file

Create an initial version of the voltage regulators JSON configuration
file for Bonnell systems.

The file contains the minimum required structure plus some g

regulators: Initial Bonnell config file

Create an initial version of the voltage regulators JSON configuration
file for Bonnell systems.

The file contains the minimum required structure plus some general rules
that will likely be used in subsequent commits.

This minimal file is enough for Bonnell hardware bring-up. No voltage
regulator configuration or monitoring will occur. The regulators will
power on with their default register values.

Testing:
* Ran validation tool
* Started Rainier 2S2U simulation session
* Modified EntityManager data so that system appeared to be a Bonnell
* Tested that file was found and loaded successfully
* Tested that chassis powered on successfully with no errors logged

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I30309e3096401c5464ae1bff75334491e2bc00d7

show more ...

regulators: Fix possible uninitialized variable

The latest version of tools used during CI are emitting a new warning in
the phosphor-regulators source code. The warning states that a variable
valu

regulators: Fix possible uninitialized variable

The latest version of tools used during CI are emitting a new warning in
the phosphor-regulators source code. The warning states that a variable
value might not be getting defined before being used.

This is not an actual bug; the variable value will always be defined.
However, modify the code so that CI will pass.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I090b50c3565ffbb57bfeab02fbcfd98d86aa527c

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ief05bd757cffb1453e058a719ee4b060861752e7

show more ...