regulators: Add Services& services to classes

Modify the configure() method in the System, Chassis, Device, and Rail
classes to have a new first parameter: Services& services.

Fix mock_services.hpp

regulators: Add Services& services to classes

Modify the configure() method in the System, Chassis, Device, and Rail
classes to have a new first parameter: Services& services.

Fix mock_services.hpp bug.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I6ef41de65d2c5b68c55edb42189ba9c0f2e436ed

show more ...

regulators: Remove TmpFile class

The TmpFile class was created in the test directory for managing
temporary files used by testcases.

A new TemporaryFile class has replaced it. TemporaryFile has mo

regulators: Remove TmpFile class

The TmpFile class was created in the test directory for managing
temporary files used by testcases.

A new TemporaryFile class has replaced it. TemporaryFile has more
features and can be used by production (non-test) code as well.

This commit removes the TmpFile class and modifies testcases to use
TemporaryFile instead.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Id06d333416e43d5685c377ee0780b475d20cba8f

show more ...

regulators: Create TemporaryFile class

Create class for handling temporary files:
* Constructor creates the temporary file
* Destructor deletes the temporary file
* Provides move constructor and mov

regulators: Create TemporaryFile class

Create class for handling temporary files:
* Constructor creates the temporary file
* Destructor deletes the temporary file
* Provides move constructor and move assignment operator so that class
can be stored in containers like std::vector
* Throws exception if errors occur creating or deleting the temporary file

This class is an enhanced version of the TmpFile class in the test
directory. A future commit will delete TmpFile and modify testcases to
use TemporaryFile instead.

Tested:
* Created automated tests for most of the code in the class.
* Manually tested some error cases that were difficult to automate.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Ieda58f4d2738dc4f184232936bc082c0d3a93fa0

show more ...

regulators: Create high level design document

Create a high level design document for the phosphor-regulators
application. Summarize the high level algorithms and key C++ classes.

The low level de

regulators: Create high level design document

Create a high level design document for the phosphor-regulators
application. Summarize the high level algorithms and key C++ classes.

The low level design is documented in doxygen comments in the source
files.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I4f57063b2d4516da06a1f063ef83bb7ca92788bf

show more ...

regulators: Add monitorSensors support to System

Implemented the monitorSensors() method in the System class. This method
reads the sensors for the voltage rails produced by the system.

Signed-off

regulators: Add monitorSensors support to System

Implemented the monitorSensors() method in the System class. This method
reads the sensors for the voltage rails produced by the system.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: Ied2248c362708aa77c1efd31abff0cf023211a7e

show more ...

regulators: Add monitorSensors support to Chassis

Implemented the monitorSensors() method in the Chassis class. This method
reads the sensors for the voltage rails produced by the chassis.

Signed-

regulators: Add monitorSensors support to Chassis

Implemented the monitorSensors() method in the Chassis class. This method
reads the sensors for the voltage rails produced by the chassis.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: Idb283b09c645983190601e030334399ee76c1995

show more ...

regulators: Add monitorSensors support to Device

Implemented the monitorSensors() method in the Device class. This method
reads the sensors for the voltage rails produced by the device.

Signed-off

regulators: Add monitorSensors support to Device

Implemented the monitorSensors() method in the Device class. This method
reads the sensors for the voltage rails produced by the device.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I5ca48ba8d6ab2019c1840f3905d9603233b1881a

show more ...

regulators: Fix for GMOCK WARNING

Add the missing EXPECT_CALL to avoid the GMOCK WARNING messages.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I304bb373045543d55e71c90ced17761cacb8cee1

regulators: Discuss firmware update in README

Update the phosphor-regulators README.md file to discuss the impacts of
installing new firmware on the BMC.

Explain that installing new firmware does n

regulators: Discuss firmware update in README

Update the phosphor-regulators README.md file to discuss the impacts of
installing new firmware on the BMC.

Explain that installing new firmware does not affect the
/etc/phosphor-regulators directory. This means that a config file in
that directory will continue to override the standard config file after
a firmware update.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Ic4419b5759d93cd796b693941874f696bffa6285

show more ...

regulators: Modify Manager to use Services

Modify the Manager class to use the new Services interface.

Tested:
* Verified all journal messages logged by Manager still work.

Signed-off-by: Shawn

regulators: Modify Manager to use Services

Modify the Manager class to use the new Services interface.

Tested:
* Verified all journal messages logged by Manager still work.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Ifaa1dfe67e4ab33ea42e9ee1daf65a5663087a0d

show more ...

regulators: Create services interface

Create an interface to system services like error logging and the
journal.

This interface is a container for a set of system services. It can be
passed as a s

regulators: Create services interface

Create an interface to system services like error logging and the
journal.

This interface is a container for a set of system services. It can be
passed as a single parameter to the rest of the application. It also
simplies automated testing.

Class hierarchy:
* Services: Abstract base class that defines the interface
* BMCServices: Implementation that uses standard BMC services
* MockServices: Implementation that uses mock services

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I4ac8696e2a9ef6521b369df532ea00bc483708c1

show more ...

regulators: Improve journal interface

Improve the interface to the system journal:
* Create class hierarchy to allow dynamic selection of implementation
* Move to standard gmock interface for mock i

regulators: Improve journal interface

Improve the interface to the system journal:
* Create class hierarchy to allow dynamic selection of implementation
* Move to standard gmock interface for mock implementation
* Make design consistent with error logging interface
* Support logging a vector of strings for use with nested exceptions

Create the following class hierarchy:
* Journal: Abstract base class that defines the interface
* SystemdJournal: Implementation that writes to systemd journal
* MockJournal: Mock implementation for testing

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I313c2a6c9e866b5ca0c16c09190a8829d5264631

show more ...

regulators: Create error logging interface

Create an error logging interface that enables automated testing:
* ErrorLogging: Abstract base class that defines the interface
* DBusErrorLogging:

regulators: Create error logging interface

Create an error logging interface that enables automated testing:
* ErrorLogging: Abstract base class that defines the interface
* DBusErrorLogging: Implementation that uses D-Bus method calls
* MockErrorLogging: Mock implementation for testing

This initial commit does not define the method parameters or
implementations. That will be done in a subsequent commit.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I47e75442de1511e33928b6aef1324022df5fd34d

show more ...

regulators: Add monitorSensors support to Rail

Implemented the monitorSensors() method in the Rail class. This method
reads the sensors for a voltage rail.

Signed-off-by: Bob King <Bob_King@wistro

regulators: Add monitorSensors support to Rail

Implemented the monitorSensors() method in the Rail class. This method
reads the sensors for a voltage rail.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: Ifbe6461349d20fee1eba233844c95c1046e1a54a

show more ...

regulators: Create ErrorHistory class

Create a class to track error history, such as error count and whether
the error has been logged.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id:

regulators: Create ErrorHistory class

Create a class to track error history, such as error count and whether
the error has been logged.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Iead88963110a699eee1d6cd8750303f05d6ecef1

show more ...

regulators: Add SensorMonitoring::execute()

Implementation and Testing for SensorMonitoring::execute().

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: If2b39b70997cd5cb84adc6c4b601d87556

regulators: Add SensorMonitoring::execute()

Implementation and Testing for SensorMonitoring::execute().

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: If2b39b70997cd5cb84adc6c4b601d87556b82f55

show more ...

regulators: Add PMBusReadSensorAction::execute()

Implementation and Testing for PMBusReadSensorAction::execute().

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I350eccfd6daaf95786532975

regulators: Add PMBusReadSensorAction::execute()

Implementation and Testing for PMBusReadSensorAction::execute().

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I350eccfd6daaf957865329756cdfb3be48f49377

show more ...

regulators: Close devices when system powering off

Modify the Manager class to close all regulator devices when monitoring
is disabled. Monitoring is normally disabled because the system is
being p

regulators: Close devices when system powering off

Modify the Manager class to close all regulator devices when monitoring
is disabled. Monitoring is normally disabled because the system is
being powered off.

Also add a closeDevices() method to the System class that closes all
devices in the system.

Tested:
* Tested when monitoring was disabled. Verified debug journal message
stating devices were closed.
* Tested multiple consecutive power on/off cycles to ensure device
access remained functional.
* Performed regression test on existing function.
* Created and executed automated tests for System::closeDevices()

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I074190454c505116cccf1bc130a70205f34d0e26

show more ...

regulators: Add closeDevices() to Chassis class

Add a closeDevices() method to the Chassis class. This will close all
devices within the chassis. The devices should be closed when monitoring
is di

regulators: Add closeDevices() to Chassis class

Add a closeDevices() method to the Chassis class. This will close all
devices within the chassis. The devices should be closed when monitoring
is disabled and the system is being powered off.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I713bf470392aa49632a34fa42bf849fa2f1c4c01

show more ...

regulators: Add close method to Device class

Add a close method to the Device class. This will be used to close all
devices in the system when monitoring is disabled. Monitoring is
disabled when t

regulators: Add close method to Device class

Add a close method to the Device class. This will be used to close all
devices in the system when monitoring is disabled. Monitoring is
disabled when the system is being powered off.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I0712ad698ebbcac5d7b17a822443b94dda230429

show more ...

regulators: ActionEnvironment enhancements

Define a new struct named SensorReading. This will be used the store the
value read when PMBusReadSensorAction::execute() is called.

Add a new data membe

regulators: ActionEnvironment enhancements

Define a new struct named SensorReading. This will be used the store the
value read when PMBusReadSensorAction::execute() is called.

Add a new data member sensorReadings.
This will hold the sensor readings that are obtained

Add a new method addSensorReading.
It add the specified SensorReading to the sensorReadings vector.

Add a new method getSensorReadings.
This will be called by the SensorMonitoring object.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I91076227498712750187d354b76faa2d95e33aac

show more ...

regulators: Add convertFromVoutLinear for sensor monitoring

Add convertFromVoutLinear function.
The function is for converting from linear_16 format to a normal
decimal number.

Signed-off-by: Bob K

regulators: Add convertFromVoutLinear for sensor monitoring

Add convertFromVoutLinear function.
The function is for converting from linear_16 format to a normal
decimal number.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: If6e2a0227502a5674f72f93623108dc155e0c99c

show more ...

regulators: Add convertFromLinear for sensor monitoring

Add convertFromLinear function.
The function is for converting from linear_11 format to a normal
decimal number.

Signed-off-by: Bob King <Bob

regulators: Add convertFromLinear for sensor monitoring

Add convertFromLinear function.
The function is for converting from linear_11 format to a normal
decimal number.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I6bdeaf8e9d9a26ae144c9db3494f758fd9eb48ee

show more ...

regulators: Create README in application directory

Create a README file in the phosphor-regulators directory. The file
summarizes the features of the application. It also contains a link to
the co

regulators: Create README in application directory

Create a README file in the phosphor-regulators directory. The file
summarizes the features of the application. It also contains a link to
the config file documentation.

Also made minor updates to the config file README.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Idf04501234237d84e6a0350fd93de3f9d3a7c431

show more ...

regulators: Implements support for pmbus_read_sensor action

Enhance the configuration file parser to support the pmbus_read_sensor
action element.

Signed-off-by: Bob King <Bob_King@wistron.com>
Cha

regulators: Implements support for pmbus_read_sensor action

Enhance the configuration file parser to support the pmbus_read_sensor
action element.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I7f87a7551469bb494fe17b6d6d79ebb1ca517e86

show more ...