| #
e2ec69ad |
| 30-Sep-2022 |
Potin Lai <potin.lai@quantatw.com> |
Add SIGHUP handling for reloading configuration
Add signal handling feature for handling the SIGHUP generated by
systemd ExecReload.
Tested log:
- Brfore reload
root@bletchley:~# systemctl status p
Add SIGHUP handling for reloading configuration
Add signal handling feature for handling the SIGHUP generated by
systemd ExecReload.
Tested log:
- Brfore reload
root@bletchley:~# systemctl status phosphor-pid-control.service
* phosphor-pid-control.service - Phosphor-Pid-Control Margin-based Fan Control Daemon
Loaded: loaded (/lib/systemd/system/phosphor-pid-control.service; enabled; preset: enabled)
Drop-In: /lib/systemd/system/phosphor-pid-control.service.d
`-10-bletchley.conf
Active: active (running) since Fri 2022-09-30 09:12:10 UTC; 1min 11s ago
Main PID: 884 (swampd)
CGroup: /system.slice/phosphor-pid-control.service
`-884 /usr/bin/swampd
Sep 30 09:12:32 bletchley swampd[884]: PID name: fan_tachs
Sep 30 09:12:32 bletchley swampd[884]: inputs: FAN0_TACH_IL, FAN0_TACH_OL, FAN1_TACH_IL, FAN1_TACH_OL, FAN2_TACH_IL, FAN2_TACH_OL, FAN3_TACH_IL, FAN3_TACH_OL,
Sep 30 09:12:32 bletchley swampd[884]: PID name: inlet_Temp
Sep 30 09:12:32 bletchley swampd[884]: inputs: Virtual_Inlet_Temp,
Sep 30 09:12:32 bletchley swampd[884]: PID name: retimer_temp
Sep 30 09:12:32 bletchley swampd[884]: inputs: MB_U19_THERM_LOCAL,
Sep 30 09:12:32 bletchley swampd[884]: PID name: switch_temp
Sep 30 09:12:32 bletchley swampd[884]: inputs: MB_U402_THERM_LOCAL,
Sep 30 09:12:32 bletchley swampd[884]: pushing zone 1
Sep 30 09:12:32 bletchley swampd[884]: PID Zone 1 max SetPoint 37 requested by inlet_Temp FAN0_TACH_IL FAN0_TACH_OL FAN1_TACH_IL FAN1_TACH_OL FAN2_TACH_IL FAN2_TACH_OL FAN3_TACH_IL FAN3_TACH_OL
- After reload called
root@bletchley:~# journalctl -u phosphor-pid-control.service | grep -i reload
Sep 30 09:13:46 bletchley systemd[1]: Reloading Phosphor-Pid-Control Margin-based Fan Control Daemon...
Sep 30 09:13:46 bletchley swampd[884]: reloading configuration
Sep 30 09:13:46 bletchley systemd[1]: Reloaded Phosphor-Pid-Control Margin-based Fan Control Daemon.
root@bletchley:~#
root@bletchley:~# systemctl status phosphor-pid-control
* phosphor-pid-control.service - Phosphor-Pid-Control Margin-based Fan Control Daemon
Loaded: loaded (/lib/systemd/system/phosphor-pid-control.service; enabled; preset: enabled)
Drop-In: /lib/systemd/system/phosphor-pid-control.service.d
`-10-bletchley.conf
Active: active (running) since Fri 2022-09-30 09:12:10 UTC; 2min 35s ago
Process: 1353 ExecReload=/bin/kill -HUP $MAINPID (code=exited, status=0/SUCCESS)
Main PID: 884 (swampd)
CGroup: /system.slice/phosphor-pid-control.service
`-884 /usr/bin/swampd
Sep 30 09:13:56 bletchley swampd[884]: PID name: fan_tachs
Sep 30 09:13:56 bletchley swampd[884]: inputs: FAN0_TACH_IL, FAN0_TACH_OL, FAN1_TACH_IL, FAN1_TACH_OL, FAN2_TACH_IL, FAN2_TACH_OL, FAN3_TACH_IL, FAN3_TACH_OL,
Sep 30 09:13:56 bletchley swampd[884]: PID name: inlet_Temp
Sep 30 09:13:56 bletchley swampd[884]: inputs: Virtual_Inlet_Temp,
Sep 30 09:13:56 bletchley swampd[884]: PID name: retimer_temp
Sep 30 09:13:56 bletchley swampd[884]: inputs: MB_U19_THERM_LOCAL,
Sep 30 09:13:56 bletchley swampd[884]: PID name: switch_temp
Sep 30 09:13:56 bletchley swampd[884]: inputs: MB_U402_THERM_LOCAL,
Sep 30 09:13:56 bletchley swampd[884]: pushing zone 1
Sep 30 09:13:56 bletchley swampd[884]: PID Zone 1 max SetPoint 37 requested by inlet_Temp FAN0_TACH_IL FAN0_TACH_OL FAN1_TACH_IL FAN1_TACH_OL FAN2_TACH_IL FAN2_TACH_OL FAN3_TACH_IL FAN3_TACH_OL
Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Change-Id: Idea1ede908fe4a2da3018cc0624c78ac7e0530eb
show more ...
|
| #
304c0332 |
| 27-May-2020 |
Vijay Khemka <vijaykhemka@fb.com> |
Fix swampd path
Fixed swampd path in service file as this file is a part of repo so
bindir was not converting to /usr/bin in build.
Signed-off-by: Vijay Khemka <vijaykhemka@fb.c
Fix swampd path
Fixed swampd path in service file as this file is a part of repo so
bindir was not converting to /usr/bin in build.
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
Change-Id: Ia70ed2e023a16668b09175486816029f6b13b8bc
Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
| #
75c65d9a |
| 06-Nov-2019 |
Peter Lundgren <peterlundgren@google.com> |
Start phoshphor-pid-control after fansensor
Occasionally, phosphor-pid-control fails to start logging:
swampd[2688]: terminate called after throwing an instance of 'std::runtime
Start phoshphor-pid-control after fansensor
Occasionally, phosphor-pid-control fails to start logging:
swampd[2688]: terminate called after throwing an instance of 'std::runtime_error'
swampd[2688]: what(): ObjectMapper Call Failure
This happens multiple times:
systemd[1]: phosphor-pid-control.service: Main process exited, code=killed, status=6/ABRT
systemd[1]: phosphor-pid-control.service: Failed with result 'signal'.
systemd[1]: phosphor-pid-control.service: Service RestartSec=1s expired, scheduling restart.
systemd[1]: phosphor-pid-control.service: Scheduled restart job, restart counter is at 2.
systemd[1]: Stopped Swampd Margin-based Fan Control Daemon.
systemd[1]: phosphor-pid-control.service: Start request repeated too quickly.
systemd[1]: phosphor-pid-control.service: Failed with result 'signal'.
systemd[1]: Failed to start Swampd Margin-based Fan Control Daemon.
and systemd gives up and stops trying to restart the service.
$ systemctl --no-page status phosphor-pid-control.service
* phosphor-pid-control.service - Swampd Margin-based Fan Control Daemon
Loaded: loaded (/lib/systemd/system/phosphor-pid-control.service; enabled; vendor preset: enabled)
Active: failed (Result: signal) since Thu 2019-10-31 18:05:11 UTC; 1min 56s ago
Process: 2738 ExecStart=/usr/bin/swampd (code=killed, signal=ABRT)
Main PID: 2738 (code=killed, signal=ABRT)
xyz.openbmc_project.fansensor.service is the service from dbus-sensors
that phosphor-pid-control uses to interact with the fans and pwms.
phosphor-pid-control should not start until after fansensor.
Tested:
swampd comes up reliably on a system using
xyz.openbmc_project.fansensor.service. I have not tried a system that
isn't using dbus-sensors.
Signed-off-by: Peter Lundgren <peterlundgren@google.com>
Change-Id: Iec019bfabcc77279c7dfe8d4899ac07c1c41a428
show more ...
|