s/minThermalRPM/minThermalOutput

The minThermalRPM is only an RPM by the fact that
that is the units of the PID. As the PID units can
be anything, change this to minThermalOutput to allow
for differ

s/minThermalRPM/minThermalOutput

The minThermalRPM is only an RPM by the fact that
that is the units of the PID. As the PID units can
be anything, change this to minThermalOutput to allow
for different units (i.e. percent).

Change-Id: Ic53fef1159ade5a413e5d519d407947f3023d8e3
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

dbuspassive: allow scaling

For tachs it is beneficial to deal in percent so that
multiple controllers can be used with different fan
types without having to recalculate. This starts using
the unused

dbuspassive: allow scaling

For tachs it is beneficial to deal in percent so that
multiple controllers can be used with different fan
types without having to recalculate. This starts using
the unused min and max fields to be able to scale readings.
Since max and min are commonly on the value interface, the
special value of <int64_t>::lowest() allows these to be gathered
from dbus instead of having to enter them manually.

Tested-by: Moved pid control to percent and printed
outputs

Change-Id: I9496eb92a18b68a7cd7f034d41d40ef5175c6974
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

stepwise: Add ceiling type

Add a stepwise ceiling type, this is used as a
upper clipping curve to limit the max output based
on a temperature sensor. This is commonly used for
quiet fan mode where C

stepwise: Add ceiling type

Add a stepwise ceiling type, this is used as a
upper clipping curve to limit the max output based
on a temperature sensor. This is commonly used for
quiet fan mode where CPU throttling is allowed to
preserve a max fan noise.

Change-Id: I181d5913c92e5498a34e6d3f67cf99b67471479c
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

dbusconfiguration: set timeout to 0

Setting this value to zero so we can limit d-bus
traffic and not send updates unless there is one.

Tested-by: fan control worked normally after

Change-Id: Ie8bd

dbusconfiguration: set timeout to 0

Setting this value to zero so we can limit d-bus
traffic and not send updates unless there is one.

Tested-by: fan control worked normally after

Change-Id: Ie8bd7fbfd86c1643ea5bf76cf49a087923db0ccf
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

build: drop support for YAML configurations

phosphor-pid-control now only supports json configurations and no longer
builds from a YAML configuration.

Change-Id: I25fa7766399a1345dca89aac20e7b49caa

build: drop support for YAML configurations

phosphor-pid-control now only supports json configurations and no longer
builds from a YAML configuration.

Change-Id: I25fa7766399a1345dca89aac20e7b49caa46797e
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

conf change: pid: all pid details are now camelCase

Convert all PID configuration details are now camelCase instead of snake
case.

Change-Id: Id132053f122dfcd8abaace17df91c99758eb2b0c
Signed-off-by

conf change: pid: all pid details are now camelCase

Convert all PID configuration details are now camelCase instead of snake
case.

Change-Id: Id132053f122dfcd8abaace17df91c99758eb2b0c
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

conf change: sensors: read and write path rename

Rename the readpath and writepath for camelcase styling to make all
configuration variables consistent.

Change-Id: I33f475075c8f40cd2029a5c0bfda9508

conf change: sensors: read and write path rename

Rename the readpath and writepath for camelcase styling to make all
configuration variables consistent.

Change-Id: I33f475075c8f40cd2029a5c0bfda950846cd5d44
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

conf change: rename zone variables

Rename the zone variables to make them camelCase as a step towards
making all configuration variables camelCase for consistency.

Note: This patchset requires a ch

conf change: rename zone variables

Rename the zone variables to make them camelCase as a step towards
making all configuration variables camelCase for consistency.

Note: This patchset requires a change to your yaml configuration if
you're using it, or libconfig if you're using it.

Change-Id: If9cf1d7eb8227d305a1625275f2f7082c0d6905a
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Move all variant usage to std

This just a style change, remove variant_ns
in favor of std.

Tested-by: it built

Change-Id: Id5a075e8b73a7724cbc5153fb7dfcf369e79c483
Signed-off-by: James Feist <jame

Move all variant usage to std

This just a style change, remove variant_ns
in favor of std.

Tested-by: it built

Change-Id: Id5a075e8b73a7724cbc5153fb7dfcf369e79c483
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add Hysteresis to pid controllers

Add hysteresis to pid controllers to lower pwm changes.
It is defaulted to 0 so it should be transparent
to any controller that choses not to implement it.
This is

Add Hysteresis to pid controllers

Add hysteresis to pid controllers to lower pwm changes.
It is defaulted to 0 so it should be transparent
to any controller that choses not to implement it.
This is the same pattern used by the stepwise controller.

Tested-by: Unit tests passed

Change-Id: Ib47114285b0017258b7f77eaf067d310f95a0c60
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

[dbus-configuration] Add regex support

Add regex support to sensors when defining PIDs
so that we don't have to type all elements of a
single type, for instance all Cores of a CPU.

Tested-by: Added

[dbus-configuration] Add regex support

Add regex support to sensors when defining PIDs
so that we don't have to type all elements of a
single type, for instance all Cores of a CPU.

Tested-by: Added a configuration with inputs

"Inputs": [
"Core \\d+ CPU0"
],

And saw all Cores added when debug printing was turned
on.

Change-Id: I21c60d1cfc83b12aaa12039f09227f22f2b1d2b9
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Change all default_bus back to new_system bus

new_default now returns a reference to a single bus,
phosphor-pid-control uses multiple busses so we do not
want that. This was the way it was implement

Change all default_bus back to new_system bus

new_default now returns a reference to a single bus,
phosphor-pid-control uses multiple busses so we do not
want that. This was the way it was implemented prior to
https://github.com/openbmc/sdbusplus/commit/8ca6025eed193c252149b2908c3d5e37b00b0107

Tested-by: swampd ran normally

These errors go away:

Jan 28 18:28:45 swampd[1760]: terminate called after throwing an instance of 'sdbusplus::exception::SdBusError'
Jan 28 18:28:45 swampd[1760]: what(): sd_bus_request_name: org.freedesktop.DBus.Error.InconsistentMessage: Bad message

Change-Id: I708cd5e6c45509f27d4fe783c0b0cfb52ff10336
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Remove singleton from dbuswriter

When you create multiple zones, they are added to multiple
threads. Doing so causes multiple threads to access the
single bus object, which is illegal in sd_bus and

Remove singleton from dbuswriter

When you create multiple zones, they are added to multiple
threads. Doing so causes multiple threads to access the
single bus object, which is illegal in sd_bus and
occasionally causes a crash on start like the below.

Assertion 'IN_SET(bus->state, BUS_RUNNING, BUS_HELLO)' failed at
../git/src/libsystemd/sd-bus/sd-bus.c:1720, function dispatch_wqueue().
Aborting.
Aborted (core dumped)

Tested-by: Started swampd multiple times and crash went away.

Change-Id: Ic44b93e51ecf3d39cd8b846bb3003516cdaf7816
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

dbusconfiguration: Change apply_visitor to visit

New sdbusplus changes remove apply_visitor.

Tested-by: Manually checked out latest sdbusplus and
made sure it built.

Change-Id: I4418cf29339c61df7a

dbusconfiguration: Change apply_visitor to visit

New sdbusplus changes remove apply_visitor.

Tested-by: Manually checked out latest sdbusplus and
made sure it built.

Change-Id: I4418cf29339c61df7a172c1b44a6347b5f20a6ea
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

dbusconfiguration: Fix and simplify zone calculation

This code was duplicated throughout the file and the index
calculation was wrong as .size() gave us greater than the
last index.

Tested-by: Adde

dbusconfiguration: Fix and simplify zone calculation

This code was duplicated throughout the file and the index
calculation was wrong as .size() gave us greater than the
last index.

Tested-by: Added two zones and set DEBUG = true to notice
all pids in the correct zone.

Change-Id: I8eaff89ffcbd75e68abca1e79ab9cfd67db0c03c
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

std::variant: Fixup apply_visitor calls

These should be std::visit compatible instead of the custom mapbox
apply_visitor.

Change-Id: I32098c02bda5a3699abace919426a6e4b9c8ae9c
Signed-off-by: William

std::variant: Fixup apply_visitor calls

These should be std::visit compatible instead of the custom mapbox
apply_visitor.

Change-Id: I32098c02bda5a3699abace919426a6e4b9c8ae9c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Move all floats to doubles

The code was developed initially around a pid loop implemented using
floats. Therefore, the code was converting back and forth between
double for sensor values as inputs

Move all floats to doubles

The code was developed initially around a pid loop implemented using
floats. Therefore, the code was converting back and forth between
double for sensor values as inputs and outputs from this PID loop.

Change-Id: I2d2919e1165103040729c9f16bb84fde3dd6b81b
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

dbusconfiguration: Protect against partial config

A zone details config is also required along with a
zone configuration or we'll end up crashing. Check
for both.

Tested-by: Removed Zone Details Co

dbusconfiguration: Protect against partial config

A zone details config is also required along with a
zone configuration or we'll end up crashing. Check
for both.

Tested-by: Removed Zone Details Config and daemon halted
correctly.

Change-Id: Icf3775eb4130fcf2683e12b272fb2051b0eb809f
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

cleanup: drop obsolete is_method_error checks

is_method_error is obsolete from sdbusplus.

Change-Id: Ia3fb76dd2f4a14eca51b3cfbcd50427b36d946b3
Signed-off-by: Patrick Venture <venture@google.com>

style: rename main globals per style

Rename the main global variables per openbmc style.

Change-Id: I9de8cf841304f24238ae0275b6904f4926a6892d
Signed-off-by: Patrick Venture <venture@google.com>

dbus: dbuswrite: add try/catch block on calls

The dbus calls can now except, therefore add try/catch blocks and report
the errors.

Change-Id: I8cae2576922fa9316065ef048e674beb48a58e88
Signed-off-by

dbus: dbuswrite: add try/catch block on calls

The dbus calls can now except, therefore add try/catch blocks and report
the errors.

Change-Id: I8cae2576922fa9316065ef048e674beb48a58e88
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

dbus: dbuswrite: use factory to catch errors

Add factories for creating DbusWrite and DbusWritePercent objects and
use these factories.

Change-Id: Iad222d4bf6c1fdf561daa4ba9d88a6644c0a5965
Signed-o

dbus: dbuswrite: use factory to catch errors

Add factories for creating DbusWrite and DbusWritePercent objects and
use these factories.

Change-Id: Iad222d4bf6c1fdf561daa4ba9d88a6644c0a5965
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

dbus: passive: move exception checking into factory

Move the exception checking into the factory to remove possibility of
exception during construction.

Change-Id: I22922f23247c0579ee2a3411b5c8cede

dbus: passive: move exception checking into factory

Move the exception checking into the factory to remove possibility of
exception during construction.

Change-Id: I22922f23247c0579ee2a3411b5c8cede44fe324c
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

dbus: util: add missing try/catch block

Add missing try/catch block to getProperties.

Change-Id: Ie1f08f496dc529432df620879416e8bddb2e7d5c
Signed-off-by: Patrick Venture <venture@google.com>

style: function names should be lower camel

Fix function names to be lower camel.

Change-Id: I145e1f4c03d7740bc1525dcffbdce2f78fd61075
Signed-off-by: Patrick Venture <venture@google.com>