dbus: util: add missing try/catch block

Add try/catch block around ObjectMapper call failures.

Change-Id: I5a2a7a8c1049ea16cebe8b87a509bf5104e432ab
Signed-off-by: Patrick Venture <venture@google.co

dbus: util: add missing try/catch block

Add try/catch block around ObjectMapper call failures.

Change-Id: I5a2a7a8c1049ea16cebe8b87a509bf5104e432ab
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

style: member functions should be lower camel

Rename member functions to be lower camel instead of snake case.

Change-Id: Ib227fd3dadb6d9607290277205223a4324cd4ce5
Signed-off-by: Patrick Venture <v

style: member functions should be lower camel

Rename member functions to be lower camel instead of snake case.

Change-Id: Ib227fd3dadb6d9607290277205223a4324cd4ce5
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

style: fixup naming of structures

Fixup naming of structures to UpperCamel.

Change-Id: I6a9bf0b954298089c85d3362e86cd95b3fc5b944
Signed-off-by: Patrick Venture <venture@google.com>

dbusconfiguration: lower cpu cycles while waiting

Put in a wait()

Tested-by: Ran on a system without config, noticed lower
cpu cycles

Change-Id: I7e59db2bd2f7d7a8fd8695a6277dfed1a86b8ab3
Signed-of

dbusconfiguration: lower cpu cycles while waiting

Put in a wait()

Tested-by: Ran on a system without config, noticed lower
cpu cycles

Change-Id: I7e59db2bd2f7d7a8fd8695a6277dfed1a86b8ab3
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

dbusconfiguration: Fix mapper call

Our downstream version of the cpp mapper allowed an
empty path for GetSubTree, change this to root "/".

Tested-by: Configuration loads with both mappers

Change-I

dbusconfiguration: Fix mapper call

Our downstream version of the cpp mapper allowed an
empty path for GetSubTree, change this to root "/".

Tested-by: Configuration loads with both mappers

Change-Id: I206d2deaf9bb54acda15eccb778633f10398098a
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

cleanup: apply constness to read-only iterators

Apply const to read-only iterators to indicate intent more clearly.

Change-Id: Ic14304c69361da203d3d3a900180bd54346acc87
Signed-off-by: Patrick Ventu

cleanup: apply constness to read-only iterators

Apply const to read-only iterators to indicate intent more clearly.

Change-Id: Ic14304c69361da203d3d3a900180bd54346acc87
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

[dbus-passive] Add threshold fan failure

When a threshold is crossed for a monitored sensor,
assert fan failure.

Tested-by: Changed a sensor threshold so that its current
reading made the threshold

[dbus-passive] Add threshold fan failure

When a threshold is crossed for a monitored sensor,
assert fan failure.

Tested-by: Changed a sensor threshold so that its current
reading made the threshold asserted and noticed via print
messages that the sensor went into failure state. Also
noticed fans ramp. Wrote unit test to verify sensor can
move in and out of error state correctly.

Change-Id: I83182536e4874eaba97f3f1d48d53ac110fba833
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

dbus: set inclusion to local-first search

Use local-first search for local headers.

Change-Id: Ib9094836c6b2932804d0d46ca8eaad0e1e4259e4
Signed-off-by: Patrick Venture <venture@google.com>

dbus: transition to find_if

[dbus/dbusconfiguration.cpp:58]: (style) Consider using std::find_if algorithm
instead of a raw loop.

Change-Id: I6fdabecc027addfc6f843a4b5f4621a61db39c2d
Signed-off-by:

dbus: transition to find_if

[dbus/dbusconfiguration.cpp:58]: (style) Consider using std::find_if algorithm
instead of a raw loop.

Change-Id: I6fdabecc027addfc6f843a4b5f4621a61db39c2d
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Stop using mapbox namespace directly

sdbusplus is transitioning to std::variant, the
sdbusplus::message::variant_ns will be changed to std
and should move over correctly, but mapbox will be deleted.

Stop using mapbox namespace directly

sdbusplus is transitioning to std::variant, the
sdbusplus::message::variant_ns will be changed to std
and should move over correctly, but mapbox will be deleted.

Tested-by: It built

Change-Id: I25672cef16a6c75ae2f3619d319ade1eb063a98b
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

[dbus-writer] limit d-bus traffic

Limit d-bus traffic by only sending updates, instead
of every value.

Tested-by: used d-bus monitor and noticed significantly
reduced messages.

Change-Id: Ie677fea

[dbus-writer] limit d-bus traffic

Limit d-bus traffic by only sending updates, instead
of every value.

Tested-by: used d-bus monitor and noticed significantly
reduced messages.

Change-Id: Ie677feaedab4e9ebb14950392b9588d4d82c0058
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

[dbusconfiguration] Allow partial configurations

In a few cases (cpu sensors, etc.) we can
add sensor during runtime, that aren't an error to be missing
when the system is off, or are optional (add-

[dbusconfiguration] Allow partial configurations

In a few cases (cpu sensors, etc.) we can
add sensor during runtime, that aren't an error to be missing
when the system is off, or are optional (add-in cards).
Add a dbus match to restart on sensors added, and don't
add configurations that are missing a sensor.

Tested-by: Turned on debug, noticed on cpu sensors being
added daemon restarted correctly. Also noticed daemon
didn't crash with no configuration.

Change-Id: Ide0bd03c12e380e5aad56b1da06e34a5fc5cdb9f
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add hysteresis to stepwise controller

Tested-by: Ran on platform monitoring output and wrote
unit test

Change-Id: I74a1d21544c1a9cb4c1cb26dd4a353cbff0442d0
Signed-off-by: James Feist <james.feist@l

Add hysteresis to stepwise controller

Tested-by: Ran on platform monitoring output and wrote
unit test

Change-Id: I74a1d21544c1a9cb4c1cb26dd4a353cbff0442d0
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add stepwise controller

This adds the ability to use stepwise curves alongside
pid control. This creates a base controller class that
pidcontroller and stepwise controller inherit from.

Note: Hyste

Add stepwise controller

This adds the ability to use stepwise curves alongside
pid control. This creates a base controller class that
pidcontroller and stepwise controller inherit from.

Note: Hysteresis to come in follow-on patch

Tested-by:
Created a stepwise controller and noticed that when it
crossed a threshold that it contributed to the pwm setting.

Change-Id: I6cf842f80eaccafc905d620970afe91e2092d568
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

DbusConfiguration Flatten configuration

It didn't make much sense to have the ILimit and OutLimit
be their own interface. Entity Manager change to be submitted
shortly.

Tested-By: Used configuratio

DbusConfiguration Flatten configuration

It didn't make much sense to have the ILimit and OutLimit
be their own interface. Entity Manager change to be submitted
shortly.

Tested-By: Used configuration from review
https://gerrit.openbmc-project.xyz/#/c/12082/ and verified swampd
still controlled fans properly.

Change-Id: Id183cd09eba43f65fb80c9a4af7092f5e2e0cc08
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

clang-format: fix pointer alignment, sort using

Change-Id: Id433d0ecc10c62807594b3a637e591045223faa6
Signed-off-by: Patrick Venture <venture@google.com>

add .clang-format

Change-Id: I6627b5569c2e0f730be7331403218b823a2c622f
Signed-off-by: Patrick Venture <venture@google.com>

dbusConfiguration: restart on configuration change

Watch for dbus interface changes and stop the daemon
when they happen. Systemd should restart us if we have
the correct service file written.

Test

dbusConfiguration: restart on configuration change

Watch for dbus interface changes and stop the daemon
when they happen. Systemd should restart us if we have
the correct service file written.

Tested-by: Used new add object entity-manager interface
and noticed daemon restart when new config was added.

Change-Id: I708447dbb6ed2ab23b60036d310606ef7a1a7d3b
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add double support for sensor interface

Add support for reading sensors that produce a double
as the value. Use a visitor to pull out the sensor value
so type doesn't matter.

Change-Id: I37c05e7077

Add double support for sensor interface

Add support for reading sensors that produce a double
as the value. Use a visitor to pull out the sensor value
so type doesn't matter.

Change-Id: I37c05e7077ead6f3084ab9704a1b2c62becb5e19
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add ability to configure from dbus

This allows configuration of PID control from dbus using
entity manager. Sample configuration will be pushed to
entity-manager repo shortly.

Tested-by: Used yaml

Add ability to configure from dbus

This allows configuration of PID control from dbus using
entity manager. Sample configuration will be pushed to
entity-manager repo shortly.

Tested-by: Used yaml configuration and dbus / entity-manager
based configuration and pid seemed to work the same.
Verified printout of configuration matched generated
cpp files.

Change-Id: Ia7b016e53262791ffcccdb9b21c1ccddae2926bc
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

test: dbus: passive read interface

Added basic unit-tests and added a factory for creating the
DbusPassive read interface so that it can be nicely error checked. This
is handled via a valid type ch

test: dbus: passive read interface

Added basic unit-tests and added a factory for creating the
DbusPassive read interface so that it can be nicely error checked. This
is handled via a valid type check where the only valid types are 'fan'
and 'temp'.

Change-Id: I558ed09bf509d26f20c6e431bb0789074e9aa841
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

dbus: transition to interface for testing

To make testing easier, the dbus objects now receive a
helper interface to use instead of calling into a helper module.

Tested: Ran on quanta-q71l board an

dbus: transition to interface for testing

To make testing easier, the dbus objects now receive a
helper interface to use instead of calling into a helper module.

Tested: Ran on quanta-q71l board and it behaved as expected.

Change-Id: I2521d9c75aec76e92d2e26dc044d01011e44d552
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

dbus: dbuspassive refactor

Moved the sensor value handler into a sub routine to enable testing.

Tested: Ran on quanta-q71l board and it behaved as expected.

Change-Id: I4873558cfc1a48a92fb60cd173d

dbus: dbuspassive refactor

Moved the sensor value handler into a sub routine to enable testing.

Tested: Ran on quanta-q71l board and it behaved as expected.

Change-Id: I4873558cfc1a48a92fb60cd173dc69e237813683
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

dbus: util: Remove explicit element count

The dbus interface can have new properties added, and
it's improbable to have the three we care about removed.
Therefore, let's remove the explicit count ch

dbus: util: Remove explicit element count

The dbus interface can have new properties added, and
it's improbable to have the three we care about removed.
Therefore, let's remove the explicit count check on the
number of properties returned.

Change-Id: Ia292c73dc889a33a4b1f334585bbce910f20a580
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Sensor Objects

This includes all the sensor objects including a few
implementations, including dbus and sysfs sensors.

Change-Id: I9897c79f9fd463f00f0e02aeb6c32ffa89635dbe
Signed-off-by: Patrick Ve

Sensor Objects

This includes all the sensor objects including a few
implementations, including dbus and sysfs sensors.

Change-Id: I9897c79f9fd463f00f0e02aeb6c32ffa89635dbe
Signed-off-by: Patrick Venture <venture@google.com>

show more ...