associations: drop unused server parameter

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: Ic6d406b09f2552dcf0d6bf9ba284b37690f1563e

style: comply with OpenBMC style guidelines

Change-Id: I72f86c59a0502777c861de901907c0a556c4c6c5
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

naming: be inclusive

Adhere to the project inclusive naming guidelines and also adhere to the
OpenBMC style guidelines.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I5a365049

naming: be inclusive

Adhere to the project inclusive naming guidelines and also adhere to the
OpenBMC style guidelines.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I5a365049b6fb27236dd55c8455fe13a4a9e7fd31

show more ...

clang-format: update to OpenBMC latest

Ignore libmapper, because it is written in C and the CPP style
guidelines are not appropriate.

Ignore subprojects; they can validate their formatting themselv

clang-format: update to OpenBMC latest

Ignore libmapper, because it is written in C and the CPP style
guidelines are not appropriate.

Ignore subprojects; they can validate their formatting themselves.

Change-Id: Id88dcc49f4176c6443e7f53ca193ca8f3e83a51f
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

meson: Add phosphor-dbus-interfaces dependency

This dependency was added with b15df6b2 but not added to meson.build,
which prevents the project from building in meson subproject mode.

Fixes: b15df6

meson: Add phosphor-dbus-interfaces dependency

This dependency was added with b15df6b2 but not added to meson.build,
which prevents the project from building in meson subproject mode.

Fixes: b15df6b28b97a0887e52d5f5e5899b10475943e1
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I0653d6c7599cfcfc3d66c9e326a0a691bc6f978e

show more ...

mapper-wait: increase polling speed

5 seconds is a really long time for one daemon to be waiting for
another to start up. Decrease the polling interval to 1s and increase
the number of retries corr

mapper-wait: increase polling speed

5 seconds is a really long time for one daemon to be waiting for
another to start up. Decrease the polling interval to 1s and increase
the number of retries correspondingly.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id27bfbe22c566b3aa057d4692778d6c0244722c1

show more ...

meson: simplify dependencies

Leverage wrapfile `[provide]` directives to simplify the dependency
searching in the meson.build.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I39d423

meson: simplify dependencies

Leverage wrapfile `[provide]` directives to simplify the dependency
searching in the meson.build.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I39d423dad8a08949317c991b845aaa5fc23969a4

show more ...

Use sdbusplus exception instead of the custom one

Currently mapper generates custom 'NotFoundException' exception when
a path is not found in the object list.
Instead of creating another exception u

Use sdbusplus exception instead of the custom one

Currently mapper generates custom 'NotFoundException' exception when
a path is not found in the object list.
Instead of creating another exception use 'ResourceNotFound' exception
from the sdbusplus library.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: Ic4fa9d2eac56dc79782e7453113574197ffce49b

show more ...

libmapper: Add missing double include guard

Change-Id: I884619d0ef6588c30f63c5c5f7d14e0dc5249b6f
Signed-off-by: William A. Kennington III <wak@google.com>

Add OWNERS file

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Ia05900171568ad40f7a71ba6e24a25a8459bac2b

Move mapper methods to free functions

As a design pattern, free functions are preferable to lambdas because
they reduce scopes, and produce better stack traces which include the
name of the function

Move mapper methods to free functions

As a design pattern, free functions are preferable to lambdas because
they reduce scopes, and produce better stack traces which include the
name of the function when things go wrong. This commit moves them.
Unfortunately, because of the interface_map capture, we still need the
lambda to be able to capture that reference, but that still seems much
better than leaving everything in a lambda.

In theory, this also makes them easier to unit test, although that
pattern isn't shown directly in this patchset.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ib3ade71ab4572378461a62e233738776578de2f1

show more ...

meson.build: drop config.h

These DBus things (service, interface, path) are not intended to be
configurable in any way. Try to discourage them from being changed by
removing them from meson.build j

meson.build: drop config.h

These DBus things (service, interface, path) are not intended to be
configurable in any way. Try to discourage them from being changed by
removing them from meson.build just in case that suggests that perhaps
they are meant to be overriden.

As the DBus names are the only content in config.h, config.h can be
removed completely.

Change-Id: I654473333932a8626a0ace5ee5a865dd14aaf296
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

exception: add errno

NotFoundException inherits from an sdbusplus exception, which
now requires a 'get_errno' interface.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I549f26a0f209

exception: add errno

NotFoundException inherits from an sdbusplus exception, which
now requires a 'get_errno' interface.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I549f26a0f2096df3be6cc05870c58755e46f393b

show more ...

Replace IRC with Discord

Discord has more users. IRC traffic has ground to a halt.

Signed-off-by: Bruce Mitchell <bruce.mitchell@linux.vnet.ibm.com>
Change-Id: I39b3b2210368134b191d34d41941a8275fc0

Replace IRC with Discord

Discord has more users. IRC traffic has ground to a halt.

Signed-off-by: Bruce Mitchell <bruce.mitchell@linux.vnet.ibm.com>
Change-Id: I39b3b2210368134b191d34d41941a8275fc03009

show more ...

build: drop autotools support

Change-Id: Ic159830e2ccbc8934f23eb4eff7d15c83a7ffaf0
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

build: switch to c++20

Change-Id: Ibe16889749f6b61a3bc8d9a2979b0f7a789cbc24
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

build: Add meson support

Add support for buildling with meson.

Support for --enable-oe-sdk is dropped because running unit tests on the
build system is now supported directly with meson subprojects

build: Add meson support

Add support for buildling with meson.

Support for --enable-oe-sdk is dropped because running unit tests on the
build system is now supported directly with meson subprojects:

meson buildir && ninja -C buildir test

I tested this by building a witherspoon image and booting it to
multi-user and verifying the mapper-wait functionality works correctly.

Change-Id: I86e5efc7b7c89183219a4c890ad658e334765fc1
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

tests: fix use-after-free

sdbusplus::asio::connection saves a reference to the io context passed
to its constructor so we need to increase its scope.

Change-Id: Ia1bf05871329a06ec39e6c0cef17e92c0d3

tests: fix use-after-free

sdbusplus::asio::connection saves a reference to the io context passed
to its constructor so we need to increase its scope.

Change-Id: Ia1bf05871329a06ec39e6c0cef17e92c0d37b138
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

libmapper: allow use of session bus for non-root

sd_bus_default will automatically pick the system bus when run as root
as intended. By using sd_bus_default instead of sd_bus_default_system
we can

libmapper: allow use of session bus for non-root

sd_bus_default will automatically pick the system bus when run as root
as intended. By using sd_bus_default instead of sd_bus_default_system
we can connect to a mapper daemon running on the session bus.

https://www.freedesktop.org/software/systemd/man/sd_bus_open_user.html

Change-Id: I7accd6119bfd84351f9a99af7cdd0dc6bf29a83c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

libmapper: fix memory leak

Fix a minor leak that occurs if a user passes zero dbus paths to wait
for.

Change-Id: I05eb8b3dbd808978ad9d566a74aee5272aa4c1e3
Signed-off-by: Brad Bishop <bradleyb@fuzzi

libmapper: fix memory leak

Fix a minor leak that occurs if a user passes zero dbus paths to wait
for.

Change-Id: I05eb8b3dbd808978ad9d566a74aee5272aa4c1e3
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

libmapper: use size_t

Use the correct type (size_t) for array sizes.

Change-Id: I337019ab7a4b125f6b64cff29dcf4bff15a80168
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

mapper client: drop patch build configuration

Support for --enable-unpatched-systemd is dropped because
sd_bus_message_append_cmdline is no longer used after
2d04816fb5a1811694272818ec41b5364ce3c691

mapper client: drop patch build configuration

Support for --enable-unpatched-systemd is dropped because
sd_bus_message_append_cmdline is no longer used after
2d04816fb5a1811694272818ec41b5364ce3c691.

Change-Id: I926ce4a0a1077ea99c14098230c2ee171ec13781
Fixes: 2d04816fb5a1811694272818ec41b5364ce3c691
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

build: fix unused-parameter warnings

A couple changes to enable the use of -Wunused-parameter.

libmapper is built with the c compiler, which does not support omitting
the parameter name in the func

build: fix unused-parameter warnings

A couple changes to enable the use of -Wunused-parameter.

libmapper is built with the c compiler, which does not support omitting
the parameter name in the function definition, so use the de-facto
workaround and define an UNUSED() cpp macro.

Change-Id: I1c0d79d33097417fc3689351c4787e591fc23e9c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

libmapper: fix logic bug

sarraylen returns the number of strings and does not include the
trailing null pointer. This results in sarraydup creating arrays of
strings where the array is not null poi

libmapper: fix logic bug

sarraylen returns the number of strings and does not include the
trailing null pointer. This results in sarraydup creating arrays of
strings where the array is not null pointer terminated (the strings
themselves _are_ \0 terminated), which in turn causes random data to be
passed to free.

The bug was found using static analysis and inspection would indicate
exposure only exists on error and shutdown paths, which might be a hint
as to how this has been lurking for as long as it has.

Change-Id: Ie5e5b6cdfb7832c84037ff039b41082fc7d20b61
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

libmapper: hide symbols by default

Hide symbols unless explicitly un-hidden. This facilitates putting unit
tests in different translation units by enabling non static declarations
yet still prevent

libmapper: hide symbols by default

Hide symbols unless explicitly un-hidden. This facilitates putting unit
tests in different translation units by enabling non static declarations
yet still preventing their use by other applications.

Change-Id: Ia85babcae5ec705bf6227bdfc1da438ba9ad587d
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...