Fix interfaces added logic error

Fix a bug that prevents the mapper from correctly processing
an interfaces added signal when the interface is added to an
object that already has interfaces that hav

Fix interfaces added logic error

Fix a bug that prevents the mapper from correctly processing
an interfaces added signal when the interface is added to an
object that already has interfaces that have been processed.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I1a9045c14d1d8b70151a8f5cc95eb18dbb20c79f

show more ...

Add phosphor-unit-failure-monitor framework

This application is designed to be called from the
OnFailure directive in a systemd unit file. It will
stop or start another unit when the current unit
f

Add phosphor-unit-failure-monitor framework

This application is designed to be called from the
OnFailure directive in a systemd unit file. It will
stop or start another unit when the current unit
fails enough times to exceed its restart policy so
it isn't restarted again.

To do this, this application will check the ActiveState
property of the failing unit. When it is 'failed', the
target unit will be started (or stopped).

The failing unit name, the target unit name, and if the
target should be stopped or started are all passed in
on the command line.

Change-Id: I93ecccaf1c091abddb769ddad8f43ecd9902210b
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

build: change oldincludedir to includedir

Change-Id: I070d49e5ea488547eaded4d88b468c8eb85641f3
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

libmapper: Add subtree callback functions

Implement subtree callback functions for match, getpaths,
and timeout.

Change-Id: I1037a52fced9e47aa630ebb9ae39b745349acb95
Signed-off-by: Adriana Kobylak

libmapper: Add subtree callback functions

Implement subtree callback functions for match, getpaths,
and timeout.

Change-Id: I1037a52fced9e47aa630ebb9ae39b745349acb95
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

libmapper: Add function to call GetSubTreePaths

Call the dbus method GetSubTreePaths to look for the
specified interface.

Change-Id: If266fc0db2c10582eeb9438e91f9556dcb525e39
Signed-off-by: Adriana

libmapper: Add function to call GetSubTreePaths

Call the dbus method GetSubTreePaths to look for the
specified interface.

Change-Id: If266fc0db2c10582eeb9438e91f9556dcb525e39
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

libmapper: Add match for removed interfaces

Add a match to look for removed interfaces.

Change-Id: If5bd68254b88c664c33f443ea593974b87996b42
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

Create libmapper subtree function and call it in event loop

Call a new mapper subtree interface in an event loop.
Create an enum to specify the mapper action, in this case
wait for an interface to b

Create libmapper subtree function and call it in event loop

Call a new mapper subtree interface in an event loop.
Create an enum to specify the mapper action, in this case
wait for an interface to be removed. This allows to later
add other operations like wait for an interface to be added
since the logic would be different.

Change-Id: I8330852d47185c3c4e40e994c6e4719054a9fc06
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

app: Split subtree argument

Split the argument string on the first colon (:) character
to get the namespace and interface.

Change-Id: Ia9c67bd149c23e68945fd80252a93a2f1fe78382
Signed-off-by: Adrian

app: Split subtree argument

Split the argument string on the first colon (:) character
to get the namespace and interface.

Change-Id: Ia9c67bd149c23e68945fd80252a93a2f1fe78382
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

app: Add subtree-remove option

New mapper option to wait until a specified interface is not
present in any of the subtrees of the specified namespace.
Usage:
mapper subtree-remove <NAMESPACE>:<INT

app: Add subtree-remove option

New mapper option to wait until a specified interface is not
present in any of the subtrees of the specified namespace.
Usage:
mapper subtree-remove <NAMESPACE>:<INTERFACE>
mapper subtree-remove /foo/namespace:bar.interface

A future change could add an additional option to wait for
interfaces to appear in a subtree of the specified path.

Note that the subtree option will look for the interface in
the subtree paths, not on the specified base namespace path.
So in order to find an interface in /base/level1/level2,
then the specified namespace path should be /base/level1/.

Change-Id: I862310d819c505c59161adcce338041a08e1218c
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Revert "Add mapper-wait-until-removed"

This reverts commit 9f4c3c7c408a5f84a52416da99d0dd8035f1ae5a.

After further design discussions, the new wait until
removed implementation should be a new API.

Revert "Add mapper-wait-until-removed"

This reverts commit 9f4c3c7c408a5f84a52416da99d0dd8035f1ae5a.

After further design discussions, the new wait until
removed implementation should be a new API. Reverting this
change to put back the original wait interfaces since new
ones will be created instead of modifying the existing ones.

Change-Id: I605439dcb24c6dca7f394325afc6587eacf417f1
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Revert "wait-until-removed: Add Interface parameter"

This reverts commit e4d6c79030ad7b7638d0fc5ea09cf13afe224cda.

The commit had incomplete changes, reverting it since the
implementation is changi

Revert "wait-until-removed: Add Interface parameter"

This reverts commit e4d6c79030ad7b7638d0fc5ea09cf13afe224cda.

The commit had incomplete changes, reverting it since the
implementation is changing per feedback from code reviews.

Change-Id: Ia99b9ae57cda805d419f3ed0e326c09154335051
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

wait-until-removed: Add Interface parameter

The additional interface parameter can be a string
(ex. "intf" "obj1"), or be in a single string with
the obj parameter (ex. "intf obj1 obj2..."). The
lat

wait-until-removed: Add Interface parameter

The additional interface parameter can be a string
(ex. "intf" "obj1"), or be in a single string with
the obj parameter (ex. "intf obj1 obj2..."). The
latter is used when passing the parameters from
a systemd unit.
The wait-until-removed option will block until the
requested interface is not present in the specified
dbus object.

Change-Id: Ia935af5721e2aec8c271eff483cff9c3a1f1fa24
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Add mapper-wait-until-removed

This option will do the opposite of mapper wait
by blocking if a dbus object exists until that
object is removed.

Change-Id: Ia460b1ffdb912ba475b15ae5f8499a177e801dfd

Add mapper-wait-until-removed

This option will do the opposite of mapper wait
by blocking if a dbus object exists until that
object is removed.

Change-Id: Ia460b1ffdb912ba475b15ae5f8499a177e801dfd
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Move object_mapper per dbus path conventions.

Partial fix for openbmc/openbmc#1112.

Change-Id: I964620e7b741dffbf5a680ae775f371a28143860
Signed-off-by: Leonel Gonzalez <lgonzalez@us.ibm.com>

Add get-service option to mapper tool

Adding this feature will allow services to use the
busctl command without hard coding the dbus service
information

Change-Id: Ibdfb2e0dce97486ad4dd6784257fa81c

Add get-service option to mapper tool

Adding this feature will allow services to use the
busctl command without hard coding the dbus service
information

Change-Id: Ibdfb2e0dce97486ad4dd6784257fa81c1122dba2
Signed-off-by: Andrew Geissler <andrewg@us.ibm.com>

show more ...

Don't return errors when busy

Respond to method calls when the mapper is in the
middle of processing a NameOwnerChanged signal, rather
than returning ObjectPathInUse.

Prior to this patch mapper res

Don't return errors when busy

Respond to method calls when the mapper is in the
middle of processing a NameOwnerChanged signal, rather
than returning ObjectPathInUse.

Prior to this patch mapper responses guaranteed causal ordering.
This patch removes that guarantee in order to remove the need
for operation retries.

Achieving both causal ordering and blocking responses is not possible
with python-dbus without additional threads. This workaround will
serve as a mitigation until the mapper can be written with sdbus
bindings that do not have the limitations of python-dbus.

Resolves openbmc/openbmc#1145

Change-Id: Idc21a11d7cc815bc8d0fcb7f18edc63bfed14da9
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Add xyz.openbmc_project.ObjectMapper.Private

The mapper client bindings currently use the NameOwnerChanged
signal as a trigger for a mapper query when waiting for an
object to appear on the bus. Th

Add xyz.openbmc_project.ObjectMapper.Private

The mapper client bindings currently use the NameOwnerChanged
signal as a trigger for a mapper query when waiting for an
object to appear on the bus. This works because at the moment
the mapper returns a busy response to clients in the window
between NameOwnerChanged and completion of its discovery.

A forthcoming patch will change this behavior such that the
mapper will go ahead and respond in the window to improve
overall mapper responsiveness, at the cost of the current
causal ordering guarantee.

The ordering guarantee is what allows the current wait binding
implementation to work. Without it, the wait binding requires
a means to determine when it is safe to make a make a query.

Add a new mapper interface xyz.openbmc_project.ObjectMapper.Private
with a single signal IntrospectionComplete to meet this
requirement. "Private" because the signal should only be
consumed by the mapper client bindings.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: Ia7b65cd7edd37c49fa7b5ad808b0c59304c68717

show more ...

Add retries for LimitsExceeded errors

There will now be retries for the LimitsExceeded
exceptions just like the ObjectPathInUse ones.

Resolves openbmc/openbmc#978.

Change-Id: Ide1465372148d804c522

Add retries for LimitsExceeded errors

There will now be retries for the LimitsExceeded
exceptions just like the ObjectPathInUse ones.

Resolves openbmc/openbmc#978.

Change-Id: Ide1465372148d804c522f99e252a0c6c48e7da41
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Changing default retry interval to 0.2 seconds

Resolves openbmc/openbmc#974.

Change-Id: I05e0ad31d98398a0375d4db620a388d4af1dec8a
Signed-off-by: Cory Klokman <cklokma@us.ibm.com>

Add sleep between retires in bindings

In bindings.py the common retry() function uses a busy loop to retry, in
some cases the busy loop just increase the work loads of mapper and the
caller still ge

Add sleep between retires in bindings

In bindings.py the common retry() function uses a busy loop to retry, in
some cases the busy loop just increase the work loads of mapper and the
caller still get the ObjectPathInUse exception. It's better to sleep for
a while between retries.

A sleep interval is added as parameter default to 0, so the change does
not break existing functions. Then the caller has an option to pass a
sleep interval to indiciate it would sleep for an interval between
retries.

Change-Id: Ie1f248dc0b1be291dfa597eba2f58ba9bf247d6b
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Increase retries times on ObjectPathInUse exception

In get_object_async() when calling ObjectMapper.GetObject(),
ObjectPathInUse exception may raise and it will retry.
Previously it retries for 5 ti

Increase retries times on ObjectPathInUse exception

In get_object_async() when calling ObjectMapper.GetObject(),
ObjectPathInUse exception may raise and it will retry.
Previously it retries for 5 times with 1000ms interval, it sometimes
cause get_object_async() raise this exception and system_manager
will not enter BMC_READY state.

This workaround increases the retry times to 20 and reduce the
interval to 500ms, so far the issue is not reproduced.

Partially fix openbmc/openbmc#862

Change-Id: Icaccc31c896e52b1c056007dff5c72d213bb7fa8
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Correct out-of-tree builds for systemd workaround

Change-Id: I27c92f1b31da36a00585fa07376766a1f94e81df
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

Workaround sd_bus_message_append_cmdline

Unable to get libmapper built without systemd being patched with the
sd_bus_message_append_cmdline function. Until it is pushed upstream,
this is a workaroun

Workaround sd_bus_message_append_cmdline

Unable to get libmapper built without systemd being patched with the
sd_bus_message_append_cmdline function. Until it is pushed upstream,
this is a workaround to get the available systemd install built for unit
testing.

Change-Id: Ieca78955a4182eebd469a860c37ccaedfe75d323
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Switch to use generated config.h

Remove libmapper/config.h and have configure put generated config.h in
libmapper directory.

Change-Id: I3591b719e7b66d532ddad3499c6092166ad9a442
Signed-off-by: Matt

Switch to use generated config.h

Remove libmapper/config.h and have configure put generated config.h in
libmapper directory.

Change-Id: I3591b719e7b66d532ddad3499c6092166ad9a442
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add path information on service lookup failure

Change-Id: Ie180b5a206eeb55c02149e5201c381652759bbdc
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>