build: fix -Wmissing-prototype

This helps make the author's original intent clear. Tested by building
and running the unit tests with clang.

Change-Id: If0231ec5634adad0b61e7fcff8ec1e5bcbbb92c1
Si

build: fix -Wmissing-prototype

This helps make the author's original intent clear. Tested by building
and running the unit tests with clang.

Change-Id: If0231ec5634adad0b61e7fcff8ec1e5bcbbb92c1
Signed-off-by: Brad Bishop <bradbish@qti.qualcomm.com>

show more ...

build: fix -Wmissing-variable-declarations

This helps make the author's original intent clear. Tested by building
and running the unit tests with clang.

Change-Id: Iaf0aca72b5a8cc931bcb84c27df1c55

build: fix -Wmissing-variable-declarations

This helps make the author's original intent clear. Tested by building
and running the unit tests with clang.

Change-Id: Iaf0aca72b5a8cc931bcb84c27df1c55d2f438dda
Signed-off-by: Brad Bishop <bradbish@qti.qualcomm.com>

show more ...

tidy: fix performance-avoid-endl

Tested by building the code.

Change-Id: I3de027d34b3e91bc08923b47bda16b0b0f4b34b4
Signed-off-by: Brad Bishop <bradbish@qti.qualcomm.com>

codespell: run and fix

Fix the misspellings. Tested by building the code and running the unit
tests.

Change-Id: I3fb3f1f46fa41bb0c65157ff6e68bc4f1079f280
Signed-off-by: Brad Bishop <bradbish@qti.q

codespell: run and fix

Fix the misspellings. Tested by building the code and running the unit
tests.

Change-Id: I3fb3f1f46fa41bb0c65157ff6e68bc4f1079f280
Signed-off-by: Brad Bishop <bradbish@qti.qualcomm.com>

show more ...

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I555df8382455157bff44671b6f284e3121d5c182
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I555df8382455157bff44671b6f284e3121d5c182
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Modernize mapper core types

There's a number of best practices that have evolved in our use of
flat_maps and flat_sets since this code was originally written.

First, add std::less<> to the Compare

Modernize mapper core types

There's a number of best practices that have evolved in our use of
flat_maps and flat_sets since this code was originally written.

First, add std::less<> to the Compare template argument. The default
for this is std::less<Key> which limits find() calls (and any lookup for
that matter) to only supporting std::string. Using std::less<> allows
lookup by std::string_view, which can prevent some copies in some cases.

Next, add std::vector<...> to the types under the AllocatorOrContainer
template arg. Per our coding standard, this overrides the default of
using boost::vector, and replaces it with std::vector, which, although
it has a very similar interface, tends to optimize better, and be better
supported overall.

The rest of this patch updates a couple places where the various types
were specifically hardcoded, so it moves to using the various using
declarations.

Tested: Unit tests; Next patch tests this more fully.

Change-Id: I11e8ecb669f31193c55dda344b25d3fa5d191502
Signed-off-by: Ed Tanous <edtanous@google.com>

show more ...

lint: fix trivial clang tidy errors

Change-Id: Ie5395004a451d6168249f56f75c5e6ae31dca4af
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

style: comply with OpenBMC style guidelines

Change-Id: I72f86c59a0502777c861de901907c0a556c4c6c5
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

tests: fix use-after-free

sdbusplus::asio::connection saves a reference to the io context passed
to its constructor so we need to increase its scope.

Change-Id: Ia1bf05871329a06ec39e6c0cef17e92c0d3

tests: fix use-after-free

sdbusplus::asio::connection saves a reference to the io context passed
to its constructor so we need to increase its scope.

Change-Id: Ia1bf05871329a06ec39e6c0cef17e92c0d37b138
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Check for missing endpoints when adding assocs

An association links 2 D-Bus object paths together, one
which is the path that has the original associations
property, and another endpoint path. It's

Check for missing endpoints when adding assocs

An association links 2 D-Bus object paths together, one
which is the path that has the original associations
property, and another endpoint path. It's possible that
that endpoint path doesn't exist on D-Bus when that
associations property is created.

This commit, along with upcoming ones, adds support to not
create the actual association object paths until that
endpoint path shows up on D-Bus. In addition, if that
endpoint path were to get removed from D-Bus in the future,
then the association paths should be removed until that
path is back again.

This particular commit introduces the PendingAssociations map
to track these cases, and adds support in the associationChanged
path to add associations to this map if the endpoint path isn't
on D-Bus instead of just blindly creating the association objects.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I1f4bf0e02bf7a350d9e3f18c3591737289a51a39

show more ...

unit-test: Debug functions to dump data structures

Visualizing the key data structures in objmgr can be very useful for
debug and for writing test cases

Example output when new function called:
##

unit-test: Debug functions to dump data structures

Visualizing the key data structures in objmgr can be very useful for
debug and for writing test cases

Example output when new function called:
##### interface_map_type #####
------------------------------------
OBJ PATH: /xyz/openbmc_project/test
DBUS SERVICE: xyz.openbmc_project.Test
INTERFACE: org.freedesktop.DBus.Introspectable
INTERFACE: org.freedesktop.DBus.Peer
INTERFACE: org.freedesktop.DBus.Properties
------------------------------------
##### AssociationOwnersType #####
------------------------------------
OBJ PATH: /xyz/openbmc_project/test/xyz
DBUS SERVICE: xyz.openbmc_project.Test
ASSOC PATH: /xyz/openbmc_project/inventory/system/chassis/error
ENDPOINT: /xyz/openbmc_project/test/xyz
ASSOC PATH: /xyz/openbmc_project/test/xyz/inventory
ENDPOINT: /xyz/openbmc_project/inventory/system/chassis
-----------------------------------
##### AssociationInterfaces #####
------------------------------------
OBJ PATH: /xyz/openbmc_project/inventory/system/chassis/error
ENDPOINTS: /xyz/openbmc_project/test/xyz
------------------------------------

Change-Id: I947ccdb071d887683c3998c6020677833579100c
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

unit-test: Test deleting entry on name change

Breaking off into a separate function enables easier unit testing of the
specific function

Testing: 97% coverage of processing.cpp

Change-Id: I08f2296

unit-test: Test deleting entry on name change

Breaking off into a separate function enables easier unit testing of the
specific function

Testing: 97% coverage of processing.cpp

Change-Id: I08f229657a8f44230b711fabbae20fb403792637
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

unit-test: Request distinct name per test app

gtest will run test suites in parallel, need to ensure each test suite
(application) requests a distinct well-known name on Dbus.

Change-Id: Ib59211ada

unit-test: Request distinct name per test app

gtest will run test suites in parallel, need to ensure each test suite
(application) requests a distinct well-known name on Dbus.

Change-Id: Ib59211ada5ef6404e70747b7377912384cc8c60e
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

unit-test: Move association create funcs to util

These will be useful in other test suites so move into util directory

Change-Id: Ibea5c417e38210e6e1388cf4492af10a64db9077
Signed-off-by: Andrew Gei

unit-test: Move association create funcs to util

These will be useful in other test suites so move into util directory

Change-Id: Ibea5c417e38210e6e1388cf4492af10a64db9077
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

unit-test: Move asio server to its own class

Other test suites will need this object so move to a utility directory
and inherit from.

Change-Id: Ia34c8149fc0df02c510717a6efd21f51086e97e6
Signed-off

unit-test: Move asio server to its own class

Other test suites will need this object so move to a utility directory
and inherit from.

Change-Id: Ia34c8149fc0df02c510717a6efd21f51086e97e6
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...