libmapper: format code using c++ clang-format

Remove libmapper/.clang-fromat and format code using c++ clang-format

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I62781743b03fa1e806

libmapper: format code using c++ clang-format

Remove libmapper/.clang-fromat and format code using c++ clang-format

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I62781743b03fa1e806f51f4844c93aaf4cdfac4f

show more ...

clang-format: update to OpenBMC latest

Ignore libmapper, because it is written in C and the CPP style
guidelines are not appropriate.

Ignore subprojects; they can validate their formatting themselv

clang-format: update to OpenBMC latest

Ignore libmapper, because it is written in C and the CPP style
guidelines are not appropriate.

Ignore subprojects; they can validate their formatting themselves.

Change-Id: Id88dcc49f4176c6443e7f53ca193ca8f3e83a51f
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

mapper-wait: increase polling speed

5 seconds is a really long time for one daemon to be waiting for
another to start up. Decrease the polling interval to 1s and increase
the number of retries corr

mapper-wait: increase polling speed

5 seconds is a really long time for one daemon to be waiting for
another to start up. Decrease the polling interval to 1s and increase
the number of retries correspondingly.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id27bfbe22c566b3aa057d4692778d6c0244722c1

show more ...

libmapper: Add missing double include guard

Change-Id: I884619d0ef6588c30f63c5c5f7d14e0dc5249b6f
Signed-off-by: William A. Kennington III <wak@google.com>

meson.build: drop config.h

These DBus things (service, interface, path) are not intended to be
configurable in any way. Try to discourage them from being changed by
removing them from meson.build j

meson.build: drop config.h

These DBus things (service, interface, path) are not intended to be
configurable in any way. Try to discourage them from being changed by
removing them from meson.build just in case that suggests that perhaps
they are meant to be overriden.

As the DBus names are the only content in config.h, config.h can be
removed completely.

Change-Id: I654473333932a8626a0ace5ee5a865dd14aaf296
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

build: drop autotools support

Change-Id: Ic159830e2ccbc8934f23eb4eff7d15c83a7ffaf0
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

build: Add meson support

Add support for buildling with meson.

Support for --enable-oe-sdk is dropped because running unit tests on the
build system is now supported directly with meson subprojects

build: Add meson support

Add support for buildling with meson.

Support for --enable-oe-sdk is dropped because running unit tests on the
build system is now supported directly with meson subprojects:

meson buildir && ninja -C buildir test

I tested this by building a witherspoon image and booting it to
multi-user and verifying the mapper-wait functionality works correctly.

Change-Id: I86e5efc7b7c89183219a4c890ad658e334765fc1
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

libmapper: allow use of session bus for non-root

sd_bus_default will automatically pick the system bus when run as root
as intended. By using sd_bus_default instead of sd_bus_default_system
we can

libmapper: allow use of session bus for non-root

sd_bus_default will automatically pick the system bus when run as root
as intended. By using sd_bus_default instead of sd_bus_default_system
we can connect to a mapper daemon running on the session bus.

https://www.freedesktop.org/software/systemd/man/sd_bus_open_user.html

Change-Id: I7accd6119bfd84351f9a99af7cdd0dc6bf29a83c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

libmapper: fix memory leak

Fix a minor leak that occurs if a user passes zero dbus paths to wait
for.

Change-Id: I05eb8b3dbd808978ad9d566a74aee5272aa4c1e3
Signed-off-by: Brad Bishop <bradleyb@fuzzi

libmapper: fix memory leak

Fix a minor leak that occurs if a user passes zero dbus paths to wait
for.

Change-Id: I05eb8b3dbd808978ad9d566a74aee5272aa4c1e3
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

libmapper: use size_t

Use the correct type (size_t) for array sizes.

Change-Id: I337019ab7a4b125f6b64cff29dcf4bff15a80168
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

mapper client: drop patch build configuration

Support for --enable-unpatched-systemd is dropped because
sd_bus_message_append_cmdline is no longer used after
2d04816fb5a1811694272818ec41b5364ce3c691

mapper client: drop patch build configuration

Support for --enable-unpatched-systemd is dropped because
sd_bus_message_append_cmdline is no longer used after
2d04816fb5a1811694272818ec41b5364ce3c691.

Change-Id: I926ce4a0a1077ea99c14098230c2ee171ec13781
Fixes: 2d04816fb5a1811694272818ec41b5364ce3c691
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

build: fix unused-parameter warnings

A couple changes to enable the use of -Wunused-parameter.

libmapper is built with the c compiler, which does not support omitting
the parameter name in the func

build: fix unused-parameter warnings

A couple changes to enable the use of -Wunused-parameter.

libmapper is built with the c compiler, which does not support omitting
the parameter name in the function definition, so use the de-facto
workaround and define an UNUSED() cpp macro.

Change-Id: I1c0d79d33097417fc3689351c4787e591fc23e9c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

libmapper: fix logic bug

sarraylen returns the number of strings and does not include the
trailing null pointer. This results in sarraydup creating arrays of
strings where the array is not null poi

libmapper: fix logic bug

sarraylen returns the number of strings and does not include the
trailing null pointer. This results in sarraydup creating arrays of
strings where the array is not null pointer terminated (the strings
themselves _are_ \0 terminated), which in turn causes random data to be
passed to free.

The bug was found using static analysis and inspection would indicate
exposure only exists on error and shutdown paths, which might be a hint
as to how this has been lurking for as long as it has.

Change-Id: Ie5e5b6cdfb7832c84037ff039b41082fc7d20b61
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

libmapper: hide symbols by default

Hide symbols unless explicitly un-hidden. This facilitates putting unit
tests in different translation units by enabling non static declarations
yet still prevent

libmapper: hide symbols by default

Hide symbols unless explicitly un-hidden. This facilitates putting unit
tests in different translation units by enabling non static declarations
yet still preventing their use by other applications.

Change-Id: Ia85babcae5ec705bf6227bdfc1da438ba9ad587d
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

mapper-wait: handle switch to openbmc exceptions

libmapper was searching for specific errno values (ENOENT) as
an indication of the mapper API failure instead of the error
message, which made it dif

mapper-wait: handle switch to openbmc exceptions

libmapper was searching for specific errno values (ENOENT) as
an indication of the mapper API failure instead of the error
message, which made it difficult to identify the need to fix up
the error path. Switch from checking for ENOENT to the
xyz.openbmc_project error message returned by the APIs.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I58700acd89f7f01474e2b985c8a8fec323cec112

show more ...

mapper: Retry if mapper is unavailable

Sometimes mapper waits begin executing before the mapper is available to
respond to requests. This will result in a EHOSTUNREACH being returned
by the broker.

mapper: Retry if mapper is unavailable

Sometimes mapper waits begin executing before the mapper is available to
respond to requests. This will result in a EHOSTUNREACH being returned
by the broker. We always want to retry and see if the broker becomes
available in these cases.

Change-Id: Id3576ddc7e82904bb55062e63506042bec826983
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

libmapper: Retry on wait timeouts

At times, early in the boot process, the async GetObject call used in
'mapper wait' can fail with an ETIMEDOUT, probably because the mapper
daemon is so busy intros

libmapper: Retry on wait timeouts

At times, early in the boot process, the async GetObject call used in
'mapper wait' can fail with an ETIMEDOUT, probably because the mapper
daemon is so busy introspecting new processes. If this happens, retry
after a 5s wait. Also get a new connection to the bus and event loop
since when this wasn't done the retried method call would fail
immediately.

I first tried to put the ETIMEDOUT check in
async_wait_getobject_callback, but that caused hundreds of more retries
across all the mapper waits in use.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I7175e958fb633b2ecb7479a3307d6918ab29b9f7

show more ...

Drop support for old association interface

A new association interface is defined in phosphor-dbus-interfaces
It would be nice to move the local version of the interface
to the new one.

The behavio

Drop support for old association interface

A new association interface is defined in phosphor-dbus-interfaces
It would be nice to move the local version of the interface
to the new one.

The behavior of how association work is described here:
https://github.com/openbmc/docs/blob/master/object-mapper.md#associations

I did some searching and confirmed that all the old interfaces
(except the openbmc/pyphosphor, but we have removed support for python)
should have been removed, so drop the support for the old interface here.

Partially resolves openbmc/openbmc#3584

In addition, when I commited this change, ci reported code format error:

@libmapper/mapper.h
-int mapper_wait_async(sd_bus*, sd_event*, char* [], void (*)(int, void*), void*,
+int mapper_wait_async(sd_bus*, sd_event*, char*[], void (*)(int, void*), void*,

Fixed that.

Signed-off-by: John Wang <wangzqbj@inspur.com>
Change-Id: I0c2d0458a3f55f4671b91f6492e7218ecc3df4aa

show more ...

mapper: Handle the expected GetSubTreePaths fails

The 'mapper subtree-remove' command calls GetSubTreePaths
when it starts up to check if a certain interface currently
exists on a certain path. If

mapper: Handle the expected GetSubTreePaths fails

The 'mapper subtree-remove' command calls GetSubTreePaths
when it starts up to check if a certain interface currently
exists on a certain path. If that interface does not exist
on that path, the current ObjectMapper implementation would
just return an empty list, and the program would exit.

The new ObjectMapper implementation will fail the GetSubTreePaths
call in that case, causing an ENXIO inside of sd_event_loop().

This commit checks for the ENXIO and then just exits immediately
with a return code of 0, as this is the case where the interface
had been removed before the program was started.

Change-Id: Iaeb908ee9a0db8952ef77cc63675e0f7abe3b6c7
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

clang-format updates

Pick up latest clang-format from the docs repo and rerun
with clang-format-6.0

Change-Id: I2f0411bb01d78f096563d63b197ce12daf43bcbd
Signed-off-by: Matt Spinler <spinler@us.ibm.

clang-format updates

Pick up latest clang-format from the docs repo and rerun
with clang-format-6.0

Change-Id: I2f0411bb01d78f096563d63b197ce12daf43bcbd
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

libmapper: Retry when receiving ENOBUFS

The dbus daemon can return ENOBUFS if a server has too many outstanding
requests that have not yet been serviced. We've noticed during boot that
the load on t

libmapper: Retry when receiving ENOBUFS

The dbus daemon can return ENOBUFS if a server has too many outstanding
requests that have not yet been serviced. We've noticed during boot that
the load on the mapper is great enough that we will hit this dbus limit.
Since this condition eventually improves, we want to retry just like
with EBUSY.

Change-Id: Ia21d87fba1793016e7c9dfa835fbe7bac0085f10
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

app: Drop mapper call subcommand

Equivalent function can be simulated with busctl call and mapper
get-service _and_ doesn't rely on systemd patches.

Change-Id: Ia0c3c8d7d0290de2b6e79f18df72cac97f2b

app: Drop mapper call subcommand

Equivalent function can be simulated with busctl call and mapper
get-service _and_ doesn't rely on systemd patches.

Change-Id: Ia0c3c8d7d0290de2b6e79f18df72cac97f2b14fa
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

libmapper: Retry with exponential backoff

We don't want to keep retrying every 1 second for 5 tries. This would
allow the timeout to lapse for a very busy BMC and just cause more
congestion. Instead

libmapper: Retry with exponential backoff

We don't want to keep retrying every 1 second for 5 tries. This would
allow the timeout to lapse for a very busy BMC and just cause more
congestion. Instead backoff at exponentially increasing intervals.

Change-Id: I9780d9a3dc787a6936aca2c2af30418dd2b0bf4b
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

libmapper: Actually examine read errors

Don't rely on undefined behavior in failed read calls where some of the
message is read. Right now the subtree remove callback parses the message
of type "as"

libmapper: Actually examine read errors

Don't rely on undefined behavior in failed read calls where some of the
message is read. Right now the subtree remove callback parses the message
of type "as" into a 1 element array. It uses this to determine if the
array is empty or not. This depends on the underlying implementation to
populate one of the array elements in the case where it has more than
one and produces an error.

Instead, properly enter the array container and check to see if it is empty
while doing error handling for the calls.

Change-Id: I542c488524a5dce5466d6196879159d888e47346
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

clang-format this repo

Use the proper-clang-format file on this repository as required by
the openbmc documentation.

Change-Id: I4f1e0d707388605f1e818dfdc647533a335e5f2d
Signed-off-by: Ed Tanous <e

clang-format this repo

Use the proper-clang-format file on this repository as required by
the openbmc documentation.

Change-Id: I4f1e0d707388605f1e818dfdc647533a335e5f2d
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...