clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ic68b91e23738cafe198c50f40e46d4163bda02b6
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

lint: update .clant-format and run

Change-Id: If9cfc42ca96517a4df2c59c130c2e22a2a443467
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

monitor: add cli11 argument parsing

Replace our custom argument parser with one from CLIUtils.

This results in a number of minor behavioral differences.
- The -? option is no longer recognized as

monitor: add cli11 argument parsing

Replace our custom argument parser with one from CLIUtils.

This results in a number of minor behavioral differences.
- The -? option is no longer recognized as an alias for -h/--help.
- The original parser returned EXIT_FAILURE in all cases, but CLIUtils
uses different non-zero error codes in different situations.
- Minor changes to help text descriptions:
----new----
Usage: build/phosphor-unit-failure-monitor.new [OPTIONS]

Options:
-h,--help Print this help message and exit
-s,--source TEXT REQUIRED
-t,--target TEXT REQUIRED
-a,--action ENUM:value in {start->0,stop->1} OR {0,1} REQUIRED

----old----
Usage: build/phosphor-unit-failure-monitor [options]
Options:
--help Print this menu
--source=<source> The source unit to monitor
--target=<target> The target unit to start or stop
--action=<action> Target unit action - start or stop

- The original parser displays the full help text on error, CLIUtils
does not:

----new----
$ phosphor-unit-failure-monitor
--source is required
Run with --help for more information.

----old----
$ phosphor-unit-failure-monitor
ERROR: Source not specified
Usage: build/phosphor-unit-failure-monitor [options]
Options:
--help Print this menu
--source=<source> The source unit to monitor
--target=<target> The target unit to start or stop
--action=<action> Target unit action - start or stop

Change-Id: I2417d9c857c6d8fc04807fe4729d2fa154e746a3
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1c3acea60ea58b8a0f9a76fd32b5d0d007bf1a16

show more ...

lint: fix trivial clang tidy errors

Change-Id: Ie5395004a451d6168249f56f75c5e6ae31dca4af
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

style: comply with OpenBMC style guidelines

Change-Id: I72f86c59a0502777c861de901907c0a556c4c6c5
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

clang-format: update to OpenBMC latest

Ignore libmapper, because it is written in C and the CPP style
guidelines are not appropriate.

Ignore subprojects; they can validate their formatting themselv

clang-format: update to OpenBMC latest

Ignore libmapper, because it is written in C and the CPP style
guidelines are not appropriate.

Ignore subprojects; they can validate their formatting themselves.

Change-Id: Id88dcc49f4176c6443e7f53ca193ca8f3e83a51f
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

build: drop autotools support

Change-Id: Ic159830e2ccbc8934f23eb4eff7d15c83a7ffaf0
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ifc7c680ca196882d890d8b7061fe56428285c276

sdbusplus: remove deprecated variant_ns

Change-Id: I96964f562c505979ad3a5c6a919c8094ba219da9
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Iff8b72c98d743c45b5f53f0bc61dd68e1af1e173

clang-format updates

Pick up latest clang-format from the docs repo and rerun
with clang-format-6.0

Change-Id: I2f0411bb01d78f096563d63b197ce12daf43bcbd
Signed-off-by: Matt Spinler <spinler@us.ibm.

clang-format updates

Pick up latest clang-format from the docs repo and rerun
with clang-format-6.0

Change-Id: I2f0411bb01d78f096563d63b197ce12daf43bcbd
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

clang-format this repo

Use the proper-clang-format file on this repository as required by
the openbmc documentation.

Change-Id: I4f1e0d707388605f1e818dfdc647533a335e5f2d
Signed-off-by: Ed Tanous <e

clang-format this repo

Use the proper-clang-format file on this repository as required by
the openbmc documentation.

Change-Id: I4f1e0d707388605f1e818dfdc647533a335e5f2d
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Fill in phosphor-unit-failure-monitor main()

Obtain the command line arguments, construct the
monitor class, and have it analyze the failure.

Change-Id: I27015b7d485995ac7605f07622112f4b8d0aa621
Si

Fill in phosphor-unit-failure-monitor main()

Obtain the command line arguments, construct the
monitor class, and have it analyze the failure.

Change-Id: I27015b7d485995ac7605f07622112f4b8d0aa621
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Add class to monitor for unit failures

This class has an analyze() method that will
check the state of a unit, and then stop or start
a target unit if the state is failed.

The units and the action

Add class to monitor for unit failures

This class has an analyze() method that will
check the state of a unit, and then stop or start
a target unit if the state is failed.

The units and the action are passed in via the constructor.

Change-Id: Ibc8e54b8371d2261eb55cce5825c5cee6d214bab
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

gitignore updates

Ignore various build artifacts.

Change-Id: I8b0447bf66844c6cfd40b57da4564324dbd0322b
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

Add phosphor-unit-failure-monitor framework

This application is designed to be called from the
OnFailure directive in a systemd unit file. It will
stop or start another unit when the current unit
f

Add phosphor-unit-failure-monitor framework

This application is designed to be called from the
OnFailure directive in a systemd unit file. It will
stop or start another unit when the current unit
fails enough times to exceed its restart policy so
it isn't restarted again.

To do this, this application will check the ActiveState
property of the failing unit. When it is 'failed', the
target unit will be started (or stopped).

The failing unit name, the target unit name, and if the
target should be stopped or started are all passed in
on the command line.

Change-Id: I93ecccaf1c091abddb769ddad8f43ecd9902210b
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...