treewide: Ignore non-ethernet devices

These are not regular ethernet devices that use INET protocols. We can
ignore them as they just produce journal spam otherwise.

Tested: Verified that our MCTP

treewide: Ignore non-ethernet devices

These are not regular ethernet devices that use INET protocols. We can
ignore them as they just produce journal spam otherwise.

Tested: Verified that our MCTP interfaces are no longer reported as
objects and that our NCSI and ETH interfaces are still added.

Change-Id: Idd5723e443b358fe76f039bcc4ce70390824094d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ia4966a0790437eb0fc011c747f3be2a52884e4d8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

treewide: Codify memory pinning

This enforces movability constraints.

Change-Id: I49dbd43a791c1d70eb7e97f30708231c053901d9
Signed-off-by: William A. Kennington III <wak@google.com>

treewide: Move timers out of networkd lib scope

Change-Id: I5fd0fc70d007e0851329172b8421846a78016d57
Signed-off-by: William A. Kennington III <wak@google.com>

treewide: Completely remove global refresh

We no longer need any of the global refresh code as we can dynamically
receive all of the updates to network configuration.

Change-Id: Ia8cb3af827c599c17d

treewide: Completely remove global refresh

We no longer need any of the global refresh code as we can dynamically
receive all of the updates to network configuration.

Change-Id: Ia8cb3af827c599c17d5df9fdddaf6cdc6546050d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ethernet_interface: Merge VLAN into EthernetInterface

This simplifies the ethernet interface as it codepended on the vlan
interface to make VLANs. It also removes the naming dependency and
tracks VL

ethernet_interface: Merge VLAN into EthernetInterface

This simplifies the ethernet interface as it codepended on the vlan
interface to make VLANs. It also removes the naming dependency and
tracks VLANs by adapter type and parent indexes.

Change-Id: I8db09cc2474472e6d4a06c6be5cf0440ee48d132
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test: Make mock syscalls take InterfaceInfo

This will make it easier to expand the parameters and plumb data through
the mock.

Change-Id: I5ca015a0494c092d9d247bbb2b7d0122c5e58fd8
Signed-off-by: Wi

test: Make mock syscalls take InterfaceInfo

This will make it easier to expand the parameters and plumb data through
the mock.

Change-Id: I5ca015a0494c092d9d247bbb2b7d0122c5e58fd8
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

system_queries: Get Interface Info from netlink

This reduces all of the interface information probing down to a single
netlink request for all the label + mac information needed to build an
ethernet

system_queries: Get Interface Info from netlink

This reduces all of the interface information probing down to a single
netlink request for all the label + mac information needed to build an
ethernet interface.

If we ever plumb the ethernet stats into dbus, we can get that
information with this same netlink code.

Change-Id: Ied8a73639dcd74bcfecda392905638573ab7970f
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

system_queries: Migrate system queries into a single place

This provides better separation of the DBus interface and the underlying
system interactions.

Change-Id: I8bf7a44c679ab065f959af19a00c2989

system_queries: Migrate system queries into a single place

This provides better separation of the DBus interface and the underlying
system interactions.

Change-Id: I8bf7a44c679ab065f959af19a00c29897c1d5c48
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test/ethernet_interface: Improve syscall test coverage

Change-Id: Ia71a030f2e2e19f2cc191992929ef08d0fa917c2
Signed-off-by: William A. Kennington III <wak@google.com>

network_manager: Allow direct access to interfaces

Change-Id: I3dc2bb944b8d3a7873e26ce2958a2cb1d9be95af
Signed-off-by: William A. Kennington III <wak@google.com>

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ief1b330c4f623ecc1be771f36083780a12260834

show more ...

test: Always create unique tmpdirs

This ensures our tests always have clear temporary directories to store
their files.

Change-Id: Ib755c4a9407b1e1925b34ae1537eb234542133b0
Signed-off-by: William A

test: Always create unique tmpdirs

This ensures our tests always have clear temporary directories to store
their files.

Change-Id: Ib755c4a9407b1e1925b34ae1537eb234542133b0
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Make the Individual tests linkable for meson

- In the current state, the tests can only be linkable
together into a single binary, as we are using the few
vaiables from external

Make the Individual tests linkable for meson

- In the current state, the tests can only be linkable
together into a single binary, as we are using the few
vaiables from external tests and using them during link
time to generate the executable.

- The idea of this commit is to make the unit test files
linkable individually, so that we have have a better way
of running unitests through meson, rather than bundling all
the tests into a gaigantic binary.

TestedBy:
The unit tests are passed in CI

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I67b953e5bc227d876139373aebeacbf5c20f56ef

show more ...

filesystem is not experimental anymore since c++17

- filesystem is merged into the mainline ISO C++ standard
since C++ 17.
- As the minimum requirement for the project to compile i

filesystem is not experimental anymore since c++17

- filesystem is merged into the mainline ISO C++ standard
since C++ 17.
- As the minimum requirement for the project to compile is
mentioned as C++17, we can now safely remove the experimental
filesystem and use them directly instead.
- This would eliminate the stdc++fs dependency when migrated to
meson.

Tested By;
- Compiled in all sdks, and unit tests are passed.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Icd63297a533c56e2d1952e99e17ec71747bd0e39

show more ...

Backend changes for Populating Nameservers(DNS & Static)

- As per the proposed design :
https://lists.ozlabs.org/pipermail/openbmc/2019-September/018399.html

Depends on :
ht

Backend changes for Populating Nameservers(DNS & Static)

- As per the proposed design :
https://lists.ozlabs.org/pipermail/openbmc/2019-September/018399.html

Depends on :
https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-dbus-interfaces/+/26060/

The idea of this commit is to

- Support NameServers(Read Only) property to display current
Nameservers (both DHCP provided& Static) configured on the
interface.

- Support StaticNameServers(Writable) property by which user
can set the Nameservers on an interface.

Tested By:

1.Configure a DNS via DHCP Server & Make sure NameServer property
populates accordingly.
2.With DNS from DHCP existing, set a name server using PATCH on
StaticNameServer property & make sure both properties populate
the data as per the proposal.
3.Make sure /etc/resolv.conf is populated with the right content
in case of DHCP/Static and DHCP & Static (Co-existing)
4.Make sure network configuration file is updated properly when
user sets a staic name server.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: If10b9aa683d2b50e51780e91323c6d10a5ec3710

show more ...

test: Don't catch exceptions needlessly

If exceptions happen the test will fail anyway. We aren't catching all
possible exceptions so just get rid of the superfluous try catch blocks.

test: Don't catch exceptions needlessly

If exceptions happen the test will fail anyway. We aren't catching all
possible exceptions so just get rid of the superfluous try catch blocks.

Change-Id: I56b7b59475b4adea8532dd0aded0966609ffb7f3
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test: Clear out old mocks prior to testing

This ensures we don't have stale mock data left over after each run
that will leak into unrelated tests.

Change-Id: I08bc12f99f1103c5d

test: Clear out old mocks prior to testing

This ensures we don't have stale mock data left over after each run
that will leak into unrelated tests.

Change-Id: I08bc12f99f1103c5d3024bf90047105b221622a2
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test: Mock out interface lookups

This will make it possible to do interface lookups inside of our classes
during testing without depending on real interfaces existing.

Change-Id

test: Mock out interface lookups

This will make it possible to do interface lookups inside of our classes
during testing without depending on real interfaces existing.

Change-Id: I4c273d6961fa4229401fb25a0e5eb06af5b59ca4
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test: Remove unused mock

This just spews out lots of warnings, and the mock interface is never
used. This makes it harder to analyze with test failures.

Change-Id: I5c71da080601

test: Remove unused mock

This just spews out lots of warnings, and the mock interface is never
used. This makes it harder to analyze with test failures.

Change-Id: I5c71da0806012dd5945f2f7ca19eb27b538c9571
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test: use mocked sdbus interface for sdbusplus

Use mocked sdbus interface for sdbusplus such that it doesn't require
talking to the real dbus interfaces.

The warnings for the un

test: use mocked sdbus interface for sdbusplus

Use mocked sdbus interface for sdbusplus such that it doesn't require
talking to the real dbus interfaces.

The warnings for the unexpected calls on the sdbus interface can be
ignored in the cases for this test as returning 0 is the desired
behavior. The warnings can be trivially handled by expecting the calls,
or setting up "ON_CALL" statements.

Change-Id: I8c72eaec957fb6a68eeaac982c1f45998487c35f
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

test: use system-first search for dbus interfaces

Use system-first search for inclusion of dbus interface headers.

Change-Id: I9953ca047c09c1003c86b1ffaf929698c157139c
Signed-of

test: use system-first search for dbus interfaces

Use system-first search for inclusion of dbus interface headers.

Change-Id: I9953ca047c09c1003c86b1ffaf929698c157139c
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

test: use expect_throw to catch expected exceptions

Use expect_throw to catch expected exceptions in tests.

Change-Id: I410655a43328d44c5b9f95dff509c132499bcd07
Signed-off-by: P

test: use expect_throw to catch expected exceptions

Use expect_throw to catch expected exceptions in tests.

Change-Id: I410655a43328d44c5b9f95dff509c132499bcd07
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

test: use real manager object for testing

Use the real manager object for testing the manager object instead of a
derived object.

Change-Id: I3b4a401d43457bffb22de8fac5e29b2e288

test: use real manager object for testing

Use the real manager object for testing the manager object instead of a
derived object.

Change-Id: I3b4a401d43457bffb22de8fac5e29b2e2887c6c6
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Re-enable unit test

Unit test were broken after sd bus calls started throwing exception,
In this repo we start the systemd-networkd with the use of sd bus
calls, which throws excepti

Re-enable unit test

Unit test were broken after sd bus calls started throwing exception,
In this repo we start the systemd-networkd with the use of sd bus
calls, which throws exception and it was not handled in the test case.

This commit fixes the problem by mocking the network manager which
mock the functionality of function which makes the sdbus call.

Change-Id: I5b60a2117a661cffa36200415ca611b85dd2fda1
Signed-off-by: Ratan Gupta <ratagupt@linux.vnet.ibm.com>

show more ...