History log of /openbmc/phosphor-networkd/src/ncsi_util.cpp (Results 1 – 8 of 8)
Revision Date Author Comments
# cbe5073f 25-Jul-2023 William A. Kennington III <wak@google.com>

ncsi_util: Cleanup joins over ranges

We can change these to std::format once we have c++23

Change-Id: If2cabd2ca57333549ca82e30f4953e7d3407ee72
Signed-off-by: William A. Kennington III <wak@google.

ncsi_util: Cleanup joins over ranges

We can change these to std::format once we have c++23

Change-Id: If2cabd2ca57333549ca82e30f4953e7d3407ee72
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...


# 89d734b9 10-May-2023 Patrick Williams <patrick@stwcx.xyz>

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ia4966a0790437eb0fc011c747f3be2a52884e4d8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...


# d423bebf 18-Apr-2023 Jagpal Singh Gill <paligill@gmail.com>

logging: switch ncsi-netlink to lg2

Tested: Build passes with "ninja -C build".
Change-Id: Iac053348b1125d15bcf65e27487c6814fa85650a
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>


# 442d9e5c 20-Oct-2022 Jian Zhang <zhangjian.3032@bytedance.com>

util: Add data ptr check to avoid crash

When the eth device is down, the data ptr is NULL,
so we should add a check to avoid crash.

Tested:
1. Let ncsi device down
`~# ip link set eth0 down`

2. Se

util: Add data ptr check to avoid crash

When the eth device is down, the data ptr is NULL,
so we should add a check to avoid crash.

Tested:
1. Let ncsi device down
`~# ip link set eth0 down`

2. Send a oem command to ncsi device, no crash.
```
ncsi-netlink -x 3 -p 0 -c 0 --oem-payload 00
Send OEM Command, CHANNEL : 0, PACKAGE : 0, IFINDEX: 3
Payload : 00
Response: No data
Failed to receive the message , RC : -1
```

Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>
Change-Id: I1e1119f7891732a87b56a345dad8ec3549868bf7

show more ...


# 7c44a78e 10-Apr-2022 Jiaqing Zhao <jiaqing.zhao@intel.com>

ncsi-netlink: Remove phosphor-logging dependency

As a CLI application, ncsi-netlink should use stderr for error messages
instead of phosphor-logging. This commits converts all phosphor-logging
logs

ncsi-netlink: Remove phosphor-logging dependency

As a CLI application, ncsi-netlink should use stderr for error messages
instead of phosphor-logging. This commits converts all phosphor-logging
logs calls to std::cerr and removes phosphor_logging_dep in meson file.

Tested:
Build pass.

Change-Id: I02227e31feab080c03d514b65dbeec4059867385
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...


# fa1f5c03 17-Sep-2020 Eddie James <eajames@linux.ibm.com>

Add support for sending NCSI command

Provide a means to send an OEM command to an NIC via NCSI netlink.
This may be invoked from a systemd Unit file to configure NIC
behavior.

Add support for sending NCSI command

Provide a means to send an OEM command to an NIC via NCSI netlink.
This may be invoked from a systemd Unit file to configure NIC
behavior.

Some NICs provide OEM commands to influence their behavior, for
example maintaining full speed even when the host is down instead
of negotiating a lower speed for power.

Signed-off-by: Eddie James <eajames@linux.ibm.com>
Change-Id: Id920b618422e8fbfc51984fbf932045bfb5e56e6

show more ...


# d49c5c65 23-Jun-2021 Johnathan Mantey <johnathanx.mantey@intel.com>

Eliminate potential null pointer references

Static analysis tools flagged a few lines of code that could result in
null pointer references. This commit adds guards against dereferencing

Eliminate potential null pointer references

Static analysis tools flagged a few lines of code that could result in
null pointer references. This commit adds guards against dereferencing
the null pointer. It also logs an error, and attempts to return to the
caller gracefully.

Tested:
Installed code changes into system under test, and searched the
journal for the error messages. The new error messages were not found,
indicating there were no null pointer references under normal
conditions.

Change-Id: Id328d71ac0456024c3ecb9878f716b98c27c7c45
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...


# 1bbe3d1e 14-May-2021 William A. Kennington III <wak@google.com>

build: Split c++ sources into a subdirectory

Change-Id: Iedea50c688189ae4953195105e323f7173d17a4b
Signed-off-by: William A. Kennington III <wak@google.com>