| 871f163e | 21-Aug-2024 |
Patrick Williams <patrick@stwcx.xyz> |
ibm: hypervisor-network-mgr: adjust includes and fwd declarations
clang-18 with C++23 complains as follows:
```
/usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:
ibm: hypervisor-network-mgr: adjust includes and fwd declarations
clang-18 with C++23 complains as follows:
```
/usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:97:16: error: invalid application of 'sizeof' to an incomplete type 'phosphor::network::HypSysConfig'
97 | static_assert(sizeof(_Tp)>0,
...
../src/ibm/hypervisor-network-mgr-src/hyp_network_manager.hpp:159:32: note: in instantiation of member function 'std::unique_ptr<phosphor::network::HypSysConfig>::~unique_ptr' requested here
159 | SystemConfPtr systemConf = nullptr;
```
Get rid of the forward declaration and adjust some of the include
directives to satisfy clang.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id2ebe1f5f7fce4962c0e3ffdf04bcaa476772e9a
show more ...
|
| ad205028 | 16-Aug-2024 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.
See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.
Change-Id: I335e0c726360eaae85b9b54c16b5dcbe4a3f182e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| d92826d2 | 17-Jun-2024 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Fix spelling mistakes using codespell
This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.
[1]: https://githu
Fix spelling mistakes using codespell
This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.
[1]: https://github.com/codespell-project/codespell
Change-Id: I169e5e1674cfda3599ea585ca3fd7afcfed601c0
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
| 08d34312 | 04-Oct-2023 |
Ravi Teja <raviteja28031990@gmail.com> |
Hypervisor Network: Remove unused log header file
This commit removes unused log header file
Change-Id: I717e80929e58b1e45426677aef91d59b76b8a815
Signed-off-by: Ravi Teja <raviteja28031990@gmail.co
Hypervisor Network: Remove unused log header file
This commit removes unused log header file
Change-Id: I717e80929e58b1e45426677aef91d59b76b8a815
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>
show more ...
|
| b1811458 | 23-Aug-2023 |
Patrick Williams <patrick@stwcx.xyz> |
hyp_ethernet_interface: add missing header
There was an assumption that an sdbus++ header file was implicitly
included, but the generated files are changing. Explicitly add that
header.
Change-Id:
hyp_ethernet_interface: add missing header
There was an assumption that an sdbus++ header file was implicitly
included, but the generated files are changing. Explicitly add that
header.
Change-Id: I48519bfe5e07d648c26c339f8b59d6a70ee9f997
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| b740196b | 21-Jul-2023 |
William A. Kennington III <wak@google.com> |
treewide: Replace fmt::print with stdplus::print
Change-Id: I9b6ea48931496bf2ca6ab480e3a3795488f2ff61
Signed-off-by: William A. Kennington III <wak@google.com> |
| af77f827 | 23-Jun-2023 |
William A. Kennington III <wak@google.com> |
treewide: Add clang-tidy
Change-Id: I1aab00b0ff8c016650225fcd1c83678a91808941
Signed-off-by: William A. Kennington III <wak@google.com> |
| 60903ee7 | 02-Jun-2023 |
William A. Kennington III <wak@google.com> |
types: Migrate to stdplus string maps
Trivial refactor to share more code.
Change-Id: I665bec386ef13a4665536457ab174e621ef64d14
Signed-off-by: William A. Kennington III <wak@google.com> |
| 89d734b9 | 10-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.
Change-Id: Ia4966a0790437eb0fc011c747f3be2a52884e4d8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| 7eb07c2d | 17-Apr-2023 |
Jagpal Singh Gill <paligill@gmail.com> |
logging: switch hyp-network-manager to lg2
Tested: Build passes with "ninja -C build".
Change-Id: If66b365354268d8577c48852876821f252ca88c8
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com> |
| 0c671a1a | 19-Apr-2023 |
Patrick Williams <patrick@stwcx.xyz> |
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t
Change-Id: I3d7315de3ebd770f1c05979226b932b928b6c109
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| cc7f5bf0 | 12-Apr-2023 |
Patrick Williams <patrick@stwcx.xyz> |
meson: remove deprecated get_pkgconfig_variable
Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig
meson: remove deprecated get_pkgconfig_variable
Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.
Change-Id: Iea38cd41ecdf6425bb335af39691dfac60cad7db
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| c8a5b7b7 | 19-Jul-2022 |
Asmitha Karunanithi <asmitk01@in.ibm.com> |
Add DHCP functionalities to hypervisor eth interfaces
This commit adds methods that provides dhcp functionalities on
the ethernet interface like - disable dhcp on an ethernet interface,
to check if
Add DHCP functionalities to hypervisor eth interfaces
This commit adds methods that provides dhcp functionalities on
the ethernet interface like - disable dhcp on an ethernet interface,
to check if dhcp is enabled on an interface.
Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: Ic713782d48c4c3cc1e1d029212b3ecf7ff5f39ad
show more ...
|
| c24de883 | 08-Jun-2021 |
Asmitha Karunanithi <asmitk01@in.ibm.com> |
Add ethernet objects under hypervisor network obj
In this commit, ethernet interface dbus objects are created
under the hypervisor network service.
busctl tree xyz.openbmc_project.Network.Hyperviso
Add ethernet objects under hypervisor network obj
In this commit, ethernet interface dbus objects are created
under the hypervisor network service.
busctl tree xyz.openbmc_project.Network.Hypervisor
└─/xyz
└─/xyz/openbmc_project
└─/xyz/openbmc_project/network
└─/xyz/openbmc_project/network/hypervisor
├─/xyz/openbmc_project/network/hypervisor/config
├─/xyz/openbmc_project/network/hypervisor/eth0
└─/xyz/openbmc_project/network/hypervisor/eth1
Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I4222fa29a9df607c8291d7f81f7f3e837442bc26
show more ...
|
| de70ccf6 | 20-Nov-2022 |
William A. Kennington III <wak@google.com> |
treewide: Move timers out of networkd lib scope
Change-Id: I5fd0fc70d007e0851329172b8421846a78016d57
Signed-off-by: William A. Kennington III <wak@google.com> |
| c38b0710 | 22-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ief1b330c4f623ecc1be771f36083780a12260834
show more ...
|
| eb40f081 | 22-Jul-2021 |
Asmitha Karunanithi <asmitk01@in.ibm.com> |
Adding system configuration object & UT
This commit adds the system config object that implements
the SystemConfiguration interface.
The hostname property under this interface will initially
be set
Adding system configuration object & UT
This commit adds the system config object that implements
the SystemConfiguration interface.
The hostname property under this interface will initially
be set from the bios table when the service starts.
Whenever user sets the property, the same will be updated
in the bios table.
busctl tree xyz.openbmc_project.Network.Hypervisor
└─/xyz
└─/xyz/openbmc_project
└─/xyz/openbmc_project/network
└─/xyz/openbmc_project/network/hypervisor
└─/xyz/openbmc_project/network/hypervisor/config
Tested By:
busctl set-property xyz.openbmc_project.Network.Hypervisor
/xyz/openbmc_project/network/hypervisor/config
xyz.openbmc_project.Network.SystemConfiguration HostName s "vmi HN"
busctl introspect xyz.openbmc_project.Network.Hypervisor /xyz/openbmc_project/network/hypervisor/config
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.Network.SystemConfiguration interface - - -
.DefaultGateway property s "" emits-change writable
.DefaultGateway6 property s "" emits-change writable
.HostName property s "vmi HN" emits-change writable
busctl call xyz.openbmc_project.BIOSConfigManager /xyz/openbmc_project/bios_config/manager xyz.openbmc_project.BIOSConfig.Manager GetAttribute s vmi_hostname
svv "xyz.openbmc_project.BIOSConfig.Manager.AttributeType.String" s "vmi HN" s ""
Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: Ib3afaef2da039d18cc672a1759b721698f9c14e2
show more ...
|
| a6c07570 | 05-May-2022 |
Asmitha Karunanithi <asmitk01@in.ibm.com> |
Add testcases for hypervisor nw manager
This commit includes three changes:
1. Add testcases for hypervisor nw manager
2. Removal of vmi_if_count support, as it is no longer
available in the bios
Add testcases for hypervisor nw manager
This commit includes three changes:
1. Add testcases for hypervisor nw manager
2. Removal of vmi_if_count support, as it is no longer
available in the bios table
3. Add methods to set default values to bios table
attributes
Tested.
Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I78397f653658c88097e4566632b0ce36c7b3861b
show more ...
|
| c41e44c3 | 31-May-2022 |
Brad Bishop <bradleyb@fuzziesquirrel.com> |
systemd: drop SyslogIdentifier
This is the default behavior, so specifing it is unnecessary.
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I8a48acd733c84d3d3bc34b08d135d9cd1b4
systemd: drop SyslogIdentifier
This is the default behavior, so specifing it is unnecessary.
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I8a48acd733c84d3d3bc34b08d135d9cd1b4a771c
show more ...
|
| 315b19bb | 26-May-2022 |
Brad Bishop <bradleyb@fuzziesquirrel.com> |
systemd: use qualified paths
Fix a documented anti-pattern:
https://github.com/openbmc/docs/blob/master/anti-patterns.md#use-of-usrbinenv-in-systemd-service-files
Signed-off-by: Brad Bishop <bradle
systemd: use qualified paths
Fix a documented anti-pattern:
https://github.com/openbmc/docs/blob/master/anti-patterns.md#use-of-usrbinenv-in-systemd-service-files
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: Ia2c78f0d39982754f1758b2e6bd89cd8b3591c0d
show more ...
|
| be2bdecb | 13-May-2021 |
Asmitha Karunanithi <asmitk01@in.ibm.com> |
An application for hypervisor network configuration
This application takes care of hypervisor network configuration
by communicating with the bios-settings-mgr in the backend.
It hosts xyz.openbmc_
An application for hypervisor network configuration
This application takes care of hypervisor network configuration
by communicating with the bios-settings-mgr in the backend.
It hosts xyz.openbmc_project.Network.Hypervisor.service similar
to that of network service and implements system config, ethernet
and ip interfaces whose properties are mapped to the appropriate
properties in the base bios table.
The flow will be like:
- User fires the redfish command to update hypervisor
network configuration properties
- BMCWeb updates the properties in the dbus object
hosted by this application
- This application would update these new values in
the base bios table
This is divided into multiple commits and this commit
hosts xyz.openbmc_project.Network.Hypervisor.service and
creates the /xyz/openbmc_project/network/hypervisor object.
Tested By:
busctl tree xyz.openbmc_project.Network.Hypervisor
└─/xyz
└─/xyz/openbmc_project
└─/xyz/openbmc_project/network
└─/xyz/openbmc_project/network/hypervisor
Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I2d4582bc9c1dbf72c9963f3e43169b695b34b1ed
show more ...
|