Fix IPMI SEL reservations and cancellations

Per the IPMI Spec, the SEL must be reserved to
Delete an entry
Clear the SEL
Get a partial entry
Add a partial entry

The current SEL reservat

Fix IPMI SEL reservations and cancellations

Per the IPMI Spec, the SEL must be reserved to
Delete an entry
Clear the SEL
Get a partial entry
Add a partial entry

The current SEL reservation must be cancelled when
A SEL entry is added
A SEL entry is deleted
The SEL is cleared
The device is reset
A new reservation is requested

This change adds a reservation status to track when a reservation
is active and a method to cancel the current reservation, and it
uses that to cancel the reservation in the Delete, Clear, and Add
SEL methods.

Change-Id: I13c88f80ec83c090ca83c1b0a8a5e1499303536b
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

phosphor-net-ipmid: use c++17

Update configure.ac to choose the c++17 standard

Change-Id: I7af16e26d36d2a5dd5341a6a7058c984ac60a78a
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

Add support for OpenSSL 1.1.0

With OpenSSL 1.1.0, some of the functions were deprecated, such
as EVP_CIPHER_CTX_cleanup.
Replace EVP_CIPHER_CTX_cleanup with EVP_CIPHER_CTX_free and
replace EVP_CIPHE

Add support for OpenSSL 1.1.0

With OpenSSL 1.1.0, some of the functions were deprecated, such
as EVP_CIPHER_CTX_cleanup.
Replace EVP_CIPHER_CTX_cleanup with EVP_CIPHER_CTX_free and
replace EVP_CIPHER_CTX_init with EVP_CIPHER_CTX_new as these
are the new recommended interfaces.

These exist in OpenSSL 1.0.2 already so this change is
backward compatible.

Resolves openbmc/openbmc#3135

Change-Id: I937d19708b10c33d9544f27af47963634c2bd36b
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Remove the support for insecure protocols in RMCP+

The two supported Cipher suites for RMCP+ will be cipher Suite 3
and 17 after this change. The cipher suite 3 is the default choice
for the ipmitoo

Remove the support for insecure protocols in RMCP+

The two supported Cipher suites for RMCP+ will be cipher Suite 3
and 17 after this change. The cipher suite 3 is the default choice
for the ipmitool if the cipher suite is not explicitly mentioned.

The supported algorithms are the following:

Authentication: a) RAKP-HMAC-SHA1, b) RAKP-HMAC-SHA256
Integrity: a) HMAC-SHA1-9, b) HMAC-SHA256-128
Confidentiality: a) AES-CBC-128

Change-Id: Ia2fbaae29235e4bd43c42b59a2295a2db28efce3
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>

show more ...

Fix to return sane error code

Any unhandled exception in the IPMI command handler
crashes the ipmi stack. IPMI command handler also becomes
bulky to catch all exceptions which must return unspecifie

Fix to return sane error code

Any unhandled exception in the IPMI command handler
crashes the ipmi stack. IPMI command handler also becomes
bulky to catch all exceptions which must return unspecified
errors. This fix adds a catch in the ipmi router command handler
functions, and returns IPMI_CC_UNSPECIFIED_ERROR for all the
unhandled exceptions. With this fix, exceptions which has to
throw IPMI_CC_UNSPECIFIED_ERROR, doesn't needs to be handled in the
command handlers.

Change-Id: Icf8741925d857170b2f748906edbaf6cf1e55cdc
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Add MAINTAINERS file

Change-Id: Ia113a0f1d2027610690bc3a175431dc16c2127ef
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Fix Table:: Command Not found: 0xb03e

The error msg:"E> Table:: Command Not found: 0xb03e" is getting dumped
into journal for every IPMI request to BMC. Here the command:b03e - is
a group extensions

Fix Table:: Command Not found: 0xb03e

The error msg:"E> Table:: Command Not found: 0xb03e" is getting dumped
into journal for every IPMI request to BMC. Here the command:b03e - is
a group extensions command to query about HPM compatibility. This is
not a standard command ,issued by ipmitool to gather information, can
be ignored.

Resolves openbmc/openbmc#3100

Change-Id: I5d89ad61144f11e80afa3bba39835119f5d96eb6
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>

show more ...

Support username for IPMI default user account

The current support in IPMI is for the nameless account, which has
no username and only password associated with the account. In
ipmitool for the namel

Support username for IPMI default user account

The current support in IPMI is for the nameless account, which has
no username and only password associated with the account. In
ipmitool for the nameless account -U option is not needed. There are
management scripts which take a parameter for -U option and fails
if -U option is not supported by ipmitool option. This patch is to
support "admin" username for the default account. Once full fledged
user account management is in place, this change can be removed.

Change-Id: Idad73c0d04f189af66f2365424a68a637fe0e476
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I30765

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I30765c0f799dabdb44b705a9720014db9a1b21df
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Implement get payload instance info command

Resolves openbmc/openbmc#2892

Change-Id: Id5f95df64bcdc97646f11d6d3630eead062c4193
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>

README: Reword cleaning the repo

Reworded cleaning the repo. The old wording did not make sense.

Change-Id: Ieb58e0b57d3527a93e62d06670854b1800da18ca
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Support SOL parameter channel number

Even though channel number is an optional parameter, the ipmitool
shows in the output the channel as 14(0x0e). 0x0e is reserved to
indicate in the command, the c

Support SOL parameter channel number

Even though channel number is an optional parameter, the ipmitool
shows in the output the channel as 14(0x0e). 0x0e is reserved to
indicate in the command, the channel on which the command is
received. So the default channel number 1 is returned.

Resolves openbmc/openbmc#2959

Change-Id: Ifd069886d4ea8e9ba5c90ca015be39ebdece413d
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>

show more ...

Patch #2 Reducing IPMI logging footprint

net-ipmid is noisy in terms of journal logging. A small step towards
cleaning that up.

Partially Resolves openbmc/openbmc#2507

Change-Id: I78e0286fb3708637

Patch #2 Reducing IPMI logging footprint

net-ipmid is noisy in terms of journal logging. A small step towards
cleaning that up.

Partially Resolves openbmc/openbmc#2507

Change-Id: I78e0286fb37086373c86dca276c0948f4595cb0a
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>

show more ...

Create sd_event outside from EventLoop

Presently timer in the provider library needs the sd_event
and sd_event gets created in the startEventLoop.
RegisterCallbackHandlers gets called before the sta

Create sd_event outside from EventLoop

Presently timer in the provider library needs the sd_event
and sd_event gets created in the startEventLoop.
RegisterCallbackHandlers gets called before the startEventLoop
hence not getting the event.

This commit creates the sd_event outside from the sd_event_loop
and pass the sd_event reference to the startEventLoop function.

Tested: run the fru print in net-ipmid context.

Change-Id: I2b227154ba60e56d7faa6c8000c20a5231c4417c
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Define the ipmid_get_sd_bus_event_connection

Due to the phosphor-host-ipmid commit (7a7f01)
transporthandler.cpp start referring to the
ipmid_get_sd_bus_event_connection function
and transporthandle

Define the ipmid_get_sd_bus_event_connection

Due to the phosphor-host-ipmid commit (7a7f01)
transporthandler.cpp start referring to the
ipmid_get_sd_bus_event_connection function
and transporthandler.cpp is a provider library
for phosphor-net-ipmid.

This commit defines the ipmid_get_sd_bus_event_connection
function in the context of phosphor-net-ipmid process.

Change-Id: I7fbc39f526138615966a90f78884a80b4cf063f4
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

SetLan: Define the global network timer

As timer is being referred in the provider library
so it should be defined in per process(host-ipmid, net-ipmid)
context.

Defining the timer requires to pull

SetLan: Define the global network timer

As timer is being referred in the provider library
so it should be defined in per process(host-ipmid, net-ipmid)
context.

Defining the timer requires to pull the code of timer in this
repository so adding the timer class.

Change-Id: I4ea5f51fed03dd87d70868b0bc76ff1fb683931c
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Add support for cipher suite 17

cipher suite 17 uses RAKP_HMAC_SHA256 for authentication and
RAKP_HMAC_SHA256_128 for integrity. This adds those in and fixes up the
lookups so the stack knows about

Add support for cipher suite 17

cipher suite 17 uses RAKP_HMAC_SHA256 for authentication and
RAKP_HMAC_SHA256_128 for integrity. This adds those in and fixes up the
lookups so the stack knows about the new algorithms.

Change-Id: Icdc66563d08060fc0e541ceaf3bee9dd5f89fdb2
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Prepare for adding RMCP+ cipher suite 17

In many places, there are baked-in assumptions about algorithms that tie
the session initiation to cipher suite 3. This commit teases out those
assumptions a

Prepare for adding RMCP+ cipher suite 17

In many places, there are baked-in assumptions about algorithms that tie
the session initiation to cipher suite 3. This commit teases out those
assumptions and prepares for the next patch that actually adds in the
new authentication and integrity algorithms to support cipher suite 17.

Change-Id: I2ee3672a7c503b89c5ff0aba30cf7a4601e24d04
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

explicit use of std::vector instead of buffer/Buffer

There were several scoped 'using buffer = std::vector<uint8_t>;' in
header files. This consolidates the code base to use
std::vector<uint8_t> ins

explicit use of std::vector instead of buffer/Buffer

There were several scoped 'using buffer = std::vector<uint8_t>;' in
header files. This consolidates the code base to use
std::vector<uint8_t> instead of buffer or Buffer. This makes the code
easier to read and debug.

Change-Id: I918a0f6ca9b8e4b9d331175dccff45cbf4c8379d
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Truncate Integrity Check Value to the correct length

According to the RMCP+ spec:

RAKP-HMAC-SHA1 specifies the use of RAKP messages for the key exchange
portion of establishing the session, and tha

Truncate Integrity Check Value to the correct length

According to the RMCP+ spec:

RAKP-HMAC-SHA1 specifies the use of RAKP messages for the key exchange
portion of establishing the session, and that HMAC-SHA1 (per [RFC2104])
is used to create 20-byte Key Exchange Authentication Code fields in
RAKP Message 2 and RAKP Message 3. HMAC-SHA1-96 (per [RFC2404]) is used
for generating a 12-byte Integrity Check Value field for RAKP Message 4.

Change-Id: Ic85b79a748ceb4083b613a0df1c253d8099a6c22
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Adding the capability to run netipmid outside of systemd

Currently, this application relies upon systemd handing it a socket from
the phosphor-ipmi-net.socket file. If for whatever reason, you want

Adding the capability to run netipmid outside of systemd

Currently, this application relies upon systemd handing it a socket from
the phosphor-ipmi-net.socket file. If for whatever reason, you want to
run this application manually (perhaps debugging), it needs to create its own socket.

This should have no affect on the normal operation of netipmid.

Change-Id: I4e46b586b09cb57d5ef1d2fd0e216552da388381
Signed-off-by: David Cobbley <david.j.cobbley@linux.intel.com>

show more ...

Small fixes for net ipmi handler

Host ipmid handler will not re-register commands,
so make the net handler follow this by skipping later registrations.
Also pass size of command to handlers for leng

Small fixes for net ipmi handler

Host ipmid handler will not re-register commands,
so make the net handler follow this by skipping later registrations.
Also pass size of command to handlers for length checks to work.
Host ipmi handler passes this parameter correctly.

Change-Id: I8eb1d645eff405b91e471433085025b6835f0bd2
Signed-off-by: Feist, James <james.feist@linux.intel.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I951ec

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I951ec38ae08ba0b20733dce1300546f4a7541eff
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Update Journal Variable Names

Journal entry variable names should be uppercase.
https://www.freedesktop.org/software/systemd/man/sd_journal_print.html

Change-Id: Id7a3f72b5079302759e0855665d241f1f2

Update Journal Variable Names

Journal entry variable names should be uppercase.
https://www.freedesktop.org/software/systemd/man/sd_journal_print.html

Change-Id: Id7a3f72b5079302759e0855665d241f1f28d9544
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

boot settings: use the new 'one time' setting

Resolves openbmc/openbmc#2301

Change-Id: I7682de2eb1f1dc224e136735af978921bf76a12f
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>