Fix coredump when using nullptr

If udpSocket is not initialized when executing the setupSignal method
acoredump may occur due to the use of a nullptr.

Change-Id: Id32990ab8ed3dc75767cc1c2e566015722

Fix coredump when using nullptr

If udpSocket is not initialized when executing the setupSignal method
acoredump may occur due to the use of a nullptr.

Change-Id: Id32990ab8ed3dc75767cc1c2e5660157223f473d
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

Fix the coredump problem caused by lock acquisition failure

As net-ipmid depends on ipmid, stress testing found that frequent
start/stop of net-ipmid will cause coredump due to lock acquisition
fail

Fix the coredump problem caused by lock acquisition failure

As net-ipmid depends on ipmid, stress testing found that frequent
start/stop of net-ipmid will cause coredump due to lock acquisition
failure in ipmid's inithannelPersistData.
Since net-ipmid depends on ipmid, stress testing found that if
net-ipmid is started/stopped frequently, it will exit abnormally due
to failure to obtain the lock in the inithannelPersistData method of
ipmid.
```
netipmid-eth1[893]: terminate called after throwing an instance of ‘boost::interprocess::lock_exception’
netipmid-eth1[893]: what(): boost::interprocess::lock_exception
```

Because in the main method of net-ipmid, the ipmi::ipmiChannelInit
method is called first, and then the startEventLoop method is called
to process the signal. This will cause a bug:
1. After net-ipmid@eth0 starts, ipmi::ipmiChannelInit will be
executed to initialize and construct ChannelConfig.
2. The initChannelPersistData method will be executed in the
construction method to obtain the lock and load the configuration.
3. If the stop method of net-ipmid is executed before the
construction method is completed, the held lock will not be
released correctly
4. If start is executed immediately at this time, the ipmid process
will coredump because the current lock is undefined.

This submission moves the signal processing to before the
ipmi::ipmiChannelInit method, which will ensure that if net-ipmid
starts and captures abnormal operations, it will stop io first, so
that the held lock will be released correctly.

Tested:
Using this patch, no ipmid coredump occurs in the stress test.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I29694405679330c083fa35d04443fb2e31bfca3b

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I8d0072c279e4de87dc001190845d0ca6da233345
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

gcc14: fix C++ One Definition Rule

The following error occurs when building with gcc14:
```
| message.hpp:117:8: error: type 'struct Message' violates the C++ One Definition Rule [-Werror=odr]
| mes

gcc14: fix C++ One Definition Rule

The following error occurs when building with gcc14:
```
| message.hpp:117:8: error: type 'struct Message' violates the C++ One Definition Rule [-Werror=odr]
| message.hpp:117:8: note: a different type is defined in another translation unit
| message.hpp:261:26: note: the first difference of corresponding definitions is field 'payload'
| message.hpp:250:13: note: a field with different name is defined in another translation unit
```

This is because some files that include this header have included
config.h, and some have not. config.h defines the RMCP_PING compile
flag.

Tested:
- Confirmed this now compiles with gcc14

Change-Id: I7f3705bdc21cc05cc7fedb591f198cbf9dc9365d
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

README.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]

README.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer to markdown-lint [1] to fix MD040
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ic79f28fcb8a68a1757f10bf2e3cd3656a11fec73

show more ...

README.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Cont

README.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## To Build"]
```
Refer to markdown-lint [1] to fix MD041
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/041-first-line-h1.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I5238df966bd7a21b2217b2668fec2b95d3ed6ac9

show more ...

Remove 'Wants' on phosphor-ipmi-host

The service file for phosphor-ipmi-host already has
WantedBy=multi-user.target, which will instruct systemd to queue a start
task for phosphor-ipmi-host. Having

Remove 'Wants' on phosphor-ipmi-host

The service file for phosphor-ipmi-host already has
WantedBy=multi-user.target, which will instruct systemd to queue a start
task for phosphor-ipmi-host. Having a 'Wants' statement here is
therefore unnecessary.

This duplicate start task can become a problem if phosphor-ipmi-host
fails to start in time and is restarted by systemd. When
phosphor-ipmi-net tries to start later, it can trigger another start
task for phosphor-ipmi-host within the start burst limit, putting
phosphor-ipmi-host into a permanent timeout state.

Tested: With this change, phosphor-ipmi-host no longer has "Start
request repeated too quickly" across 1,000 powercycles.

Signed-off-by: Benjamin Fair <benjaminfair@google.com>
Change-Id: Iabcc57e2ba73522d373d91d02b12fa6e6f389979

show more ...

auth_algo: Remove unused variables

Since the userName variable was declared in[1] and deprecated in[2],
this commit removes the deprecated variable.

[1]: https://gerrit.openbmc.org/c/openbmc/phosph

auth_algo: Remove unused variables

Since the userName variable was declared in[1] and deprecated in[2],
this commit removes the deprecated variable.

[1]: https://gerrit.openbmc.org/c/openbmc/phosphor-net-ipmid/+/9643
[2]: https://gerrit.openbmc.org/c/openbmc/phosphor-net-ipmid/+/13094/7/command/rakp12.cpp#b66

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia606607ae49e1f1923eae792a0f178fab52bbc3f

show more ...

meson: Enable link time optimization

Currently local boost subproject compilation fails with a message:
"""
../subprojects/boost-1.84.0/libs/container/src/dlmalloc_ext_2_8_6.c:
1085:41: error: itera

meson: Enable link time optimization

Currently local boost subproject compilation fails with a message:
"""
../subprojects/boost-1.84.0/libs/container/src/dlmalloc_ext_2_8_6.c:
1085:41: error: iteration 2305843009213693951 invokes undefined
behavior [-Werror=aggressive-loop-optimizations]
1085 | size = request2size(sizes[i]*element_size);

...

cc1: all warnings being treated as errors
"""
To solve the issue enable link time optimization.

Change-Id: I88a6779ae91936a8067ae4dbd8c685823cd2f28c
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

SOL: Another attempt to fix coredump issue

The commit "SOL: Fix coredump due to recursive call deadlock"
(5499bf862d1240bdbc061afc6e3d4f332c31329a) tried to fix coredump
issue when the buffer size i

SOL: Another attempt to fix coredump issue

The commit "SOL: Fix coredump due to recursive call deadlock"
(5499bf862d1240bdbc061afc6e3d4f332c31329a) tried to fix coredump
issue when the buffer size is larger than the send threshold (i.e. user
types too fast in the SoL session). Despite of the commit message the
provided solution doesn't seem to fix the crashdump issue.
Revert 5499bf862d and implement a proper solution.

Normally 'enableAccumulateTimer()' launches a timer to accumulate data
before send, and after the timeout the 'charAccTimerHandler()' sends
all the data via the 'sendOutboundPayload()' function.
If the buffer is not ready at that moment, the 'charAccTimerHandler()'
relaunches the timer via the 'enableAccumulateTimer()' call.
At the same time the 'enableAccumulateTimer()' function has an
optimization: if the data size is more than 'sendThreshold' there is no
point in timer, data can be send directly from the function. For that
the current code calls the 'charAccTimerHandler()'.
In the end this can create an endless recursion in times when buffer is
not ready:
enableAccumulateTimer()
charAccTimerHandler()
sendOutboundPayload()
enableAccumulateTimer()
...
To solve the issue we need to be careful about when we call the
'enableAccumulateTimer()' function:
- first of all we don't need to call it from 'sendOutboundPayload()'
since it is already called from the 'charAccTimerHandler()',
- secondary in the 'enableAccumulateTimer' optimization case we don't
need to call 'charAccTimerHandler()' which can re-launch timer but can
just use 'sendOutboundPayload()' directly.

Tested:
SOL console in ipmitool works fine if holding arrow up/down key
for a long time.

Change-Id: Ibec03fc1394f23ba39b6f2d5a929928588e00590
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: Add CLI11 dependency

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I3b4016acc026c46cd312ffe3b829e00bf2281617

Remove libmapper dependency

phosphor-net-ipmid does not use the API in libmapper. This patch
removes the dependence on libmapper.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Iffae

Remove libmapper dependency

phosphor-net-ipmid does not use the API in libmapper. This patch
removes the dependence on libmapper.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Iffaee8f84e0485c1b36a469d328b82ec4dad218c

show more ...

Handle SOL payload deactivation for stale session

User is unable to deactivate active SOL session using IPMI command.
To get SOL session ptr, getSession() from session manager was used,
which throwi

Handle SOL payload deactivation for stale session

User is unable to deactivate active SOL session using IPMI command.
To get SOL session ptr, getSession() from session manager was used,
which throwing Session ID is not found error and Deactivate payload
command not returning any response.

So provided fix to use SOL session ptr obtained from Context to check
if current session user has privilege to deactivate SOL payload.

Tested:
Verified using SOL IPMI commands.
//Activate SOL
~$ipmitool -I lanplus -H <BMC-IP> -U <UserID> -P <PWD> -C 17 raw 0x06
0x48 0x01 0x01 0xc0 0x00 0x00 0x00
Response: 00 00 00 00 ff 00 ff 00 6f 02 ff ff
//Deactivate SOL
~$ipmitool -I lanplus -H <BMC-IP> -U <UserID> -P <PWD> -C 17 raw 0x06
0x49 0x01 0x01 0x00 0x00 0x00 0x00
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x49 rsp=0x80): Unknown (0x80)
//Check Payload Activation status
~$ipmitool -I lanplus -H <BMC-IP> -U <UserID> -P <PWD> -C 17 raw 0x06
0x4A 0x01
Response: 01 00 00

Signed-off-by: athuljox <athulx.joseph@intel.com>
Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I49b34a9f17fe356fc86cdecb44aac627c581ba0a

show more ...

SOL: Fix coredump due to recursive call deadlock

When the data buffer size is always larger than the send threshold.
The recursive call deadlock when any input event is received.

the backtrace is a

SOL: Fix coredump due to recursive call deadlock

When the data buffer size is always larger than the send threshold.
The recursive call deadlock when any input event is received.

the backtrace is as below:
- enableAccumulateTimer
- charAccTimerHandler
- sendOutboundPayload
- enableAccumulateTimer

using io.post avoid the recursive call deadlock.

Change-Id: Ic67d2c6dfce5c658b7ef4813bf3a62ad93ced8ad
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I5278656122f19da46fcd0a84bc96af420d4cb8bd
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I82fefec49af420c862922ea2b73343a2daa3d246

show more ...

Update System GUID handling to be more robust

If the service that owns the GUID has not yet started when
netipmid starts, netipmid was throwing an error and failing
to start. If the time difference

Update System GUID handling to be more robust

If the service that owns the GUID has not yet started when
netipmid starts, netipmid was throwing an error and failing
to start. If the time difference was too great, it would fail
to re-start and then stay stopped. This makes the error
handling more robust so that the order is not so important.

Tested: started netipmid with and without the UUID service
running and restarted the service to ensure that
netipmid would stay running.

Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
Change-Id: Id464330a2ba8416ff229fa258fff0ad7a1b8f51c

show more ...

Optimize SOL logic according to SOL Configuration Parameters definition

Issue without this patch:
ipmi sol is always slower than web sol and system output.

Defined in ipmi spec:
Byte 2: Character S

Optimize SOL logic according to SOL Configuration Parameters definition

Issue without this patch:
ipmi sol is always slower than web sol and system output.

Defined in ipmi spec:
Byte 2: Character Send Threshold. 1-based. The BMC will automatically
send an SOL character data packet containing this number of characters
as soon as this number of characters(or greater) has been accepted from
the baseboard serial controller into the BMC.

Tested:
1. ipmitool -I lanplus -H <BMC IP> -U <user> -P <pwd> sol activate
2. ipmi sol output is consistent with system output.

Signed-off-by: Tang Yiwei <tangyiwei.2022@bytedance.com>
Change-Id: I097e5f4bf7ff224a90505dcb69cd59039a297e08

show more ...

Fix the wrong service and path to get the guid

The service and the path to get the guid is wrong; and the
'PropertiesChanged' also use the wrong path and interface

Test:
```
1. set the guid
busctl

Fix the wrong service and path to get the guid

The service and the path to get the guid is wrong; and the
'PropertiesChanged' also use the wrong path and interface

Test:
```
1. set the guid
busctl set-property xyz.openbmc_project.Settings /xyz/openbmc_project/inventory/item/bmc xyz.openbmc_project.Common.UUID UUID s 5c410eb0-ec99-11ec-831a-eec108c4c29c

2. restart netipmid
Jan 16 07:35:47 g220a systemd[1]: Stopping Network IPMI daemon...
Jan 16 07:35:47 g220a systemd[1]: phosphor-ipmi-net@bond1.service: Deactivated successfully.
Jan 16 07:35:47 g220a systemd[1]: Stopped Network IPMI daemon.
Jan 16 07:35:48 g220a systemd[1]: Started Network IPMI daemon.
Jan 16 07:35:48 g220a netipmid[735]: get guid
Jan 16 07:35:48 g220a netipmid-bond1[735]: 0x9c, 0xc2, 0xc4, 0x08, 0xc1, 0xee, 0x1a, 0x83, 0xec, 0x11, 0x99, 0xec, 0xb0, 0x0e, 0x41, 0x5c,

3. get the guid by ipmi
ipmitool raw 0x06 0x37
9c c2 c4 08 c1 ee 1a 83 ec 11 99 ec b0 0e 41 5c

4. change the guid property
busctl set-property xyz.openbmc_project.Settings /xyz/openbmc_project/inventory/item/bmc xyz.openbmc_project.Common.UUID UUID s 5c410eb0-ec99-11ec-831a-eec108c4c29d
Jan 16 07:36:09 g220a netipmid[735]: propertiesChanged
Jan 16 07:36:09 g220a netipmid[735]: get guid
Jan 16 07:36:09 g220a netipmid-bond1[735]: 0x9d, 0xc2, 0xc4, 0x08, 0xc1, 0xee, 0x1a, 0x83, 0xec, 0x11, 0x99, 0xec, 0xb0, 0x0e, 0x41, 0x5c,

5. get the guid by ipmi
ipmitool raw 0x06 0x37
9d c2 c4 08 c1 ee 1a 83 ec 11 99 ec b0 0e 41 5c
```

Signed-off-by: Xie Ning <xiening.xll@bytedance.com>
Change-Id: Icc81cb68c08ec019b717519028bd94def968e151

show more ...

Add privilege check in activate payload

When a user's privilege is lower than sol privilege level, payload
activate and deactivate command will be executed failed with this user.
Refer to ipmi spec

Add privilege check in activate payload

When a user's privilege is lower than sol privilege level, payload
activate and deactivate command will be executed failed with this user.
Refer to ipmi spec v2.0 Appendix G, The configuration parameters for a
given payload type determine the privilege level required to activate
and deactivate the payload.

Tested:
1. Check sol privilege level
```
~# ipmitool -I lanplus -H $ip -U $username -P $password sol activate
[SOL Session operational. Use ~? for help]
SOL session closed by BMC
```
~# ipmitool -I lanplus -H $ip -U $username -P $password sol info
```
Info: SOL parameter 'Nonvolatile Bitrate (5)' not supported
Info: SOL parameter 'Volatile Bitrate (6)' not supported
Set in progress : set-complete
Enabled : true
Force Encryption : false
Force Authentication : false
Privilege Level : ADMINISTRATOR
Character Accumulate Level (ms) : 60
Character Send Threshold : 96
Retry Count : 7
Retry Interval (ms) : 500
Volatile Bit Rate (kbps) : IPMI-Over-Serial-Setting
Non-Volatile Bit Rate (kbps) : IPMI-Over-Serial-Setting
Payload Channel : 1 (0x01)
Payload Port : 623
```

2. Set the privilege of user to 'Operator', run 'sol activate'
and 'sol deactivate'
```
~# ipmitool -I lanplus -H $ip -U $username -P $password sol activate -L OPERATOR
Error activating SOL payload: Insufficient privilege level
~# ipmitool -I lanplus -H $ip -U $username -P $password sol deactivate -L OPERATOR
Error de-activating SOL payload: Insufficient privilege level
```
3. Set the privilege of user to 'ReadOnly', run 'sol activate'
and 'sol deactivate'
```
~# ipmitool -I lanplus -H $ip -U $username -P $password sol activate -L USER
Error activating SOL payload: Insufficient privilege level
~# ipmitool -I lanplus -H $ip -U $username -P $password sol deactivate -L USER
Error de-activating SOL payload: Insufficient privilege level
```
4. Create new users test1 and test2 with 'ReadOnly' privilege,
set sol privilege to 'ReadOnly', run 'sol activate' with test1
```
~# ipmitool -I lanplus -H $ip -U $username -P $password sol set privilege-level user
~# ipmitool -I lanplus -H $ip -U test1 -P $password sol activate -L USER
[SOL Session operational. Use ~? for help]
```
On another console, deactivate session owned by test1
```
~# ipmitool -I lanplus -H $ip -U test2 -P $password sol deactivate -L USER
Error de-activating SOL payload: Insufficient privilege level
~# ipmitool -I lanplus -H $ip -U test1 -P $password sol deactivate -L USER
```
Session owned by test1 cannot be deactivated by test2, can be
deactivated by test1

Signed-off-by: Tang Yiwei <tangyiwei.2022@bytedance.com>
Change-Id: Ie5ca60c9891140614b701392c94245e916cd97ab

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: Ib1521ce39359eaffd09ae

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: Ib1521ce39359eaffd09aeab49f04f4f9933aeffc
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Use new default obmc-console socket path

Change-Id: I15d6dcdb6993e51f13572d022cb3039e50df6c47
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>

Fix formatting

Change-Id: I1f0fb76d21a854155d3cae419fbb8e8d1f350b1f
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I862ed296ce1f42dba7047a74540d9004ad78130c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: I6885fe8da34917145a5b8e62c96be47b31e0d98c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...