Support privilege based lookup with user name

Support for privilege based lookup, with user name is added.
Still NULL user name is not supported for user/privilege based
lookup for security reasons

Support privilege based lookup with user name

Support for privilege based lookup, with user name is added.
Still NULL user name is not supported for user/privilege based
lookup for security reasons

Unit-Test:
Verified ipmitool session with -L <privielge>+ and also verified
that RAKP12 fails, when requested privilege is more than the user
privilege.
ipmitool -I lanplus -H xx.xx.xx.xx -U root -P 0penBmc -L Administrator+
raw 6 1

Change-Id: Ia97d4f3091c5ca7e3b688188ce1690c17fce9891
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

netipmid: move event loop to boost::asio::io_context

Replacing the event loop with asio provides for more flexibility and
less code than the sd_event model. Intially, this will require the loop
to h

netipmid: move event loop to boost::asio::io_context

Replacing the event loop with asio provides for more flexibility and
less code than the sd_event model. Intially, this will require the loop
to handle both sd_events with a wrapper, but after all the sd_event
sources are replaced with asio event sources the wrapper can be removed.

Change-Id: Icf020c6c26a214bb1239641733c89603501c0c49
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Revert "W/A for CI test case - Accept empty user name"

This reverts commit d2563c52eea33c2e4575f34eddac564ba1a44d85.

As CI test cases are updated to work with mandatory
-U options, this commit is r

Revert "W/A for CI test case - Accept empty user name"

This reverts commit d2563c52eea33c2e4575f34eddac564ba1a44d85.

As CI test cases are updated to work with mandatory
-U options, this commit is reverted. Going forward in order
to establish a RMCP+ session, user name with -U option is
mandatory

Change-Id: I2e1405562f0c20d34b2fcd5a2bba668c87cc7f06
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Command execution restriction based on privilege

Restrict IPMI command execution based on privilege of
the user session.

Unit test:
1. Verified the command execution as per the privilege
2. Executi

Command execution restriction based on privilege

Restrict IPMI command execution based on privilege of
the user session.

Unit test:
1. Verified the command execution as per the privilege
2. Executing higher privilege IPMI command fails

Change-Id: I5901f2b18f4f7ecb6311882de558f75b61836109
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

W/A for CI test case - Accept empty user name

W/A code added for CI Test cases to pass, which uses empty
user name with 0penBmc as password. The following code
allows the same to keep the test case

W/A for CI test case - Accept empty user name

W/A code added for CI Test cases to pass, which uses empty
user name with 0penBmc as password. The following code
allows the same to keep the test case going.
This commit has to be removed once test cases are updated to
include "-U root" option.

Unit-Test:
1. Verfied by issuing
ipmitool -I lanplus -C 3 -H X.X.X.X -P 0penBmc raw 6 1

Change-Id: I9e9d6ead0630a553efbd66d6bbee3ddb7eef527e
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

netipmid: move to sdbusplus from sdbus minus

In main, wrapping the raw sd_bus object with an sdbusplus class makes
deals with the unref problem automatically.

Change-Id: I7d21c21bc09cc96e2d4b07d1b5

netipmid: move to sdbusplus from sdbus minus

In main, wrapping the raw sd_bus object with an sdbusplus class makes
deals with the unref problem automatically.

Change-Id: I7d21c21bc09cc96e2d4b07d1b51b6f82239e0793
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

netipmid: startSession does not need to call getSession

Change-Id: Id0e482705e8fda39270ec2e6c3534f81d11797b3
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

netipmid: use shared_ptr on session instead of shared_ptr+references

session objects were being created and held by shared_ptr objects and
then shared via reference. This is dangerous and sidesteps

netipmid: use shared_ptr on session instead of shared_ptr+references

session objects were being created and held by shared_ptr objects and
then shared via reference. This is dangerous and sidesteps the whole
point of a shared_ptr, which is to share reference-counted ownership.
This replaces the usage with a shared_ptr, which shows shared ownership.

Change-Id: Ie22d812a6d260d606201eca6a9011e773c89e487
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

netipmid: use shared_ptr on messages instead of unique_ptr+references

Messages were being created and held by unique_ptr objects and then
shared via reference. This is dangerous and sidesteps the wh

netipmid: use shared_ptr on messages instead of unique_ptr+references

Messages were being created and held by unique_ptr objects and then
shared via reference. This is dangerous and sidesteps the whole point of
a unique_ptr, which is to enforce single ownership. This replaces the
usage with a shared_ptr, which denotes shared ownership.

Change-Id: I19ed2693f5a0f5ce47d720ed255fa05bdf3844f8
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

RMCP+ login support with privilege

Implementation of RMCP login support with appropriate
privilege level.

Unit Test:
1. Verified that user is able to login without any issues
2. Privilege of the us

RMCP+ login support with privilege

Implementation of RMCP login support with appropriate
privilege level.

Unit Test:
1. Verified that user is able to login without any issues
2. Privilege of the user is minimum of requested, user & channel
3. Unable to set higher privilege using Set session commands

Change-Id: I5e9ef21dfc1f1b50aa815562a3a65d90c434877c
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Add LAN1 selfchannel suppport for IPMI

Defining the sudo API's for returning channel
index for self channel. This API returns LAN1
for net-ipmi.

Change-Id: Icefd5d949e94d4399adaffdad102ccb18c1b7cdc

Add LAN1 selfchannel suppport for IPMI

Defining the sudo API's for returning channel
index for self channel. This API returns LAN1
for net-ipmi.

Change-Id: Icefd5d949e94d4399adaffdad102ccb18c1b7cdc
Signed-off-by: ssekar <suryakanth.sekar@intel.com>
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

netipmid: use libcrypto prng instead of insecure std::rand

std::rand is insecure. Add a simple openssl-crypto wrapper for a similar
interface that can replace it.

Tested-by: Run ipmitool six times

netipmid: use libcrypto prng instead of insecure std::rand

std::rand is insecure. Add a simple openssl-crypto wrapper for a similar
interface that can replace it.

Tested-by: Run ipmitool six times in parallel to see that five
independent sessions are created and the sixth one causes the
BMC to dump the session list on the console. Note that the
session numbers are still random.

Change-Id: I0b387f1343abefc45be0d62cf9af45fbd5563047
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

netipmid: make session a header-only situation

The Session class is a fairly simple class, no need for an external cpp
file; make it all header-only and allow the compiler to do its job.

Change-Id:

netipmid: make session a header-only situation

The Session class is a fairly simple class, no need for an external cpp
file; make it all header-only and allow the compiler to do its job.

Change-Id: Ibbe7e963762926ec04c75ab187a5b8045de851f4
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

netipmid: Remove unused argc/argv from main

main doesn't currently use any arguments, so no point in even declaring
them.

Change-Id: Ibc7ad06a7f6d92a407493141f77fa3c953933c0e
Signed-off-by: Vernon

netipmid: Remove unused argc/argv from main

main doesn't currently use any arguments, so no point in even declaring
them.

Change-Id: Ibc7ad06a7f6d92a407493141f77fa3c953933c0e
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

netipmid: use the default system bus

The documentation says sd_bus_default_system() is preferred over
sd_bus_open_system() because all the calls to sd_bus_default_system()
will use the same resource

netipmid: use the default system bus

The documentation says sd_bus_default_system() is preferred over
sd_bus_open_system() because all the calls to sd_bus_default_system()
will use the same resources, whereas the sd_bus_open_system() will
create a new connection and consume more resources for every call.

Change-Id: Ifc6a62cf9d35df3615d1133ef5c8f115ff462d98
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

netipmid: add more files to .gitignore

This adds a few more files to the ignore list:

vi swap files
cscope artifacts
patch orig and rej
~ temp copies

Change-Id: I33e1e6f9b378b87492

netipmid: add more files to .gitignore

This adds a few more files to the ignore list:

vi swap files
cscope artifacts
patch orig and rej
~ temp copies

Change-Id: I33e1e6f9b378b87492846c1c52b3474f83eec4b5
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

netipmid: Remove local timer class

Remove the local timer class, migrating to the sdbusplus/timer.hpp class
for now. As the project moves toward the single ipmi execution queue the
timers will all g

netipmid: Remove local timer class

Remove the local timer class, migrating to the sdbusplus/timer.hpp class
for now. As the project moves toward the single ipmi execution queue the
timers will all go away anyway in preference to the asio timers.

Tested-by: making changes to the network via rmcp+ with ipmitool. This
should make use of the networkTimer variable that was
changed from the internal timer class to the sdbusplus timer
class.

Change-Id: I4a86e3b9c1f3cfefee1e112229dcb63aa5119f2f
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

netipmid: Add -flto to CXXFLAGS

Following the example of openbmc/openbmc#3364, adding -flto to CXX flags
in order to reduce overall library and binary sizes.

Ref:
https://gcc.gnu.org/wiki/LinkTimeO

netipmid: Add -flto to CXXFLAGS

Following the example of openbmc/openbmc#3364, adding -flto to CXX flags
in order to reduce overall library and binary sizes.

Ref:
https://gcc.gnu.org/wiki/LinkTimeOptimization

Change-Id: Iad0c9ccf5c0409321da4aaef21882eb7171e14b0
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

style: cppcheck cleanup

[command/guid.cpp:37]: (style) The scope of the variable 'rc' can be
reduced.
[socket_channel.hpp:44]: (performance) Variable 'timeout' is assigned
in constructor body. Consi

style: cppcheck cleanup

[command/guid.cpp:37]: (style) The scope of the variable 'rc' can be
reduced.
[socket_channel.hpp:44]: (performance) Variable 'timeout' is assigned
in constructor body. Consider performing initialization in
initialization list.
[sd_event_loop.cpp:107]: (style) The scope of the variable 'instance'
can be reduced.
[sd_event_loop.cpp:108]: (style) The scope of the variable 'rc' can be
reduced.
[sd_event_loop.cpp:142]: (style) The scope of the variable 'instance'
can be reduced.
[sd_event_loop.cpp:304]: (style) The scope of the variable 'rc' can be
reduced.

Change-Id: Id090cb217ea7ed9019f1b8d39ebebd6bb73113b1
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

netipmid: use std variant interface

Update code to remove mapbox-style interface usages.

Tested-by: run ipmitool to start a remote connection. See that sessions
can be started, same as b

netipmid: use std variant interface

Update code to remove mapbox-style interface usages.

Tested-by: run ipmitool to start a remote connection. See that sessions
can be started, same as before change.

Change-Id: Ifc1a30069b6dc4e2d3706e1ca93f6b965552a051
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

netipmid: use system path include style

For external header files, us the system path include style to fit with
the standard coding style of the project.

Change-Id: Iba08b6b5adf20ebf7cebdb2d39aaad8

netipmid: use system path include style

For external header files, us the system path include style to fit with
the standard coding style of the project.

Change-Id: Iba08b6b5adf20ebf7cebdb2d39aaad84463e3ff3
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

netipmid: use std::shared_ptr instead of weak_ptr/lock

All of the instances of getSession and startSession were assigning the
result to a local shared_ptr via lock on the weak_ptr. It doesn't make
s

netipmid: use std::shared_ptr instead of weak_ptr/lock

All of the instances of getSession and startSession were assigning the
result to a local shared_ptr via lock on the weak_ptr. It doesn't make
sense to demote the shared_ptr (from the sessionsMap) to a weak_ptr via
the return, only to promote to a shared_ptr again via lock.

Tested-by: running ipmitool -H a.b.c.d -P 0penBmc -I lanplus mc info
Sessions start and stop, same as before.

Change-Id: Ic10779285891d73ee51115f16ed0000b38d1c52a
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

netipmid: apply clang-format rules

Lots of whitespace change. Let clang-format do its job and keep the code
looking nice.

Change-Id: Idfcad1a99cab8170d55a06163de8ad3f420b68b7
Signed-off-by: Vernon

netipmid: apply clang-format rules

Lots of whitespace change. Let clang-format do its job and keep the code
looking nice.

Change-Id: Idfcad1a99cab8170d55a06163de8ad3f420b68b7
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

build: set language to C++

Set the language in the build to C++.

Change-Id: Id8c2bc7a4f8d71205b0adee2f11848fb2f049957
Signed-off-by: Patrick Venture <venture@google.com>

MAINTAINERS: Update Emily's IRC nick

Change-Id: I3a9a34e5c65dc24aeee431644592ca9a581f51cb
Signed-off-by: Emily Shaffer <emilyshaffer@google.com>