rakp12: Fix for Callback privilege

Issue: GetPayload Activation status should not be allowed for Callback
privilege as Callback privilege is deprecated.

Fix: Returning proper error response

rakp12: Fix for Callback privilege

Issue: GetPayload Activation status should not be allowed for Callback
privilege as Callback privilege is deprecated.

Fix: Returning proper error response for Callback privilege

Tested:
Before:
Command: ipmitool -I lanplus -U root -P 0penBmc -H <BMC-IP>
-L Callback raw 6 0x4A 1 // GetPayload Activation Status
Response: 01 00 00

After:
Command: ipmitool -I lanplus -U root -P 0penBmc -H <BMC-IP>
-L Callback raw 6 0x4A 1 //GetPayload Activation Status
Response: Error: Unable to establish IPMI v2 / RMCP+ session

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Iab12aa546ec6b05e547a39032e400d0c382f5178

show more ...

MAINTAINERS: remove Emily Shaffer

See https://lists.ozlabs.org/pipermail/openbmc/2020-January/020345.html

Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
Change-Id: Ia782ac797bfe85752b20ae88

MAINTAINERS: remove Emily Shaffer

See https://lists.ozlabs.org/pipermail/openbmc/2020-January/020345.html

Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
Change-Id: Ia782ac797bfe85752b20ae880189e137c1e8e917

show more ...

Fix elapsedSeconds date formatting causing netimid crash during BMC booting

If sending ipmi command during BMC booting process or BMC is very busy,
the netipmid service will crash.
The root cause is

Fix elapsedSeconds date formatting causing netimid crash during BMC booting

If sending ipmi command during BMC booting process or BMC is very busy,
the netipmid service will crash.
The root cause is that the incoming UDP packet processing time > 2 seconds,
and triggers the log, but the elapsedSeconds date formatting is incorrect,
it causes the process crash.

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: Ia84149e4b4344793916003fc1ad0cdb26070e388

show more ...

Fix: fix the access to sin/sin6_addr in getRemoteAddress

inet_ntop using 'remoteSockAddr' instead of casting it to 'sockaddr_in/in6'
structure and getting the field 'sin/sin6_addr' access. As result

Fix: fix the access to sin/sin6_addr in getRemoteAddress

inet_ntop using 'remoteSockAddr' instead of casting it to 'sockaddr_in/in6'
structure and getting the field 'sin/sin6_addr' access. As result of this
'getRemoteAddress' returns junk from top of the 'sockaddr_storage' structure.

Tested: Verified by calling 'getRemoteAddress' inside net-ipmi lambda
handler.

[handler, this](const boost::system::error_code& ec,
const IpmiDbusRspType& response) {
...
std::string raddr =
handler->getChannel()->getRemoteAddress();
some_func_for_put_addr(raddr);
...
}

Signed-off-by: Ivan Mikhaylov <i.mikhaylov@yadro.com>
Change-Id: Ia8ae2763a2ab372c148323974fe33ac44b1d28f0

show more ...

Always return Message Tag and Remote Console Session ID

Per the IPMI spec, even on an error we should return the
Message Tag and Remote Console Session ID values.

This sets those two response value

Always return Message Tag and Remote Console Session ID

Per the IPMI spec, even on an error we should return the
Message Tag and Remote Console Session ID values.

This sets those two response values first so they are always
set in case of an error.

Tested:
Ran ipmitool with verbose enabled and confirmed that the
Console Session ID is set:
ipmitool -vv -C 7 mc info

<<OPEN SESSION RESPONSE
<< Message tag : 0x00
<< RMCP+ status : invalid authentication algorithm
<< Maximum privilege level : Unknown (0x00)
<< Console Session ID : 0xa0a2a3a4

Ran ipmipower with --debug and confirmed that the Message Tag
is set and the command returns an error instead of timing out
ipmipower --debug -D LAN_2_0 -s -l ADMIN -I 7

IPMI Command Data:
------------------
[ BCh] = message_tag[ 8b]
[ 4h] = rmcpplus_status_code[ 8b]
[ 41F00603h] = remote_console_session_id[32b]

Ran both of the above commands using cipher suite 17 and they
both complete successfully.

Change-Id: Ic21ec910103a1befdf5e79f7b1afaf83dae63e9f
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Do not stop session in deactivate payload call

According to section 24.2 of the spec, the Deactivate Payload command
should not cause the session to be terminated.

Also during SOL looptest, there i

Do not stop session in deactivate payload call

According to section 24.2 of the spec, the Deactivate Payload command
should not cause the session to be terminated.

Also during SOL looptest, there is only one time startSession call,
but multiple stopSessions calls.
This causes the looptest will fail if there is any new session comes in,
needs to remove the stopSession call.

Tested:
Start the loop test in a terminal:
ipmitool -H $BMCIP -Uroot -P 0penBmc -I lanplus sol looptest 500 200

Then start another session in another terminal:
ipmitool -H $BMCIP -Uroot -P 0penBmc -I lanplus raw 6 1

The looptest still works

sol on web still works
ssh -p2200 still works

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: I15729fa220fae18adb318bdae98d5d9ccfec9ae1

show more ...

Fix: Handle exception during sol activate cmd

When there is any exception during StartConsole, the console must be
freed,without which it was wrongly assumeed that console is active.

Tested :
1.Dis

Fix: Handle exception during sol activate cmd

When there is any exception during StartConsole, the console must be
freed,without which it was wrongly assumeed that console is active.

Tested :
1.Disable SSH using systemctl stop obmc-console@xxx.service and
systemctl stop obmc-console@xxx.socket.
2.Activate sol multiple times. It should always give unspecified error
as response

Signed-off-by: Rashmi RV <rashmi.r.v@linux.intel.com>
Change-Id: Ia5b1e0686331a9a2c6c90383472030513adf1226

show more ...

Add boost_coroutine to the link list

In preparation for a commit that adds yielding calls to the utils in
libipmid, netipmid needs to be linking against boost_coroutine or it
will fail to build afte

Add boost_coroutine to the link list

In preparation for a commit that adds yielding calls to the utils in
libipmid, netipmid needs to be linking against boost_coroutine or it
will fail to build after the commit is merged.

Tested: Builds and runs the same as before, but ldd shows that the new
binary is linked against boost_coroutine

Change-Id: I2d2c06f6fd529819ee38777547e576acbe06408c
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Added current session Id to options map.

Added current session Id to options map, it is passed to
ipmid-host. This will enable certain commands to know
the current sessionid.

Tested:

Current sessi

Added current session Id to options map.

Added current session Id to options map, it is passed to
ipmid-host. This will enable certain commands to know
the current sessionid.

Tested:

Current session Id is used in Get session info command to get current
session info and it is working fine.

ipmitool -I lanplus -U <user> -P <password> -H <lan1_ip> raw 6 0x3d <Zero>
Response : gives currents session info

ipmitool -I lanplus -U <user> -P <password> -H <lan2_ip> raw 6 0x3d <Zero>
Response : gives currents session inf

//host interface
ipmitool raw 6 0x3d 0
Response: 0xCC // invalid field in the request

//This command shows info of all sessions, which includes current
session info as well.

ipmitool -I lanplus -U <user> -P <password> -H <lan1_ip> session info all
session handle : 129
slot count : 45
active sessions : 1
user id : 1
privilege level : ADMINISTRATOR
session type : IPMIv1.5
channel number : 0x03
console ip : 0.0.0.0
console mac : 00:00:00:00:00:00
console port : 52670

session handle : 0
slot count : 45
active sessions : 1

//This command shows info of all sessions, which includes current
session info as well.
ipmitool -I lanplus -U <user> -P <password> -H <lan2_ip> session info all
session handle : 0
slot count : 45
active sessions : 1

session handle : 1
slot count : 45
active sessions : 1
user id : 1
privilege level : ADMINISTRATOR
session type : IPMIv1.5
channel number : 0x01
console ip : 0.0.0.0
console mac : 00:00:00:00:00:00
console port : 57622

//host interface
ipmitool session info all
session handle : 0
slot count : 45
active sessions : 0

session handle : 0
slot count : 45
active sessions : 0

tested other postive and negative test cases for get session info
command in Lan1, Lan2 and host interfaces. All are working fine

Signed-off-by: Rajashekar Gade Reddy <raja.sekhar.reddy.gade@linux.intel.com>
Change-Id: I6b511331654c85436379fc4d833a7d642aabf757

show more ...

Add VLAN device binding

IPMI net channel supports the VLAN. This patch will bind the service
to VLAN device if the VLANID is set in net channel.

Tested:
In all the steps, use following commands to

Add VLAN device binding

IPMI net channel supports the VLAN. This patch will bind the service
to VLAN device if the VLANID is set in net channel.

Tested:
In all the steps, use following commands to check if ipmi overlan is
still working and lan channel info is correct.
ipmitool -I lanplus ... mc info
ipmitool -I lanplus ... lan print 1

1. Start the phosphor-ipmi-net@eth0.service and this service binds to
eth0 device
# Command to get the binding device
journalctl -u phosphor-ipmi-net@eth0.service -o verbose | grep \
INTERFACE
INTERFACE=eth0

2. Set the VLANID (123) for channel 1 (eth0) and restart the service.
The service is binded to eth0.123
# Command to set the channel 1 VLANID
ipmitool -I lanplus ... lan set 1 vlan id 123

# Command to restart
systemctl restart phosphor-ipmi-net@eth0.service

# Command to check the binding
journalctl -u phosphor-ipmi-net@eth0.service -o verbose | grep \
INTERFACE
INTERFACE=eth0.123

3. Disable the VLANID for channel 0 and restart the service.
The service is binded to eth0
# Command to disable the channel 1 VLANID
ipmitool -I lanplus ... lan set 1 vlan id off

# Command to restart
systemctl restart phosphor-ipmi-net@eth0.service

# Command to check the binding
journalctl -u phosphor-ipmi-net@eth0.service -o verbose | grep \
INTERFACE
INTERFACE=eth0

Limitation: Need to restart this service when the VLANID is changed.
This should be done in phosphor-host-ipmid.

Change-Id: I6c05aacf6b18cb1fa0d1cabe6ad36f0d683948d1
Signed-off-by: Alvin Wang <alvinwang@msn.com>

show more ...

Updated the close session to close any session

Added support in close session command to close not only the self
sessions but also other netipmid sessions.

With this support, now any netipmid insta

Updated the close session to close any session

Added support in close session command to close not only the self
sessions but also other netipmid sessions.

With this support, now any netipmid instance will be able to close
any other netipmid instance's session.

Tested close session command for both self and other netipmid sessions:

Unit Tested:

Close the existing valid session by session id
ipmitool raw 0x6 0x3c <valid sesssion id >
Response : 00 // success

Close the existing valid session by session handle
ipmitool raw 0x6 0x3c <zero session id> <valid session handle>
Response : 00 // success

Close the session by zero session id
ipmitool raw 0x6 0x3c <zero session id>
Response : 0x87 // Inavlid Session Id

Close the session by zero session handle
ipmitool raw 0x6 0x3c <zero session id> <zero session handle>
Response : 0x88 // inavlid session handle

Close an inactive session.
ipmitool raw 0x6 0x3c <valid session id>
Response : 0xcc // invalid data field in request

Close an inactive session.
ipmitool raw 0x6 0x3c <zero session id> <valid session handle>
Response : 0xcc // invalid data field in request

Close high privilege session by session id.
ipmitool raw 0x6 0x3c <valid session id>
Response : 0xd4 // insufficient privilege level

Close high privilege session by session handle.
ipmitool raw 0x6 0x3c <zero session id> <valid session handle>
Response : 0xd4 // insufficient privilege level

Signed-off-by: Rajashekar Gade Reddy <raja.sekhar.reddy.gade@linux.intel.com>
Change-Id: Ieade8e342777a940d30248bb23f67dc3c787a001

show more ...

Fix: Incorrect max instance for get payload status

Response data byte 2 value for the get payload activation status cmd,
was 0x10 which is decoded as 0 instances activated since
bit 7:4 reserved.
Cu

Fix: Incorrect max instance for get payload status

Response data byte 2 value for the get payload activation status cmd,
was 0x10 which is decoded as 0 instances activated since
bit 7:4 reserved.
Currently SOL payload is only supported and there can be 1 max sol
payload instance. This code provides fix for the same by correcting
sol payload instance capacity.

Tested:
Verified by issuing get payload status activation command through
ipmitool.

ipmitool -I lanplus -H <ip> -U xxxx -P xxxxxxx raw 0x06 0x4A 0x01
01 00 00 //Response

Signed-off-by: Ayushi Smriti <smriti.ayushi@linux.intel.com>
Change-Id: I874fe3fe784417c9460a1cee5bb5e6bc36291012

show more ...

Fix:Activate payload missing req param length check

Activate payload cmd with invalid length of request data
parameters results in completion code of 0x00 instead of 0xc7.
Added req parameter length

Fix:Activate payload missing req param length check

Activate payload cmd with invalid length of request data
parameters results in completion code of 0x00 instead of 0xc7.
Added req parameter length check to provide fix for the same.

Tested:
Verified by issuing activate payload cmd through ipmitool.

ipmitool -I lanplus -H <ip> -U xxxx -P xxxxxx raw 0x06 0x48
0x01 0x01 0xc0 0x00 0x00 0x00 0x00 0x00
Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x48 rsp=0xc7): Request data length invalid //response

Signed-off-by: Ayushi Smriti <smriti.ayushi@linux.intel.com>
Change-Id: I03eed84c4bc4a2e41b04c35741ae9d7609f108c5

show more ...

Remove unused settings.cpp/settings.hpp

These two files are no longer used now that netipmid is just a bridge
to send commands onto ipmid. This removes them.

Tested: Compile and run netipmid. Becau

Remove unused settings.cpp/settings.hpp

These two files are no longer used now that netipmid is just a bridge
to send commands onto ipmid. This removes them.

Tested: Compile and run netipmid. Because they are unused, behavior is
unchanged.

Change-Id: I24c9f30822050fc89028945b380fbc471a5c5b88
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

netipmid: Set right value for session->channelNum.

Use getInterfaceIndex() to find the channel number on which
netipmid waits for incoming messages. session->channelNum should
use this value instead

netipmid: Set right value for session->channelNum.

Use getInterfaceIndex() to find the channel number on which
netipmid waits for incoming messages. session->channelNum should
use this value instead of static value 'ipmi::EChannelID::chanLan1'.

Tested-by:
1. Enable SOL payload in channel 3, and disable it in channel 1.
Verify SOL session establishes in channel 3, and fails in channel 1.
(session->channelNum is used by 'Set User Payload Access(SOL)).

Signed-off-by: Saravanan Palanisamy <saravanan.palanisamy@linux.intel.com>
Change-Id: If7baecc6a15a327629e10ce6b4cf01ff020b0ee4

show more ...

netipmid: Handle invalid length for getPayloadInfo

Invalid length error check added for getPayloadInfo command

Tested:
1.Verified negative case by providing improper length
ipmitool -I lanplus -H <

netipmid: Handle invalid length for getPayloadInfo

Invalid length error check added for getPayloadInfo command

Tested:
1.Verified negative case by providing improper length
ipmitool -I lanplus -H <ip-addr> -U <user> -P <passwd> raw 0x06 0x4b 0x01 0x01 0x00
Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x4b rsp=0xc7):
Request data length invalid //response

2.Verified normal case and output is same
ipmitool -I lanplus -H <ip-addr> -U <user> -P <passwd> raw 0x06 0x4b 0x01 0x01
00 00 00 00 00 00 00 00 00 00 00 00 //response

Signed-off-by: anil kumar appana <anil.kumarx.appana@intel.com>
Change-Id: I5d03e1703dc3bcf6503bfcfdbebc9fc4c29074be

show more ...

netipmid: SOL payload activation control.

Activate the SOL payload session only if 'user payload access' allows.
IPMI Spec reference: Section 24.6, 24.7.

Tested-by:
1. For user 15 in channel 3, Dis

netipmid: SOL payload activation control.

Activate the SOL payload session only if 'user payload access' allows.
IPMI Spec reference: Section 24.6, 24.7.

Tested-by:
1. For user 15 in channel 3, Disable SOL payload and activate sol.

// Command - (channel 3 is of LAN channel type)
ipmitool -I lanplus...raw 0x4C 3 0x4F 0x2 0 0 0
// Try to launch SOL session.
ipmitool -v -I lanplus -U saravanan...sol activate
Info: SOL payload disabled. <Compl Code : 0x81> // Response

2. For user 15 in channel 3, Enable SOL payload and activate sol.

// Command
ipmitool -I lanplus...raw 0x4C 3 0xF 0x2 0 0 0
// Try to launch SOL session.
ipmitool -I lanplus -U saravanan...sol activate
[SOL Session operational. Use ~? for help] // Response

Signed-off-by: Saravanan Palanisamy <saravanan.palanisamy@linux.intel.com>
Change-Id: I5436572349b116ffc2e4f1605db8233186c0bd3d

show more ...

netipmid: Manage and expose session object

Session (RMCP+) is managed by net-ipmid directly, but
session commands has to be supported in both LAN & other
session-less interfaces. In order to make se

netipmid: Manage and expose session object

Session (RMCP+) is managed by net-ipmid directly, but
session commands has to be supported in both LAN & other
session-less interfaces. In order to make session commands
to work in other interfaces, session objects must be
exposed as D-Bus objects, so that ipmi-providers can
query the same.

Tested:
1. Verified that RMCP+ session are perfectly working
2. Verified RMCP+ session establishment fails for wrong
password
3. Verified that session privilege level are maintained
and access are restricted accordingly
4. Verified session timeout and sessions are destroyed
accordingly after timeout
5. verified max session count working behavior
6. verified ipmi-providers responding with proper response for this
(or D-Bus objects are exposed correctly during session creation,
session deletion,session update,
(like privilege, - say even set session privilege level command)
7.Session objects are created dynamically.

Change-Id: I78a8449359877ef6cc4cd8161d8c67e6e54eb52b
Signed-off-by: Suryakanth Sekar <suryakanth.sekar@linux.intel.com>

show more ...

[netipmid] Fix: validate user lockout status

User lockout validation must happen after reading the password
and not before it. This was causing RMCP+ session establishment
failure. This fixes the sa

[netipmid] Fix: validate user lockout status

User lockout validation must happen after reading the password
and not before it. This was causing RMCP+ session establishment
failure. This fixes the same

Tested:
1. Verified RMCP+ session establishment when users are not locked
out.
2. Enabled user lockout feature property, and tried to login
after failed login attempts. Able to see RMCP+ session establishment
failed as expected.

Change-Id: Ie4651dfed330a2769114562e031c4263a429da8f
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Rakp12: Validate user lockout status, before RMCP+ session

In RAKP12, after fetching of the password, user pam authenticate
check is added

Tested:
1. Verified regular ipmitool -I lanplus works.
2.

Rakp12: Validate user lockout status, before RMCP+ session

In RAKP12, after fetching of the password, user pam authenticate
check is added

Tested:
1. Verified regular ipmitool -I lanplus works.
2. Verified the negative case, by configuring lockout for failure
attempts, and locking the user by failed login attempt through
webpage, and then trying to establish IPMI RMCP+ (as expected,
session establishment failed, till lockout timeout happens, or
user is allowed to login.

Change-Id: Idcc9e9289f570fc34a64414031f3f2c7f58e6222
Signed-off-by: Ayushi Smriti <smriti.ayushi@linux.intel.com>

show more ...

Set the current interface number based on the channel name

Now that netipmid is launched with -c <channel_name>, it is possible
to look up the channel number for the 'current channel' 0x0e for
comma

Set the current interface number based on the channel name

Now that netipmid is launched with -c <channel_name>, it is possible
to look up the channel number for the 'current channel' 0x0e for
commands that get handled for session init/fini. This is needed for
tools that request channel access info for the current channel.

Tested-by: run ipmitool to establish a session, using -vvvvv
see that the get channel auth command returns the correct
channel ID.

In this config, eth0 is channel 3 and eth1 is channel 1.

As is evident by the highlighted <0X> byte in each of the
returned responses, the value of the current channel byte
went from a hard-coded value 03 to a value that changed with
the current channel.

Before:
ipmitool -H <ip of eth0> ... mc info
...
>> sending packet (23 bytes)
06 00 ff 07 00 00 00 00 00 00 00 00 00 09 20 18
c8 81 00 38 0e 04 35
<< received packet (31 bytes)
06 00 ff 07 00 00 00 00 00 00 00 00 00 10 81 1c
63 20 00 38 00<03>80 04 02 00 00 00 00 1f 00

ipmitool -H <ip of eth1> ... mc info
...
>> sending packet (23 bytes)
06 00 ff 07 00 00 00 00 00 00 00 00 00 09 20 18
c8 81 00 38 0e 04 35
<< received packet (31 bytes)
06 00 ff 07 00 00 00 00 00 00 00 00 00 10 81 1c
63 20 00 38 00<03>80 04 02 00 00 00 00 1f 00

After:
ipmitool -H <ip of eth0> ... mc info
...
>> sending packet (23 bytes)
06 00 ff 07 00 00 00 00 00 00 00 00 00 09 20 18
c8 81 00 38 8e 04 b5
<< received packet (31 bytes)
06 00 ff 07 00 00 00 00 00 00 00 00 00 10 81 1c
63 20 00 38 00<03>80 04 02 00 00 00 00 1f 00

ipmitool -H <ip of eth1> ... mc info
...
>> sending packet (23 bytes)
06 00 ff 07 00 00 00 00 00 00 00 00 00 09 20 18
c8 81 00 38 8e 04 b5
<< received packet (31 bytes)
06 00 ff 07 00 00 00 00 00 00 00 00 00 10 81 1c
63 20 00 38 00<01>80 04 02 00 00 00 00 21 00

Change-Id: I743260a6924606b9ad3eeb8b49bda424dc0ba3d7
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

spawn one rmcpp bridge per interface

According to the new architecture, each bridge should be a separate
process, or at the very least, be attached on a separate D-Bus
connection with a well-known n

spawn one rmcpp bridge per interface

According to the new architecture, each bridge should be a separate
process, or at the very least, be attached on a separate D-Bus
connection with a well-known name that corresponds to the channel name.

This commit brings netipmid to a state where it can be launched as:
systemctl start phosphor-ipmi-net@eth0

with a parameterized unit file and socket file that binds the socket to
the interface specified. If not launched this way, it will by default be
bound to all interfaces.

This includes the new parameterized service and socket file and the
autoconf/automake magic to install them to the correct place.

Tested-by: launch netipmid via current unit file/socket file
launch netipmid via parameterize unit file/socket file

Change-Id: Ib202015fb560da269e535f11c0ac316b17f6c262
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Skip IPMI Payload commands - IPMI Mesg disabled

Skip IPMI Payload type commands, if IPMI messaging is disabled
for the user.

Tested-by:
Verified that commands are not executed through RMCP+ when
IP

Skip IPMI Payload commands - IPMI Mesg disabled

Skip IPMI Payload type commands, if IPMI messaging is disabled
for the user.

Tested-by:
Verified that commands are not executed through RMCP+ when
IPMI Messaging is disabled for the user through Set
Channel Acess command. Verified the reverse too.

Change-Id: Ibcfd2a18ccc8b0c498eb06ffb56363b94a735b5e
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Cache the user & channel acces in session

Instead of querying the user & channel access for every time
cache the same during session creation, and use it for
enforcements.

Tested-by:
Verified that

Cache the user & channel acces in session

Instead of querying the user & channel access for every time
cache the same during session creation, and use it for
enforcements.

Tested-by:
Verified that RMCP+ session establishment works as expected
including INSUFFICIENT_PRIVILEGE error.

Change-Id: Ib5a05bd07cc9aabf2625a18090fd905d93489b24
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I6ce824eb1be11356c0b902f90bdc6e8c2ede950c