clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I8d0072c279e4de87dc001190845d0ca6da233345
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Remove libmapper dependency

phosphor-net-ipmid does not use the API in libmapper. This patch
removes the dependence on libmapper.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Iffae

Remove libmapper dependency

phosphor-net-ipmid does not use the API in libmapper. This patch
removes the dependence on libmapper.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Iffaee8f84e0485c1b36a469d328b82ec4dad218c

show more ...

Handle SOL payload deactivation for stale session

User is unable to deactivate active SOL session using IPMI command.
To get SOL session ptr, getSession() from session manager was used,
which throwi

Handle SOL payload deactivation for stale session

User is unable to deactivate active SOL session using IPMI command.
To get SOL session ptr, getSession() from session manager was used,
which throwing Session ID is not found error and Deactivate payload
command not returning any response.

So provided fix to use SOL session ptr obtained from Context to check
if current session user has privilege to deactivate SOL payload.

Tested:
Verified using SOL IPMI commands.
//Activate SOL
~$ipmitool -I lanplus -H <BMC-IP> -U <UserID> -P <PWD> -C 17 raw 0x06
0x48 0x01 0x01 0xc0 0x00 0x00 0x00
Response: 00 00 00 00 ff 00 ff 00 6f 02 ff ff
//Deactivate SOL
~$ipmitool -I lanplus -H <BMC-IP> -U <UserID> -P <PWD> -C 17 raw 0x06
0x49 0x01 0x01 0x00 0x00 0x00 0x00
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x49 rsp=0x80): Unknown (0x80)
//Check Payload Activation status
~$ipmitool -I lanplus -H <BMC-IP> -U <UserID> -P <PWD> -C 17 raw 0x06
0x4A 0x01
Response: 01 00 00

Signed-off-by: athuljox <athulx.joseph@intel.com>
Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I49b34a9f17fe356fc86cdecb44aac627c581ba0a

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I5278656122f19da46fcd0a84bc96af420d4cb8bd
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Update System GUID handling to be more robust

If the service that owns the GUID has not yet started when
netipmid starts, netipmid was throwing an error and failing
to start. If the time difference

Update System GUID handling to be more robust

If the service that owns the GUID has not yet started when
netipmid starts, netipmid was throwing an error and failing
to start. If the time difference was too great, it would fail
to re-start and then stay stopped. This makes the error
handling more robust so that the order is not so important.

Tested: started netipmid with and without the UUID service
running and restarted the service to ensure that
netipmid would stay running.

Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
Change-Id: Id464330a2ba8416ff229fa258fff0ad7a1b8f51c

show more ...

Fix the wrong service and path to get the guid

The service and the path to get the guid is wrong; and the
'PropertiesChanged' also use the wrong path and interface

Test:
```
1. set the guid
busctl

Fix the wrong service and path to get the guid

The service and the path to get the guid is wrong; and the
'PropertiesChanged' also use the wrong path and interface

Test:
```
1. set the guid
busctl set-property xyz.openbmc_project.Settings /xyz/openbmc_project/inventory/item/bmc xyz.openbmc_project.Common.UUID UUID s 5c410eb0-ec99-11ec-831a-eec108c4c29c

2. restart netipmid
Jan 16 07:35:47 g220a systemd[1]: Stopping Network IPMI daemon...
Jan 16 07:35:47 g220a systemd[1]: phosphor-ipmi-net@bond1.service: Deactivated successfully.
Jan 16 07:35:47 g220a systemd[1]: Stopped Network IPMI daemon.
Jan 16 07:35:48 g220a systemd[1]: Started Network IPMI daemon.
Jan 16 07:35:48 g220a netipmid[735]: get guid
Jan 16 07:35:48 g220a netipmid-bond1[735]: 0x9c, 0xc2, 0xc4, 0x08, 0xc1, 0xee, 0x1a, 0x83, 0xec, 0x11, 0x99, 0xec, 0xb0, 0x0e, 0x41, 0x5c,

3. get the guid by ipmi
ipmitool raw 0x06 0x37
9c c2 c4 08 c1 ee 1a 83 ec 11 99 ec b0 0e 41 5c

4. change the guid property
busctl set-property xyz.openbmc_project.Settings /xyz/openbmc_project/inventory/item/bmc xyz.openbmc_project.Common.UUID UUID s 5c410eb0-ec99-11ec-831a-eec108c4c29d
Jan 16 07:36:09 g220a netipmid[735]: propertiesChanged
Jan 16 07:36:09 g220a netipmid[735]: get guid
Jan 16 07:36:09 g220a netipmid-bond1[735]: 0x9d, 0xc2, 0xc4, 0x08, 0xc1, 0xee, 0x1a, 0x83, 0xec, 0x11, 0x99, 0xec, 0xb0, 0x0e, 0x41, 0x5c,

5. get the guid by ipmi
ipmitool raw 0x06 0x37
9d c2 c4 08 c1 ee 1a 83 ec 11 99 ec b0 0e 41 5c
```

Signed-off-by: Xie Ning <xiening.xll@bytedance.com>
Change-Id: Icc81cb68c08ec019b717519028bd94def968e151

show more ...

Add privilege check in activate payload

When a user's privilege is lower than sol privilege level, payload
activate and deactivate command will be executed failed with this user.
Refer to ipmi spec

Add privilege check in activate payload

When a user's privilege is lower than sol privilege level, payload
activate and deactivate command will be executed failed with this user.
Refer to ipmi spec v2.0 Appendix G, The configuration parameters for a
given payload type determine the privilege level required to activate
and deactivate the payload.

Tested:
1. Check sol privilege level
```
~# ipmitool -I lanplus -H $ip -U $username -P $password sol activate
[SOL Session operational. Use ~? for help]
SOL session closed by BMC
```
~# ipmitool -I lanplus -H $ip -U $username -P $password sol info
```
Info: SOL parameter 'Nonvolatile Bitrate (5)' not supported
Info: SOL parameter 'Volatile Bitrate (6)' not supported
Set in progress : set-complete
Enabled : true
Force Encryption : false
Force Authentication : false
Privilege Level : ADMINISTRATOR
Character Accumulate Level (ms) : 60
Character Send Threshold : 96
Retry Count : 7
Retry Interval (ms) : 500
Volatile Bit Rate (kbps) : IPMI-Over-Serial-Setting
Non-Volatile Bit Rate (kbps) : IPMI-Over-Serial-Setting
Payload Channel : 1 (0x01)
Payload Port : 623
```

2. Set the privilege of user to 'Operator', run 'sol activate'
and 'sol deactivate'
```
~# ipmitool -I lanplus -H $ip -U $username -P $password sol activate -L OPERATOR
Error activating SOL payload: Insufficient privilege level
~# ipmitool -I lanplus -H $ip -U $username -P $password sol deactivate -L OPERATOR
Error de-activating SOL payload: Insufficient privilege level
```
3. Set the privilege of user to 'ReadOnly', run 'sol activate'
and 'sol deactivate'
```
~# ipmitool -I lanplus -H $ip -U $username -P $password sol activate -L USER
Error activating SOL payload: Insufficient privilege level
~# ipmitool -I lanplus -H $ip -U $username -P $password sol deactivate -L USER
Error de-activating SOL payload: Insufficient privilege level
```
4. Create new users test1 and test2 with 'ReadOnly' privilege,
set sol privilege to 'ReadOnly', run 'sol activate' with test1
```
~# ipmitool -I lanplus -H $ip -U $username -P $password sol set privilege-level user
~# ipmitool -I lanplus -H $ip -U test1 -P $password sol activate -L USER
[SOL Session operational. Use ~? for help]
```
On another console, deactivate session owned by test1
```
~# ipmitool -I lanplus -H $ip -U test2 -P $password sol deactivate -L USER
Error de-activating SOL payload: Insufficient privilege level
~# ipmitool -I lanplus -H $ip -U test1 -P $password sol deactivate -L USER
```
Session owned by test1 cannot be deactivated by test2, can be
deactivated by test1

Signed-off-by: Tang Yiwei <tangyiwei.2022@bytedance.com>
Change-Id: Ie5ca60c9891140614b701392c94245e916cd97ab

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I862ed296ce1f42dba7047a74540d9004ad78130c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

netipmid: Make pam_auth configurable

Allow people to disable pam_authenticate if it is not working for their
system.

Tested:
Testing on a system with no dropbear and was able to pass the check.

Ch

netipmid: Make pam_auth configurable

Allow people to disable pam_authenticate if it is not working for their
system.

Tested:
Testing on a system with no dropbear and was able to pass the check.

Change-Id: I932830cd518b7f8ef6c828405b4959a8d14b1b58
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

phosphor-ipmi-net: Add sysrq handle in netipmid for ipmitool sol.

Send MSG_OOB flag to console server to generate a break.

Tested:
1. Open SOL by ipmitool: ipmitool -H <bmcip> -I lanp -U <user> -P

phosphor-ipmi-net: Add sysrq handle in netipmid for ipmitool sol.

Send MSG_OOB flag to console server to generate a break.

Tested:
1. Open SOL by ipmitool: ipmitool -H <bmcip> -I lanp -U <user> -P <password> sol activate
2. In SOL terminal, login os and "echo 1 > /proc/sys/kernel/sysrq" to open sysrq function
3. In SOL terminal, Enter ~+B to generate break, then enter "h" in 5 second.
4. Veirfy below message shown in SOL:
root@bytedance:~# ~B [send break]
[ 366.377331] sysrq: HELP : loglevel(0-9) reboot(b) crash(c) terminate-all-tasks(e)
memory-full-oom-kill(f) kill-all-tasks(i) thaw-filesystems(j) sak(k) show-backtrace-all-active-cpus(l)
show-memory-usage(m) nice-all-RT-tasks(n) poweroff(o) show-registers(p) show-all-timers(q) unraw(r)
sync(s) show-task-states(t) unmount(u) force-fb(V) show-blocked-tasks(w) dump-ftrace-buffer(z)

Change-Id: Ieac3ee0c7f964920214aa185a947e0449034726f
Signed-off-by: Tingting Chen <chentingting.2150@bytedance.com>

show more ...

logging: switch to lg2

After switching to C++20, it is recommended to use `phosphor::lg2`
to format log, and the correct `CODE_LINE` and `CODE_FUNC` values
can be used in log tracking.

Signed-off-b

logging: switch to lg2

After switching to C++20, it is recommended to use `phosphor::lg2`
to format log, and the correct `CODE_LINE` and `CODE_FUNC` values
can be used in log tracking.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I4aabaafe997e13c10d655a83a9ef0071ad11126e

show more ...

Fix cppcheck warnings

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ibe6b12e81292c655f0ab1420159521c2e6991e37

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic68a12ef7c12222b1300981282161c971b561dc1

show more ...

Update to latest clang-format

Refer:https://github.com/openbmc/docs/blob/ac5d544553934f8083c61c5986a1420261bc8a4c/style/cpp/.clang-format

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id:

Update to latest clang-format

Refer:https://github.com/openbmc/docs/blob/ac5d544553934f8083c61c5986a1420261bc8a4c/style/cpp/.clang-format

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I1e06864afc29ce7de463e62fa2a0eb6f70e8fd93

show more ...

net-ipmid: sol: Remove set/get sol conf command

Move set/get sol config parameter command from net-ipmid to
host-ipmid, these commands could be set by other interface,
not Lan only.
In ipmi-host, wi

net-ipmid: sol: Remove set/get sol conf command

Move set/get sol config parameter command from net-ipmid to
host-ipmid, these commands could be set by other interface,
not Lan only.
In ipmi-host, will be achieved in transporthandler.

Notice:
In host-ipmid, will get/set the dbus properties only, need sol
manager register the signal to update sol manager when properties
changed.

Tested: Build OK, for details will describe in ipmi-host commit
message.

Change-Id: Iae79aa02a483e983c212d8cd617685fc33c64c67
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

Fix calling sol info command immediately after sol set command issue

Problem:
ipmitool sol info command doesn't reflect the value set by ipmitool sol set command after being called consecutively aft

Fix calling sol info command immediately after sol set command issue

Problem:
ipmitool sol info command doesn't reflect the value set by ipmitool sol set command after being called consecutively after ipmitool sol set command

Root Cause:
Lack of updating the latest dbus property value to sol mananger

Solution:
Add updateSOLParameter() method in getConfParams() function.

Test:

ipmitool -I lanplus -H BMC-IP -U BMC-user -P BMC-password -C 17 sol info
Info: SOL parameter 'Nonvolatile Bitrate (5)' not supported
Info: SOL parameter 'Volatile Bitrate (6)' not supported
Set in progress : set-complete
Enabled : true
Force Encryption : true
Privilege Level : USER
Character Accumulate Level (ms) : 100
Character Send Threshold : 1
Retry Count : 7
Retry Interval (ms) : 100
Volatile Bit Rate (kbps) : IPMI-Over-Serial-Setting
Non-Volatile Bit Rate (kbps) : IPMI-Over-Serial-Setting
Payload Channel : 1 (0x01)
Payload Port : 623

ipmitool -I lanplus -H BMC-IP -U BMC-user -P BMC-password -C 17 sol set character-accumulate-level 0x5

ipmitool -I lanplus -H BMC-IP -U BMC-user -P BMC-password -C 17 sol info
Info: SOL parameter 'Nonvolatile Bitrate (5)' not supported
Info: SOL parameter 'Volatile Bitrate (6)' not supported
Set in progress : set-complete
Enabled : true
Force Encryption : true
Force Authentication : true
Privilege Level : USER
Character Accumulate Level (ms) : 25
Character Send Threshold : 1
Retry Count : 7
Retry Interval (ms) : 100
Volatile Bit Rate (kbps) : IPMI-Over-Serial-Setting
Non-Volatile Bit Rate (kbps) : IPMI-Over-Serial-Setting
Payload Channel : 1 (0x01)

Character Accumulate Level (ms) = 25ms = character-accumulate-leverl * accIntervalFactor = 5 * 5

Signed-off-by: Connie Yin <conniey@ami.com>
Change-Id: I987c2f36492418e70dedf4c4f6448821f3c95f79

show more ...

Fix for closeSession with invalid session ID

Issue: If user trying to closeSession with invalid session ID, response
is incorrect and getting as "Unspecified error" (0xff).

Fix: Handle invalid sess

Fix for closeSession with invalid session ID

Issue: If user trying to closeSession with invalid session ID, response
is incorrect and getting as "Unspecified error" (0xff).

Fix: Handle invalid session ID/Handle using separate try cache blocks
and correct the response. i.e. Return "invalid Session ID in request"
(0x87) if user requests to close invalid session ID. Return "invalid
Session Handle in request" (0x88) if user requests to close invalid
session Handle.

Tested:
Verified using RMCPP command.
Command : ipmitool -I lanplus -H <BMC-IP> -U <Username> -P <pwd> -C 17
raw 0x06 0x3C 0x87 0x00 0xEC 0x8E //Close session command
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x3c rsp=0x87): Unknown (0x87)
Command : ipmitool -I lanplus -H <BMC-IP> -U <Username> -P <pwd> -C 17
raw 0x06 0x3C 0x0 0x0 0x0 0x0 0x80
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x3c rsp=0x88): Unknown (0x88)

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I97f57c7cc48efb17e561985b1f4964a8a15bf30e

show more ...

session_cmds: Validate reserved field content

In "Set Session Privilege Level Command" byte-1’s [7-4] bits and
"CALLBACK" privilege level also reserved. So return
"InvalidFieldRequest" when reserved

session_cmds: Validate reserved field content

In "Set Session Privilege Level Command" byte-1’s [7-4] bits and
"CALLBACK" privilege level also reserved. So return
"InvalidFieldRequest" when reserved content is non-zero.

Tested:
Verified using IPMI Command: Set Session Privilege Level Command
Command: ipmitool -I lanplus -H <BMC-IP> -U <usename> -P <pwd> -C 17
raw 0x06 0x3B 0x14
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x3b rsp=0xcc): Invalid data field in request
Command: ipmitool -I lanplus -H <BMC-IP> -U <usename> -P <pwd> -C 17
raw 0x06 0x3B 0x4
Response: 04
Command: ipmitool -I lanplus -H <BMC-IP> -U <usename> -P <pwd> -C 17
raw 0x06 0x3B 0x01 //Set Session Privilege Level for CALLBACK
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x3b rsp=0xcc): Invalid data field in request
Command: ipmitool -I lanplus -H <BMC-IP> -U <usename> -P <pwd> -C 17
raw 0x06 0x3B 0x05 //Set Session Privilege Level for OEM
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x3b rsp=0x81): Unknown (0x81)
Command: ipmitool -I lanplus -H <BMC-IP> -U <usename> -P <pwd> -C 17
raw 0x06 0x3B 0x06
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x3b rsp=0xcc): Invalid data field in request

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Id76b137112486bb4c617cfa7c861403ce6f6c060

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If18cc0293b52ce5f7f8e068688aa17d28ed27d50

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2ed759771f89c1e2e70accb0bee1f5cf0d7ac2c5

show more ...

rakp12: Clear security sensitive data

As password is sensitive data Clear after use.

Tested:
Verified using ipmitool command
Command: ipmitool -I lanplus -C 17 -p 623 -U root -P <password> -H

rakp12: Clear security sensitive data

As password is sensitive data Clear after use.

Tested:
Verified using ipmitool command
Command: ipmitool -I lanplus -C 17 -p 623 -U root -P <password> -H
<BMC-IP> user list 1
Response: Displayed user list successfully.

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I662572855fcdc083009a5217042b1018990be9b8

show more ...

Log Redfish event for invalid login via RMCPP interface

This commit adds support for logging RedFish event log while user tries
to attempt login with invalid credentials.
When user trying to login w

Log Redfish event for invalid login via RMCPP interface

This commit adds support for logging RedFish event log while user tries
to attempt login with invalid credentials.
When user trying to login with invalid credentials on RMCP+ session
interface event should be logged in RedFish event log.
This is a requirement for system events auditing purpose.

Tested:
1. Login with wrong credentials on RMCP+ interface.
2. Verified RedFish event logged successfully.

"Members": [
{
"@odata.id": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/1622785246",
"@odata.type": "#LogEntry.v1_4_0.LogEntry",
"Created": "2021-06-04T05:40:46+00:00",
"EntryType": "Event",
"Id": "1622785246",
"Message": "Invalid username or password attempted on RMCPP.",
"MessageArgs": [
"RMCP+"
],
"MessageId": "OpenBMC.0.1.InvalidLoginAttempted",
"Name": "System Event Log Entry",
"Severity": "Warning"
}
],
"Members@odata.count": 1,
"Name": "System Event Log Entries"
}

3. Verified RedFish validator passed

Signed-off-by: sunitakx <sunitax.kumari@linux.intel.com>
Change-Id: I40b37ff5dd518c52d01b00196e8607c9762a17bf

show more ...

Add Get Channel Cipher Suites Command

Get Channel Cipher Suites Command is already implemented in
phosphor-ipmi-host, but it needs to be implemented in phosphor-ipmi-net
to be able to provide it as

Add Get Channel Cipher Suites Command

Get Channel Cipher Suites Command is already implemented in
phosphor-ipmi-host, but it needs to be implemented in phosphor-ipmi-net
to be able to provide it as a pre-session command for discovering the
available cipher suites before initiating the session.

Without this, ipmitool will have a ten second timeout while attempting
to get the list of available cipher suites. At the same time, netipmid
will show the following messages in the journal:

netipmid[8261]: Table: refuse to forward session-zero command

Tested: ran ipmitool and saw that it did not require a timeout
ipmitool -U <user> -P <pw> -I lanplus -H <host> mc info

Change-Id: Iec1b6fc3262647b82acce0cba607b99e86b74985
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

make internal command functor match external

The internal command functor was getting passed a
const message::Handler& instead of a std::shared_ptr<message::Handler>
which will not work with an upco

make internal command functor match external

The internal command functor was getting passed a
const message::Handler& instead of a std::shared_ptr<message::Handler>
which will not work with an upcoming patch that needs the functor to be
able to modify the Handler object. Also, it is convenient to have the
same signature for both types of handlers.

Tested: run ipmitool to see that behavior does not change.

Change-Id: Ie8660e4d16bd66eccc282aef2594b88c25b847db
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

replace tuple-based singleton with individual singletons

The tuple-based singletons did not actually enforce singleton behavior
and the requirement of the accessor mechanism to include all of the
me

replace tuple-based singleton with individual singletons

The tuple-based singletons did not actually enforce singleton behavior
and the requirement of the accessor mechanism to include all of the
member types at once was starting to cause a header prerequisite
tangle. This removes the cross-dependencies and enforces actual
singletons by making a single way to access the class.

Tested: Run ipmitool to show that behavior has not changed

Change-Id: Ie966e1142363d279365b1095066380c8383e9f9b
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...