Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I3b65183bab2be7aab90d1e184eb778216a54c145
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Remove gen_devtree.pl

This script never ended up being used, so remove it.

Change-Id: Ib43a99b1915b424ba327bf2641aa6f7744b3c20e
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

gen_path_callouts: Add non strict mode

The targets generated from an MRW XML file may initially have some
structural problems, such as a unit target not having a parent chip
target. It's easier to

gen_path_callouts: Add non strict mode

The targets generated from an MRW XML file may initially have some
structural problems, such as a unit target not having a parent chip
target. It's easier to find all of the problems at once when the script
doesn't just die on the first one, so add a '-n' non strict mode where
it will continue on.

Change-Id: I7ca8097d6ad3c0dc44c661a474be63a727515457
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

markdownlint: fix all warnings

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0b596901eaa0eb80edfba31007c7d106797127f0

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: Ia94aa869b11a6df25640c9081bbdb5650fe0bd60
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

python: fix flake8 warnings and format with black

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3e600ba98282393cfbc4a049c08a93118b136550

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7b3041817212656f9184967a779425fed166576e

show more ...

utilize "/usr/bin/env perl" in perl scripts

When utilizing /usr/bin/perl, this expands to the full path of your
filesystem build. i.e. something like this:

/home/andrewg/Code/openbmc/build/withersp

utilize "/usr/bin/env perl" in perl scripts

When utilizing /usr/bin/perl, this expands to the full path of your
filesystem build. i.e. something like this:

/home/andrewg/Code/openbmc/build/witherspoon/tmp/work/x86_64-linux/mrw-perl-tools-native/1.0+gitAUTOINC+65ca8e19c4-r1/recipe-sysroot-native/usr/bin/perl

This now exceeds the allowed size by yocto:
"maximum shebang size exceeded, the maximum size is 128."

There are ways to disable this check in yocto, and we probably have a
case to argue this upstream, but our use in OpenBMC of perl is pretty
limited so the easiest solution is to just move the perl scripts over to
using /usr/bin/env. Half the perl scripts in this repo already do this.

Tested:
- Verified new yocto now builds this repo

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I1c6dfc49a9a1d5ace0d0b9fdd4fa7a0abdee033e

show more ...

ensure no space in script type string

New bitbake checks to ensure the #! line does not exceed 180 characters
and it requires no space between it and the script type info.

Signed-off-by: Andrew Gei

ensure no space in script type string

New bitbake checks to ensure the #! line does not exceed 180 characters
and it requires no space between it and the script type info.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: If52da98c06aced381a6b82cfc0756c1a322f7aec

show more ...

gen_path_callouts: Looks for I2C_BUS_ALIAS

The I2C_BUS_ALIAS bus attribute holds the alias value the BMC uses for
I2C buses behind I2C muxes. For example, a value of 30 could be an
alias for the bu

gen_path_callouts: Looks for I2C_BUS_ALIAS

The I2C_BUS_ALIAS bus attribute holds the alias value the BMC uses for
I2C buses behind I2C muxes. For example, a value of 30 could be an
alias for the bus on channel 3 of a mux on I2C bus 5. This is the
actual value the BMC uses, so it doesn't need to be adjusted later
(subtract 1) like the other buses in the MRW require.

If this attribute is filled in for a device, use that value as the I2C
bus.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I502d3cdabe19c8f47011fa941ad1c09e446c3a50

show more ...

Add an OWNERS file

The OWNERS file contains information about code maintainers and how to
contact them.

Change-Id: Ibb427d051b54b1d098290fcae94426d56f9fe12c
Signed-off-by: Brad Bishop <bradleyb@fuz

Add an OWNERS file

The OWNERS file contains information about code maintainers and how to
contact them.

Change-Id: Ibb427d051b54b1d098290fcae94426d56f9fe12c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

gen_path_callouts: Fix usage string

The code had a string concat operator '.' instead of a ';'.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I4bf77d4eb639558882e904925920aa6e068a52e9

gen_ipmi_sensor: Add occ path conversion conditions for one CPU

When the platform has only one CPU, the occ inventory path will be
/system/chassis/motherboard/cpu/occ.
So checkOccPathFixup cannot be

gen_ipmi_sensor: Add occ path conversion conditions for one CPU

When the platform has only one CPU, the occ inventory path will be
/system/chassis/motherboard/cpu/occ.
So checkOccPathFixup cannot be successfully converted to the correct
application d-bus path.

Change-Id: Ia48d478be8a1177fe465d119c541eff879b14c64
Signed-off-by: Ben Pai <Ben_Pai@wistron.com>

show more ...

gen_path_callouts: Write callouts to JSON file

Save all of the Callout objects to a JSON file. This is where the FRU
callout has its duplicates removed and is sorted based on priority.

This also a

gen_path_callouts: Write callouts to JSON file

Save all of the Callout objects to a JSON file. This is where the FRU
callout has its duplicates removed and is sorted based on priority.

This also adds a new Util module function getLocationCode to find the
location code of a target.

The JSON file is organized into sections for each callout type,
with keys based on the type. I2c uses a bus and address, FSI uses a
link, and SPI uses a bus number. If FSI is combined with I2C or SPI,
then the link plus the I2C/SPI keys is used. Multi-hop FSI links are
indicated by a dash in between the links, eg "0-1". A contrived example
of an entry in the FSI section, on link 5, is:

"FSI":
{
"5":
{
"Callouts":[
{
"Priority":"H"
"LocationCode": "P1-C50",
"MRU":"/sys-0/node-0/motherboard/proc_socket-0/module-0/power9-0",
"Name":"/sys-0/node-0/motherboard/cpu0"
},
{
"Priority":"M",
"LocationCode": "P1-C42",
"MRU":"/sys-0/node-0/motherboard/ebmc-card/BMC-0",
"Name":"/sys-0/node-0/motherboard/ebmc-card"
},
{
"Priority":"L",
"LocationCode": "P1",
"Name":"/sys-0/node-0/motherboard"
}
],
"Dest":"/sys-0/node-0/motherboard-0/proc_socket-0/module-0/power9-0",
"Source":"/sys-0/node-0/motherboard-0/ebmc-card-connector-0/card-0/bmc-0"
}
}

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Iee3493834d5045c553a52c80bbb62f7aa71140e0

show more ...

gen_path_callouts: Create multi-segment callouts

The BMC FSI segments will be connected to other FSI segments to create
new FSI callouts as far out as there is a path, and all the FSI callouts
will

gen_path_callouts: Create multi-segment callouts

The BMC FSI segments will be connected to other FSI segments to create
new FSI callouts as far out as there is a path, and all the FSI callouts
will be connected with any I2C or SPI segments to create new FSII2C or
FSISPI callouts. For example, there could be a Callout object that
contains the path of: BMC -> FSI -> Proc -> FSI -> Proc -> I2C ->
end device.

When the new Callout objects are created from two other callout objects,
the FRU callout lists will be cumulative. In a future commit, they will
be sorted and made unique.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Id1aeb02ead755a876a25f28341c4693762b8b86a

show more ...

gen_path_callouts: Create objects for segments

Create FSI, I2C, and SPI callout objects for the bus segments directly
off of the BMC.

A future commit will extend the FSI callouts to other segments

gen_path_callouts: Create objects for segments

Create FSI, I2C, and SPI callout objects for the bus segments directly
off of the BMC.

A future commit will extend the FSI callouts to other segments further
away.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I3c34034162369bad6722bdebacd651bf37518c74

show more ...

Create gen_path_callouts.pl

This script will pull callouts out of the FRU_PATH attribute on
connections and create a JSON file that has those callouts along with
the FSI/I2C/SPI/FSI-I2C/FSI-SPI keys

Create gen_path_callouts.pl

This script will pull callouts out of the FRU_PATH attribute on
connections and create a JSON file that has those callouts along with
the FSI/I2C/SPI/FSI-I2C/FSI-SPI keys to look them up.

It will be used by OpenBMC code to add callouts to error logs for device
access failure.

This first commit just builds an array of all the FSI/I2C/SPI bus
segments in the system and optionally prints them to JSON.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I4c789ca82b48e00925e03e613b03e965edd383d4

show more ...

Change the key [name] to [Name] in members property

All the other keys start with Uppercase. Changing this to make it
consistent.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I023d0c0

Change the key [name] to [Name] in members property

All the other keys start with Uppercase. Changing this to make it
consistent.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I023d0c0004830bc1758457aed6c1a2d93f394bcf

show more ...

Parse MRW and create JSON file

Previously, it was to parse MRW and create a YAML file.
Now, we need to add a method to parse MRW and create a JSON file.

Tested:
create YAML file:
./gen_led_group

Parse MRW and create JSON file

Previously, it was to parse MRW and create a YAML file.
Now, we need to add a method to parse MRW and create a JSON file.

Tested:
create YAML file:
./gen_led_groups.pl -i witherspoon.xml -o led.yaml
create JSON file:
./gen_led_groups.pl -i witherspoon.xml -o led.json

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I508d06d50163942a87a917895138c8d5b4f24b81

show more ...

python2 to python3 conversion

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia0e00fdd8ae8d4f3c657384be9224cfc9911285f

gen_openpower_fru: Allow multiple instances

Add support for allowing multiple instances of the same MRW type.
Before, since the type was deleted out of %targetHash, it wouldn't
save it in the output

gen_openpower_fru: Allow multiple instances

Add support for allowing multiple instances of the same MRW type.
Before, since the type was deleted out of %targetHash, it wouldn't
save it in the output again.

Now it will only skip adding the results to the @targetTypes and
@paths arrays if the type is empty, or it is not in %targetHash
and also not already in @targetTypes.

Tested: Will now see multiple instances:
FRUS=PANEL,BMC,VRM,VRM,ETHERNET

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ifca9a492fea1341a6d75ab0955badf8e85604bf6

show more ...

IPMI Parser Script Updates

This commit adds a new option to the IPMI MRW
parsing scripts (--skip-broken-mrw).

When specified, the option will cause the scripts
to ignore broken MRW targets such as

IPMI Parser Script Updates

This commit adds a new option to the IPMI MRW
parsing scripts (--skip-broken-mrw).

When specified, the option will cause the scripts
to ignore broken MRW targets such as IPMI sensor
targets without a valid SENSOR_ID attribute
or a FRU without a valid FRU_ID.

This allows us to pull in an in-progress MRW without
it breaking our builds.

Tested:
I tested the scripts against an incomplete MRW and made
sure that the scripts ignored broken targets and generated
output config files for whatever targets were valid.

Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>
Change-Id: Ibf2ca3769e6030d62e73fb362d73a775433273bc

show more ...

Do not add empty paths to output file

This commit fixes a bug in the script where an undefined (blank)
path would get added to the output inventory file in case the
path for a given FRU is not found

Do not add empty paths to output file

This commit fixes a bug in the script where an undefined (blank)
path would get added to the output inventory file in case the
path for a given FRU is not found in both the MRW and the
default path map.

Having an empty path would result in a bad inventory environment
file that would cause the openpower vpd parser service that relies
on this file to fail at runtime.

Tested:
I ran the script manually against the witherspoon MRW and the
openpower layout YAML and verified that the generated inventory
file was good.

Change-Id: I6443208bd3e9e7705da40c30799f007a386b3612
Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>

show more ...

gen-ipmi-sel: force numeric context

Coerce any bin/oct/hex strings returned from Targets.pm getAttribute
calls into numeric context, so the user can use whatever number base
encoding makes sense to

gen-ipmi-sel: force numeric context

Coerce any bin/oct/hex strings returned from Targets.pm getAttribute
calls into numeric context, so the user can use whatever number base
encoding makes sense to them.

Change-Id: I66195dde94093041e304e1738b9b4330a1681d06
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Add tool to dump out all targets and attributes

Prints out every target along with its attributes for debug.

Looks like:

--------------------------------------------------------------
Target /sys-

Add tool to dump out all targets and attributes

Prints out every target along with its attributes for debug.

Looks like:

--------------------------------------------------------------
Target /sys-0/node-0/motherboard-0/proc_socket-0/module-0/p9_proc_m/eq2/core9
MRW_TYPE: NA
CHIPLET_ID: 0x29
CDM_DOMAIN: CPU
PRIMARY_CAPABILITIES:
reserved: 0
supportsFsiScom: 1
supportsInbandScom: 0
supportsXscom: 1
MODEL:
HWAS_STATE_CHANGED_FLAG: 0x0
CLASS: UNIT
HWAS_STATE_CHANGED_SUBSCRIPTION_MASK: 0x00000001
PHYS_PATH:
FRU_NAME: CORE9
BUS_TYPE: NA
FRU_ID: 1
TYPE: CORE
RESOURCE_IS_CRITICAL: 0
DUMMY_RW: 5
CHIP_UNIT: 9
INSTANCE_PATH: instance:sys-0/node-0/motherboard-0/proc_socket-0/core
DECONFIG_GARDABLE: 1
IPMI_INSTANCE: 9
IPMI_SENSORS:

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I65f79ca0e85adfe93f6ff5d9dc5da6948757e1e0

show more ...