first-boot-set-hostname: Restart mDNS services when the hostname changes

mDNS services do not immediately broadcast the updated name when
the hostname is changed. As a result, the system remains dis

first-boot-set-hostname: Restart mDNS services when the hostname changes

mDNS services do not immediately broadcast the updated name when
the hostname is changed. As a result, the system remains discoverable
only under the previous hostname. To address this issue, the relevant
mDNS services are restarted when a new hostname is applied, ensuring
that the new hostname is advertised correctly.

Change-Id: I39f2392609e2ef883546df13089b6ea980199b5e
Signed-off-by: Jae Hyun Yoo <jae.yoo@oss.qualcomm.com>

show more ...

first-boot-set-hostname: fix to update 127.0.1.1 in the /etc/hosts

When updating the hostname, if the /etc/hosts file exists and has an
entry for 127.0.1.1, make sure to update that entry as well.

first-boot-set-hostname: fix to update 127.0.1.1 in the /etc/hosts

When updating the hostname, if the /etc/hosts file exists and has an
entry for 127.0.1.1, make sure to update that entry as well.

Tested:
Without this fix, the issue consistently reproduces as follows.

root@qcom-bmc-ast2600-c00000ea3cf0:~# cat /etc/hostname
qcom-bmc-ast2600-c00000ea3cf0

root@qcom-bmc-ast2600-c00000ea3cf0:~# cat /etc/hosts
127.0.0.1 localhost

# The following lines are desirable for IPv6 capable hosts
::1 localhost ip6-localhost ip6-loopback
fe00::0 ip6-localnet
ff00::0 ip6-mcastprefix
ff02::1 ip6-allnodes
ff02::2 ip6-allrouters
127.0.1.1 qcom-bmc-ast2600

With this fix applied, the behavior changes as follows.

root@qcom-bmc-ast2600-c00000ea3cf0:~# cat /etc/hostname
qcom-bmc-ast2600-c00000ea3cf0

root@qcom-bmc-ast2600-c00000ea3cf0:~# cat /etc/hosts
127.0.0.1 localhost

# The following lines are desirable for IPv6 capable hosts
::1 localhost ip6-localhost ip6-loopback
fe00::0 ip6-localnet
ff00::0 ip6-mcastprefix
ff02::1 ip6-allnodes
ff02::2 ip6-allrouters
127.0.1.1 qcom-bmc-ast2600-c00000ea3cf0

Change-Id: I94b5c4ac879cc8c482f03f7251774dfb30d09184
Signed-off-by: Jae Hyun Yoo <jae.yoo@oss.qualcomm.com>

show more ...

first-boot-set-hostname: add ethaddr U-Boot env handling

Modify the script to use the U-Boot environment's ethaddr to generate
a unique hostname if neither the BMC serial number nor the Ethernet
int

first-boot-set-hostname: add ethaddr U-Boot env handling

Modify the script to use the U-Boot environment's ethaddr to generate
a unique hostname if neither the BMC serial number nor the Ethernet
interface inventories are available,

Change-Id: Ie55de1c553ee53bc9315ce319ac5ac3d46fe94df
Signed-off-by: Jae Hyun Yoo <jae.yoo@oss.qualcomm.com>

show more ...

meson: use non-deprecated systemd packageconfig

Systemd's packageconfig file has both `systemdsystemunitdir` and
`systemd_system_unit_dir` defined. The non-underscore one appears
to be a deprecated

meson: use non-deprecated systemd packageconfig

Systemd's packageconfig file has both `systemdsystemunitdir` and
`systemd_system_unit_dir` defined. The non-underscore one appears
to be a deprecated alias[1]. Move to the non-deprecated /
underscore-separated variant.

[1]: https://github.com/systemd/systemd/commit/4908de44b0a0409f84a7cdc5641b114d6ce8ba03

Change-Id: Ice33455fe91a14d4235cc4d6c5ea2f4220751ecb
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

markdownlint: minor fixes

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I465fc39aba2f1a815d07f8ff1019a6a53390339e

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: I147ee758f6fca48cdd18889f7f018c76dcca39b3
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

usb-ctrl: fix optional mac-addresses

The `help` usb-ctrl declares the MAC options for ecm|emm|rndis optional.
But if they are skipped, the operation will fail.

The change fixes the problem and the

usb-ctrl: fix optional mac-addresses

The `help` usb-ctrl declares the MAC options for ecm|emm|rndis optional.
But if they are skipped, the operation will fail.

The change fixes the problem and the MAC settings can now be safely
omitted.

Tested: each of the commands below works fine:

* `usb-ctrl ecm usb0 on`
* `usb-ctrl ecm usb0 on .`
* `usb-ctrl ecm usb0 on . 5e:e9:8e:01:fa:b4`
* `usb-ctrl ecm usb0 on 5e:e9:8e:01:fa:b3 5e:e9:8e:01:fa:b3`

Change-Id: I7096476656d2f830c32fbc6cb9c784b3ba6bbd2f
Signed-off-by: Igor Kononenko <i.kononenko.e@gmail.com>

show more ...

usb-ctrl: add a way to mount composite gdts

The usb-vhub has a limited number of usb-gadget ports. The BMC features
might want to attach usb-device count greater than the aspeed-vhub
contains ports.

usb-ctrl: add a way to mount composite gdts

The usb-vhub has a limited number of usb-gadget ports. The BMC features
might want to attach usb-device count greater than the aspeed-vhub
contains ports. One of the ways to solve the issue could be by attaching
usb-gadget functions to a composite usb interface.

The change brings a way to mount mass_storage and cdc-based devices
under composite device configuration (VID/PID: 1D6B:0104)

This make possible to mount bouth device functions under single
vhub-port.

Tested:
* Insert usb-gadget:mass-storage device is success:
```bash
#: usb-ctrl insert usb0 /tmp/image.iso cdrom
```
* Insert usb-gadget:usb-ecm device for same port is success:
```bash
#: usb-ctrl ecm usb0 on A0:C5:F2:15:B5:89 A0:C5:F2:15:B5:88
```
* the sysfs displays function-descriptors for both interfaces:
```bash
#: root@vegman-r120-020323000A:~# cd /sys/kernel/config/usb_gadget
#: root@vegman-r120-020323000A:~# ls -la ./usb0/functions/
drwxr-xr-x 4 root root 0 Dec 14 12:13 .
drwxr-xr-x 6 root root 0 Dec 14 12:14 ..
drwxr-xr-x 2 root root 0 Dec 14 12:13 ecm.usb0
drwxr-xr-x 3 root root 0 Dec 14 12:11 mass_storage.usb0
```
* eject one of the mounted device works properly, another one stay
online:
```bash
#: usb-ctrl ecm usb0 off
#: ls -la /sys/kernel/config/usb_gadget/usb0/functions/
drwxr-xr-x 3 root root 0 Dec 14 12:19 .
drwxr-xr-x 6 root root 0 Dec 14 12:19 ..
drwxr-xr-x 3 root root 0 Dec 14 12:11 mass_storage.usb0
```

* output on the host side
```bash
#: root@ubuntu:/home/ubuntu# lsusb -d 1d6b:0104 -v

Bus 001 Device 003: ID 1d6b:0104 Linux Foundation Multifunction ...
Device Descriptor:
...
idVendor 0x1d6b Linux Foundation
idProduct 0x0104 Multifunction Composite Gadget
...
Interface Descriptor:
...
bInterfaceClass 8 Mass Storage
bInterfaceSubClass 6 SCSI
bInterfaceProtocol 80 Bulk-Only
iInterface 5 Mass Storage
...
Interface Descriptor:
...
bInterfaceClass 2 Communications
bInterfaceSubClass 6 Ethernet Networking
bInterfaceProtocol 0
iInterface 7 CDC Ethernet Control Model (ECM)
...

```

Change-Id: I6f54ac5c116ee0bb08e9d18c33267f5b401c2c00
Signed-off-by: Igor Kononenko <i.kononenko.e@gmail.com>

show more ...

README.md: Fix MD034 warnings

The following warnings are generated by using markdownlint analysis:
```
README.md:14:1 MD034/no-bare-urls Bare URL used [Context: "https://gerrit.openbmc-project..."]

README.md: Fix MD034 warnings

The following warnings are generated by using markdownlint analysis:
```
README.md:14:1 MD034/no-bare-urls Bare URL used [Context: "https://gerrit.openbmc-project..."]
README.md:18:1 MD034/no-bare-urls Bare URL used [Context: "https://github.com/openbmc/pho..."]
```
Refer to markdown-lint [1] to fix MD034
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/034-no-bare-urls.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ic67570e3343407a80a2d3cfec1f7c2dc56270159

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: Ieb1a6b353443eabfdc157a80b0e998e35202820f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

OWNERS: Update Igor Username

Gerrit seems to want the associated Username, not the Name. Try that

Change-Id: Iddef9a1dd467b4f4353f9bed2c7c404fc91a81f8
Signed-off-by: Andrew Geissler <geissonator@ya

OWNERS: Update Igor Username

Gerrit seems to want the associated Username, not the Name. Try that

Change-Id: Iddef9a1dd467b4f4353f9bed2c7c404fc91a81f8
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

OWNERS: Change Igor name

Igor has two accounts in gerrit, both of which had the same name
associated with it. He changed the name on the new account so it is
distinct now.

Change-Id: I99187517f7d84

OWNERS: Change Igor name

Igor has two accounts in gerrit, both of which had the same name
associated with it. He changed the name on the new account so it is
distinct now.

Change-Id: I99187517f7d84cc4b35f166b7ff19c4e7cc7abf9
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

OWNERS: Change Igor email to name

Our gerrit prolog rule causes a difficult to debug bug where it will not
allow any scores on a review if an email has a certain amount of "." in
it. Try to workarou

OWNERS: Change Igor email to name

Our gerrit prolog rule causes a difficult to debug bug where it will not
allow any scores on a review if an email has a certain amount of "." in
it. Try to workaround this by using the users name instead of the email.

Change-Id: I64885ea86faccf488ab4519785d1f1010ced652d
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

update OWNERS

Update self(IK) e-mail address.
I have updated my email address as I'm now planning to contribute under
a personal License Agreement.

Change-Id: I266372006f222f86f38a6d3e34f92a051b3b5

update OWNERS

Update self(IK) e-mail address.
I have updated my email address as I'm now planning to contribute under
a personal License Agreement.

Change-Id: I266372006f222f86f38a6d3e34f92a051b3b516b
Signed-off-by: Igor Kononenko <i.kononenko.e@gmail.com>

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: I0aa20f956a896d11ba062f3df4a947f9e68dfb53
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: Ib1e9ab2fa

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: Ib1e9ab2fa4867e4f89401c97e3e4694fa3ea6765
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: I0cca6395bcc6ea64f1c3fded07b9c0cb1329fe9a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

shellcheck: fix issues and format with beautysh

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib06266cbe243a3e70a4c468c0d4d2c4d2b1f1914

meson: set fake language

The organization-wide CI currently assumes that every meson-based
project is either C or C++ and attempts to run sanitizer options
which are only applicable to those languag

meson: set fake language

The organization-wide CI currently assumes that every meson-based
project is either C or C++ and attempts to run sanitizer options
which are only applicable to those languages. This causes the CI
to fail on this repository. This repository only uses meson.build
as a way to direct scripts for install and requires no compile or
language, but set a fake language of 'c' to bypass the CI issues.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ifcaefbe75f955df8bc54e5c3ac1aee27ee88f6e5

show more ...

usb-ctrl: add RNDIS and EEM type support

Add RNDIS and EEM gadget type support.
These kernel configs should be enabled for RNDIS and EEM respectively.

CONFIG_USB_F_RNDIS
CONFIG_USB_CONFIGFS_RNDIS

usb-ctrl: add RNDIS and EEM type support

Add RNDIS and EEM gadget type support.
These kernel configs should be enabled for RNDIS and EEM respectively.

CONFIG_USB_F_RNDIS
CONFIG_USB_CONFIGFS_RNDIS

CONFIG_USB_F_EEM
CONFIG_USB_CONFIGFS_EEM

Tested: RNDIS and EEM type USB ethernet gadgets were created properly.

Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
Change-Id: I562fbf0e9f19e38190174cc2b5cc64bfde182c8b

show more ...

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I25c79772e8c5f73b5800fb354c7e95bbd3c9ec41

show more ...

Add an OWNERS file

The OWNERS file contains information about code maintainers and how to
contact them.

Change-Id: I80ee99cb6d1deebd2063cf7eb988f098450100a4
Signed-off-by: Brad Bishop <bradleyb@fuz

Add an OWNERS file

The OWNERS file contains information about code maintainers and how to
contact them.

Change-Id: I80ee99cb6d1deebd2063cf7eb988f098450100a4
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

usb_ctrl: clean up usb storage configuration

The usb storage interface selection had significant factoring during the
review process. Here are a few cleanups I found reviewing ecm MAC addresses.

-

usb_ctrl: clean up usb storage configuration

The usb storage interface selection had significant factoring during the
review process. Here are a few cleanups I found reviewing ecm MAC addresses.

- We already handled the default empty
+ Anything else is Unknown not Illegal
- Usually its called a backing file, but use backing storage here
+ We also support backing devices
+ The variable name is storage
- Specify the default storage interface in one place
+ By shortening the variable name we can avoid a wrapped line
+ Instead add a comment on default handling in the setter

Signed-off-by: Milton Miller <miltonm@us.ibm.com>
Change-Id: I09fad56f3ae4a92c1394e69acd5a82775b409aef

show more ...

usb-ctrl: Add support to set BMC and Host's mac address

By default it uses the random MAC address when usb ecm is enabled.
Inspired from usb-network.sh in meta-quanta, it is possible to specify
the

usb-ctrl: Add support to set BMC and Host's mac address

By default it uses the random MAC address when usb ecm is enabled.
Inspired from usb-network.sh in meta-quanta, it is possible to specify
the MAC address.

Add optional arguments to set the MAC address when ecm is enabled, so
that the BMC and Host side's MAC addresses are known.

Tested: Verify the MAC addresses could be specified by below command:

usb-ctrl ecm usbeth0 on <bmc-addr host-addr>

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Signed-off-by: Milton Miller <miltonm@us.ibm.com>
Change-Id: I4a944d62d3bbb7e57d1beab90e435663d3ff1e1f

show more ...

usb-ctrl: factor and simplify quoting, reorder interface_type

The function name in sysfs was assembled several times when configuring
a mass storage device. Change usb_set_interface_type to not exp

usb-ctrl: factor and simplify quoting, reorder interface_type

The function name in sysfs was assembled several times when configuring
a mass storage device. Change usb_set_interface_type to not expect the
path to have a trailing slash. Consolidate the function name to one
variable and use it.

Quote complete strings instead of individual variables reducing the
number of quotes needed. Quotes are not required when a safe string is
assigned within the script.

Also set filename after calling usb_set_iterface_type which may help
some cases (read-only files on read-only device type?).

Change-Id: I6c070957b1b9b36693af5717566d9bb13e93269d
Signed-off-by: Milton Miller <miltonm@us.ibm.com>

show more ...