PEL: Fixing procedure name in callout details

In the newly introduced PEL in the callout details
we had procedure name as "next_level_support" but
recently made a change to expose the procedure
call

PEL: Fixing procedure name in callout details

In the newly introduced PEL in the callout details
we had procedure name as "next_level_support" but
recently made a change to expose the procedure
callouts in the RCDL because service said they needed
them. This changes fixes this missing actual procedure
name from next_level_support to BMC0002.

Signed-off-by: Swarnendu Roy Chowdhury <swarnendu.roy.chowdhury@ibm.com>
Change-Id: I7f49ca37cef3c6f49fc08808b68fdd9f72549b25

show more ...

peltool: Fixing memory leak in peltool

On analysis of a defect which points BMC reboot issue, it is found that
peltool has a memory leak which increases the memory consumption on
runtime.

Done the

peltool: Fixing memory leak in peltool

On analysis of a defect which points BMC reboot issue, it is found that
peltool has a memory leak which increases the memory consumption on
runtime.

Done the analysis for the same by generating valgrind report for peltool
and figured out that a block of memory which is getting allocated
dynamically in the API dumpHex() is not getting freed properly, results
in memory leak.

Fixing the same by changing the pointer which points to the block of
memory to a unique_ptr.

Tested:
The new valgrind report generated for peltool after adding the changes
shows zero leakage.
```
==883== LEAK SUMMARY:
==883== definitely lost: 0 bytes in 0 blocks
==883== indirectly lost: 0 bytes in 0 blocks
==883== possibly lost: 0 bytes in 0 blocks
==883== still reachable: 9,786 bytes in 31 blocks
==883== suppressed: 0 bytes in 0 blocks
```

Signed-off-by: Arya K Padman <aryakpadman@gmail.com>
Change-Id: I55db4feedff3a139d0f44a5ace1778acc7375596

show more ...

PEL: Add a new error when occ-control can't find PDRs

The occ-control app needs the PDRs for the OCCs in order to know when
the OCCs are available. If those PDRs are not able to be found for a
perio

PEL: Add a new error when occ-control can't find PDRs

The occ-control app needs the PDRs for the OCCs in order to know when
the OCCs are available. If those PDRs are not able to be found for a
period of time, this PEL will be created for further investigation.

'''
"0x500813BD": {
"SRC": "BD8D2685",
"Message": "BMC firmware was not able to find the OCC sensor ID records",
"PLID": "0x500813BD",
"CreatorID": "BMC",
"Subsystem": "BMC Firmware",
"Commit Time": "04/22/2024 17:05:58",
"Sev": "Predictive Error",
"CompID": "bmc occ control"
},
'''

Change-Id: Ic8167f6d06a346c6bdaa59058fcbbf4b5a63ec38
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

PEL: Changing the remaining traces to lg2 style

Some of the logging traces of PEL files still uses old style of logging.

Changing the remaining traces in PEL files to lg2 style of logging.Some
of t

PEL: Changing the remaining traces to lg2 style

Some of the logging traces of PEL files still uses old style of logging.

Changing the remaining traces in PEL files to lg2 style of logging.Some
of the traces in phosphor logging code which use the old style is also
considered.

Change-Id: I0daf9589af443881cb61730047c23db17fdec2c3
Signed-off-by: Arya K Padman <aryakpadman@gmail.com>

show more ...

PEL: fix the subsystem type for proc sbe internal data msg

Modified to fix the subsystem value used for SBEInternalData
error message for processor.

Signed-off-by: Marri Devender Rao <devenrao@in.i

PEL: fix the subsystem type for proc sbe internal data msg

Modified to fix the subsystem value used for SBEInternalData
error message for processor.

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I96337231257f8f61756cb00b4c892d343c903c4c

show more ...

PEL: Add a new error msg for FFDC collected after SBE chip-op success

SBE enqueues the FFDC (first failure data capture) corresponding
to the internal SBE operations and internal hardware procedure

PEL: Add a new error msg for FFDC collected after SBE chip-op success

SBE enqueues the FFDC (first failure data capture) corresponding
to the internal SBE operations and internal hardware procedure FFDC

After any SBE chip-op request from BMC, if the chip-op is
success BMC needs to check if any FFDC is present and needs
to create PEL based on the severity set in the FFDC packet.

There will be non-fatal errors when executing asynchronous
operations ( e.g auto-boot, MPIPL, DMT or any periodic
background operations in the SBE).

All accumulated non-fatal errors will be regularly reported back
in every chip-op response.

'''
root@rain71bmc:/tmp# peltool -l
{
"0x50006027": {
"SRC": "BD204503",
"Message": "SBE internal FFDC data after chipop request success",
"PLID": "0x50006027",
"CreatorID": "BMC",
"Subsystem": "Memory",
"Commit Time": "04/02/2024 12:42:14",
"Sev": "Unrecoverable Error",
"CompID": "bmc POZ PEL parser"
},
"0x50006028": {
"SRC": "BD204503",
"Message": "SBE internal FFDC data after chipop request success",
"PLID": "0x50006028",
"CreatorID": "BMC",
"Subsystem": "Memory",
"Commit Time": "04/02/2024 12:42:14",
"Sev": "Predictive Error",
"CompID": "bmc POZ PEL parser"
}
}
'''

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: Ib488eccfca3df8c68035c78b49661749d7d9889c

show more ...

log_manager: remove redundant createWithFFDC

Fold the functionality of creating an event entry with FFDC appended
into a common implementation to avoid code duplication and to ease
further extension

log_manager: remove redundant createWithFFDC

Fold the functionality of creating an event entry with FFDC appended
into a common implementation to avoid code duplication and to ease
further extension and maintainability.

Build-tested with 'openpower-pel-extension' enabled.

Change-Id: I0f8151b782bf42cc7bc0981e58f6ab1e3cda080c
Signed-off-by: Paul Fertser <fercerpav@gmail.com>

show more ...

meson: Fix local cereal build

Currently local build is failing with a message:
"""
cereal| Exception: Failed to configure the CMake subproject: Could NOT
find Boost (missing: Boost_INCLUDE_DIR seria

meson: Fix local cereal build

Currently local build is failing with a message:
"""
cereal| Exception: Failed to configure the CMake subproject: Could NOT
find Boost (missing: Boost_INCLUDE_DIR serialization)
Subproject subprojects/cereal is buildable: NO (disabling)
"""
Since cereal requires boost only for the sandbox build and this
functionality is not needed, add option to skip building performance
sandbox comparison to solve the issue.

Tested:
"meson setup build && cd build && meson compile" now finishes
successfully.

Change-Id: Iddc61f432f33ebfce17d9875e685d4c24f64729f
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

PEL: Message_registry: System name as per new compatible interface

As part of the migration from IBMCompatible interface to the new
Compatible interface the PEL code is changed to use the new system

PEL: Message_registry: System name as per new compatible interface

As part of the migration from IBMCompatible interface to the new
Compatible interface the PEL code is changed to use the new system name
format as 'com.ibm.Hardware.Chassis.Model.<system_name>'.

The message registry file still uses the old system name format
'ibm,<system_name>' which results parsing error of PEL message registry
callout JSON.

Hence modifies the message registry file to use the new system name
format.

Tested:
The dev_callouts file in /usr/share/phosphor-logging/pels/ have the new
system name format.
```
com.ibm.Hardware.Chassis.Model.Rainier1S4U_dev_callouts.json
com.ibm.Hardware.Chassis.Model.Rainier2U_dev_callouts.json
com.ibm.Hardware.Chassis.Model.Rainier4U_dev_callouts.json
```

Creating a PEL for SbeTimeout which leads to the PEL callouts as
expected:
```
"Callout Section": {
"Callout Count": "2",
"Callouts": [{
"FRU Type": "Normal Hardware FRU",
"Priority": "Lowest priority replacement",
"Location Code": "U78DA.ND0.WZS004A-P0",
"Part Number": "02WG676",
"CCIN": "2E2D",
"Serial Number": "Y131UF07302J"
}, {
"FRU Type": "Normal Hardware FRU",
"Priority": "Lowest priority replacement",
"Location Code": "U78DA.ND0.WZS004A-P0-C22",
"Part Number": "02WF429",
"CCIN": "6B59",
"Serial Number": "YL101314Y002"
}]
}
```

Signed-off-by: Arya K Padman <aryakpadman@gmail.com>
Change-Id: I438bb3de5014edd6a510e5334c8b1981d5ac512c

show more ...

PEL: Fix PEL to callout PGDPART symbolic FRU

Tested:
Injected a error and verified the output
busctl call xyz.openbmc_project.Logging /xyz/openbmc_project/logging \
xyz.openbmc_project.Logging

PEL: Fix PEL to callout PGDPART symbolic FRU

Tested:
Injected a error and verified the output
busctl call xyz.openbmc_project.Logging /xyz/openbmc_project/logging \
xyz.openbmc_project.Logging.Create Create ssa{ss} \
xyz.openbmc_project.State.Shutdown.Power.Error.Regulator \
xyz.openbmc_project.Logging.Entry.Level.Critical 0

'''
peltool -l
{
"0x5000012C": {
"SRC": "11002602",
"Message": "A power off was issued because a regulator for standby power faulted",
"PLID": "0x5000012C",
"CreatorID": "BMC",
"Subsystem": "Power Control Hardware",
"Commit Time": "03/28/2024 02:49:10",
"Sev": "Critical Error, System Termination",
"CompID": "bmc power and thermal"
}
}
'''

peltool -i 0x5000012C
{
"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "bmc power and thermal",
"Created at": "03/28/2024 02:49:10",
"Committed at": "03/28/2024 02:49:10",
"Creator Subsystem": "BMC",
"CSSVER": "",
"Platform Log Id": "0x5000012C",
"Entry Id": "0x5000012C",
"BMC Event Log Id": "32"
},
"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "bmc error logging",
"Subsystem": "Power Control Hardware",
"Event Scope": "Entire Platform",
"Event Severity": "Critical Error, System Termination",
"Event Type": "Not Applicable",
"Action Flags": [
"Service Action Required",
"Report Externally",
"HMC Call Home"
],
"Host Transmission": "Not Sent",
"HMC Transmission": "Acked"
},
'''
"Primary SRC": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc power and thermal",
"SRC Version": "0x02",
"SRC Format": "0x55",
"Virtual Progress SRC": "False",
"I5/OS Service Event Bit": "False",
"Hypervisor Dump Initiated":"False",
"Backplane CCIN": "2E44",
"Terminate FW Error": "True",
"Deconfigured": "False",
"Guarded": "False",
"Error Details": {
"Message": "A power off was issued because a regulator for standby power faulted"
},
"Valid Word Count": "0x09",
"Reference Code": "11002602",
"Hex Word 2": "00000055",
"Hex Word 3": "2E440010",
"Hex Word 4": "11002602",
"Hex Word 5": "20000000",
"Hex Word 6": "00000000",
"Hex Word 7": "00000000",
"Hex Word 8": "00000000",
"Hex Word 9": "00000000",
"Callout Section": {
"Callout Count": "1",
"Callouts": [{
"FRU Type": "Symbolic FRU",
"Priority": "Mandatory, replace all with this type as a unit",
"Part Number": "PGDPART"
}]
}
},
'''
"Extended User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "bmc error logging",
"Reporting Machine Type": "9028-21B",
"Reporting Serial Number": "788C451",
"FW Released Ver": "NL1060_034",
"FW SubSys Version": "fw1060.00-4.36",
"Common Ref Time": "00/00/0000 00:00:00",
"Symptom Id Len": "20",
"Symptom Id": "11002602_2E440010"
}
'''

Change-Id: I87418ffc51e0a2eb98e795c53c209965b81cfcd9
Signed-off-by: Faisal Awada <faisal@us.ibm.com>

show more ...

PEL: Add POZ PEL Parser

Parser to parse the POZ PLAT data in the PEL. Changing the component ID
from F400 to 4500 to be used for all the SBE's PEL data parsers.
"o3500.py" will handle only P10 proce

PEL: Add POZ PEL Parser

Parser to parse the POZ PLAT data in the PEL. Changing the component ID
from F400 to 4500 to be used for all the SBE's PEL data parsers.
"o3500.py" will handle only P10 processor SBE. "o4500.py" will be for
Odyssey and Pfuture chips.

Change-Id: I4be341888b6ea7a0b999b3e4555604b4d39ea4ce
Signed-off-by: SwethaParasa <parasa.swetha1@ibm.com>

show more ...

PEL: Fix the max packets that can be received for Odyssey OCMB

There is no limit for the number of "ffdc" data packets that
can be received for Odyssey OCMB, a modified parser to loop
through the co

PEL: Fix the max packets that can be received for Odyssey OCMB

There is no limit for the number of "ffdc" data packets that
can be received for Odyssey OCMB, a modified parser to loop
through the complete data received in the ffdc file.

Now check the max ffdc packet count only for p10 proc ffdc.

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I971490afd77d9558d52dbf3422b76239e73079b2

show more ...

PEL: Modify the sbe ffdc handler to cater for POZ format

A new format is defined for the FFDC data received from
odyssey SBE.

The old format will be used for the proc chip, and the new format will

PEL: Modify the sbe ffdc handler to cater for POZ format

A new format is defined for the FFDC data received from
odyssey SBE.

The old format will be used for the proc chip, and the new format will
be used for odyssey OCMB.

Using the chiptype defined in the additionalData section of the
PEL to collect the respective FFDC.

passing "chip type" to libekb to collect respective ffdc data.

Tested:
'''
---p10-poz format---
phosphor-log-manager[11319]: POZFFDC magic bytes 0xfbad
phosphor-log-manager[11319]: POZFFDC lengthinWords 0x18
phosphor-log-manager[11319]: POZFFDC seqId 0x0
phosphor-log-manager[11319]: POZFFDC cmdClass 0xc1
phosphor-log-manager[11319]: POZFFDC cmd 0x1
phosphor-log-manager[11319]: POZFFDC slid 0x2
phosphor-log-manager[11319]: POZFFDC severity 0x2
phosphor-log-manager[11319]: POZFFDC chipId 0x0
phosphor-log-manager[11319]: POZFFDC fapiRc 0x9fb509
phosphor-log-manager[11319]: POZFFDC pktLenWords 0x15

phosphor-log-manager[11319]: HWP_RC= RC_ERROR_UNSUPPORTED_BY_SBE
phosphor-log-manager[11319]: HWP_RC_DESC= An error was encountered
that the SBE didn't expect.
phosphor-log-manager[11319]: HWP_FFDC_INVALID_ERRVAL= 009fb509

---p10-ffdc format---
phosphor-log-manager[364]: SBE FFDC processing requested
phosphor-log-manager[364]: SBE FFDC file fd:(8), parsing started
phosphor-log-manager[364]: P10 FFDC magic: 65500 length in
words:151 Fapirc:81920
phosphor-log-manager[364]: P10 FFDC magic: 65500 length in
words:24 Fapirc:131584
phosphor-log-manager[364]: Created PEL 0x50005409 (BMC ID 842)
with SRC BD20F401
'''
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: Id6b1eb0e2b91c2459bf78abd52e6a3d233d81206

show more ...

PEL: Fix the memory leak error when parsing multiple ffdc packets

"ffdcData" array pointer of sbeFfdcPacketType is deleted as part
of the struct destructor

As the ffdcPkt is declared in the outer s

PEL: Fix the memory leak error when parsing multiple ffdc packets

"ffdcData" array pointer of sbeFfdcPacketType is deleted as part
of the struct destructor

As the ffdcPkt is declared in the outer scope, the memory allocated
gets released only once, and for multiple packets, there will be
memory leak

Change-Id: I2b224ea3db067d4086dbf3ab03ef65a21ae72b0e
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

PEL: Move definitions and variables to the proper scope

Some of the variables and definitions defined in the header
file are used only in the implementation file, so moving those
to the implementati

PEL: Move definitions and variables to the proper scope

Some of the variables and definitions defined in the header
file are used only in the implementation file, so moving those
to the implementation file itself.

Tested:
No testing is required only need to pass compilation.

Change-Id: I4db72c12185b81c4e3e6dfa3f26d69081453c753
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

PEL: add new error messages for odyssey sbe related failures

There will be SBE instances for ocmb targets, so adding
error messages for any SBE access failures.

Adding the new attribute "CHIP_TYPE"

PEL: add new error messages for odyssey sbe related failures

There will be SBE instances for ocmb targets, so adding
error messages for any SBE access failures.

Adding the new attribute "CHIP_TYPE" as we now need to cater for
colletcing SBE FFDC data both for proc and ocmb.

Now added "chip type", to the libekb_get_sbe_ffdc method, which is
called in the sbe ffdc handler so that it can collect data for that
specified chip type.

Tested:
'''
"Private Header": {
"Created by": "0xF400",
},
"Primary SRC": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0xF400",
"Error Details": {
"Message": "chipop request failure reported by OCMB SBE",
"SRC6": [
"0x4AA01",
"[0:15] chip position, [16:23] command class,
[24:31] command type"
],
"CHIP_TYPE": [
"0x28",
"Chip Type"
]
},
"Valid Word Count": "0x09",
"Reference Code": "BD20F401",
},
},
'''
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I622b670d23fc1f6b0d62ad65a41ddcf89c65d319

show more ...

PEL: Use lg2 in Callouts class

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I0dc89e3047e5e735ea887081df4d7ca9df642042

PEL: Don't allow duplicate callouts

When adding callouts, check if the callout being added already exists.
If it does, don't add it and rather just update the priority of the
existing one to be the

PEL: Don't allow duplicate callouts

When adding callouts, check if the callout being added already exists.
If it does, don't add it and rather just update the priority of the
existing one to be the highest of the two.

Callouts are considered to be equal if their location code matches, or
if they have the same maintenance procedure, or if they have the same
symbolic FRU.

The change entails adding an operator== on the Callout object, as well
as an operator> so that the callout with the highest priority can be
determined. Also use this new operator> in the sort of the callout list
that happens after a callout is added or changed.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I5ee148cc12e92f67fb3da233c3615e9665e95355

show more ...

lg2: update structured-logging with latest conversions

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I299eb37a617f8ba9cbeb94b63f817338a7e9a921

lg2: allow enumeration formatting

A good amount of code is using something like `std::to_underlying` to
convert enums to a value for output with lg2. Add support directly in
the library.

Tested:
M

lg2: allow enumeration formatting

A good amount of code is using something like `std::to_underlying` to
convert enums to a value for output with lg2. Add support directly in
the library.

Tested:
Modified phosphor-health-monitor with one enum with a `to_string`
conversion and one without:
```
<7> TYPE=CPU, NAME=CPU SUBTYPE=Enum(1) PATH=, FREQ=1, WSIZE=120
<7> TYPE=CPU, NAME=CPU_Kernel SUBTYPE=Enum(0) PATH=, FREQ=1, WSIZE=120
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0644ff00fb7ff9b20daaf4ea5f9564b9b9e83237

show more ...

lg2: allow type output customizations

Allow lg2 output for custom types where the type has a `to_string`
function defined per ADL lookup rules.

Tested:
Modified phosphor-health-monitor to have a `t

lg2: allow type output customizations

Allow lg2 output for custom types where the type has a `to_string`
function defined per ADL lookup rules.

Tested:
Modified phosphor-health-monitor to have a `to_string` for local
enumerations.
```
<7> TYPE=CPU, NAME=CPU SUBTYPE=CPU PATH=, FREQ=1, WSIZE=120
<7> TYPE=CPU, NAME=CPU_Kernel SUBTYPE=CPU_Kernel PATH=, FREQ=1, WSIZE=120
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6850b0bb142f0ef5219a5fc07c2cb4e2c90d5779

show more ...

PEL: Update sev of critical threshold errors

The Temperature/Voltage CriticalHigh/Low PELs previously had a PEL
severity of 'predictive', and this commit changes them to
'unrecoverable' so that it m

PEL: Update sev of critical threshold errors

The Temperature/Voltage CriticalHigh/Low PELs previously had a PEL
severity of 'predictive', and this commit changes them to
'unrecoverable' so that it matches the D-Bus severity value it's being
created with.

Note: The D-Bus severity value is 'critical'. While there is a PEL
severity value of 'critical', both 'unrecoverable' and 'critical' get
mapped to the Redfish field value of 'Critical' anyway, and the PEL
'critical' field seems to be just used for system crashes and the like.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I174c48180abe9ddca09d0e020e6d16f81311bb61

show more ...

PEL: Convert missed procedure callouts

The three PELs that were added in parallel to the commit that changed
procedure names to the BMCXXXX values got missed, so fix them up.

Signed-off-by: Matt Sp

PEL: Convert missed procedure callouts

The three PELs that were added in parallel to the commit that changed
procedure names to the BMCXXXX values got missed, so fix them up.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I0bbced6d42da14f66be748d96448847fa95f1fe5

show more ...

PEL: Use raw procedure names in PEL msg reg

Start using the raw maintenance procedure names in the PEL message
registry, such as BMC0001, instead of the enum values, such as
'bmc_firmware'. This wa

PEL: Use raw procedure names in PEL msg reg

Start using the raw maintenance procedure names in the PEL message
registry, such as BMC0001, instead of the enum values, such as
'bmc_firmware'. This way, the script that generates documentation can
list the procedure in the section for that PEL. This was requested by
the support team.

Note that there is still one user of the enums - the checkstop analysis
code uses them when it creates callouts by passing in them via JSON user
data files.

There are pointers added to the README and schema to find the available
procedures and their descriptions.

Tested:
- The unit tests still work which verify the callout contents when PEL
callouts are created via the message registry.
- Also manually verified PEL procedure callouts look correct when
created from the message registry.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I3e8416956120d4dae1ff40592fd0df4f0285d072

show more ...

PEL: Add missing File errors to message registry

Add the remaining Common.File errors to the message registry. These are
all in the File.errors.yaml file in phosphor-dbus-interfaces.

Signed-off-by

PEL: Add missing File errors to message registry

Add the remaining Common.File errors to the message registry. These are
all in the File.errors.yaml file in phosphor-dbus-interfaces.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I3b1bb8bc0896dfb6c43df36142bf86750a1fa989

show more ...