History log of /openbmc/phosphor-logging/ (Results 1 – 25 of 1077)
Revision Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
9fdcad5a07-Feb-2025 Matt Spinler <spinler@us.ibm.com>

PELs: Use pldm_msg_hdr_correlate_response()

This call to ensure the PLDM response matches the PLDM request for the
'New PEL Available' command was previously missing (since it didn't
exist at the ti

PELs: Use pldm_msg_hdr_correlate_response()

This call to ensure the PLDM response matches the PLDM request for the
'New PEL Available' command was previously missing (since it didn't
exist at the time this code was written), causing the code to think it
got the correct response when really it was someone else's.

It would then move on to the next PEL before it actually heard back
about the current one, causing issues on the host side.

Change-Id: I471d7727a2b8c77a0ffc85c15cef7531898d22d7
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

2529115701-Feb-2025 Patrick Williams <patrick@stwcx.xyz>

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Iac96affe709a51dd865117d006cb033cf5c624b1
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Iac96affe709a51dd865117d006cb033cf5c624b1
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

963683ac31-Jan-2025 Patrick Williams <patrick@stwcx.xyz>

regenerate-meson: enable meson formatting

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iaee0721778dfce7cfcbd90a8dea0eb0d5de774a0

1f2bb81d30-Jan-2025 Patrick Williams <patrick@stwcx.xyz>

build: use allowed over enabled or not-disabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`)

build: use allowed over enabled or not-disabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and
auto.

Switch all uses of `enabled` to `allowed`.
Switch all uses of `not disabled` to `allowed`.

Change-Id: Icc698b95d762197d496ec9f228a12d7fe48beef0
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

6cfa592327-Jan-2025 Matt Spinler <spinler@us.ibm.com>

Remove readme section on app specific yaml

Requiring application specific phosphor-dbus-interfaces YAML definitions
is very rare and also it is autoconf specific and all repositories have
moved to m

Remove readme section on app specific yaml

Requiring application specific phosphor-dbus-interfaces YAML definitions
is very rare and also it is autoconf specific and all repositories have
moved to meson.

Change-Id: I21d69da5aaf07b1c5e232ed77f3ebd1ea3031520
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

4e8c034322-Jan-2025 Amithash Prasasd <amithash@meta.com>

Add helper method to resolve a log object path

Add a helper method to resolve a previously generated
log entry which can be used by other services in conjunction
with the `lg2::commit` API.

Change-

Add helper method to resolve a log object path

Add a helper method to resolve a previously generated
log entry which can be used by other services in conjunction
with the `lg2::commit` API.

Change-Id: Ia1582177b51ca2f0bfecae98f999b5b8f2f61c93
Signed-off-by: Amithash Prasasd <amithash@meta.com>

show more ...

1d0aba2a13-Jan-2025 Chris Cain <cjcain@us.ibm.com>

PEL: Removed severity from OCC OpenFailure PEL

The OpenFailure PEL was being set to predictive severity.
These errors can happen when a system hits a processor checkpoint. There
should already be an

PEL: Removed severity from OCC OpenFailure PEL

The OpenFailure PEL was being set to predictive severity.
These errors can happen when a system hits a processor checkpoint. There
should already be another error logged for the checkstop, so if the code
hits this condition it will be logged as Notice/Informational.
Also made some changes to add journal traces to other occ-control PELs.

Tested on Rainier.

Change-Id: I320a0758344718e8d1fff478c9c561063ec070e6
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

ad0d752210-Jan-2025 Patrick Williams <patrick@stwcx.xyz>

sdbusplus: update meson to v10 format

There was significant refactoring in sdbusplus generated meson files
in order to support generating Redfish Message Registries. Those
aren't interesting to thi

sdbusplus: update meson to v10 format

There was significant refactoring in sdbusplus generated meson files
in order to support generating Redfish Message Registries. Those
aren't interesting to this repository (and are disabled) but there
are minor top-level meson changes necessary in order to the latest
version of those.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I79dde5151bb5971813506252b7e0cebaacb105c2

show more ...

78679a0317-Dec-2024 Jayanth Othayoth <ojayanth@gmail.com>

clang-tidy: Replace NULL with nullptr

Replaced all instances of NULL with nullptr to improve type safety
and clarity, as nullptr is the modern C++ standard for null pointers.

Tested: Build verified

clang-tidy: Replace NULL with nullptr

Replaced all instances of NULL with nullptr to improve type safety
and clarity, as nullptr is the modern C++ standard for null pointers.

Tested: Build verified

Change-Id: I35a696a754bf88e8b017984bad7e9f143ecfbb9e
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

b6d3e2fc18-Dec-2024 Patrick Williams <patrick@stwcx.xyz>

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have b

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have been deprecated, so adjust the style file
accordingly.

See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style.
See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.

Change-Id: I754b2a89844754c9d87ca20a829cce32dd7feb51
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

ea6d9c4511-Dec-2024 Patrick Williams <patrick@stwcx.xyz>

entry: switch AdditionalData to dict

Clients have been switched to use AddtionalData2, which is a
dictionary. Move AdditionalData also to a dictionary so we
can stage a removal of AdditionalData2.

entry: switch AdditionalData to dict

Clients have been switched to use AddtionalData2, which is a
dictionary. Move AdditionalData also to a dictionary so we
can stage a removal of AdditionalData2.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7cc9591895f219471ac098387f72a35c18e6c750

show more ...

e594063422-Nov-2024 Patrick Williams <patrick@stwcx.xyz>

extension: use map in create extension

Adjust the Create extension to use a map for metadata instead of
vector.

Tested: Unit tests updated and passing.

Signed-off-by: Patrick Williams <patrick@stw

extension: use map in create extension

Adjust the Create extension to use a map for metadata instead of
vector.

Tested: Unit tests updated and passing.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9bd62b8dcc8b18a61958ed64de98b52a48333637

show more ...

64a9eaa322-Nov-2024 Patrick Williams <patrick@stwcx.xyz>

log_manager: directly create metadata from journal

Eliminate one call to `additional_data::parse` by having the journal
metadata search use a `map` for the metadata instead of a `vector`.

Tested: T

log_manager: directly create metadata from journal

Eliminate one call to `additional_data::parse` by having the journal
metadata search use a `map` for the metadata instead of a `vector`.

Tested: Test cases pass.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib1af2e2c96cb9b385fd0f22a63043973b7e2ae14

show more ...

ea21d99522-Nov-2024 Patrick Williams <patrick@stwcx.xyz>

entry: use map for metadata in ctor

Transition the entry constructor to use the `map<string,string>`
rather than the `vector<string>`.

Tested: UTs pass and daemon still creates logs.

Signed-off-by

entry: use map for metadata in ctor

Transition the entry constructor to use the `map<string,string>`
rather than the `vector<string>`.

Tested: UTs pass and daemon still creates logs.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icf3ead163cc99a1498734d33335fb6da52e6c98c

show more ...

5402fa6822-Nov-2024 Patrick Williams <patrick@stwcx.xyz>

entry: use AdditionalData2 for serialization

Prefer the `map<std::string, std::string>` for serialization of
metadata over the `vector<std::string>` format. Add backwards
compatible parsing of the

entry: use AdditionalData2 for serialization

Prefer the `map<std::string, std::string>` for serialization of
metadata over the `vector<std::string>` format. Add backwards
compatible parsing of the `vector<std::string>` format.

Tested: Loaded a "version 5" entry. Created a new entry and verified
it was "version 6" in the binary dump. Reloading the daemon restores
both version 5 and 6 objects.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I39b8a4099ad61161d52c3784d6325df7da031011

show more ...

e7e741ea21-Nov-2024 Patrick Williams <patrick@stwcx.xyz>

entry: add AdditionalData2

Support metadata as dict property "AdditionalData2".

Tested: Created a new event and ensured property is created. Reloaded
the daemon with an old event and ensured prope

entry: add AdditionalData2

Support metadata as dict property "AdditionalData2".

Tested: Created a new event and ensured property is created. Reloaded
the daemon with an old event and ensured property exists and is
populated.

```
.AdditionalData2 property a{ss} 8 "READING_VALUE" "98.6" "SENSOR_NAME" "Inlet Temperature" "THRESHOLD_VALUE" "40.0" "UNITS" "xyz.openbmc_project.Sensor.Value.Unit.DegreesC" "_CODE_FILE" "../log_create_main.cpp" "_CODE_FUNC" "int generate_event(const std::string&, const nlohmann::json_abi_v3_11_2::json&)" "_CODE_LINE" "34" "_PID" "2239596" emits-change writable
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4f96370b9fb07664192e4fe09308cab170176213

show more ...

2731161602-Dec-2024 SwethaParasa <parasa.swetha1@ibm.com>

PEL: Add a new error message for Dump Offload

We log the same error for Dump Delete and Offload right now. Adding a
new error to distinguish between a dump delete and a dump offload.

Change-Id: I1c

PEL: Add a new error message for Dump Offload

We log the same error for Dump Delete and Offload right now. Adding a
new error to distinguish between a dump delete and a dump offload.

Change-Id: I1c74906fb170d883447a021c59199baaa4f6dc97
Signed-off-by: SwethaParasa <parasa.swetha1@ibm.com>

show more ...

d1fc909a28-Nov-2024 Daniel Hsu <Daniel-Hsu@quantatw.com>

Update event log section in README.md

Display the full namespace of metadata in the example

Change-Id: I47ead58878320975b6c2c024a5028f16fae5026b
Signed-off-by: Daniel Hsu <Daniel-Hsu@quantatw.com>

110287ba02-Dec-2024 Shawn McCarney <shawnmm@us.ibm.com>

lg2: Add path to list of supported types in docs

Update the documentation on the lg2 API to include std::filesystem::path
in the list of supported types.

Also updated a README.md that was failing C

lg2: Add path to list of supported types in docs

Update the documentation on the lg2 API to include std::filesystem::path
in the list of supported types.

Also updated a README.md that was failing CI due to a line that was too
long for the formatting checks.

Change-Id: I61a3694d6ad994155829d433a62b2f4a05980e3d
Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>

show more ...

eaabf98b22-Nov-2024 Shawn McCarney <shawnmm@us.ibm.com>

openpower-pels: Add BMC0005 callout to pgood error

Add the procedure BMC0005 as a high priority callout for pgood errors on
the 3V3IO voltage rail. Reduce first VRM callout to medium priority.

Whe

openpower-pels: Add BMC0005 callout to pgood error

Add the procedure BMC0005 as a high priority callout for pgood errors on
the 3V3IO voltage rail. Reduce first VRM callout to medium priority.

When the lid (cover) is removed on Everest/Fuji systems, main power is
automatically shut off for safety reasons. Due to the hardware design
and UCD configuration, the resulting pgood error is incorrectly isolated
to the 3V3IO voltage rail. Add the BMC0005 procedure as the first
callout for this error so the lid will be checked as a possible cause.

Tested:
* Created 11002620 error for the 3V3IO rail using busctl.
* Verified all callouts in the resulting error log were correct.

Change-Id: I3af8ce6ae146ff8c6816602a2bfa47e679268387
Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>

show more ...

a06b4c6b21-Nov-2024 Patrick Williams <patrick@stwcx.xyz>

refactor metadata pack/unpack functions

Move the `parse` and `combine` functions, which are used to translate
between `map<string,string>` and `vector<string>` for the metadata.
This is in preparati

refactor metadata pack/unpack functions

Move the `parse` and `combine` functions, which are used to translate
between `map<string,string>` and `vector<string>` for the metadata.
This is in preparation for transitioning the AdditionalData field
from `vector` to `map`.

Tested: Test cases pass. Simple `log-create` call has no change in
behavior.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib968e1fe02903072c300d5387cf91f2d8164b1b4

show more ...

dd9694ae21-Nov-2024 Patrick Williams <patrick@stwcx.xyz>

lg2: commit: avoid double quoting strings

The JSON `.dump()` function will quote a string, if that is what the
JSON type was. This results in AdditionalData fields which appear
double-quoted. Fix

lg2: commit: avoid double quoting strings

The JSON `.dump()` function will quote a string, if that is what the
JSON type was. This results in AdditionalData fields which appear
double-quoted. Fix this by checking the type and using the raw value
for strings.

Before:
```
.AdditionalData property as 8 "READING_VALUE=98.6" "SENSOR_NAME=\"Inlet Temperature\"" "THRESHOLD_VALUE=40.0" "UNITS=\"xyz.openbmc_project.Sensor.Value.Unit.DegreesC\"" "_CODE_FILE=../log_create_main.cpp" "_CODE_FUNC=int generate_event(const std::string&, const nlohmann::json_abi_v3_11_2::json&)" "_CODE_LINE=34" "_PID=1931265" emits-change writable
```

After:
```
.AdditionalData property as 8 "READING_VALUE=98.6" "SENSOR_NAME=Inlet Temperature" "THRESHOLD_VALUE=40.0" "UNITS=xyz.openbmc_project.Sensor.Value.Unit.DegreesC" "_CODE_FILE=../log_create_main.cpp" "_CODE_FUNC=int generate_event(const std::string&, const nlohmann::json_abi_v3_11_2::json&)" "_CODE_LINE=34" "_PID=2219391" emits-change writable
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie29ab523f7517d5484a833d91c58c2058b710069

show more ...

3f766af122-Nov-2024 Alexander Hansen <alexander.hansen@9elements.com>

log-create: fix listOnly variable

Variable was uninitialized.

For me, it was true on the target (AST2500) when compiling in yocto
environment and false when compiling on x86 with
g++ (GCC) 14.2.1 2

log-create: fix listOnly variable

Variable was uninitialized.

For me, it was true on the target (AST2500) when compiling in yocto
environment and false when compiling on x86 with
g++ (GCC) 14.2.1 20240910

Change-Id: I271cda0ea74121989d82271607f25ea6d0718328
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

236d864b18-Nov-2024 Amithash Prasasd <amithash@meta.com>

Install commit.hpp into target include directory

This ensures that users can include commit.hpp which
is needed to generate event logs

Change-Id: Ie04479d9a9ef41a3e3533db7bc20d33ff22b38be
Signed-of

Install commit.hpp into target include directory

This ensures that users can include commit.hpp which
is needed to generate event logs

Change-Id: Ie04479d9a9ef41a3e3533db7bc20d33ff22b38be
Signed-off-by: Amithash Prasasd <amithash@meta.com>

show more ...

c6396da514-Nov-2024 Deepa Karthikeyan <deepakala.karthikeyan@ibm.com>

openpower-pels: Fix libguard initialization

The initialization of libguard was being skipped because the device tree
was not set up during the initial phosphor-logging phase. As a result,
all guard

openpower-pels: Fix libguard initialization

The initialization of libguard was being skipped because the device tree
was not set up during the initial phosphor-logging phase. As a result,
all guard library calls failed, preventing the creation of system guards
in the event of an error.

To address this, the libguard initialization has been moved to the point
where guard creation occurs. Since libguard initialization is
lightweight, this change has no noticeable impact on performance.

The fix has been tested, and guards are now correctly created as
expected.

```
root@p10bmc:~# putscom pu.c 20018600 8000000000000000 -n0 -p0 -cft
pu.c k0:n0:s0:p00:c0
/usr/bin/edbg putscom pu.c 20018600 8000000000000000 -n0 -p0 -cft

root@p10bmc:~# guard -l
ID | ERROR | Type | Path
0x00000001 | 0x50000a78 | unrecoverable | physical:sys-0/node-0/proc-0/eq-0/fc-0/core-0
```
Change-Id: I8c718be4638743dc1015d0f4f327a4f65c9d9c2d
Signed-off-by: deepakalak <deepakala.karthikeyan@ibm.com>

show more ...

12345678910>>...44