PEL: Use new Compatible interface

Code previously looked at an IBMCompatible interface provided by
entity-manager to get the system type in order to find the device
callouts file when necessary.

EM

PEL: Use new Compatible interface

Code previously looked at an IBMCompatible interface provided by
entity-manager to get the system type in order to find the device
callouts file when necessary.

EM now also puts the xyz.openbmc_project.Inventory.Decorator.Compatible
on D-Bus with the same Names property.

Change the code to use this new interface so it isn't using an IBM
specific one.

Tested:
With the dev_callouts file renamed in /usr/share:
```
/usr/share/phosphor-logging/pels# ls *Rainier2U*
com.ibm.Hardware.Chassis.Model.Rainier2U_dev_callouts.json
```

and with entity-manager hosting the new interface:

```
busctl get-property xyz.openbmc_project.EntityManager
/xyz/openbmc_project/inventory/system/chassis/Rainier_2U_Chassis \
xyz.openbmc_project.Inventory.Decorator.Compatible Names \
as 2
"com.ibm.Hardware.Chassis.Model.Rainier2U"
"com.ibm.Hardware.Chassis.Model.Rainier"
```

Creating a PEL with a device path callout:
```
CALLOUT_DEVICE_PATH /sys/bus/i2c/devices/7-0052
```

Leads to PEL callouts of:
```
"Callout Section": {
"Callout Count": "3",
"Callouts": [{
"FRU Type": "Normal Hardware FRU",
"Priority": "Mandatory, replace all with this type as a unit",
"Location Code": "U78DA.ND0.1234567-P0-C5",
"Part Number": "F191014",
"CCIN": "6B58",
"Serial Number": "YL6B58010000"
}, {
"FRU Type": "Normal Hardware FRU",
"Priority": "Mandatory, replace all with this type as a unit",
"Location Code": "U78DA.ND0.1234567-P0-T10",
"Part Number": "F191014",
"CCIN": "2E2D",
"Serial Number": "YL2E2D010000"
}, {
"FRU Type": "Normal Hardware FRU",
"Priority": "Lowest priority replacement",
"Location Code": "U78DA.ND0.1234567-P0",
"Part Number": "F191014",
"CCIN": "2E2D",
"Serial Number": "YL2E2D010000"
}]
}
```

which matches what's in the file.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I42b71ba184c9526ec3d29360b062c2a335dca343

show more ...

PEL: Removed unused constants in DataInterface

clangd flagged some unused constants and includes.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I82affc530f6ec5601053e9682c01e91ab86079

PEL: Removed unused constants in DataInterface

clangd flagged some unused constants and includes.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I82affc530f6ec5601053e9682c01e91ab8607990

show more ...

PEL: Fixup OCC errors

Add the .Error. segment to the OCC error names so that the manually
created errors can match the ones in the phosphor-dbus-interfaces yaml.

Also add a missing OpenFailure erro

PEL: Fixup OCC errors

Add the .Error. segment to the OCC error names so that the manually
created errors can match the ones in the phosphor-dbus-interfaces yaml.

Also add a missing OpenFailure error.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I0a1776157fd7930ea45a20adfa47823475a2a40a

show more ...

PEL: Add LogsCleared event to message registry

This is an informational event when all event logs are deleted with the
DeleteAll method.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id:

PEL: Add LogsCleared event to message registry

This is an informational event when all event logs are deleted with the
DeleteAll method.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I939a2a228903701b4a31fbb1c617432df6f4b487

show more ...

Add event log for log cleared

-Create log on d-bus when user cleared all log entries.

Tested: tested and verified the implementation on greatlakes platform.
-Call method DeleteAll and check the d-b

Add event log for log cleared

-Create log on d-bus when user cleared all log entries.

Tested: tested and verified the implementation on greatlakes platform.
-Call method DeleteAll and check the d-bus path for event log.

Change-Id: Ib0e71b014608a25cc17bd803768b53774b8f4539
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>

show more ...

test: Set some cases non-parallel

Some UT cases read and write to `ERRLOG_PERSIST_PATH` dir so they will
try to remove/create the dir and read/write files in the dir during the
case execution.
It ca

test: Set some cases non-parallel

Some UT cases read and write to `ERRLOG_PERSIST_PATH` dir so they will
try to remove/create the dir and read/write files in the dir during the
case execution.
It causes races and the unit tests fail intermittently.

Fix the issue by setting the `is_parallel` to false for the specific
cases that use the `ERRLOG_PERSIST_PATH` dir, so that these cases are
run in sequence.

Tested: Verify the UT always passes for more than 300 loops.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I33f10ded3ca0dc11ae52f7f43849d9483ee9d202

show more ...

PEL: Change asprintf call to snprintf

A static analysis security scanner (HCL AppScan SAST) flagged the
asprintf call as a vulnerability because the format string is passed in.

While really it isn'

PEL: Change asprintf call to snprintf

A static analysis security scanner (HCL AppScan SAST) flagged the
asprintf call as a vulnerability because the format string is passed in.

While really it isn't an issue because the format string is always
hardcoded in the calling function and isn't input by a user, this commit
changes it anyway to get it off the list.

Use snprintf instead. While it still takes a passed in format string, a
hardcoded maximum length is used so that the scanner shouldn't flag it
as a possible buffer overrun.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ife309b63470536940ac88c27d13fe73716096326

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: I2c043f5e8daae2f0c603a091f707ce06b1c7663e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: adjust nlohmann-json dependency

Simplify the meson directive for nlohmann-json dependency and rename the
wrap file to align with other repositories.

Signed-off-by: Patrick Williams <patrick@

meson: adjust nlohmann-json dependency

Simplify the meson directive for nlohmann-json dependency and rename the
wrap file to align with other repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6ad9d4fe3e8fa24673b736bab81e2fcabc51f1a0

show more ...

PEL: Use 'Notify' when setting Functional prop

Use phosphor-inventory-manager's Notify method when setting the
Functional property based on PEL callouts.

Using the method will have PIM persist the

PEL: Use 'Notify' when setting Functional prop

Use phosphor-inventory-manager's Notify method when setting the
Functional property based on PEL callouts.

Using the method will have PIM persist the functional value so it isn't
lost after a reboot, unlike a regular property set call.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: If94f788a91fa4668b1297e2d265beb72318d4666

show more ...

PEL: add in ramoops error

Introduce a new component and new error log under that component for
when a ramoops dump is collected.

A ramoops being detected is a critical event for a BMC based system.

PEL: add in ramoops error

Introduce a new component and new error log under that component for
when a ramoops dump is collected.

A ramoops being detected is a critical event for a BMC based system. It
indicates the BMC had an unexpected reboot because of a kernel panic.

Tested:
- Injected ramoops error and verified when BMC came back that the
following error was logged:
```
"0x50000001": {
"SRC": "BD8DC201",
"Message": "BMC rebooted unexpectedly resulting in a ramoops dump being collected",
"PLID": "0x50000001",
"CreatorID": "BMC",
"Subsystem": "BMC Firmware",
"Commit Time": "11/13/2023 18:05:45",
"Sev": "Unrecoverable Error",
"CompID": "bmc dump collector"
}
```

Change-Id: I88e1646cb9b6e7c15a54f91d44ee346d86d39ead
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

PEL: add missing 0x1C00 ComponentID

Change-Id: I26d668a2cbda9c68c2e9314c98b7ba3521018238
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

Remove SDBUSPP_REMOVE_DEPRECATED_NAMESPACE

Fix the code to support new sdbusplus error without
SDBUSPP_REMOVE_DEPRECATED_NAMESPACE.

Change-Id: I12713ec1757d3835e1acf07c7abf409ff97615e1
Signed-off-b

Remove SDBUSPP_REMOVE_DEPRECATED_NAMESPACE

Fix the code to support new sdbusplus error without
SDBUSPP_REMOVE_DEPRECATED_NAMESPACE.

Change-Id: I12713ec1757d3835e1acf07c7abf409ff97615e1
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ib459ac591ed3031de84d0239948d8daa583ef8a5
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

PEL: Change BaseBIOSTable property signature

The D-Bus signature of the BaseBIOSTable property provided by the
BIOSConfigManager app added another string into its D-Bus signature,
which is now a{s(s

PEL: Change BaseBIOSTable property signature

The D-Bus signature of the BaseBIOSTable property provided by the
BIOSConfigManager app added another string into its D-Bus signature,
which is now a{s(sbsssvva(svs))}.

Before it was a{s(sbsssvva(sv))}.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ia74f8f098a84d212db100a3886b4dd876c29cc08

show more ...

PEL: Add error log entries for faultlog poweron time read/write

During chassis poweron current system time is written to a persistent
file that is used to ignore old power or thermal errors as part

PEL: Add error log entries for faultlog poweron time read/write

During chassis poweron current system time is written to a persistent
file that is used to ignore old power or thermal errors as part of
faultlog dump/pel generation.

Add error log entries for failure to read/write from the persistent
file.

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I70420b529d930fee833402d1b3276ffb1ec2a518

show more ...

PEL: switch fmt::format to use std::format

fmt::format is supported in the c++ std. This will
help to remove fmt package dependency.

Change-Id: I89f0a5b67bbfe54168a20e93c989a1ae87f54503
Signed-

PEL: switch fmt::format to use std::format

fmt::format is supported in the c++ std. This will
help to remove fmt package dependency.

Change-Id: I89f0a5b67bbfe54168a20e93c989a1ae87f54503
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

PEL: Change info trace to a debug one

The PLDM daemon was missing the call to HostReject when PHYP responded
to getting a new PEL with the 'file discarded' response. Now that it's
being added, this

PEL: Change info trace to a debug one

The PLDM daemon was missing the call to HostReject when PHYP responded
to getting a new PEL with the 'file discarded' response. Now that it's
being added, this trace was showing up multiple times as PHYP would
accept one new PEL at a time as the OS slowly acked them.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I13bccf821b96a8d918d33646893efa34faf4c088

show more ...

PEL: Close SBE FFDC file descriptors

The descriptors were being leaked since deleting the file doesn't close
the FD which was explicitly opened earlier.

Signed-off-by: Matt Spinler <spinler@us.ibm.

PEL: Close SBE FFDC file descriptors

The descriptors were being leaked since deleting the file doesn't close
the FD which was explicitly opened earlier.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I5d0f1ed91f38af6830ea4f3c600adc402102564c

show more ...

elog-gen: handle new sdbusplus error names

The sdbusplus repository changed the format of the error names that it
generates, which causes the forward-declarations created by elog-gen
to cause a comp

elog-gen: handle new sdbusplus error names

The sdbusplus repository changed the format of the error names that it
generates, which causes the forward-declarations created by elog-gen
to cause a compiler error due to a name-conflict between a `struct` and
an `using` alias. Trying to handle just the sdbusplus rename was
challenging, so instead I also changed the phosphor-logging structs
and created a similar old-style alias.

As a side-effect of this work, I was able to simplify quite a bit of
the mako template as well.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4177654da83387ace892acc481e095901e9549e4

show more ...

regenerate-meson: re-run with latest from sdbusplus

The sdbus++-gen-meson has a new version, which requires regenerating
all the meson in this repository. Re-run the `regenerate-meson`
script.

Sig

regenerate-meson: re-run with latest from sdbusplus

The sdbus++-gen-meson has a new version, which requires regenerating
all the meson in this repository. Re-run the `regenerate-meson`
script.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4d087b25982301a329177c4e65ceb7bf5a9335f5

show more ...

PEL: Update pgood error information for Bonnell

Update the pgood error information in the message registry for Bonnell
systems.

Modify the rail names to match the naming scheme used in the hardware

PEL: Update pgood error information for Bonnell

Update the pgood error information in the message registry for Bonnell
systems.

Modify the rail names to match the naming scheme used in the hardware
documentation. Remove information related to pgood GPIOs that should
not be monitored. Update call outs based on feedback from the hardware
team.

Tested:
* Ran validation tool
* Injected pgood error for each new or modified rail
* Verified error log was created successfully
* Verified system reference code
* Verified call outs

Change-Id: I95da0ba3592b00b372aff322ff267cc3d3740115
Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>

show more ...

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I96388417db1a5c375ad831e6cdf5e7f33b5dd2ae

show more ...

PEL: Ignore hotplugged FRUs owned by PLDM

When the code is watching for newly plugged fans or power supplies, it
can ignore ones hosted by the PLDM daemon because those are in IO
expansion drawers a

PEL: Ignore hotplugged FRUs owned by PLDM

When the code is watching for newly plugged fans or power supplies, it
can ignore ones hosted by the PLDM daemon because those are in IO
expansion drawers and nothing needs to be done when those are added.

In fact, calling into PLDM to get the location code can cause a D-Bus
deadlock because when this code runs it can be in the middle of PLDM
calling into the logging daemon to create event logs.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I0ebb4811a2d115692acfa3301aa53e6d19e635de

show more ...

lg2: Add mutex to avoid stderr line corruption

Use of a mutex, along with flushing after every line, prevents threads
in multithreaded programs from corrupting each other's stderr logging
lines. As

lg2: Add mutex to avoid stderr line corruption

Use of a mutex, along with flushing after every line, prevents threads
in multithreaded programs from corrupting each other's stderr logging
lines. As for the D-Bus journal messages, they are already atomic, not
needing this fix.

Tested: The corruption appears fixed
https://gist.github.com/Krellan/d5d9942cb5ab405c9689e4eb4bb75cf0

Change-Id: I1db88139406eb617aa713740d5ccb6c9420ca773
Signed-off-by: Josh Lehan <krellan@google.com>

show more ...