Pull file path into elog Entry constructor

The path property on the FilePath interfaces was previously being set
after the entry object was created, sending a properties changed signal
after the int

Pull file path into elog Entry constructor

The path property on the FilePath interfaces was previously being set
after the entry object was created, sending a properties changed signal
after the interfaces added signal.

Since the path can be known at the time the entry is constructed, pass
it into the constructor instead so no extra signal will be sent.

Change-Id: I1150236d23cecb1df78e3fb4ae641c75b488af37

show more ...

test: serialization_test_properties: fix stale stack use

Fix use of stale stack variable. The previous code saved
the result of `path.filename().c_str()`, but since the results
of f

test: serialization_test_properties: fix stale stack use

Fix use of stale stack variable. The previous code saved
the result of `path.filename().c_str()`, but since the results
of filename are a temporary it and its `c_str` only exist for
the lifetime of the statement and thus cannot be saved.

Make minor modification to the function to save the `filename()`
portion of the path rather than the filename's `c_str`, thus
extending the lifetime of the `filename()` return.

==2872441==ERROR: AddressSanitizer: stack-use-after-scope
READ of size 3 at 0x7ffcb507c3d0 thread T0
...
#3 0x556b63ed4a35 in phosphor::logging::test::TestSerialization_testProperties_Test::TestBody() ../test/serialization_test_properties.cpp:27

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I17d22741686ac964beef6cc4cb131250c5e79e9b

show more ...

Support UpdateTimestamp log entry property

The UpdateTimestamp property says when an event log property was last
updated. On log creation, this field is initialized with the time that

Support UpdateTimestamp log entry property

The UpdateTimestamp property says when an event log property was last
updated. On log creation, this field is initialized with the time that
the log was created.

The only other time a log entry property can change is when the Resolved
property changes, so also added support there to update the new
UpdateTimestamp property.

While technically every property of the Entry interface is writeable,
there is no use case nor code for changing those in the field, so
UpdateTimestamp does not support those.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I9b1360b9c5424e130947045cee7b64ede6264829

show more ...

add .clang-format

Change-Id: I2c36b7886a25d0b235693b0776019d29608e1d52
Signed-off-by: Patrick Venture <venture@google.com>

Add the BMC code version to error logs

Add the xyz.openbmc_project.Software.Version interface to
the elog entries. This allows a user to know what BMC code
level was running when th

Add the BMC code version to error logs

Add the xyz.openbmc_project.Software.Version interface to
the elog entries. This allows a user to know what BMC code
level was running when the error was created. The level is
persisted along with the other elog fields.

If this code is flashed on a system that was running older code,
and there were existing error logs, the version property will
be left empty in the restored log entries.

Older code is still able to restore logs created by this code
as the version property is at the end of the serialized data
and so is just ignored by Cereal.

Resolves openbmc/openbmc#3133

Tested: Check that new error logs have the code level, and that
restarting phosphor-log-manager preserves that property
on the existing logs. Various incantations of running
the older code with logs created by this code, and running
this code with logs created by older code.

Change-Id: I682aa3bf97c8352ce6dda05dfdf55d33173de891
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

serialization: add tests

Resolves openbmc/openbmc#1684.

Change-Id: Ia554147001e51b05fe8692ae0b39e3efaf481130
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>