Logging.Create: return result path from create call

Support new object path return from Logging.Create.

See Ia010e53fda55cef8b9cfc948482e133f20040320.

```
$ busctl --user call xyz.openbmc_project.

Logging.Create: return result path from create call

Support new object path return from Logging.Create.

See Ia010e53fda55cef8b9cfc948482e133f20040320.

```
$ busctl --user call xyz.openbmc_project.Logging /xyz/openbmc_project/logging xyz.openbmc_project.Logging.Create Create "ssa{ss}" "Example Event" xyz.openbmc_project.Logging.Entry.Level.Error 0
o "/xyz/openbmc_project/logging/entry/1"
$ busctl --user introspect xyz.openbmc_project.Logging /xyz/openbmc_project/logging/entry/1 -l
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.Association.Definitions interface - - -
.Associations property a(sss) 0 emits-change writable
xyz.openbmc_project.Common.FilePath interface - - -
.Path property s "/tmp/phosphor-logging/errors/1" emits-change writable
xyz.openbmc_project.Logging.Entry interface - - -
.GetEntry method - h -
.AdditionalData property as 0 emits-change writable
.EventId property s "" emits-change writable
.Id property u 1 emits-change writable
.Message property s "Example Event" emits-change writable
.Resolution property s "" emits-change writable
.Resolved property b false emits-change writable
.ServiceProviderNotify property s "xyz.openbmc_project.Logging.Entry.Notify.NotSupported" emits-change writable
.Severity property s "xyz.openbmc_project.Logging.Entry.Level.Error" emits-change writable
.Timestamp property t 1727728256156 emits-change writable
.UpdateTimestamp property t 1727728256156 emits-change writable
xyz.openbmc_project.Object.Delete interface - - -
.Delete method - - -
xyz.openbmc_project.Software.Version interface - - -
.Purpose property s "xyz.openbmc_project.Software.Version.VersionPurpose.BMC" emits-change writable
.Version property s "2.15" emits-change writable
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id2f45a1376a88d9785e860a47ea1135179b28ed9

show more ...

PEL: Prevent deletion if it's associated with HWIsolation

- This ensures that PELs linked to HWIsolation records are protected
from accidental deletion.
- Shows error message of "Call failed: The se

PEL: Prevent deletion if it's associated with HWIsolation

- This ensures that PELs linked to HWIsolation records are protected
from accidental deletion.
- Shows error message of "Call failed: The service is temporarily
unavailable.", when attempting to delete such a PEL individually.
- If trying to Delete all, will skip such PELs without showing any
message.

Tested:
Sample output:
```bash
$ busctl call xyz.openbmc_project.Logging /xyz/openbmc_project/
logging xyz.openbmc_project.Collection.DeleteAll DeleteAll

$ busctl call xyz.openbmc_project.Logging /xyz/openbmc_project/
logging/entry/2 xyz.openbmc_project.Object.Delete Delete
Call failed: The service is temporarily unavailable.

```
Change-Id: I2d28de91bbb0fbc2a991e3d5e5631814d41fe044
Signed-off-by: Harsh Agarwal <Harsh.Agarwal@ibm.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I21d2ca8065f24fd73509229c517f5caf48934b60
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

log_manager: remove redundant createWithFFDC

Fold the functionality of creating an event entry with FFDC appended
into a common implementation to avoid code duplication and to ease
further extension

log_manager: remove redundant createWithFFDC

Fold the functionality of creating an event entry with FFDC appended
into a common implementation to avoid code duplication and to ease
further extension and maintainability.

Build-tested with 'openpower-pel-extension' enabled.

Change-Id: I0f8151b782bf42cc7bc0981e58f6ab1e3cda080c
Signed-off-by: Paul Fertser <fercerpav@gmail.com>

show more ...

Add event log for log cleared

-Create log on d-bus when user cleared all log entries.

Tested: tested and verified the implementation on greatlakes platform.
-Call method DeleteAll and check the d-b

Add event log for log cleared

-Create log on d-bus when user cleared all log entries.

Tested: tested and verified the implementation on greatlakes platform.
-Call method DeleteAll and check the d-bus path for event log.

Change-Id: Ib0e71b014608a25cc17bd803768b53774b8f4539
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>

show more ...

Remove SDBUSPP_REMOVE_DEPRECATED_NAMESPACE

Fix the code to support new sdbusplus error without
SDBUSPP_REMOVE_DEPRECATED_NAMESPACE.

Change-Id: I12713ec1757d3835e1acf07c7abf409ff97615e1
Signed-off-b

Remove SDBUSPP_REMOVE_DEPRECATED_NAMESPACE

Fix the code to support new sdbusplus error without
SDBUSPP_REMOVE_DEPRECATED_NAMESPACE.

Change-Id: I12713ec1757d3835e1acf07c7abf409ff97615e1
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Move journal sync function to util.cpp

Move it out of log_manager.cpp so other code will be able to call it.

The code itself wasn't changed, though a comment was modified, as it is
now a utility fu

Move journal sync function to util.cpp

Move it out of log_manager.cpp so other code will be able to call it.

The code itself wasn't changed, though a comment was modified, as it is
now a utility function it may no longer just be called when an error log
is created.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I33a20c1a68059fd50678464776e88168ce93d030

show more ...

clang-format: update with latest

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I329396457b83bb2eb8740629b4ac1fbe9106bced

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibc25db433a6926f7ee43ea83312c3ac14f480c33

show more ...

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.

Change-Id: I21f8e8d8e988ee29933b544fd4ffd8bf0fe3963c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Trace when all log entries are deleted

It can be helpful for debug to know when someone deletes all of the
log entries at once, like when a user clicks the 'Delete all' button
on the web UI. If audi

Trace when all log entries are deleted

It can be helpful for debug to know when someone deletes all of the
log entries at once, like when a user clicks the 'Delete all' button
on the web UI. If audit logs are ever implemented, it could be changed
to one of those instead.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I88b5c4a5e7830c64d3283de8f830f0cae4d501da

show more ...

log_manager: add override to deleteAll

The function 'deleteAll' is intended to override a function
in one of the phosphor-dbus-interfaces classes. Clang throws
a warning without thi

log_manager: add override to deleteAll

The function 'deleteAll' is intended to override a function
in one of the phosphor-dbus-interfaces classes. Clang throws
a warning without this being present, so add it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibb71c3f2ae296db20369add90b48c69f7af12474

show more ...

Reset entryID to 0 after eraseAll.

After eraseAll(), reset the entryID to 0, so that the entry IDs reset,
and the ipmi sel's entry ID resets.

Tested: Run `ipmitool sel clear&&ip

Reset entryID to 0 after eraseAll.

After eraseAll(), reset the entryID to 0, so that the entry IDs reset,
and the ipmi sel's entry ID resets.

Tested: Run `ipmitool sel clear&&ipmitool sel list`:

1 | 05/23/21 | 09:01:11 UTC | Event Logging Disabled #0x8b | Log area reset/cleared | Asserted

Signed-off-by: Lotus Xu <xuxiaohan@bytedance.com>
Change-Id: Ic244f4a972a0c4c367722361baa548676c394b31

show more ...

Return entryID on commiting logs

Let the Commit()/CommitWithLvl() methods return entryID, so that the
caller of commit()/report() could get the entryID directly without
querying the

Return entryID on commiting logs

Let the Commit()/CommitWithLvl() methods return entryID, so that the
caller of commit()/report() could get the entryID directly without
querying the logging service again.

This is useful in cases that the caller needs to know the entryID of the
commit()/report() events.

Tested: Manually verify the report() returns the correct entryID.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: Ieb22d32d4e9242ec46b799f6e98ca3d49e7590b9

show more ...

extensions: pels: Add PEL path to elog entry

Populate the path property of the error log entry with the path
to the PEL path. This requires making the entries map public.

Restor

extensions: pels: Add PEL path to elog entry

Populate the path property of the error log entry with the path
to the PEL path. This requires making the entries map public.

Restore the value of the path for the entries when the PEL
manager starts up once the Repository has verified each PEL file.

Tested: Verified the PEL path was populated in the path property
and that it was re-populated after restarting the app.
root@openbmc:~# busctl --no-pager get-property xyz.openbmc_project.Logging \
/xyz/openbmc_project/logging/entry/884 xyz.openbmc_project.Common.FilePath Path
s "/var/lib/phosphor-logging/extensions/pels/logs/2020120522023306_50000D30"

Change-Id: I2a7315bbc3f0f4699e77aadbc7da05818c0c15e3
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

PEL: Implement CreatePELWithFFDCFiles

This D-Bus method on the org.open_power.Logging.PEL interface is the
same as the already existing createWithFFDCFiles method on the
xyz.openbmc_

PEL: Implement CreatePELWithFFDCFiles

This D-Bus method on the org.open_power.Logging.PEL interface is the
same as the already existing createWithFFDCFiles method on the
xyz.openbmc_project.Logging.Create interface, except it also returns the
IDs of the newly created OpenBMC event log and PEL.

Code was added to track the IDs of the most recently added event log and
PEL so they they can be returned by the function.

Change-Id: I3a1e0d93f97aa1953ff8b10293b47e28f79edfb1

show more ...

quiesce: use entry id for interface

Extension code does not have the Entry object as an input parameter. The
quiesce interface should not require an Entry object. Refactor the code
a

quiesce: use entry id for interface

Extension code does not have the Entry object as an input parameter. The
quiesce interface should not require an Entry object. Refactor the code
a bit to allow for this.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I5caee881dae3d6c22f4f619af5acd3e3e33379aa

show more ...

boot-block: quiesce host on error

If the user has requested the boot be blocked on an error with a
callout then also quiesce the host if it is running when this error
occurs.

boot-block: quiesce host on error

If the user has requested the boot be blocked on an error with a
callout then also quiesce the host if it is running when this error
occurs.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I9f1f4fc1c704850649217770f4cfcff1cad70404

show more ...

boot-block: clear block on error resolve

If the blocking error is resolved then remove the blocking object and
it's property change callback

Signed-off-by: Andrew Geissler <geis

boot-block: clear block on error resolve

If the blocking error is resolved then remove the blocking object and
it's property change callback

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I9acb844ef273e8390b4f5283f234990b3c008e70

show more ...

boot-block: remove blocking error on erase

When an entry is erased, remove it from the blocking array. This will
result in the d-bus object at the /xyz/openbmc_project/logging/blockX

boot-block: remove blocking error on erase

When an entry is erased, remove it from the blocking array. This will
result in the d-bus object at the /xyz/openbmc_project/logging/blockX
path being deleted as well.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ib49073532588d25c4ae357917ecd6339a70d8c1e

show more ...

boot-block: create d-bus block object on callout

If the QuiesceOnHwError is set and a callout is present in the Entry
then create the new block object and the
xyz.openbmc_project.Log

boot-block: create d-bus block object on callout

If the QuiesceOnHwError is set and a callout is present in the Entry
then create the new block object and the
xyz.openbmc_project.Logging.ErrorBlocksTransition interface.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I9aea289ab7cc8dc7649820ff54edc8c04ecb3ef5

show more ...

boot-block: look for a callout in the entry

phosphor-logging callouts always start with a CALLOUT_ in the additional
data entry. Look for this to determine if a callout is present in the

boot-block: look for a callout in the entry

phosphor-logging callouts always start with a CALLOUT_ in the additional
data entry. Look for this to determine if a callout is present in the
log.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I721e794dc4610a18705e1b0d75e545b14f844402

show more ...

boot-block: check quiesce on error setting

An initial commit to check the new QuiesceOnHwError setting. Future
commits will act on this setting by creating the appropriate error
asso

boot-block: check quiesce on error setting

An initial commit to check the new QuiesceOnHwError setting. Future
commits will act on this setting by creating the appropriate error
associations if needed.

Make public functions so code outside of log_manager (such as extension
code) can utilize these functions.

The design for this feature can be found here:
https://github.com/openbmc/docs/blob/master/designs/fail-boot-on-hw-error.md

Tested:
Verified code correctly read setting and took correct code path

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I2d113b5ca05afc39a5b81808eaafbc15da03bf8e

show more ...

Implement createWithFFDCFiles

This commit adds support for the createWithFFDCFiles D-Bus method. This
method creates a new OpenBMC event log, just like create() does, but it
also ad

Implement createWithFFDCFiles

This commit adds support for the createWithFFDCFiles D-Bus method. This
method creates a new OpenBMC event log, just like create() does, but it
also adds a new parameter to pass through information about files
containing FFDC (First Failure Data Capture) to any extensions. This
FFDC may be stored by the extensions code to provide additional debug
information about an error.

The FFDC parameter is a vector of tuples. Each tuple contains:
* Format Type - An enumeration describing the format of the data
* Subtype - If the format type is custom, then this can be used
to provide a format type that is specific to the
creator.
* Version - If the format type is custom, then this can be used
to provide the version of the custom data.
* FD - A file descriptor to the file containing the FFDC.
This does not need to be closed (an attempt will fail)
by phosphor-log-manager.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I3e8e03d6393dfc145e9fd11bd078595868bb3767

show more ...

Format fix

CI didn't like the format of the previous commit, where the error was
masked by the CI step failure that builds phosphor-logging from master
as a dependency before it buil

Format fix

CI didn't like the format of the previous commit, where the error was
masked by the CI step failure that builds phosphor-logging from master
as a dependency before it builds the repo under test.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ia7d62c5c226260ae78e40552f842105478a1453d

show more ...