Remove SDBUSPP_REMOVE_DEPRECATED_NAMESPACE

Fix the code to support new sdbusplus error without
SDBUSPP_REMOVE_DEPRECATED_NAMESPACE.

Change-Id: I12713ec1757d3835e1acf07c7abf409ff97615e1
Signed-off-b

Remove SDBUSPP_REMOVE_DEPRECATED_NAMESPACE

Fix the code to support new sdbusplus error without
SDBUSPP_REMOVE_DEPRECATED_NAMESPACE.

Change-Id: I12713ec1757d3835e1acf07c7abf409ff97615e1
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ib459ac591ed3031de84d0239948d8daa583ef8a5
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

PEL: Change BaseBIOSTable property signature

The D-Bus signature of the BaseBIOSTable property provided by the
BIOSConfigManager app added another string into its D-Bus signature,
which is now a{s(s

PEL: Change BaseBIOSTable property signature

The D-Bus signature of the BaseBIOSTable property provided by the
BIOSConfigManager app added another string into its D-Bus signature,
which is now a{s(sbsssvva(svs))}.

Before it was a{s(sbsssvva(sv))}.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ia74f8f098a84d212db100a3886b4dd876c29cc08

show more ...

PEL: Add error log entries for faultlog poweron time read/write

During chassis poweron current system time is written to a persistent
file that is used to ignore old power or thermal errors as part

PEL: Add error log entries for faultlog poweron time read/write

During chassis poweron current system time is written to a persistent
file that is used to ignore old power or thermal errors as part of
faultlog dump/pel generation.

Add error log entries for failure to read/write from the persistent
file.

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I70420b529d930fee833402d1b3276ffb1ec2a518

show more ...

PEL: switch fmt::format to use std::format

fmt::format is supported in the c++ std. This will
help to remove fmt package dependency.

Change-Id: I89f0a5b67bbfe54168a20e93c989a1ae87f54503
Signed-

PEL: switch fmt::format to use std::format

fmt::format is supported in the c++ std. This will
help to remove fmt package dependency.

Change-Id: I89f0a5b67bbfe54168a20e93c989a1ae87f54503
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

PEL: Change info trace to a debug one

The PLDM daemon was missing the call to HostReject when PHYP responded
to getting a new PEL with the 'file discarded' response. Now that it's
being added, this

PEL: Change info trace to a debug one

The PLDM daemon was missing the call to HostReject when PHYP responded
to getting a new PEL with the 'file discarded' response. Now that it's
being added, this trace was showing up multiple times as PHYP would
accept one new PEL at a time as the OS slowly acked them.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I13bccf821b96a8d918d33646893efa34faf4c088

show more ...

PEL: Close SBE FFDC file descriptors

The descriptors were being leaked since deleting the file doesn't close
the FD which was explicitly opened earlier.

Signed-off-by: Matt Spinler <spinler@us.ibm.

PEL: Close SBE FFDC file descriptors

The descriptors were being leaked since deleting the file doesn't close
the FD which was explicitly opened earlier.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I5d0f1ed91f38af6830ea4f3c600adc402102564c

show more ...

PEL: Update pgood error information for Bonnell

Update the pgood error information in the message registry for Bonnell
systems.

Modify the rail names to match the naming scheme used in the hardware

PEL: Update pgood error information for Bonnell

Update the pgood error information in the message registry for Bonnell
systems.

Modify the rail names to match the naming scheme used in the hardware
documentation. Remove information related to pgood GPIOs that should
not be monitored. Update call outs based on feedback from the hardware
team.

Tested:
* Ran validation tool
* Injected pgood error for each new or modified rail
* Verified error log was created successfully
* Verified system reference code
* Verified call outs

Change-Id: I95da0ba3592b00b372aff322ff267cc3d3740115
Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>

show more ...

PEL: Ignore hotplugged FRUs owned by PLDM

When the code is watching for newly plugged fans or power supplies, it
can ignore ones hosted by the PLDM daemon because those are in IO
expansion drawers a

PEL: Ignore hotplugged FRUs owned by PLDM

When the code is watching for newly plugged fans or power supplies, it
can ignore ones hosted by the PLDM daemon because those are in IO
expansion drawers and nothing needs to be done when those are added.

In fact, calling into PLDM to get the location code can cause a D-Bus
deadlock because when this code runs it can be in the middle of PLDM
calling into the logging daemon to create event logs.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I0ebb4811a2d115692acfa3301aa53e6d19e635de

show more ...

PEL: Update Deconfig D-Bus property after clear

When a fan or power supply is replaced, the deconfig flag field in the
PEL is cleared. There is also a Deconfig property on D-Bus that should
match t

PEL: Update Deconfig D-Bus property after clear

When a fan or power supply is replaced, the deconfig flag field in the
PEL is cleared. There is also a Deconfig property on D-Bus that should
match the PEL field, but the code to clear that was missed, so add it.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I6fc971953b6e4d1e1c2da421bbc920923b199dbb

show more ...

Revert "PEL: Use lg2 in peltool.cpp"

Since lg2 prints to the console when the application is called from the
commandline like peltool is, when the -D peltool option is used to
delete all PELs it wil

Revert "PEL: Use lg2 in peltool.cpp"

Since lg2 prints to the console when the application is called from the
commandline like peltool is, when the -D peltool option is used to
delete all PELs it will print something. This isn't that helpful and
people are complaining about it. So just go back to the original
phosphor-logging API which won't do this.

This reverts commit aaf23ee78584181b7b64450c3eafa8b3c7372b3b.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I387f277ca0e57fbf5f52f3e8294572bc702db997

show more ...

build: simplify nlohmann-json subproject

The phosphor-pid-control repository uses both phosphor-logging and
phosphor-host-ipmid as subprojects, but the way they incorporate
nlohmann-json is differen

build: simplify nlohmann-json subproject

The phosphor-pid-control repository uses both phosphor-logging and
phosphor-host-ipmid as subprojects, but the way they incorporate
nlohmann-json is different. Simplify the phosphor-logging one to
match what is available in phosphor-host-ipmid so that they can both be
build a subprojects within a single top-level project.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3484d9ee9697900dbe5e8e1895ea9d477485553d

show more ...

PEL: Use lg2 in peltool.cpp

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I3bbedab2e3115ac6d7c16662765a6f40285913fd

PEL: Use lg2 in SRC class

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Iccb7cbd56f394bcafb4e8c5a8d3aef506007ebad

PEL: Use lg2 in Repository class

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I36563086f862e20a4f2a4f43fee46f4a800af606

PEL: Use lg2 in PEL class

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ibc052f66eb0e5d8429a3da45569fe09931b43b49

PEL: Use lg2 in user_data_json.cpp

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I59944fbfd4ed8aba16c2c1a3742ff5e8d9d73066

PEL: Use lg2 in Registry class

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I5a7499843887afba545688d24876d4308384dc61

PEL: Use lg2 in Manager class

Modernize it a bit and it makes it easier to see debug traces which can
be done by just running the daemon from the command line. There are
quite a few debug traces in

PEL: Use lg2 in Manager class

Modernize it a bit and it makes it easier to see debug traces which can
be done by just running the daemon from the command line. There are
quite a few debug traces in this file.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Id1291e3a3c3882d1ed917d4a414cb6253ebf2644

show more ...

PEL: Use lg2 in DataInterface files

Modernize it a bit and it makes it easier to see debug traces which can
be done by just running the daemon from the command line.

Signed-off-by: Matt Spinler <sp

PEL: Use lg2 in DataInterface files

Modernize it a bit and it makes it easier to see debug traces which can
be done by just running the daemon from the command line.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ic0416222e29be0c6687b6d31cb6ca4feae2ad619

show more ...

PEL: Handle failing to start a PLDM cmd better

A recent PLDM bug caused the registerReceiveCallback() function, which
is used to setup listening for the PLDM response from the host when
telling the

PEL: Handle failing to start a PLDM cmd better

A recent PLDM bug caused the registerReceiveCallback() function, which
is used to setup listening for the PLDM response from the host when
telling them about a new PEL, to throw an exception.

When this happened, the code got stuck in the 'in progress' state, so it
would never try again when the next PEL came in.

Fix that by having startCommand() throw an exception instead of calling
the failure response function callback. With this change, the code will
continue on to call the cleanupCmd() function so everything is ready
when the next PEL comes in.

Tested:
With the bad PLDM code, after the first PEL ran out of retry attempts,
created another PEL and saw the code attempt again to call PLDM. Also,
wrote a new unit test case for it.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I38034440435d6a86e8dd880eef09499f19dd6e9c

show more ...

PEL: Use lg2 in PLMD related files

There are a lot of debug traces in the code that uses PLDM to send PELs
up to the OS. Convert the files that deal with that to lg2 so that the
debug traces can be

PEL: Use lg2 in PLMD related files

There are a lot of debug traces in the code that uses PLDM to send PELs
up to the OS. Convert the files that deal with that to lg2 so that the
debug traces can be seen by just running phosphor-log-manager from the
command line where lg2 will print to the console as opposed to having to
change the journal priority in an overlay file.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I818bab1bf636fe83d3e7ff64c1bc31ad5e09705e

show more ...

PEL: Remove unnecessary call to restore resolution

The Resolution D-Bus property, which holds the PEL callouts, are saved
along with the other elog properties in the cereal backing file and
don't ne

PEL: Remove unnecessary call to restore resolution

The Resolution D-Bus property, which holds the PEL callouts, are saved
along with the other elog properties in the cereal backing file and
don't need to be manually restored when the daemon starts up.

Tested:
Resolution is still filled in after restarting the daemon.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I18e1b79d40b219a6a37c013355cd965de11ce8cb

show more ...

PEL: Fixed serializing of elog properties

The PEL code modifies the Resolution and EventId properties on the
standard event log objects to fill them in with PEL specific values. It
was originally d

PEL: Fixed serializing of elog properties

The PEL code modifies the Resolution and EventId properties on the
standard event log objects to fill them in with PEL specific values. It
was originally doing this by using the resolution() and eventId()
override functions on the Entry object that would do the elog serialize
after it updated those properties.

Since then, the code was changed to instead call the resolution() and
eventId() functions that also take the bool skipSignal parameter, which
caused it to not call the overridden functions which meant those
properties weren't serialized and so not restored after a restart.

While we could just also override the functions that take that
skipSignal parameter to do the serialize, those get called when the
event log object is restored on startup, so it would cause unnecessary
calls to serialize.

Instead, just call the serialize() function directly after updating the
event ID and resolution when creating a PEL.

Tested:
The Resolution and EventId D-Bus properties are now correct after the
process is restarted.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I8c1822e9c31925983feddab657644c98f37ef079

show more ...

PEL: Error log entries for ECC errors

This commit adds three new error log entries for ECC errors.

The new entries include:
- Correctable ECC memory error collection limit is reached.
- Correctable

PEL: Error log entries for ECC errors

This commit adds three new error log entries for ECC errors.

The new entries include:
- Correctable ECC memory error collection limit is reached.
- Correctable ECC/other correctable memory error.
- Uncorrectable ECC/other uncorrectable memory error.

Change-Id: Ibfa7654bdfbccc5cf7154664a048d931d10b433c
Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>

show more ...