PEL: Take a PEL off the queue and send to host

Fill in the code that looks for the first PEL on the queue that still
needs to be sent up, and send it.

If the failure retry timer is active, or it ha

PEL: Take a PEL off the queue and send to host

Fill in the code that looks for the first PEL on the queue that still
needs to be sent up, and send it.

If the failure retry timer is active, or it has already retried the max
number of times, then don't send anything. In the former case the timer
callback will do the send, and in the latter the next time a log comes
in it will start trying again.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ibb9692ca83b23e5e021db8b8a89b5549fb979df1

show more ...

PEL: Fill in host state change callback

If the host is up, start sending PELs.

If the host is off, move all of the PELs that are sent but
not acked back to the queue to be sent again next time.

Si

PEL: Fill in host state change callback

If the host is up, start sending PELs.

If the host is off, move all of the PELs that are sent but
not acked back to the queue to be sent again next time.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I66d382a85afc88f6b23367fb515df4dbe5326be1

show more ...

PEL: Fill in host command response handler

If notifying the host of a new PEL was successful, then it
will modify the PEL's host transmission state to 'sent' and
add it to the list of sent PELs.

If

PEL: Fill in host command response handler

If notifying the host of a new PEL was successful, then it
will modify the PEL's host transmission state to 'sent' and
add it to the list of sent PELs.

If there was a failure, then a timer will be started so a
retry can be done.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I77000c603a18726d4cdbb3920ca349e69198fb7f

show more ...

PEL: Logic to enqueue a PEL to send to host

Fill in the function to determine if a PEL needs to be placed on the
qeueue to be sent up to the host. It involves checking both the host
and HMC transmi

PEL: Logic to enqueue a PEL to send to host

Fill in the function to determine if a PEL needs to be placed on the
qeueue to be sent up to the host. It involves checking both the host
and HMC transmission states, as well as the PEL action flags field.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I9f1a9fba1b7e6dc7a167f1c7e9dfd6c40d90883f

show more ...

PEL: Add HostNotifier class

This class will watch for new PELs being created, and handle sending
them up to the host. This first commit for this class mostly just fills
in the constructor to set up

PEL: Add HostNotifier class

This class will watch for new PELs being created, and handle sending
them up to the host. This first commit for this class mostly just fills
in the constructor to set up the various callbacks it will use.

It is only instantiated in the Manager class if the Manager constructor
used is the one that passes in the HostInterface object, to allow for
configurations that don't need PELs passed up.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I0ddcf94d047979eb78209d396c2351566c634dbe

show more ...

PEL: Add HostInterface base class

This is an abstract base class that is overridden to send a command to
the host (such as a hypervisor) to notify it of new PELs.

The only concrete implementation i

PEL: Add HostInterface base class

This is an abstract base class that is overridden to send a command to
the host (such as a hypervisor) to notify it of new PELs.

The only concrete implementation is using the 'New File Available'
PLDM command. Using this base class allows the PLDM aspects to be
mocked in testcases that involve queuing and sending PELs.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I830298d0fd949b4268c31c83acafe2afd90dd4cb

show more ...

PEL: Print the JSON formatted UserData

Override the getJSON() function in the UserData section so it will
support peltool pretty printing when the data has been stored as JSON
(component phosphor-l

PEL: Print the JSON formatted UserData

Override the getJSON() function in the UserData section so it will
support peltool pretty printing when the data has been stored as JSON
(component phosphor-logging, subtype 1 as defined in
user_data_formats.hpp).

It first converts the original JSON string to a nlohmann::json object to
validate it is valid JSON and then uses nlohmann::json's stream <<
operator to convert it into a pretty string.

This also sets up a framework where other UserData parsing functions can
be called from, and it is all only compiled into peltool, and not into
phosphor-log-manager.

The UserData section created out of the OpenBMC event log's
AdditionalData property already makes use of this format.

Here are some example outputs. Note that the 'Data' key is added by
this code for JSON that isn't already an object (dict) to make it one.

"User Data": {
"OPERATION": "something",
"REGISTER_FFDC": "REG1=0x8|REG2=0x9|REG3=0x55",
"RETURN_VALUE": "-12",
"TIMEOUT_IN_MSEC": "100",
"_PID": "993"
},

"User Data": {
"Data": [
"OPERATION",
"REGISTER_FFDC",
"RETURN_VALUE",
"TIMEOUT_IN_MSEC",
"_PID"
]
},

"User Data": {
"Data": "This is a string"
}

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I7b034ac24339b5b019db3b57d8e71cb03559363e

show more ...

PEL: Print OBMC event log ID in peltool

In the PrivateHeader section, add an entry into peltool's JSON
output for the OpenBMC event log ID.

This is a reserved field in the PEL spec, but we are usin

PEL: Print OBMC event log ID in peltool

In the PrivateHeader section, add an entry into peltool's JSON
output for the OpenBMC event log ID.

This is a reserved field in the PEL spec, but we are using it to
associate the PEL to the BMC event log it came from.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Id347aa67f79d7f5fac1e572de100755df7b29e6e

show more ...

PEL: Print host trans state in peltool

In the UserHeader section, add an entry into peltool's JSON
output for the host transmission state.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id

PEL: Print host trans state in peltool

In the UserHeader section, add an entry into peltool's JSON
output for the host transmission state.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ie906a447859e30175652d291ef2f929e8a7077f6

show more ...

PEL: API for getting if system is HMC managed

Add an API to the DataInterface class for determining if
the system is HMC (hardware management console, which usually
reference to a specific set of so

PEL: API for getting if system is HMC managed

Add an API to the DataInterface class for determining if
the system is HMC (hardware management console, which usually
reference to a specific set of software and hardware that
connects to IBM servers) managed.

As of now there is no way to determine this, so just return
the default of false.

This status impacts which PELs are sent to the host.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I803bc71c271dec6d68821dd36089e7a46461aac6

show more ...

PEL: Trace when event logs don't create PELs

To help show which events are missing from the PEL message registry,
add a journal entry for when an OpenBMC event log name isn't found
in the registry a

PEL: Trace when event logs don't create PELs

To help show which events are missing from the PEL message registry,
add a journal entry for when an OpenBMC event log name isn't found
in the registry and a PEL won't be created. Eventually, this will
be replaced with creating a brand new PEL that contains the event
log info.

In addition, add a journal entry displaying the SRC ASCII string of
newly created PELs.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I1228339cfa7d1d5aa60ef3b3ce2b2c0424ab0bf4

show more ...

PEL: Print Private Header into JSON aligned

"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "0x1000",
"Created at":

PEL: Print Private Header into JSON aligned

"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "0x1000",
"Created at": "12/05/2019 18:32:42",
"Committed at": "12/05/2019 18:32:42",
"Creator Subsystem": "BMC",
"CSSVER": "",
"Platform Log Id": "0x50000C00",
"Entry Id": "0x50000C00"
}

Testing: Manually run peltool and verified output
Signed-off-by: Harisuddin Mohamed Isa <harisuddin@gmail.com>
Change-Id: Ib6ef49f1b29486a97e86700b19ac982e43bede37

show more ...

PEL: Taking regex calls out of PEL listing function

Taking out regex calls to improve time complexity

Change-Id: Id0ca32bf78b006b3c8e03ac95206c670f92d4002
Signed-off-by: Aatir <aatrapps@gmail.com>

PEL: PEL listing time fix

Previously PELs were being flattened twice before being listed.
This commit brings it down to one.

Change-Id: I027d1e22e8d6d793c30c6f26a06178a448a6c301
Signed-off-by: Aati

PEL: PEL listing time fix

Previously PELs were being flattened twice before being listed.
This commit brings it down to one.

Change-Id: I027d1e22e8d6d793c30c6f26a06178a448a6c301
Signed-off-by: Aatir <aatrapps@gmail.com>

show more ...

PEL: Display PEL by ID

This command displays a PEL by id.

Change-Id: I26b8d30b886f47c02dd8cf648e6a261a6867a048
Signed-off-by: Aatir <aatrapps@gmail.com>

PEL: Print action flags into JSON aligned

"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "0x4552",
"Subsystem":

PEL: Print action flags into JSON aligned

"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "0x4552",
"Subsystem": "System Hypervisor Firmware",
"Event Scope": "Entire Platform",
"Event Severity": "Informational Event",
"Event Type": "Miscellaneous, Informational Only",
"Action Flags": [
"Report Externally"
]
}

Testing: Manually run peltool and verified output
Signed-off-by: Harisuddin Mohamed Isa <harisuddin@gmail.com>
Change-Id: Ie8376953b5f1baa093fc0aa9564d50cd4208564e

show more ...

PEL: Add API to get the PLDM instance ID

In order to send a PLDM command, one must get the instance ID parameter
to use for that command from the PLDM daemon via a D-Bus method.

Implement this API

PEL: Add API to get the PLDM instance ID

In order to send a PLDM command, one must get the instance ID parameter
to use for that command from the PLDM daemon via a D-Bus method.

Implement this API in the DataInterface class, though leave the body of
it stubbed out until the PLDM daemon switches to using async D-Bus
operations as right now the logging daemon and PLDM daemon can deadlock
with each calling into the other.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I592e7bad922c725edee67003e9957388df5f195c

show more ...

PEL: Add repo function to get a PEL FD

Add Repository::getPELFD() to return a file descriptor to a PEL data
file based on its ID.

This will be used by a future D-Bus method to return the descriptor

PEL: Add repo function to get a PEL FD

Add Repository::getPELFD() to return a file descriptor to a PEL data
file based on its ID.

This will be used by a future D-Bus method to return the descriptor to
the PLDM daemon.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I1110a514e30a9387d9672e42862139b988717c53

show more ...

PEL: Filled in PEL value descriptions

Updated getValue to return value description instead of registry name.
Updated unit test to add checking of value description.

Testing: Ran unit test successfu

PEL: Filled in PEL value descriptions

Updated getValue to return value description instead of registry name.
Updated unit test to add checking of value description.

Testing: Ran unit test successfully on QEMU and also verified peltool
output

Signed-off-by: Harisuddin Mohamed Isa <harisuddin@gmail.com>
Change-Id: Icf64f51a467c3bd4dd9bbcd78aea3df966b20eb7

show more ...

PEL: Fix message registry schema typo

Change-Id: Ic20d6560a79dc8cc871ebc1ab64ce5aefc2ccfe6

PEL: Put back in the default error log caps

Since there is no code in place yet to purge old logs after some amount
of total space is consumed, it will be safest to put back in the default
cap of 20

PEL: Put back in the default error log caps

Since there is no code in place yet to purge old logs after some amount
of total space is consumed, it will be safest to put back in the default
cap of 200. If more than 200 is needed in the short term, we can use
the currently available configure option to increase the cap.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ide1af5432271817f30bfaf0b065c35906aaa05cf

show more ...

PEL: Add ExtendedUserHeader section class

This is a required PEL section.

The section contains:
* The machine type/model/SN
* The server firmware version
* The BMC firmware version
* The 'Event Com

PEL: Add ExtendedUserHeader section class

This is a required PEL section.

The section contains:
* The machine type/model/SN
* The server firmware version
* The BMC firmware version
* The 'Event Common Reference Time' (not used yet)
* The symptom ID (a unique event signature)

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I223041f85965195fccf69542dbe86ce856073b36

show more ...

PEL: Add APIs to read the FW versions

Add methods to the DataInterface class to read the BMC and server
firmware versions. The server firmware version represents the version
of all firmware images

PEL: Add APIs to read the FW versions

Add methods to the DataInterface class to read the BMC and server
firmware versions. The server firmware version represents the version
of all firmware images that are in the flash image, not just the BMC.
There is nowhere to get that version yet, so this commit just has a
placeholder.

These will be used by the ExtendedUserHeader section.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I47389714c987337cb96c72b6bf2b270c78003357

show more ...

PEL: Add constructors to BCDTime

Add constructors to set all members to zero initially or pass
them all in.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ic28cee19014c739f331fd0498229

PEL: Add constructors to BCDTime

Add constructors to set all members to zero initially or pass
them all in.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ic28cee19014c739f331fd0498229dfb503b0df88

show more ...

PEL: Add Repo API to update transmission states

Provided APIs for the Repository class to update the host and HMC
transmission states on a PEL it contains. It saves the updated PEL data
in the file

PEL: Add Repo API to update transmission states

Provided APIs for the Repository class to update the host and HMC
transmission states on a PEL it contains. It saves the updated PEL data
in the filesystem.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Iadbc589ee85d4408339e1171c36b8324910f4f0a

show more ...