openpower-pels: json_utils: fix crash on invalid format string

The `getNumberString` function previously crashed if an invalid
format string was passed, because it would attempt to construct
a std::

openpower-pels: json_utils: fix crash on invalid format string

The `getNumberString` function previously crashed if an invalid
format string was passed, because it would attempt to construct
a std::string from a nullptr. There was even a test case that
confirmed that the code crashed via a SIGSEGV!

AddressSanitizer, which is ran on all of our meson-based CIs,
does not allow this kind of behavior. Change `getNumberString`
so it throws a `std::invalid_argument` instead of crashing, which
itself might result in a `std::terminate` if the exception is
uncaught, but is at least acceptable behavior in the eyes of the
AddressSanitizer (and mine as well).

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I06d25edc2ddf552169383e03595426bb065425be

show more ...

openpower-pels: repository: fix use-after-free

ERROR: AddressSanitizer: heap-use-after-free
READ of size 4 at 0x60b0000007f0 thread T0
#0 0x55b0e3e2740e in openpower::pels::Repository::r

openpower-pels: repository: fix use-after-free

ERROR: AddressSanitizer: heap-use-after-free
READ of size 4 at 0x60b0000007f0 thread T0
#0 0x55b0e3e2740e in openpower::pels::Repository::remove(
openpower::pels::Repository::LogID const&)
../extensions/openpower-pels/repository.cpp:228

This is caused by using an element out of a vector after it has
already been erased. Modify function to avoid stale use.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I91a66a0fe45b82439cbe6c8c66463075b50aa953

show more ...

openpower-pels: clean up various compile warnings

Compile warnings observed when compiling parts of the
openpower-pels (or corresponding tests) under stricter
compiler warning flags of Meson.

Issue

openpower-pels: clean up various compile warnings

Compile warnings observed when compiling parts of the
openpower-pels (or corresponding tests) under stricter
compiler warning flags of Meson.

Issues fixed:
- many unused parameters
- invalid case fall-through
- excess semi-colons
- incorrect 'const' on return-by-value type
- removal of variable length array in test case
- uncaught return from 'system' call in test case

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8af69184042cf8661d1307a02ecf3afcab4724a1

show more ...

openpower-pels: src: remove use of VLA

Clean up the following warning by rewriting the reported loop to
use C++ string iterators rather than a string copy into a VLA.

../extensions/openpower-pe

openpower-pels: src: remove use of VLA

Clean up the following warning by rewriting the reported loop to
use C++ string iterators rather than a string copy into a VLA.

../extensions/openpower-pels/src.cpp:489:18: error: ISO C++ forbids
variable length array ‘msg’ [-Werror=vla]
489 | char msg[msgLen + 1];
| ^~~

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0c61ab52a9cdf78ace6a1ff90109cdc1f54194c6

show more ...

PEL: Support user supplied flag to indicate a fatal/terminating

User can supply SEVERITY_DETAIL=SYSTEM_TERM as part
of AdditionalData entry in the event log to set the
severity level in User Header

PEL: Support user supplied flag to indicate a fatal/terminating

User can supply SEVERITY_DETAIL=SYSTEM_TERM as part
of AdditionalData entry in the event log to set the
severity level in User Header of PEL

Tested: I ran unit test using docker. Also tested manually
by setting D-bus event log

Change-Id: I9205c084c32576734c2b5b4c79c273f8defde9d4
Signed-off-by: Vijay Lobo <vijaylobo@gmail.com>

show more ...

python: enable code formatting

Enable code formatting in CI by creating a dummy Python 'setup.cfg'
and fix up the minor errors reported.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-I

python: enable code formatting

Enable code formatting in CI by creating a dummy Python 'setup.cfg'
and fix up the minor errors reported.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9ddaa263f7407c42fb4f58d478bd2efb1d2fe026

show more ...

PEL: Use ordered_json in code instead of fifo_map

JSON objects are defined as 'unordered collections' of zero or more
name/value pairs. The implementation doesn't need to preserve specific
orders of

PEL: Use ordered_json in code instead of fifo_map

JSON objects are defined as 'unordered collections' of zero or more
name/value pairs. The implementation doesn't need to preserve specific
orders of inputs objects and where it did (say in older versions)
external fifo_map header method was used. Now with built-in ordered_json
supported (nlohmann::ordered_json), the specific 'order of inputs
objects are preserved' automatically and are not jumbled up or external
header needed to preserve input objects anymore.

Signed-off-by: Sumit Kumar <sumit_kumar@in.ibm.com>
Change-Id: I9abc1220b9fbefbae412efc6ac128d797d0faa16

show more ...

PEL: Change method of asserting a fault LED

There was a recent change in direction on how PELs should request that
fault LEDs be turned on. Previously, the code would talk to the LED
group objects

PEL: Change method of asserting a fault LED

There was a recent change in direction on how PELs should request that
fault LEDs be turned on. Previously, the code would talk to the LED
group objects directly. The new direction is to set the Functional
property on the OperationalStatus interface on the inventory objects in
question to false, and the LED manager code will watch that to know when
to turn on the LEDs.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ieebb09ba002843cf863359a09aba26540356aa91

show more ...

PEL: Support creator supplied power fault flag

User can supply POWER_THERMAL_CRITICAL_FAULT=TRUE as part
of AdditionalData entry in the event log to set the power
fault bit in PEL

Tested: I ran uni

PEL: Support creator supplied power fault flag

User can supply POWER_THERMAL_CRITICAL_FAULT=TRUE as part
of AdditionalData entry in the event log to set the power
fault bit in PEL

Tested: I ran unit test using docker. Also tested manually
by setting D-bus event log

Change-Id: Ifa03f091a7d1efcc67f181c2be1cc0a6240891e1
Signed-off-by: Vijay Lobo <vijaylobo@gmail.com>

show more ...

PEL: Fix to support early msg registry callouts

The existing code would make a D-Bus call to read the Compatible
interface provided by entity-manager in order to have it when creating a
PEL from the

PEL: Fix to support early msg registry callouts

The existing code would make a D-Bus call to read the Compatible
interface provided by entity-manager in order to have it when creating a
PEL from the PEL message registry. However, early in the boot there are
attempts to create PELs before entity-manager has put its interfaces on
D-Bus, causing the message registry parsing to fail.

The fix is to continue on even if that interface isn't present. The
caller will need to beware that if they want to create PELs early in the
boot that they can't refer to any system names in the PEL message
registry entry for that error.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ie488786675c33107402b1e19cccfbebc0e73f9f7

show more ...

PEL:phosphor-power PSU Severity updates

In customer support situations, it was found to be confusing to label
the communication failure with unrecoverable_redundancy_loss. In
addition that, it was e

PEL:phosphor-power PSU Severity updates

In customer support situations, it was found to be confusing to label
the communication failure with unrecoverable_redundancy_loss. In
addition that, it was equally confusing to label a power supply missing
as just unrecoverable, when redundancy is likely actually lost.

Swap the severity values of 0x15F2 and 0x15F6.

0x15F2 - communication failure - unrecoverable.
0x15F6 - PSU missing - unrecoverable_redundancy_loss

Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
Change-Id: Ie9521100f4f32a6884b76bb3c1c7e62042f27708

show more ...

PEL: Add message registry entry for power loss.

Add PEL message entry for power loss.

Tested:
Power on machine.
Build and install phosphor-log-manager and restart its service.
Delete all existing P

PEL: Add message registry entry for power loss.

Add PEL message entry for power loss.

Tested:
Power on machine.
Build and install phosphor-log-manager and restart its service.
Delete all existing PEL entries.
Install patched message registry into /etc/phosphor-logging.
Use the APC GUI for the ePDU to turn off power to all power supplies.
Turn power back on, get the PEL entry which shows the blackout entry.

Signed-off-by: Jay Meyer <jaymeyer@us.ibm.com>
Change-Id: Ic7b06c3db7d6356ac19dc46062ee8abc4f9c8723

show more ...

peltool to delete PEL files permanently

Instead of calling xyz.openbmc_project.Logging.Entry to delete PELs
st::filesystem remove is used to permanently delete the corresponding
files. In the future

peltool to delete PEL files permanently

Instead of calling xyz.openbmc_project.Logging.Entry to delete PELs
st::filesystem remove is used to permanently delete the corresponding
files. In the future deleting a D-Bus event log will not delete
the corresponding PEL, so the only way to delete a PEL is to delete the file.

Signed-off-by: Miguel Gomez <mgomez@mx1.ibm.com>
Change-Id: Idec00bdbe4864c703bb5a874d12144c44dae7d5e

show more ...

PEL: Add temp threshold reg entries

Add PEL message registry entries for performance loss, warning, and
critical temperature exceed/clear errors. If the ambient sensor is
involved, use the appropri

PEL: Add temp threshold reg entries

Add PEL message registry entries for performance loss, warning, and
critical temperature exceed/clear errors. If the ambient sensor is
involved, use the appropriate symbolic FRU callout, otherwise use a
normal FRU callout based on the passed inventory path.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I9ea4389534b6a8cb394fdd38486bde361dc2a600

show more ...

PEL: Change external PEL trace to debug

Seeing when the host sends down PELs probably isn't important enough to
put in the regular journal. If someone really wanted to know that, they
could look at

PEL: Change external PEL trace to debug

Seeing when the host sends down PELs probably isn't important enough to
put in the regular journal. If someone really wanted to know that, they
could look at the timestamps of the PEL files. Changing the trace to
debug so there is still the ability to turn it on if desired.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ic463576f05ed69faed910b68aacfb45f6b907072

show more ...

PEL: Add critical error for regulators config file

Add a new message registry entry for a critical error involving the
phosphor-regulators configuration file.

The regulators application requires a

PEL: Add critical error for regulators config file

Add a new message registry entry for a critical error involving the
phosphor-regulators configuration file.

The regulators application requires a valid JSON config file. When the
application starts, if a valid file cannot be found, a non-critical
error is logged. This error is already defined in the message registry.

However, if the chassis starts powering on and a config file still
cannot be found, a critical error should be logged. The voltage
regulators in the system will not be configured, and this could
potentially cause hardware damage. For example, the default output
voltage of a regulator may be too high.

The existing message registry entry cannot be reused because it gets the
PEL severity from the base BMC error log severity. The base BMC
severity "Critical" is mapped to the PEL severity "critical". However,
in this case the PEL severity "critical_system_term" is needed instead.
Also, the PowerFault property should be true for the critical entry and
false for the non-critical entry.

Tested:
* Ran the validation tool.
* Loaded the message registry file into a BMC simulation session.
* Verified that when the error occurred, the expected PEL was created.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I4950e912481dd71be40a1a176591b235e9d4c668

show more ...

PEL: Add ambient temp PEL registry entries

Add 3 new PEL message registry entries:
* temp crossed EPOW3 threshold
* temp crossed EPOW4 threshold
* temp under EPOW3 threshold

These error logs will c

PEL: Add ambient temp PEL registry entries

Add 3 new PEL message registry entries:
* temp crossed EPOW3 threshold
* temp crossed EPOW4 threshold
* temp under EPOW3 threshold

These error logs will come from the sensor-monitor application that
monitors the HardShutdown (EPOW4) and SoftShutdown (EPOW3) D-Bus
threshod interfaces. These interfaces will only ever be used on the
ambient virtual sensor in the systems that use PELs.

There is no entry for going below the EPOW4 threshold because, while
ther sensor-monitor code would create an error for that, the interface
will have the hysteresis set so that it will never happen.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ieed5364654a80697e189cf2e7614b0aead1fb218

show more ...

PEL: Allow missing AD keys in the reg callouts

In the code where the message registry can select callouts based on an
AdditionalData property value, don't trace an error messsage if it
doesn't find

PEL: Allow missing AD keys in the reg callouts

In the code where the message registry can select callouts based on an
AdditionalData property value, don't trace an error messsage if it
doesn't find a matching value in the callout list.

This may be done on purpose, such as only wanting to add the ambient
temperature symbolic FRU if the sensor name passed in is the ambient
temp sensor, and not adding any callouts otherwise.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Id45a4769fcdbb719e473ce0b414090207b62baeb

show more ...

extensions: pels: Add PEL path to elog entry

Populate the path property of the error log entry with the path
to the PEL path. This requires making the entries map public.

Restore the value of the p

extensions: pels: Add PEL path to elog entry

Populate the path property of the error log entry with the path
to the PEL path. This requires making the entries map public.

Restore the value of the path for the entries when the PEL
manager starts up once the Repository has verified each PEL file.

Tested: Verified the PEL path was populated in the path property
and that it was re-populated after restarting the app.
root@openbmc:~# busctl --no-pager get-property xyz.openbmc_project.Logging \
/xyz/openbmc_project/logging/entry/884 xyz.openbmc_project.Common.FilePath Path
s "/var/lib/phosphor-logging/extensions/pels/logs/2020120522023306_50000D30"

Change-Id: I2a7315bbc3f0f4699e77aadbc7da05818c0c15e3
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Add shebang line to run-ci.sh

With commit
https://github.com/openbmc/openbmc-build-scripts/commit/55448adb2d4a975e39a3ff991493b686f92ed6a5
run-ci.sh now requires the shebang line (the #! shell inter

Add shebang line to run-ci.sh

With commit
https://github.com/openbmc/openbmc-build-scripts/commit/55448adb2d4a975e39a3ff991493b686f92ed6a5
run-ci.sh now requires the shebang line (the #! shell interpreter line)
to run.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ifb02852e127fa6efece2846871a743b051b39ac7

show more ...

run-ci: modify permissions to execute

Per discussion in Ib420c69e88e88ca0a50863c83ad43fac750d3e7a, we
are going to require these scripts to have execute permission.

Signed-off-by: Patrick Williams

run-ci: modify permissions to execute

Per discussion in Ib420c69e88e88ca0a50863c83ad43fac750d3e7a, we
are going to require these scripts to have execute permission.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7e8cb2387fc58269bf0ee3fee97f9ece78ad91fc

show more ...

PEL: Use different property for host running

The new method to tell if the hypervisor is running is to use the
BootProgress property on the xyz.openbmc_project.State.Boot.Progress
interface. Use th

PEL: Use different property for host running

The new method to tell if the hypervisor is running is to use the
BootProgress property on the xyz.openbmc_project.State.Boot.Progress
interface. Use that instead in the code that will send PELs up to the
hypervisor.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I02c30716f7223706c7ae2b4a6c67704097cf5d1f

show more ...

PEL: Add power-sequencer registry entries

Make changes necessary to create PEL entries for errors issued by the
power-sequencer application.

Signed-off-by: Jim Wright <jlwright@us.ibm.com>
Change-I

PEL: Add power-sequencer registry entries

Make changes necessary to create PEL entries for errors issued by the
power-sequencer application.

Signed-off-by: Jim Wright <jlwright@us.ibm.com>
Change-Id: I36f9caaa44e3fb9e6116c59e267eadc406116d58

show more ...

peltool: Print the Words6To9 'Description' field

Include the 'Description' field from the Words6To9 registry entry when printing
SRC error details.

Changed from this:

"Error Details": {
"Messa

peltool: Print the Words6To9 'Description' field

Include the 'Description' field from the Words6To9 registry entry when printing
SRC error details.

Changed from this:

"Error Details": {
"Message": "There was a failure when reading a sensor device",
"CALLOUT_ERRNO": "0x5"
}

to this:

"Error Details": {
"Message": "There was a failure when reading a sensor device",
"CALLOUT_ERRNO": [
"0x5",
"errno of the failure"
]
}

Signed-off-by: Harisuddin Mohamed Isa <harisuddin@gmail.com>
Change-Id: Icc107b0516062eb891f14f3ff3f3cffd316c6d77

show more ...

PEL related fields for event log of VPD errors.

This commit defines PEL related fields for standard event log,
to be used while creation of PEL in case of defined VPD errors.

Signed-off-by: Sunny S

PEL related fields for event log of VPD errors.

This commit defines PEL related fields for standard event log,
to be used while creation of PEL in case of defined VPD errors.

Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>
Change-Id: I566bae5661e5e40268774d1932941f07dc135ff3

show more ...