PEL: Add error message registry entry for devtree sync

Adding error entry in the message registry JSON file for
devtree sync failure during BMC reboot path. During the
concurrent code update new pha

PEL: Add error message registry entry for devtree sync

Adding error entry in the message registry JSON file for
devtree sync failure during BMC reboot path. During the
concurrent code update new phal devtree need to update r/w
attributes states with previous state. This error entry
indicates the failure during this data sync.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I99631403164d2efe66f7a732446bc4805b7eff52

show more ...

PEL: Fix to remove files from archive folder

Archive folder contains the PEL logs (corresponding to deleted event
logs) that are deleted first, if the repo logs size exceeds the warning
size. Variab

PEL: Fix to remove files from archive folder

Archive folder contains the PEL logs (corresponding to deleted event
logs) that are deleted first, if the repo logs size exceeds the warning
size. Variable _archiveSize is used to keep track of size of archive
folder. After all logs in archive folder are deleted the _ardchiveSize
wasn't reset to zero as a result it would keep entering this function
trying to delete the logs again under archive folder.
The fix here is to reset the _archiveSize and also use robust remove
API for deletion instead of system command.

Signed-off-by: Sumit Kumar <sumit_kumar@in.ibm.com>
Change-Id: Ia98086c47d6083d8a104c1c28efc94c8b30a47ef

show more ...

build: Refactor to separate out library

This makes it more clear what code is intended for use by the
phosphor-logging shared library. This is especially nice since it
isolates the `phosphor_logging

build: Refactor to separate out library

This makes it more clear what code is intended for use by the
phosphor-logging shared library. This is especially nice since it
isolates the `phosphor_logging_dep` to only provide the exported headers
instead of everything in the project.

Additionally, this adds an option to build only the library components
of the project when the services aren't needed.

Change-Id: Ied0858fc70e8054df4c056d91f35a6f0b3acfcb1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

PEL: Support resolution property

Support resolution property to add callouts

Tested: Created new PEL using busctl and checked for the property to
see if the value is updated. The error log daemon w

PEL: Support resolution property

Support resolution property to add callouts

Tested: Created new PEL using busctl and checked for the property to
see if the value is updated. The error log daemon was restarted and the
property is checked again to make sure the value is restored.

Verified serialization of new error log by recreating it on a old code
version to make sure logs are created w/o the new property and the
daemon did not crash.

Result:
root@rainier:~# busctl get-property xyz.openbmc_project.Logging \
/xyz/openbmc_project/logging/entry/1 xyz.openbmc_project.Logging.\
Entry Resolution
s "1. Priority: High, Procedure: BMCSP02\n2. Priority: Medium, PN: \
SVCDOCS\n"

Test with location Code:
root@p10bmc:~# busctl get-property xyz.openbmc_project.Logging \
/xyz/openbmc_project/logging/entry/3 xyz.openbmc_project.Logging.Entry \
Resolution
s "1. Location Code: U78DA.ND0.1234567-P0, Priority: Medium, PN: SVCDOCS\n2. \
Priority: Low, Procedure: BMCSP02\n"

Signed-off-by: Vijay Lobo <vijaylobo@gmail.com>
Change-Id: I44eebbf794efeb8e752fff98de7c638c927982cd

show more ...

PEL: move libekb init function to sbe ffdc init

libekb init should run only after pdbg initialisation.

Tested: created sbe error and validated.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com

PEL: move libekb init function to sbe ffdc init

libekb init should run only after pdbg initialisation.

Tested: created sbe error and validated.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I8fe2b9ccff61e42aa0e6b0fd7bc6c85a295edd3e

show more ...

PEL: Manager: Implemented the GetBMCLogIdFromPELId dbus method

In OpenPOWER based system, the application may need to get
the OpenBMC event log id by using the PEL id (aka Entry ID (EID) which
is a

PEL: Manager: Implemented the GetBMCLogIdFromPELId dbus method

In OpenPOWER based system, the application may need to get
the OpenBMC event log id by using the PEL id (aka Entry ID (EID) which
is a unique id in the PEL) so added the interface for the same.

Tested:
- Tested by below unit test cases.
- With valid PEL ID
- With invalid PEL ID

- Tested by using busctl command
- With valid PEL ID
```
busctl call xyz.openbmc_project.Logging \
/xyz/openbmc_project/logging org.open_power.Logging.PEL \
GetBMCLogIdFromPELId u 1342211909
>>> u 4534
```
- With invalid PEL ID
```
busctl call xyz.openbmc_project.Logging \
/xyz/openbmc_project/logging org.open_power.Logging.PEL \
GetBMCLogIdFromPELId u 0xFFFFFFFF
>>> Call failed: Invalid argument was given.
```

DBus interface:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/44421

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: Ibc67c0d1ad83457800847853e30254e2d9be53e6

show more ...

PEL: Manager: Implemented the GetPELIdFromBMCLogId dbus method

In OpenPOWER based system, the application may need to get
the PEL id (aka Entry ID (EID) which is a unique id in the PEL) by using
Ope

PEL: Manager: Implemented the GetPELIdFromBMCLogId dbus method

In OpenPOWER based system, the application may need to get
the PEL id (aka Entry ID (EID) which is a unique id in the PEL) by using
OpenBMC event log id so added the interface for the same.

Tested:
- Tested by below unit test cases.
- With valid OpenBMC Event Log ID
- With invalid OpenBMC Event Log ID

- Tested by using busctl command
- With valid OpenBMC Event Log ID
```
busctl call xyz.openbmc_project.Logging \
/xyz/openbmc_project/logging org.open_power.Logging.PEL \
GetPELIdFromBMCLogId u 4534
>>> u 1342211909
```
- With invalid OpenBMC Event Log ID
```
busctl call xyz.openbmc_project.Logging \
/xyz/openbmc_project/logging org.open_power.Logging.PEL \
GetPELIdFromBMCLogId u 0xFFFFFFFF
>>> Call failed: Invalid argument was given.
```

DBus interface:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/44420

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: I60ff5b86bb82cef2c2d3ceab74c49de5b6f6f99d

show more ...

PEL: Repository: Added getLogID() as public method

Currently, don't have any public method to get LogID from
the Repository class so added an api "getLogID()" which can be
used to get the LogID by u

PEL: Repository: Added getLogID() as public method

Currently, don't have any public method to get LogID from
the Repository class so added an api "getLogID()" which can be
used to get the LogID by using either OpenBMC event log id or
PEL id (aka Entry ID (EID)).

Tested:
- Tested by below unit test cases.
- GetLogIDFoundTC
- With valid PEL ID
- With valid OpenBMC Event Log ID
- GetLogIDNotFoundTC
- With invalid PEL ID
- With invalid OpenBMC Event Log ID

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: Ia621c46f67198fccd88ec5b00c32d4f65be05743

show more ...

PEL: Support ServiceProviderNotify property

Redfish API needs to find out if the callhome event occurred in a system
and this support is provided by updating the ServiceProviderNotify
property in D-

PEL: Support ServiceProviderNotify property

Redfish API needs to find out if the callhome event occurred in a system
and this support is provided by updating the ServiceProviderNotify
property in D-Bus if the callhome flag in PEL is set.

Tested: Manually created informational and unrecoverable errors directly
on D-Bus using busctl call and verified that the ServiceProviderNotify
property set to false for informational error and its set to true for
unrecoverable error.

Signed-off-by: Vijay Lobo <vijaylobo@gmail.com>
Change-Id: Ia7246bf170f3289400a3b3c947ef9e67c06d2c46

show more ...

PEL: Deleted PELs moved to new folder under logs

- PELs whose corresponding event logs have been deleted
will be available in the archive folder.
- Archive folder size is tracked under sizeWarn

PEL: Deleted PELs moved to new folder under logs

- PELs whose corresponding event logs have been deleted
will be available in the archive folder.
- Archive folder size is tracked under sizeWarning() function.
- Archived PELs log can be viewed using peltool with flag --archive.
- PELs deleted using peltool is not archived.
- Updated README.md

Change-Id: Ie2c1b4c2ca30fb79904bc9d582a01ef8102aed0e
Signed-off-by: Sumit Kumar <sumit_kumar@in.ibm.com>

show more ...

PEL:Skip assigning id to hostboot PELs

As hostboot will be managing their own PEL Ids skip assigning
id to its PELs.

Signed-off-by: Sumit Kumar <sumit_kumar@in.ibm.com>
Change-Id: I43dc6a2fbf5ec134

PEL:Skip assigning id to hostboot PELs

As hostboot will be managing their own PEL Ids skip assigning
id to its PELs.

Signed-off-by: Sumit Kumar <sumit_kumar@in.ibm.com>
Change-Id: I43dc6a2fbf5ec13458d12572b766cc5aa5d8e01b

show more ...

PEL: Handle location codes for connectors

There are cases where PELs need to callout physical system connectors,
such as a USB or other cable connector. This would be done by
specifying the connect

PEL: Handle location codes for connectors

There are cases where PELs need to callout physical system connectors,
such as a USB or other cable connector. This would be done by
specifying the connector's location code in either the message registry
JSON or device callout JSON. The problem is that the connector may not
be modeled by the inventory, and even if it was, there would need to be
a way to get the serial number, etc for the FRU that connector is on to
use in the callout

Instead of forcing all connectors to be modeled in the inventory along
with a copy of the SN/FN/CC from the parent FRU just to do a callout,
this commit will just pop off the connector segment of the location
code, a '-Tx', before trying to expand it or getting its related
inventory item. That way, it will be operating on the parent FRU which
would be in the inventory with its SN/FN/CC. In the case of the
location code expansion, the connector segment will then just be
re-appended afterwards.

This commit also makes a change to the device path callouts code to
expand the location code of the callout from the device path JSON
instead of trying to look it up later, which would have lost the
connector portion.

Note that when a cable itself wants to be called out, there usually
would need be a symbolic FRU specified saying which cable it is, along
with the connector location codes. In that case, the SN/FN/CC of the
parent FRU would not show up in the PEL.

Change-Id: I8e0eb58dfe630858f75e64b11ac13432bff4d2d1

show more ...

PEL: Add GPIODeviceUnavailable reg entry

Used with phosphor-fan-presence::NullGpio class.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: Iaa09afedf75ed73df4cfdbcacabb7faa39a99303

PEL: Add FanControllerOffline message reg entry

This error is posted when the fan monitor application cannot find any
fan sensors on D-Bus, so it doesn't know the fan states when a power on
is attem

PEL: Add FanControllerOffline message reg entry

This error is posted when the fan monitor application cannot find any
fan sensors on D-Bus, so it doesn't know the fan states when a power on
is attempted. It will shut down the system.

The P0-T12 and P0-T17 callouts are connectors for the fan signal cable.
These callouts follow the rules of using a symbolic FRU to identify the
cable for the first endpoint and a 'CBLCONT' symbolic FRU for the other
one.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I99eadacf7c9f3a5a1037c9ddbaeeb4f5e11c08e8

show more ...

PEL: PHAL: Added new message registry for pre-poweroff

In OpenPOWER based system, we need to do some PHAL specific
operations (rises the cfam fences, drop the FSI I2C fence, etc)
before poweroff the

PEL: PHAL: Added new message registry for pre-poweroff

In OpenPOWER based system, we need to do some PHAL specific
operations (rises the cfam fences, drop the FSI I2C fence, etc)
before poweroff the host processor but, any failure can occur
while doing those operations so, added a new message registry
to capture in PEL.

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: I7c875781570a568a44017c7e8071b0b0758ced78

show more ...

peltool: Fix Python C Extension for UD parsing

This fixes some issues with reference counting which could possibly
lead to memory leaks and unwanted behaviours.

Only accepts valid data from python

peltool: Fix Python C Extension for UD parsing

This fixes some issues with reference counting which could possibly
lead to memory leaks and unwanted behaviours.

Only accepts valid data from python module (non-empty object, array and
string) or else to return the default hex dump.

Signed-off-by: Harisuddin Mohamed Isa <harisuddin@gmail.com>
Change-Id: I13d06247533018709b93e5d7887453e652132956

show more ...

peltool: Fixed output for SRC parser

This changes the output of SRC parser when empty JSON object or array is
returned by python module. No "SRC Details" key will be shown.

JSON objects will also b

peltool: Fixed output for SRC parser

This changes the output of SRC parser when empty JSON object or array is
returned by python module. No "SRC Details" key will be shown.

JSON objects will also be nested under "SRC Details" instead of
appending to the "Primary SRC" key:

"Hex Word 8": "00000000",
"Hex Word 9": "00000000",
"SRC Details": {
"Key": "Value"
}

Fixed reference counting to avoid possible memory leaks and undefined behaviours.

Signed-off-by: Harisuddin Mohamed Isa <harisuddin@gmail.com>
Change-Id: I4bf5382ee9eac53f38b8e1cf7ead8a9d2dd47f8d

show more ...

PEL: Use ordered_json parse on plugin data

When calling parse() to parse JSON data from a string, if the JSON is a
dictionary and the key order needs to be preserved, then the code needs
to call ord

PEL: Use ordered_json parse on plugin data

When calling parse() to parse JSON data from a string, if the JSON is a
dictionary and the key order needs to be preserved, then the code needs
to call ordered_json::parse() instead of the standard json::parse().
This would get used when parsing the JSON string returned from PEL SRC
or UserData plugin modules.

I also changed it on the from_cbor() call since that was being saved in
an ordered_json object.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I1ac27698320f839d12d2ac45de1e4fe303cefc0d

show more ...

PEL: Support eventId property

Support eventId property to add SRC and the hex words to the property

Tested by creating the PEL log and to make sure that the eventId
property was updated properly wi

PEL: Support eventId property

Support eventId property to add SRC and the hex words to the property

Tested by creating the PEL log and to make sure that the eventId
property was updated properly with 9 words and then its present in the
right format when the logging daemon is restarted

Test result:
root@rainier# busctl get-property xyz.openbmc_project.Logging
/xyz/openbmc_project/logging/entry/1 xyz.openbmc_project.Logging.Entry EventId
s "BD8D1001 00000055 2E2D0010 00000000 00000000 00000000 00000000
00000000 00000000"

Also tested with old version of error log and new version with the
eventId property to make sure we don't have issues in serialization

Change-Id: I8e39804cd3d47f0e321c1cf533b97bf165c07518
Signed-off-by: Vijay Lobo <vijaylobo@gmail.com>

show more ...

PEL: PHAL: Changed existing reason code instead use component id

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: Ice640e2f454b8a184f29c84c8666da9e0236a4a2

PEL: move pdbg init function to sbe ffdc init

BMC reboot followed by BMC software update pdbg attribute read
api failure due to pdbg default device tree selection instead
of BMC specific device tree

PEL: move pdbg init function to sbe ffdc init

BMC reboot followed by BMC software update pdbg attribute read
api failure due to pdbg default device tree selection instead
of BMC specific device tree. Pdbg initialises default
device tree incase user is not configured correctly.

In this usecase DEVTREE links initialises as part of
obmc-flash-bios-init.service, and this runs after
phosphor logging service. Proposed fix is to do pdbg
init as part of PEL request from application. This requests
only triggered when host

Tested: SBE PEL is created after software code update
and verified.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Ie04d65b2d295d72c0ea9fe7b374dbb74a80d7a41

show more ...

PEL: set pdbg environment variable

pdbg needs PDBG_DTB environment variable initialisation
prior to pdbg init to set correct device tree back-end.

Tested: After software update with this change ver

PEL: set pdbg environment variable

pdbg needs PDBG_DTB environment variable initialisation
prior to pdbg init to set correct device tree back-end.

Tested: After software update with this change verified
that pdbg is using BMC initialised DEVTREE.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I6a59a79ccd9ae1f7d5947df0905e4ba999f835ec

show more ...

PEL: message_registry - Add an entry for WatchdogTimeout

Validated json file using tools/process_registry.py
Tested generated PELs from this WatchdogTimeout entry:
- Copied message_registry and Comp

PEL: message_registry - Add an entry for WatchdogTimeout

Validated json file using tools/process_registry.py
Tested generated PELs from this WatchdogTimeout entry:
- Copied message_registry and ComponentIDs.md to /etc/phosphor-logging
- Used busctl Create method to create an event log to the new registry
entry, and checked the PEL using peltool
- Used docker unit test

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: I9b16ed1eedf3a71a05bdf927674164ec8bf9d7be

show more ...

PEL: enable SBE FFDC support in pel log

FFDC Package structure and definitions are based on the
SBE chip-op spec.
FFDC packet Starts with a header word (Word 0) that has
an unique magic identifi

PEL: enable SBE FFDC support in pel log

FFDC Package structure and definitions are based on the
SBE chip-op spec.
FFDC packet Starts with a header word (Word 0) that has
an unique magic identifier code of 0xFFDC followed by the
length of the FFDC package including the header itself.
Word 1 contains a sequence id , command-class and command
fields. The sequence id field is ignored on the BMC side.
Word 2 contains a 32 bit Return Code which acts like the
key to the contents of subsequent FFDC Data Words (0-N).

A FFDC package can typically contain debug data from either:
1. A failed hardware procedure (e.g. local variable values
at point of failure) or
2. SBE firmware
(e.g. traces, attributes and other information).
___________________________________________________________
| | Byte 0 | Byte 1 | Byte 2 | Byte 3 |
|----------------------------------------------------------|
| Word 0 | Magic Bytes : 0xFFDC | Length in words (N+4) |
| Word 1 | [Sequence ID] | Command-Class | Command |
| Word 2 | Return Code 0..31 |
| Word 3 | FFDC Data – Word 0 |
| ... |
| Word N+3 | FFDC Data – Word N |
-----------------------------------------------------------

This commit enables SBE FFDC packet parsing for packet type
mentioned in option 1 (A failed hardware procedure). Other case
SBE provided tool based parsing is required. Not enabled in
this patch.

SBE FFDC file data added as part of PEL user data section for
future SBE tool based parsing.

Tested: Manually created SBE error with No core available for
Boot use case.

"User Data 2": { --> Raw SBE FFDC data
"Section Version": "1",
"Sub-section type": "203",
"Created by": "0x3500",
"Data": [
"FF DC 00 12 00 00 A1 01 00 8E CE 72 00 00 FF FE
"00 00 00 04 00 00 00 00 00 00 00 04 00 00 00 00
"00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 02
"00 00 00 04 00 00 00 00 00 00 00 00 00 00 00 04
"00 00 00 00 00 00 00 00
]
},
"User Data 3": { --> callout details
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"Data": [
{
"Deconfigured": false,
"Guarded": false,
"LocationCode": "Ufcs-P0-C24",
"MRUs": [
{
"ID": 65536,
"Priority": "H"
}
],
"Priority": "H"
}
]
},
"User Data 4": { --> User Debug data.
"Section Version": "1",
"Sub-section type": "3",
"Created by": "0x2000",
"Data": [
"HWP_RC = RC_SBE_SELECT_EX_INSUFFICIENT_ACTIVE_CORES_ERROR",
"HWP_RC_DESC = The requested active cores were
not able to be configured.",
"HWP_FFDC_CHIP = 6b3a7570 306e3a30 3a30733a 00323070
00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000",
"HWP_FFDC_CORE_CONFIG = 00000000",
"HWP_FFDC_ATTR_ACTIVE_CORES_NUM = 02",
"HWP_FFDC_ACTIVE_CORES_NUM = 00000000",
"HWP_FFDC_ACTIVE_CORES_VEC = 00000000",
"HWP_CDG_TGT_01_LOC_CODE = Ufcs-P0-C24",
"HWP_CDG_TGT_01_PHYS_PATH = physical:sys-0/node-0/proc-2",
"HWP_CDG_TGT_01_CO_REQ = true",
"HWP_CDG_TGT_01_CO_PRIORITY = HIGH",
"HWP_CDG_TGT_01_DECONF_REQ = false",
"HWP_CDG_TGT_01_GUARD_REQ = false",
"HWP_CDG_TGT_01_GUARD_TYPE = GARD_Fatal"
]
}

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Id94d8e10b3e0f82cb61d40bab9ef8b3f4a3beff9

show more ...

PEL: Add SBE FFDC process function

Helper function to process SBE FFDC packet.
This function call libekb function to process the
FFDC packet and convert in to known format for PEL
specific file cre

PEL: Add SBE FFDC process function

Helper function to process SBE FFDC packet.
This function call libekb function to process the
FFDC packet and convert in to known format for PEL
specific file creation. This function also creates
json callout file and text type file, which includes
the addition debug data included in SBE FFDC packet.

Tested: Manually verified,

Sample test results with all the cores de-configured
system boot usecase.

"User Data 3": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"Data": [
{
"Deconfigured": false,
"Guarded": false,
"LocationCode": "Ufcs-P0-C24",
"MRUs": [
{
"ID": 65536,
"Priority": "H"
}
],
"Priority": "H"
}
]
},
"User Data 4": {
"Section Version": "1",
"Sub-section type": "3",
"Created by": "0x2000",
"Data": [
"HWP_RC = RC_SBE_SELECT_EX_INSUFFICIENT_ACTIVE_CORES_ERROR",
"HWP_RC_DESC = The requested active cores were
not able to be configured.",
"HWP_FFDC_CHIP = 6b3a7570 306e3a30 3a30733a 00323070
00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000
00000000 00000000",
"HWP_FFDC_CORE_CONFIG = 00000000",
"HWP_FFDC_ATTR_ACTIVE_CORES_NUM = 02",
"HWP_FFDC_ACTIVE_CORES_NUM = 00000000",
"HWP_FFDC_ACTIVE_CORES_VEC = 00000000",
"HWP_CDG_TGT_01_LOC_CODE = Ufcs-P0-C24",
"HWP_CDG_TGT_01_PHYS_PATH = physical:sys-0/node-0/proc-2",
"HWP_CDG_TGT_01_CO_REQ = true",
"HWP_CDG_TGT_01_CO_PRIORITY = HIGH",
"HWP_CDG_TGT_01_DECONF_REQ = false",
"HWP_CDG_TGT_01_GUARD_REQ = false",
"HWP_CDG_TGT_01_GUARD_TYPE = GARD_Fatal"
]
}

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Iac2689c3608ddb0090a1c17753bbf9be96d12939

show more ...