PEL: Convert a BCDTime to epoch milliseconds

Add a new function to convert a BCDTime value from a PEL to the number
of milliseconds since the epoch.

This will be used to put the PEL creation timest

PEL: Convert a BCDTime to epoch milliseconds

Add a new function to convert a BCDTime value from a PEL to the number
of milliseconds since the epoch.

This will be used to put the PEL creation timestamp on D-Bus.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ic470c9324e959b3e6a7eea29db4162a45dd54fc3

show more ...

PEL: Catch exception as const

That's the preferred way when catching exceptions.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ib4f27c1de673a99e61468adf261050d9c95172df

PEL: Remove old TODO comment

As usual a TODO didn't need to be done, so remove it.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ifdcf2d8a5ae4c36652eeb60bb9e536265ea13298

PEL: Point to libpldm repo in subproject

PLDM split into two repositories, so point at the one that is actually
needed as a subproject. Also remove a PLDM meson option that isn't used
anymore.

Cha

PEL: Point to libpldm repo in subproject

PLDM split into two repositories, so point at the one that is actually
needed as a subproject. Also remove a PLDM meson option that isn't used
anymore.

Change-Id: I79d4084d9dc6260dc1a0915f679d429f3c81792e
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I077deb6e98025e4e8c6abd4d039f9af4db19342b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

PEL: remove OSStart as indication host is running

This logic is checking whether PHYP is at standby or runtime. The
OSStart was never implemented by PHYP so it should not be looked at to
determine t

PEL: remove OSStart as indication host is running

This logic is checking whether PHYP is at standby or runtime. The
OSStart was never implemented by PHYP so it should not be looked at to
determine this state. The hostboot team is going to utilize this
BootProgress to indicate when they are starting PHYP.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I580703f739be9fe04f49ae00eb51f485e554287f

show more ...

PEL: new info log for when chassis power on is started

This new informational error is being defined for a couple of reasons:
- An easy eye catcher when reviewing logs to easily distinguish between

PEL: new info log for when chassis power on is started

This new informational error is being defined for a couple of reasons:
- An easy eye catcher when reviewing logs to easily distinguish between
major boots of the system (ones including a chassis power cycle)
- A mechanism for other OpenBMC software which utilizes the log to
report back to the user when errors from the current boot need
attention

This log will be created by an optional opt-in service within
phosphor-state-manager as a part of the obmc-chassis-poweron@.target.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Idd39680091c6e915997d69370e988e4d0bd29912

show more ...

PEL: Add DeconfigFlag to certain PELs in msg reg

Set the DeconfigFlag field to true for PELs that have fan, power supply,
or regulator callouts.

This is used by the 'nag' software that creates PELs

PEL: Add DeconfigFlag to certain PELs in msg reg

Set the DeconfigFlag field to true for PELs that have fan, power supply,
or regulator callouts.

This is used by the 'nag' software that creates PELs to remind customers
that their system is running with deconfigured/unhealthy hardware.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I2de219982bbfabe87ceda87e999e1edeb04c3522

show more ...

PEL: Support new DeconfigFlag msg reg field

Add a new field to the PEL message registry to indicate that some
hardware associated with a callout was deconfigured.

"DeconfigFlag": true

This results

PEL: Support new DeconfigFlag msg reg field

Add a new field to the PEL message registry to indicate that some
hardware associated with a callout was deconfigured.

"DeconfigFlag": true

This results in bit 6 in the SRC's hex word 5 being set. It is looked
at by the code that creates the periodic PELs when there is a system
running with deconfigured hardware.

Note: For something to be considered deconfigured, it doesn't
necessarily mean that firmware chose to not configure it. It could also
mean that it is broken or missing, at least in the case of power
supplies or fans.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I3e657cb52416fc50000e299bf2d583db7b67caf8

show more ...

PEL: Update host watchdog timeout event name

watchdog: Update host watchdog event name triggered

When the host watchdog timer hits, if the hostboot-dump-collection flag
is disabled in openpower-deb

PEL: Update host watchdog timeout event name

watchdog: Update host watchdog event name triggered

When the host watchdog timer hits, if the hostboot-dump-collection flag
is disabled in openpower-debug-collector, the
org.open_power.Host.Boot.Error.WatchdogTimedOut event is triggered.

Whereas if the hostboot-dump-collection flag is enabled,
the org.open_power.Host.Boot.Error.WatchdogTimeout event is triggered

Due to this, when host dump collection is disabled, the event did not
match any entry in registry entry. Changing the event name and the
message registry in both enabled and disabled cases to
org.open_power.Host.Boot.Error.WatchdogTimedOut to see the expected PEL

Fix:
Update the event name to org.open_power.Host.Boot.Error.WatchdogTimedOut

Test:
Tested and verified that in both scenarios it creates SRC BD5EC101 PEL

Change-Id: I869588e4c0bf7f67aff1cef019f300a47bf29f63
Signed-off-by: Deepa Karthikeyan <deepakala.karthikeyan@ibm.com>

show more ...

PEL: Add new error message for system health state

A new error message added that will be created when there are
guard records And/Or Deconfigured records And/Or unresolved pels
with deconfig bit se

PEL: Add new error message for system health state

A new error message added that will be created when there are
guard records And/Or Deconfigured records And/Or unresolved pels
with deconfig bit set.

HMC will subscribe to this error SRC and when it gets notified
it requests for NAG dump which will capture serviceable records
in a JSON file and attach it to the dump.

This error message acts as a reminder for servicing faulty hardware
pending service present in the system.

Tested:
"0x500F05A1": {
"SRC": "BD50F138",
"PLID": "0x500F05A1",
"CreatorID": "BMC",
"Subsystem": "CEC Hardware",
"Commit Time": "04/24/2023 07:47:45",
"Sev": "Predictive Error",
"CompID": "bmc faultlog"
}

"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "bmc error logging",
"Subsystem": "CEC Hardware",
"Event Scope": "Entire Platform",
"Event Severity": "Predictive Error",
"Event Type": "Not Applicable",
"Action Flags": [
"Service Action Required",
"Report Externally",
"HMC Call Home"
],
"Host Transmission": "Not Sent",
"HMC Transmission": "Not Sent"
},

"User Data 1": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc error logging",
"DECONFIG_RECORD_COUNT": "0",
"GUARD_WITH_ASSOC_ERROR_COUNT": "1",
"GUARD_WITH_NO_ASSOC_ERROR_COUNT": "0",
"UNRESOLVED_PEL_WITH_DECONFIG_BIT_COUNT": "0"
}

"Primary SRC": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc faultlog",
"Callout Section": {
"Callout Count": "1",
"Callouts": [{
"FRU Type": "Maintenance Procedure Required",
"Priority": "Mandatory, replace all with this type as a
unit",
"Procedure": "BMC0008"
}]
}
}
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I1a046d4416719e479378d7032f32663fc07fd03a

show more ...

Address markdownlint warnings

Addressed markdownlint warnings reported by
"../openbmc-build-scripts/scripts/format-code.sh --enable markdownlint"

Tested: Verified and fixed warnings using
"../openb

Address markdownlint warnings

Addressed markdownlint warnings reported by
"../openbmc-build-scripts/scripts/format-code.sh --enable markdownlint"

Tested: Verified and fixed warnings using
"../openbmc-build-scripts/scripts/format-code.sh --enable markdownlint"

Change-Id: I6f8fe65373c748b907b9ca55c527800583983538
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

PEL: Add Bonnell callouts to certain fan PELs

Add Bonnell system callouts to the fan related PELs that have system
based callouts.

Also, add Bonnell callouts to the standby regulator error.

Signed

PEL: Add Bonnell callouts to certain fan PELs

Add Bonnell system callouts to the fan related PELs that have system
based callouts.

Also, add Bonnell callouts to the standby regulator error.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I35501ca208edafbe43dbe833ef7f2c7be93524cd

show more ...

PEL: Add Bonnell callouts to SBE boot timeout PEL

It calls out the backplane and first processor.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: If532a9eceda08143ad08d73c8cb273a2c8c010

PEL: Add Bonnell callouts to SBE boot timeout PEL

It calls out the backplane and first processor.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: If532a9eceda08143ad08d73c8cb273a2c8c0105e

show more ...

PEL: Add message registry for invalid certificate

Added message registry for certificate verification failure.

Tested:

xx@xxxxx# peltool -l
{
"0x500010BC": {
"SRC":

PEL: Add message registry for invalid certificate

Added message registry for certificate verification failure.

Tested:

xx@xxxxx# peltool -l
{
"0x500010BC": {
"SRC": "BDA3100C",
"Message": "Certificate verification failed",
"PLID": "0x500010BC",
"CreatorID": "BMC",
"Subsystem": "User Error",
"Commit Time": "03/29/2023 16:45:33",
"Sev": "Predictive Error",
"CompID": "0x1000"
}
}

"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "bmc error logging",
"Subsystem": "User Error",
"Event Scope": "Entire Platform",
"Event Severity": "Predictive Error",
"Event Type": "Not Applicable",
"Action Flags": [
"Service Action Required",
"Report Externally",
"HMC Call Home"
],
"Host Transmission": "Not Sent",
"HMC Transmission": "Not Sent"
},

Change-Id: I5b096d5bb0e5ecf16dd2d472c5aaea87f940f45e
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

PEL: Error log entry for TPM measurement failure

Log an error when TPM measurement fails.

Change-Id: Ice19f85d91727b9d05750aee81643812383aa4fe
Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>

PEL: Print component name in peltool list

Printing the component name instead of just the component ID was
introduced in a previous commit, though it was just done when displaying
a full PEL.

In th

PEL: Print component name in peltool list

Printing the component name instead of just the component ID was
introduced in a previous commit, though it was just done when displaying
a full PEL.

In this commit, also display the component name of the creator when
listing PELs via peltool -l.

For example:

```
"0x50000032": {
"SRC": "BD5EC101",
...
"CompID": "bmc system dump collector"
}
```

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: If6b503bd3d28a0c1879844a19527cc1f5144d78a

show more ...

PEL: Print component names in peltool

Every PEL section has a 2 byte component ID field in its header that
peltool prints. Currently, it just prints the hex version, like
"0x1000".

There are JSON

PEL: Print component names in peltool

Every PEL section has a 2 byte component ID field in its header that
peltool prints. Currently, it just prints the hex version, like
"0x1000".

There are JSON files in the flash already that contain mappings of
component IDs to to component names, and this commit starts looking
up the component names from those files and using those in the peltool
output.

An example of a file is:
/usr/share/phosphor-logging/pels/O_component_ids.json:
{
"1000": "bmc common function",
"2000": "bmc error logging",
...
}

Where the 'O' in the filename is the creator ID field of the PEL. There
is also a file for hostboot, which is B_component_ids.json.

Also, for PELs with a PHYP creator ID, just convert the ID to two
characters, like 0x4552 - > "ER" as that is what they are.

peltool output examples:
"Created by": "bmc error logging",
"Created by": "hostboot: errl",
"Created by": "IO",

This matches what is already done by the python peltool.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Id616739e1b7ca67c85dc7efa85dc34acf6aca9b5

show more ...

PEL: Fix typo in journal trace

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I57aff70bebb20e84b443bb2827e94ec913e2584a

PEL: Usability fixes to msg registry validator

This commit makes some usability improvements to the script that
validates the PEL message registry.

1) Renames the script from process_registry.py to

PEL: Usability fixes to msg registry validator

This commit makes some usability improvements to the script that
validates the PEL message registry.

1) Renames the script from process_registry.py to validate_registry.py
to more accurately reflect what it does.
2) Removes the '-v' option that was required to make it do any
validation and just run it by default. (At one point in the past it
was going to do more than just validation.)

An internal improvement was made to just use argparse's ability to
check for required parameters instead of checking manually.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I30c4ba5c693388048095b385d5cae1993e906975

show more ...

PEL:Description change in VPD SRCs

This commit modifies the description for VPD SRCs
BD554004 and BD554008.

Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>
Change-Id: I3587672afd7b47db362a

PEL:Description change in VPD SRCs

This commit modifies the description for VPD SRCs
BD554004 and BD554008.

Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>
Change-Id: I3587672afd7b47db362a3a905008f7de3e30c0ab

show more ...

PELs: Added journal capture to power/thermal PELs

Added phosphor-psu-monitor, phosphor-power-control, systemd,
phosphor-chassis-state-manager journal entries to Power Supply PELs.
Added same journal

PELs: Added journal capture to power/thermal PELs

Added phosphor-psu-monitor, phosphor-power-control, systemd,
phosphor-chassis-state-manager journal entries to Power Supply PELs.
Added same journal entries to Power Control PELs plus
phosphor-regulators.

Change-Id: Ia2a630265aad5b23ef846e212bbd9f86d5a8ec3e
Signed-off-by: Faisal Awada <faisal@us.ibm.com>

show more ...

PEL: Adding a PEL message entry into message_registry.json file

Adding a PEL entry into message_registry.json file for dump delete.

Default severity is informational and can be overwritten by calle

PEL: Adding a PEL message entry into message_registry.json file

Adding a PEL entry into message_registry.json file for dump delete.

Default severity is informational and can be overwritten by caller

Change-Id: I71520889bc9c7b0f2f3d401eb513292aeb2f8994

Change-Id: I6d5af1d5a1720ef856642aabae768a30fa36db7d
Signed-off-by: Swarnendu Roy Chowdhury <swarnendu.roy.chowdhury@ibm.com>

show more ...

PEL: Handle multiple inv paths per loc code

DataInterface::getInventoryFromLocCode() was only returning a single
inventory path from GetFRUsByExpandedLocationCode() even though multiple
paths may ha

PEL: Handle multiple inv paths per loc code

DataInterface::getInventoryFromLocCode() was only returning a single
inventory path from GetFRUsByExpandedLocationCode() even though multiple
paths may have been returned.

Mostly that was fine, except when a processor on a DCM was called out.
That would lead to only one processor on the DCM being set to not
functional by service_indicators.cpp, so on the web UI the actual CPU
called out may not have been marked as unhealthy (health status critical
in Redfish).

This commit changes getInventoryFromLocCode() to return all the paths
that GetFRUsByExpandedLocationCode() returns, and then makes the
corresponding changes in service_indicators.cpp to be able to handle
multiple inventory paths per location code when setting them to not
functional and creating a critical association.

The other code that was calling this function can just use the first
path returned, since in those cases it's just needed to get the VPD
information for the PEL, and all the paths would return the same info
anyway since they had the same location code.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ia16f50881e4a4f84c171ae20b7a99eddcc98ad4f

show more ...

PEL: Put validation fail details into journal msg

In the PEL section classes, move some journal fields from the journal
metadata section into the journal message itself, to make debug slightly
easie

PEL: Put validation fail details into journal msg

In the PEL section classes, move some journal fields from the journal
metadata section into the journal message itself, to make debug slightly
easier.

Specifically, this is just for when unflattening or validating the
sections fail.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I6d5661015b5ce5c07ed2fd6eb7ce864d0c620092

show more ...