build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: I2c043f5e8daae2f0c603a091f707ce06b1c7663e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: adjust nlohmann-json dependency

Simplify the meson directive for nlohmann-json dependency and rename the
wrap file to align with other repositories.

Signed-off-by: Patrick Williams <patrick@

meson: adjust nlohmann-json dependency

Simplify the meson directive for nlohmann-json dependency and rename the
wrap file to align with other repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6ad9d4fe3e8fa24673b736bab81e2fcabc51f1a0

show more ...

build: simplify nlohmann-json subproject

The phosphor-pid-control repository uses both phosphor-logging and
phosphor-host-ipmid as subprojects, but the way they incorporate
nlohmann-json is differen

build: simplify nlohmann-json subproject

The phosphor-pid-control repository uses both phosphor-logging and
phosphor-host-ipmid as subprojects, but the way they incorporate
nlohmann-json is different. Simplify the phosphor-logging one to
match what is available in phosphor-host-ipmid so that they can both be
build a subprojects within a single top-level project.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3484d9ee9697900dbe5e8e1895ea9d477485553d

show more ...

PEL: Point to libpldm repo in subproject

PLDM split into two repositories, so point at the one that is actually
needed as a subproject. Also remove a PLDM meson option that isn't used
anymore.

Cha

PEL: Point to libpldm repo in subproject

PLDM split into two repositories, so point at the one that is actually
needed as a subproject. Also remove a PLDM meson option that isn't used
anymore.

Change-Id: I79d4084d9dc6260dc1a0915f679d429f3c81792e
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

PEL: Create class to read from the journal

Create a Journal class that can extract messages out of the journal and
return them as a vector of strings that look like:

"Dec 14 15:58:17 systemd[1]: sy

PEL: Create class to read from the journal

Create a Journal class that can extract messages out of the journal and
return them as a vector of strings that look like:

"Dec 14 15:58:17 systemd[1]: systemd-tmpfiles-clean.service: Deactivated
successfully."

It can either grab the previous N entries, or the previous N entries
that match a specific SYSLOG_IDENTIFIER value.

The class follows the same strategy as the DataInterface class where a
base class pointer is passed into the PEL Manager class so that during
unit test it can be mocked.

Future commits will capture the journal into PEL UserData sections.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I9f4bb304c4b213165049fa00de2e62f962ae67f1

show more ...

PEL: Add hostboot component ID file

Add a file with the hostboot component names for use by PEL parsers.

There are other ways these could be looked up, such as creating a new
python plugin process

PEL: Add hostboot component ID file

Add a file with the hostboot component names for use by PEL parsers.

There are other ways these could be looked up, such as creating a new
python plugin process to be able to ask for a component name with python

However, as these names are typically static per processor generation,
this is going with the approach that takes the least amount of effort
until another approach is deemed necessary.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Iabeb4d77cade8a0f4ef064e1f7f892fd766c48d6

show more ...

PEL: Convert component ID list to JSON

With a machine readable list of BMC PEL component IDs, the PEL parsers
will be able to use it to look up component names for display.

The component ID names a

PEL: Convert component ID list to JSON

With a machine readable list of BMC PEL component IDs, the PEL parsers
will be able to use it to look up component names for display.

The component ID names all have 'bmc' in them to avoid confusion with
similar components in other subsystems, like hostboot. This was added
at the request of hostboot.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ia08dee13695a55f34885940348cb44bce9cb7bb5

show more ...

meson: simplify dependencies

Leverage wrapfile `[provide]` directives to simplify the dependency
searching in the meson.build. phosphor-dbus-interfaces now defaults to
enabling all of the project o

meson: simplify dependencies

Leverage wrapfile `[provide]` directives to simplify the dependency
searching in the meson.build. phosphor-dbus-interfaces now defaults to
enabling all of the project options, so there is no need to manually
specify this either.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I550667da15ce8347acfede53a60516a0428bad2b

show more ...

PEL: Add deconfigure records

PHAL enabled systems enabled harwdare deconfigure (set state
to non-functional, do any Deconfigure actions and create a
deconfigure Record in cec devtree

PEL: Add deconfigure records

PHAL enabled systems enabled harwdare deconfigure (set state
to non-functional, do any Deconfigure actions and create a
deconfigure Record in cec devtree) during PEL create.
This function enabled only for the PEL create request with
required "Deconfigured" key in the callout information.

libphal api is used for creating deconfigure records.

Tested: Verified deconfigure records in the cec devtree

root@xxxx:~# attributes read /proc0 ATTR_HWAS_STATE
ATTR_HWAS_STATE = 0x50000684 0x40

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I77b630da00d9c1f2807aac06a0220e4c14c79fdb

show more ...

PEL: Added phal specific service action support

This commits enables the basic infrastructure to add service
actions(guard/deconfigure) supports for "phal" feature enabled
systems.

PEL: Added phal specific service action support

This commits enables the basic infrastructure to add service
actions(guard/deconfigure) supports for "phal" feature enabled
systems. Also enabled "guard" related service , which includes
creating guard D-Bus object using hardware isolation D-Bus api's

To enable this support, PEL users has to include the array of
JSON callouts, which includes the below required informations.
"EntityPath": entity path of the hardware from the PHAL device tree.
"GuardType": Guard type string defined libekb_p10.
"Guarded": boolean, true to create guard records.

Tested: created guard records and verified
root@xxxx:~# guard -l
ID | ERROR | Type | Path
00000001 | 50000684 | fatal | physical:sys-0/node-0/proc-0
00000002 | 50000685 | fatal | physical:sys-0/node-0/proc-1
00000003 | 50000686 | fatal | physical:sys-0/node-0/proc-2
00000004 | 50000687 | fatal | physical:sys-0/node-0/proc-3

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Ibc57ae0363cd5fb9facd2ed7049a70806a5b891e

show more ...

PEL: rename feature flag SBE_FFDC_SUPPORTED

Initially SBE_FFDC_SUPPORTED flag introduced to enable
SBE ffdc specific feature from phal feature enabled systems.
There is new require

PEL: rename feature flag SBE_FFDC_SUPPORTED

Initially SBE_FFDC_SUPPORTED flag introduced to enable
SBE ffdc specific feature from phal feature enabled systems.
There is new requirement to add additional callout details
for phal feature enabled systems.
Changing "SBE_FFDC_SUPPORTED" to PHAL feature specific
name "PEL_ENABLE_PHAL".

Tested: verified build with phal enabled option.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Ief4b7a97fa148707f48f70f3f99d2f1a04a05f2e

show more ...

PEL.Entry - Add managementSystemAck property

Add managementSystemAck property to PEL.Entry interface to support HMC
acknowledgement of event receipt.

Tested:
1. Created a PE

PEL.Entry - Add managementSystemAck property

Add managementSystemAck property to PEL.Entry interface to support HMC
acknowledgement of event receipt.

Tested:
1. Created a PEL log using busctl and set-property managementSystemAck
to true. Verified that the flag is set by using peltool
Result:(output of peltool)
"Host Transmission": "Not Sent",
"HMC Transmission": "Acked"
Restarted phosphor-log-manager and verified that the flag is true.

2. Generated PEL using RAWPEL and verified all the steps as in 1.

Change-Id: Ifa06cca0063c6c609317192f9c18bb2524e2f292
Signed-off-by: Vijay Lobo <vijaylobo@gmail.com>

show more ...

PEL: fix bitbake failures related to commit e0538848

fatal error: phosphor-logging/log.hpp: No such file
or directory.

Fix: Added phosphor_logging_dep to pel dependencies.

PEL: fix bitbake failures related to commit e0538848

fatal error: phosphor-logging/log.hpp: No such file
or directory.

Fix: Added phosphor_logging_dep to pel dependencies.

Tested: Unit testing is successfull.
Created and verified SBE failure related PEL.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I880ad5d0c80f6b4ded69c6575657398008d28b91

show more ...

build: Target c++ arguments specifically where they are needed

This fixes the build with phal enabled, since it tries to add global
project cpp_args after targets have already been decla

build: Target c++ arguments specifically where they are needed

This fixes the build with phal enabled, since it tries to add global
project cpp_args after targets have already been declared.

Change-Id: I907fbd40a82725da4e751b82c66c71c602dd2018
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

build: Refactor to separate out library

This makes it more clear what code is intended for use by the
phosphor-logging shared library. This is especially nice since it
isolates the `

build: Refactor to separate out library

This makes it more clear what code is intended for use by the
phosphor-logging shared library. This is especially nice since it
isolates the `phosphor_logging_dep` to only provide the exported headers
instead of everything in the project.

Additionally, this adds an option to build only the library components
of the project when the services aren't needed.

Change-Id: Ied0858fc70e8054df4c056d91f35a6f0b3acfcb1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

PEL: Add SBE FFDC process function

Helper function to process SBE FFDC packet.
This function call libekb function to process the
FFDC packet and convert in to known format for PEL

PEL: Add SBE FFDC process function

Helper function to process SBE FFDC packet.
This function call libekb function to process the
FFDC packet and convert in to known format for PEL
specific file creation. This function also creates
json callout file and text type file, which includes
the addition debug data included in SBE FFDC packet.

Tested: Manually verified,

Sample test results with all the cores de-configured
system boot usecase.

"User Data 3": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"Data": [
{
"Deconfigured": false,
"Guarded": false,
"LocationCode": "Ufcs-P0-C24",
"MRUs": [
{
"ID": 65536,
"Priority": "H"
}
],
"Priority": "H"
}
]
},
"User Data 4": {
"Section Version": "1",
"Sub-section type": "3",
"Created by": "0x2000",
"Data": [
"HWP_RC = RC_SBE_SELECT_EX_INSUFFICIENT_ACTIVE_CORES_ERROR",
"HWP_RC_DESC = The requested active cores were
not able to be configured.",
"HWP_FFDC_CHIP = 6b3a7570 306e3a30 3a30733a 00323070
00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000
00000000 00000000",
"HWP_FFDC_CORE_CONFIG = 00000000",
"HWP_FFDC_ATTR_ACTIVE_CORES_NUM = 02",
"HWP_FFDC_ACTIVE_CORES_NUM = 00000000",
"HWP_FFDC_ACTIVE_CORES_VEC = 00000000",
"HWP_CDG_TGT_01_LOC_CODE = Ufcs-P0-C24",
"HWP_CDG_TGT_01_PHYS_PATH = physical:sys-0/node-0/proc-2",
"HWP_CDG_TGT_01_CO_REQ = true",
"HWP_CDG_TGT_01_CO_PRIORITY = HIGH",
"HWP_CDG_TGT_01_DECONF_REQ = false",
"HWP_CDG_TGT_01_GUARD_REQ = false",
"HWP_CDG_TGT_01_GUARD_TYPE = GARD_Fatal"
]
}

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Iac2689c3608ddb0090a1c17753bbf9be96d12939

show more ...

PEL: API to convert FAPI based data to PEL format

API support to convert processed SBE FFDC FAPI format packets
into PEL expected format.

This function is ported from openpowe

PEL: API to convert FAPI based data to PEL format

API support to convert processed SBE FFDC FAPI format packets
into PEL expected format.

This function is ported from openpower-proc-control and
customised to make independent function.

Added pdbg and device tree libraries to support phal based
device tree support.

Tested: Manually verified.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I8afdb5861be6b129314621eea342bee5eaae82d7

show more ...

PEL: Create TemporaryFile class

Added support for creating temporary file
- Constructor creates the temporary file with data
- Destructor doesn't deletes file due to PEL function

PEL: Create TemporaryFile class

Added support for creating temporary file
- Constructor creates the temporary file with data
- Destructor doesn't deletes file due to PEL function
related requirements.
- Provided remove function to delete the file.

Tested: Added test cases for TemporaryFile class and verified
test_openpower_pels_temporary_file OK 0.03s

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I5295998d746ef1228512545f0a19faa1f94260d8

show more ...

PEL: enable base infrastructure for SBE FFDC base PEL create

This commits provides the base infrastructure for SBE FFDC based
on createPELWithFFDCFiles`D-Bus method on the
org.open_p

PEL: enable base infrastructure for SBE FFDC base PEL create

This commits provides the base infrastructure for SBE FFDC based
on createPELWithFFDCFiles`D-Bus method on the
org.open_power.Logging.PEL.

More details related to usage of this interface is documented
as part of extensions/openpower-pels/README.md.

In the PEL create interface if the type is custom and subtype
is 0xCB, PEL class function invokes SBE FFDC function to process
SBE FFDC to extract Hardware procedure added user data section and
callouts. SBE FFDC class appends the callout json and create
user data file based FFDC information and continue the normal
PEL create function.

SCOPE of this commit:
- Add base infrastructure and control build only for "phal" supported
systems. "phal" feature is mandatory requirement for processing
SBE FFDC.
- Add SBE FFDC raw information in PEL user data section

To enable this feature use the below meson build options
meson build -Dopenpower-pel-extension=enabled -Dphal=enabled

Tested:

"Error Details": {
"Message":"chipop timeout reported during SBE communication",
"SRC6": [
"0x2",
"[0:15] chip position, [16:23] command class,
[24:31] command type"
]
},

"User Data 2": {
"Section Version": "1",
"Sub-section type": "203",
"Created by": "0x3500",
"Data": [
"FF DC 00 12 00 00 A1 01 00 8E CE 72 00 00 FF FE | ...........r....",
"00 00 00 04 00 00 00 00 00 00 00 04 00 00 00 00 | ................",
"00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 02 | ................",
"00 00 00 04 00 00 00 00 00 00 00 00 00 00 00 04 | ................",
"00 00 00 00 00 00 00 00 | ........"
]
}

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I2200b3ba9c0977be13e71f25e87f0b16cb50ec5b

show more ...

build: meson support for openpower-pel extensions

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4b45f71a3de4966fe3649480d4333806f201f405