#
075c7923 |
| 16-Aug-2024 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda forma
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda formatting also changed, so we have made changes to the organization default style format to better handle lambda formatting.
See I5e08687e696dd240402a2780158664b7113def0e for updated style. See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.
Change-Id: I21d2ca8065f24fd73509229c517f5caf48934b60 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
#
cc9adb79 |
| 26-Feb-2024 |
Matt Spinler <spinler@us.ibm.com> |
PEL: Use lg2 in Callouts class
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I0dc89e3047e5e735ea887081df4d7ca9df642042
|
#
4efed0ef |
| 26-Feb-2024 |
Matt Spinler <spinler@us.ibm.com> |
PEL: Don't allow duplicate callouts
When adding callouts, check if the callout being added already exists. If it does, don't add it and rather just update the priority of the existing one to be the
PEL: Don't allow duplicate callouts
When adding callouts, check if the callout being added already exists. If it does, don't add it and rather just update the priority of the existing one to be the highest of the two.
Callouts are considered to be equal if their location code matches, or if they have the same maintenance procedure, or if they have the same symbolic FRU.
The change entails adding an operator== on the Callout object, as well as an operator> so that the callout with the highest priority can be determined. Also use this new operator> in the sort of the callout list that happens after a callout is added or changed.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I5ee148cc12e92f67fb3da233c3615e9665e95355
show more ...
|
#
2544b419 |
| 04-Oct-2022 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: update with latest
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I329396457b83bb2eb8740629b4ac1fbe9106bced
|
#
7f1b9052 |
| 22-Mar-2022 |
Matt Spinler <spinler@us.ibm.com> |
Revert "PEL: Create trace wrapper for peltool"
This reverts commit 2ea96f6c6c92bb585668cff7c659cdea606dfc68.
Going to go in a different direction and not build peltool in other contexts.
Change-Id
Revert "PEL: Create trace wrapper for peltool"
This reverts commit 2ea96f6c6c92bb585668cff7c659cdea606dfc68.
Going to go in a different direction and not build peltool in other contexts.
Change-Id: I92fefbb3fe5249f2cc0ccf679febe5a3b3340048
show more ...
|
#
7681e5ed |
| 11-Mar-2022 |
Matt Spinler <spinler@us.ibm.com> |
PEL: Add missing <map> include to callouts.cpp
This won't come for free starting in a future commit.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I4bdb44ab60c688d71336992bc6e97d81929
PEL: Add missing <map> include to callouts.cpp
This won't come for free starting in a future commit.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I4bdb44ab60c688d71336992bc6e97d8192931aec
show more ...
|
#
2ea96f6c |
| 23-Feb-2022 |
Matt Spinler <spinler@us.ibm.com> |
PEL: Create trace wrapper for peltool
In preparation for peltool being compiled for non-BMC platforms where libphosphor_logging.so isn't available, create a wrapper function for tracing so phosphor:
PEL: Create trace wrapper for peltool
In preparation for peltool being compiled for non-BMC platforms where libphosphor_logging.so isn't available, create a wrapper function for tracing so phosphor::logging::log() isn't directly used by the code that is part of peltool.
For now, the wrapper will just call phosphor::logging::log, but in the future will be changed to call std::cerr when not on the BMC.
A few files were changed to make use of the new calls. Others will be done with future commits. Only the code that is built into peltool needs to use this. This mostly consists of the PEL section classes.
Using this new API does mean no extra data can be stored in the journal metadata, as the systemd journal may not be available on some platforms the tool may need to run on, such as AIX. Instead, the data can just be added into the trace string itself.
In a future commit, the meson.build file will be refactored to remove the libphosphor_logging dependency so the build will fail if a call to the phosphor-logging's log() is made within peltool code.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I5e6c235d60466b031e15b157860c07a3f8ddb148
show more ...
|
#
53ef1552 |
| 14-Oct-2020 |
Miguel Gomez <mgomez@mx1.ibm.com> |
Specify PEL callout priority and sort callouts. Allow the priority to be passed in at creation time by calling the CALLOUT_PRIORITY keyword. When creating a PEL, callouts will always
Specify PEL callout priority and sort callouts. Allow the priority to be passed in at creation time by calling the CALLOUT_PRIORITY keyword. When creating a PEL, callouts will always be sorted by priority instead of creation time, the order is as follows: H,M,A,B,C,L. Signed-off-by: Miguel Gomez <mgomez@mx1.ibm.com> Change-Id: I84345aaf3fad7b2e4958b698ab761966f499986b
show more ...
|
#
e0366f31 |
| 13-Mar-2020 |
Matt Spinler <spinler@us.ibm.com> |
PEL: Let Callouts class have a Callout added Add an addCallout() function to the Callouts class to add a new Callout object to it. Signed-off-by: Matt Spinler <spinler@us.ibm.co
PEL: Let Callouts class have a Callout added Add an addCallout() function to the Callouts class to add a new Callout object to it. Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ib2a352b3b10e2948c4e847d29a456b8de9cb3559
show more ...
|
#
724d0d8c |
| 06-Nov-2019 |
Matt Spinler <spinler@us.ibm.com> |
PEL: Const flattens for the SRC sub classes Make the flatten functions const for the various classes that represent the SRC substructures. Signed-off-by: Matt Spinler <spinler@u
PEL: Const flattens for the SRC sub classes Make the flatten functions const for the various classes that represent the SRC substructures. Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I08f4ae6de65e269c9f1b82315115969c8552c782
show more ...
|
#
711d51d8 |
| 06-Nov-2019 |
Matt Spinler <spinler@us.ibm.com> |
PEL: Add license prologue to source files Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I31b12f509d32b79064a8a427af35e6a310273051
|
#
32f13c91 |
| 09-Oct-2019 |
Matt Spinler <spinler@us.ibm.com> |
PEL: SRC callouts subsection object This Callouts class represents the optional subsection of an SRC PEL section that contains FRU callouts. It is only present in the SRC when there
PEL: SRC callouts subsection object This Callouts class represents the optional subsection of an SRC PEL section that contains FRU callouts. It is only present in the SRC when there are callouts, and it comes at the end of the section. It is basically just a container for the Callout objects that represent the actual callouts. Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I1d4d95b82f9b4943728d7939e3bf89e4a7bcbb75
show more ...
|