4a435516 | 07-Aug-2024 |
Andrew Geissler <geissonator@yahoo.com> |
IBM: Config: Update to put pca955x at end
Not sure when the disconnect occurred but phosphor-led-sysfs appends the hardware device at the end of the dbus object name.
Update the config files to ref
IBM: Config: Update to put pca955x at end
Not sure when the disconnect occurred but phosphor-led-sysfs appends the hardware device at the end of the dbus object name.
Update the config files to reflect this for phosphor-led-sysfs provided LEDs.
Tested: - Confirmed p10bmc no longer fills journal with "The resource not found" for all the BMC provided LEDs
Change-Id: I00ec2822ecb223b17635fe2c3a863ba1152fec4f Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
show more ...
|
fe476e17 | 23-Jul-2024 |
Alexander Hansen <alexander.hansen@9elements.com> |
readability: remove redundant check before iterate
There were some patterns like
if (collection.size()) { for(auto& it : collection){ //... } }
which is redundant.
Change-Id: I10c
readability: remove redundant check before iterate
There were some patterns like
if (collection.size()) { for(auto& it : collection){ //... } }
which is redundant.
Change-Id: I10c0ad1ecd0aa2e96b456dcf9c5ea4d8995ae016 Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
show more ...
|
2099d9f5 | 23-Jul-2024 |
Alexander Hansen <alexander.hansen@9elements.com> |
docs: document "Priority" feature
Change-Id: If9ddb4d159b390fb6760a23e669911cb3b5cda15 Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com> |
191949c8 | 22-Jul-2024 |
George Liu <liuxiwei@ieisystem.com> |
Fix cppcheck warnings
Warning message: ``` /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:97:16: error: invalid application of 'sizeof' to an incomplete type 'phosphor
Fix cppcheck warnings
Warning message: ``` /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:97:16: error: invalid application of 'sizeof' to an incomplete type 'phosphor::led::fru::fault::monitor::Remove' 97 | static_assert(sizeof(_Tp)>0, | ^~~~~~~~~~~ /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:404:4: note: in instantiation of member function 'std::default_delete<phosphor::led::fru::fault::monitor::Remove>::operator()' requested here 404 | get_deleter()(std::move(__ptr)); | ^ /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:88:15: note: in instantiation of member function 'std::unique_ptr<phosphor::led::fru::fault::monitor::Remove>::~unique_ptr' requested here 88 | __location->~_Tp(); | ^ /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:149:12: note: in instantiation of function template specialization 'std::destroy_at<std::unique_ptr<phosphor::led::fru::fault::monitor::Remove>>' requested here 149 | std::destroy_at(__pointer); | ^ /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:163:11: note: in instantiation of function template specialization 'std::_Destroy<std::unique_ptr<phosphor::led::fru::fault::monitor::Remove>>' requested here 163 | std::_Destroy(std::__addressof(*__first)); | ^ /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:193:35: note: in instantiation of function template specialization 'std::_Destroy_aux<false>::__destroy<std::unique_ptr<phosphor::led::fru::fault::monitor::Remove> *>' requested here 193 | return std::_Destroy_aux<false>::__destroy(__first, __last); | ^ /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/alloc_traits.h:948:12: note: in instantiation of function template specialization 'std::_Destroy<std::unique_ptr<phosphor::led::fru::fault::monitor::Remove> *>' requested here 948 | std::_Destroy(__first, __last); | ^ /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_vector.h:735:7: note: in instantiation of function template specialization 'std::_Destroy<std::unique_ptr<phosphor::led::fru::fault::monitor::Remove> *, std::unique_ptr<phosphor::led::fru::fault::monitor::Remove>>' requested here 735 | std::_Destroy(this->_M_impl._M_start, this->_M_impl._M_finish, | ^ ../../../fault-monitor/fru-fault-monitor.hpp:48:14: note: in instantiation of member function 'std::vector<std::unique_ptr<phosphor::led::fru::fault::monitor::Remove>>::~vector' requested here 48 | explicit Add(sdbusplus::bus_t& bus) : | ^ ../../../fault-monitor/fru-fault-monitor.hpp:28:7: note: forward declaration of 'phosphor::led::fru::fault::monitor::Remove' 28 | class Remove; | ^ ```
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: I5c20a0031deff51e6bacccdd81310e95f14e52a0
show more ...
|
deab0fcc | 21-Jul-2024 |
George Liu <liuxiwei@ieisystem.com> |
README.md: Fix MD014 warnings
The following warnings are generated by using markdownlint analysis: ``` MD014/commands-show-output Dollar signs used before commands without showing output [Context: "
README.md: Fix MD014 warnings
The following warnings are generated by using markdownlint analysis: ``` MD014/commands-show-output Dollar signs used before commands without showing output [Context: "$ ./phosphor-led-manager --con..."] ``` Refer to markdown-lint [1] to fix MD014 [1]: https://github.com/updownpress/markdown-lint/blob/master/rules/014-commands-show-output.md
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: If8a9428dfc69b788fe780651ac8ab275a188ee9b
show more ...
|
d30c9d37 | 21-Jul-2024 |
George Liu <liuxiwei@ieisystem.com> |
README.md: Fix MD040 warnings
The following warnings are generated by using markdownlint analysis: ``` MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
README.md: Fix MD040 warnings
The following warnings are generated by using markdownlint analysis: ``` MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] ``` Refer to markdown-lint [1] to fix MD040 [1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: I7a9b9851a17919c8cb650fdbd5b8e9eda2faac36
show more ...
|
bdbfcde1 | 26-Jun-2024 |
Alexander Hansen <alexander.hansen@9elements.com> |
Add README.md
Explaining the high level workings of this project.
Change-Id: I066820dc2f7b09081385d3111d3e1beee46b7d8f Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com> |
94e894cb | 17-Jun-2024 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Fix spelling mistakes using codespell
This commit corrects various spelling mistakes throughout the repository. The corrections were made automatically using `codespell`[1] tool.
[1]: https://githu
Fix spelling mistakes using codespell
This commit corrects various spelling mistakes throughout the repository. The corrections were made automatically using `codespell`[1] tool.
[1]: https://github.com/codespell-project/codespell
Change-Id: I3a5360efb5b6a71d5eabb557accf939cd6abc864 Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
e1303415 | 02-Apr-2024 |
Konstantin Aladyshev <aladyshev22@gmail.com> |
meson: Fix local cereal build
Currently local build is failing with a message: """ cereal| Exception: Failed to configure the CMake subproject: Could NOT find Boost (missing: Boost_INCLUDE_DIR seria
meson: Fix local cereal build
Currently local build is failing with a message: """ cereal| Exception: Failed to configure the CMake subproject: Could NOT find Boost (missing: Boost_INCLUDE_DIR serialization) Subproject subprojects/cereal is buildable: NO (disabling) """ Since cereal requires boost only for the sandbox build and this functionality is not needed, add option to skip building performance sandbox comparison to solve the issue.
Tested: "meson setup build" no longer fails with the cereal error.
Change-Id: Ib09b7fc33e60cd1784a33e4fb1d4ab3c36b567ba Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
show more ...
|
f9e049b3 | 12-Mar-2024 |
Gunnar Mills <gmills@us.ibm.com> |
OWNERS: Remove Vishwa
Like https://gerrit.openbmc.org/c/openbmc/phosphor-time-manager/+/70003
Vishwa is no longer associated with IBM and appears to have disengaged from OpenBMC since 2022. Further
OWNERS: Remove Vishwa
Like https://gerrit.openbmc.org/c/openbmc/phosphor-time-manager/+/70003
Vishwa is no longer associated with IBM and appears to have disengaged from OpenBMC since 2022. Furthermore, his inactivity on Discord suggests a lack of interest in OpenBMC. Consequently, it seems appropriate to remove him from the maintainers list.
Vishwa - Thank you for your contributions to OpenBMC!
Signed-off-by: Gunnar Mills <gmills@us.ibm.com> Change-Id: Idb98261f8f2a8d87c4d84a19fde435039433bbf8
show more ...
|
dc7a951d | 15-Jan-2024 |
George Liu <liuxiwei@ieisystem.com> |
Remove unused variables
The `LED_JSON_FILE` variable declared in meson.build has been deprecated and replaced by `confBasePath`[1].
[1] https://github.com/openbmc/phosphor-led-manager/commit/616a07
Remove unused variables
The `LED_JSON_FILE` variable declared in meson.build has been deprecated and replaced by `confBasePath`[1].
[1] https://github.com/openbmc/phosphor-led-manager/commit/616a0716970203cb77dc92301f0763043c5b461c#diff-6d7dfec73b9c66c317e9bfab43d3320b2133bf883674773fd467a99888896ff5R21
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: Ia78cdf51843d90b7c7495ac4688c45a208600550
show more ...
|
7d887627 | 22-Dec-2023 |
Priyanga Ramasamy <priyanga24@in.ibm.com> |
leds:Make use of Decorator.Compatible interface
Switching led-manager to use xyz.openbmc_project.Inventory.Decorator. Compatible interface from using xyz.openbmc_project.Configuration. IBMCompatible
leds:Make use of Decorator.Compatible interface
Switching led-manager to use xyz.openbmc_project.Inventory.Decorator. Compatible interface from using xyz.openbmc_project.Configuration. IBMCompatibleSystem interface.
Test: Tested that the right config json is picked based on the Names property from xyz.openbmc_project.Inventory.Decorator.Compatible interface.
Change-Id: I48ee37cb3f11fd6cd99e913caee4ebeb2e1004c3 Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>
show more ...
|
7c5f1934 | 10-Jan-2024 |
Priyanga Ramasamy <priyanga24@in.ibm.com> |
leds:Restructure and rename configs directory
Rename led config jsons in a simple and straight forward way and remove subdirectory wherever required.
Change-Id: Icfa0ae3b8cb2be0ef71a5f51525ab46865d
leds:Restructure and rename configs directory
Rename led config jsons in a simple and straight forward way and remove subdirectory wherever required.
Change-Id: Icfa0ae3b8cb2be0ef71a5f51525ab46865de19bd Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>
show more ...
|
254f5292 | 09-Jan-2024 |
George Liu <liuxiwei@ieisystem.com> |
owners: updated George email
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: Ie7d0e84b7952ebf15d5127071da23ea3a3acdb50 |
6fc3562e | 07-Dec-2023 |
Patrick Williams <patrick@stwcx.xyz> |
meson: adjust nlohmann-json dependency
- Simplify the nlohmann-json dependency logic in meson.build - Change wrap file name to align with other repositories. - Use HEAD for nlohmann-json revision ra
meson: adjust nlohmann-json dependency
- Simplify the nlohmann-json dependency logic in meson.build - Change wrap file name to align with other repositories. - Use HEAD for nlohmann-json revision rather than a pinned version.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I5ba6cc684c7c2dc8889e9a4cd882d5c6840b4b92
show more ...
|
55b599e9 | 05-Dec-2023 |
Anupama B R <anupama.b.r1@ibm.com> |
Updating LED config JSONs
Config JSON files related to IBM specific systems has been updated with some new groups. The groups has been added to handle LEDs w.r.t those FRUs. Commit also updates defa
Updating LED config JSONs
Config JSON files related to IBM specific systems has been updated with some new groups. The groups has been added to handle LEDs w.r.t those FRUs. Commit also updates default settings for some of the existing groups.
Change-Id: Ie56bbedaaa1b84800b76fd8cdbee20498e8aa5b2 Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>
show more ...
|
95b0db91 | 29-Nov-2023 |
Patrick Williams <patrick@stwcx.xyz> |
build: use allowed over enabled
Meson feature options are typically in a tri-state of enabled, disabled, or auto. The enabled and disabled functions on an option (from `get_option`) no longer retur
build: use allowed over enabled
Meson feature options are typically in a tri-state of enabled, disabled, or auto. The enabled and disabled functions on an option (from `get_option`) no longer return true for auto features. Instead, the expectation is to use `allowed()` which is true for both enabled and auto.
Switch all uses of `enabled` to `allowed`.
Change-Id: I4db060ea85cfae7be96693ec04a09829767351a1 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
e3515c71 | 15-Oct-2022 |
Sunny Srivastava <sunnsr25@in.ibm.com> |
Reset lamps after reboot
In case lamp test has been triggered and reboot takes place, even after reboot the lamps are found to be in the on state.
The commit switches off the lamps in case such sit
Reset lamps after reboot
In case lamp test has been triggered and reboot takes place, even after reboot the lamps are found to be in the on state.
The commit switches off the lamps in case such situation is found and restores the LEDs to the state in which they were before lamp test was triggered.
Change-Id: I3d199b7066751e89bd6faffc38af3e36877ca003 Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>
show more ...
|
0175a811 | 13-Nov-2023 |
George Liu <liuxiwei@inspur.com> |
meson.options: Enable use-lamp-test feature by default
Enable use-lamp-test feature so that the repo CI could compile this code, and disable this feature in Yocto.
Signed-off-by: George Liu <liuxiw
meson.options: Enable use-lamp-test feature by default
Enable use-lamp-test feature so that the repo CI could compile this code, and disable this feature in Yocto.
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I65cb7b31c0aeaa257ddbb21eff72bf35d1d88f0b
show more ...
|
180090cf | 10-Oct-2022 |
PriyangaRamasamy <priyanga24@in.ibm.com> |
Resolve issues in lamp test feature
This commit implements the following changes in lamp test
1. Reset lamp test timer on assert to assert case 2. Reject stopping lamp test when there is a request
Resolve issues in lamp test feature
This commit implements the following changes in lamp test
1. Reset lamp test timer on assert to assert case 2. Reject stopping lamp test when there is a request to deassert lamp test.
Test: Case 1: Start lamp test (False to True). Result: 4mins of lamp test execution and Asserted is set back to false after 4mins.
Case 2: Stop lamp test (False to False). Result: Lamp test is not performed and Asserted remains false.
Case 3: Stop request when lamp test is still on (True to false) Result: Stop request not allowed and lamp test continues to execute. Asserted stays true until the lamp test ends.
Case 4: Retrigger lamp test (True to True). Result: 4mins timer restarts. Asserted should be back to false after 4mins.
Change-Id: Ib6086f223d5c5ce80b872ed5f35645893ce79cf9 Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>
show more ...
|
54671853 | 29-Oct-2023 |
George Liu <liuxiwei@inspur.com> |
Persistence the led group asserted value by default
Currently, only IBM's P10 machine will persist the Asserted attribute value of ledGroup by default. But for other systems, most do not need to per
Persistence the led group asserted value by default
Currently, only IBM's P10 machine will persist the Asserted attribute value of ledGroup by default. But for other systems, most do not need to perform persistence actions.
The intent behind this commit is to add a switch to control the persistence function, and it is enabled by default in CI and disabled by default in Yocto.
Tested: Regardless of whether `persistent-led-asserted` is enabled or disabled, the ledmanager process works fine.
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I75b59a12dde417a9ccadaf25b2af07fc33186a01
show more ...
|
605600eb | 20-Oct-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-17 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest
clang-format: copy latest and re-format
clang-format-17 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest .clang-format from the docs repository and reformat the repository.
Change-Id: Ie509bd0c9f5a19db463c4bb51ede752e778439b3 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
4549fb05 | 15-Aug-2023 |
George Liu <liuxiwei@inspur.com> |
meson_options.txt: Support for reading options from meson.options
Support has been added for reading options from meson.options instead of meson_options.txt[1]. These are equivalent, but not using t
meson_options.txt: Support for reading options from meson.options
Support has been added for reading options from meson.options instead of meson_options.txt[1]. These are equivalent, but not using the .txt extension for a build file has a few advantages, chief among them many tools and text editors expect a file with the .txt extension to be plain text files, not build scripts.
[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: Icf7286351b49c526d02327e3a2d72c40b5f9a960
show more ...
|
f1ed4796 | 13-Jul-2023 |
Potin Lai <potin.lai@quantatw.com> |
manager: add timer for failed LED actions
The current manager performs LED ActionSet one-time only when LED group asserted property changes, so if the physical LED object path is not ready when it i
manager: add timer for failed LED actions
The current manager performs LED ActionSet one-time only when LED group asserted property changes, so if the physical LED object path is not ready when it is set, the LED will be in an error state. Most of time this error occurs at BMC booting due phospohr-led-manager starts before LED driver is probed.
In order to correct LED state after physical LED is ready, add a timer to repeatedly setting failed LED after 1 second.
Change-Id: I0bb46189c79c961cdaa501a7386346c2bb351252 Signed-off-by: Potin Lai <potin.lai@quantatw.com>
show more ...
|
049700cc | 07-Aug-2023 |
George Liu <liuxiwei@inspur.com> |
build-tests: The allowed method is used by default
The allowed method returns true when the feature is set to `enabled` or `auto`. The allowed method returns false when the feature is set to `disabl
build-tests: The allowed method is used by default
The allowed method returns true when the feature is set to `enabled` or `auto`. The allowed method returns false when the feature is set to `disabled`. So we prefer to use the `allowed` method instead of `enabled`.
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I3cc28241cd9ef0d907aa73409a63a4470a628e70
show more ...
|