yaml: update default led.yaml config

The default led.yaml configuration having old definition for a led
priority.
Running `scripts/parse_led.py` goes failure:
```bash
ValueError: Invalid Configurati

yaml: update default led.yaml config

The default led.yaml configuration having old definition for a led
priority.
Running `scripts/parse_led.py` goes failure:
```bash
ValueError: Invalid Configuration for LED [heartbeat] in Group
[bmc_booted]: no group priority or led priority defined
```

The change adds `Priority: "On"` for each Leds across all led groups.

Tested:
* run `scripts/parse_led.py -i . -o .`
* the `parse_led.py` generates `led-gen.hpp` properly

Change-Id: Icabb4bc6127a468102387e576e8ce9a54ea07693
Signed-off-by: Igor Kononenko <i.kononenko.e@gmail.com>

show more ...

yaml: add back support for empty LED groups

The old script had support for empty LED groups. I tried removing the
empty "bmc_booted" LED group, but that caused systemd to never "finish"
booting (sys

yaml: add back support for empty LED groups

The old script had support for empty LED groups. I tried removing the
empty "bmc_booted" LED group, but that caused systemd to never "finish"
booting (systemctl is-system-running returned "starting" because it was
blocked waiting for the "bmc_booted" LED service to start).

This adds back support for empty LED groups.

Tested:
Confirmed that with an empty "bmc_booted" LED group, the firmware will
build successfully and systemd doesn't get blocked waiting for the
"bmc_booted" LED service.

Change-Id: I11d7c50696cd50d989a4eaef28f8e5c43473ce6e
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

prettier: enable formatting

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I4e140b0eca1945efa456c297085ae2e84e7c8d5d

clang-tidy: Enable readability-braces-around-statements check

This checks that bodies of if statements and loops
(for, do while, and while) are inside braces.

Signed-off-by: George Liu <liuxiwei@ie

clang-tidy: Enable readability-braces-around-statements check

This checks that bodies of if statements and loops
(for, do while, and while) are inside braces.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I9b79aaa3d3299d42ae245afe4b9488ae58e2c28d

show more ...

clang-tidy: Enable readability-redundant-string-cstr check

This check finds unnecessary calls to std::string::c_str() and
std::string::data().

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Cha

clang-tidy: Enable readability-redundant-string-cstr check

This check finds unnecessary calls to std::string::c_str() and
std::string::data().

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I4ff9cd7f1595a1cd7c6dbab4c7a80d6f7cf05ca2

show more ...

clang-tidy: Enable readability-qualified-auto check

This check aims to improve code readability by suggesting the use
of const auto * instead of auto for variables that are pointers
or iterators. Th

clang-tidy: Enable readability-qualified-auto check

This check aims to improve code readability by suggesting the use
of const auto * instead of auto for variables that are pointers
or iterators. This helps clarify the const-ness of the pointed-to
object or container elements.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia132b6dd8ae4e3c16809326f6055396666abc95a

show more ...

clang-tidy: Enable readability-simplify-boolean-expr check

This checks for boolean expressions involving boolean constants
and simplifies them to use the appropriate boolean expression
directly.

Si

clang-tidy: Enable readability-simplify-boolean-expr check

This checks for boolean expressions involving boolean constants
and simplifies them to use the appropriate boolean expression
directly.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: If2316dc52cbd280971f0333ee805b11e1b99d27f

show more ...

clang-tidy: Enable readability-implicit-bool-conversion check

This check can be used to find implicit conversions between
built-in types and booleans.
the following conversion types are checked:
- i

clang-tidy: Enable readability-implicit-bool-conversion check

This check can be used to find implicit conversions between
built-in types and booleans.
the following conversion types are checked:
- integer expression/literal to boolean
- floating expression/literal to boolean
- pointer/pointer to member/nullptr/NULL to boolean
- boolean expression/literal to integer
- boolean expression/literal to floating

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I3f4bc8902e255d1c85ec57f47d9532ee7326a442

show more ...

clang-tidy: Enable readability-avoid-const-params-in-decls check

Checks whether a function declaration has parameters that are top
level const.
const values in declarations do not affect the signatu

clang-tidy: Enable readability-avoid-const-params-in-decls check

Checks whether a function declaration has parameters that are top
level const.
const values in declarations do not affect the signature of a
function, so they should not be put there.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ic4c2fc0f4ce0ce03fd6621d1f8c928890cf5da88

show more ...

clang-tidy: Enable readability-redundant-member-init check

Finds member initializations that are unnecessary because the same
default constructor would be called if they were not present.

Signed-of

clang-tidy: Enable readability-redundant-member-init check

Finds member initializations that are unnecessary because the same
default constructor would be called if they were not present.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia112636b43360f6a4e14c0a7a80a2635754325c7

show more ...

clang-tidy: Enable readability-static-accessed-through-instance check

Checks for member expressions that access static members through
instances, and replaces them with uses of the appropriate
quali

clang-tidy: Enable readability-static-accessed-through-instance check

Checks for member expressions that access static members through
instances, and replaces them with uses of the appropriate
qualified-id.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I24de8ac8897de839594c6c71319febd0209bbc2e

show more ...

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers readability-static-accessed-through
-instance check as we are trying to access a static member
function through an instance.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I6efe76666f75fb4f65621796466d9347cea25d01

show more ...

clang-tidy: Enable readability-string-compare check

Finds string comparisons using the compare method.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I78c904bca4724e84aa3999d9f34ed66

clang-tidy: Enable readability-string-compare check

Finds string comparisons using the compare method.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I78c904bca4724e84aa3999d9f34ed66b567af984

show more ...

clang-tidy: Enable readability-redundant-access-specifiers check

Finds classes, structs, and unions containing redundant member
(field and method) access specifiers.

Signed-off-by: George Liu <liux

clang-tidy: Enable readability-redundant-access-specifiers check

Finds classes, structs, and unions containing redundant member
(field and method) access specifiers.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I6ce8c84fbab98de5efd6a11804f9dc58afae5027

show more ...

clang-tidy: Enable readability-const-return-type check

Checks for functions with a const-qualified return type and
recommends removal of the const keyword. Such use of const is usually
superfluous,

clang-tidy: Enable readability-const-return-type check

Checks for functions with a const-qualified return type and
recommends removal of the const keyword. Such use of const is usually
superfluous, and can prevent valuable compiler optimizations. Does
not (yet) fix trailing return types.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ifff7541c95d7881d8c6407b20c906ec7eb13abf1

show more ...

clang-tidy: Enable readability checks on repo

The readability-* checks in Clang-Tidy focus on improving code
readability by enforcing guidelines and suggesting improvements
that can enhance the clar

clang-tidy: Enable readability checks on repo

The readability-* checks in Clang-Tidy focus on improving code
readability by enforcing guidelines and suggesting improvements
that can enhance the clarity and maintainability of C++ code.
This enables readability-const-return-type check.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I4253456bcab534ebf1c373988e0a1e5e6cfa1616

show more ...

clang-tidy: Add few cppcoreguidelines check

These checks cover a wide range of best practices and
recommendations aimed at improving the safety, readability,
maintainability, and performance of our

clang-tidy: Add few cppcoreguidelines check

These checks cover a wide range of best practices and
recommendations aimed at improving the safety, readability,
maintainability, and performance of our C++ codebase according
to the C++ Core Guidelines.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Id929229bdb6b42670f178dd24e8005c1168aa31f

show more ...

clang-tidy: Enable performance-faster-string-find check

Optimize calls to std::string::find() and friends when the needle
passed is a single character string literal. The character literal
overload

clang-tidy: Enable performance-faster-string-find check

Optimize calls to std::string::find() and friends when the needle
passed is a single character string literal. The character literal
overload is more efficient.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I7cfc50410d6b6c9057995df8db47084445119d7b

show more ...

clang-tidy: Enable performance-move-const-arg check

The check warns:
- if std::move() is called with a constant argument.
- if std::move() is called with an argument of a trivially-copyable
type.

clang-tidy: Enable performance-move-const-arg check

The check warns:
- if std::move() is called with a constant argument.
- if std::move() is called with an argument of a trivially-copyable
type.
- if the result of std::move() is passed as a const reference
argument.

In all three cases, the check will suggest a fix that removes the
std::move().

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ibaf1050b39bbcaddd27473c6f2009adbfb96125f

show more ...

clang-tidy: Enable performance-for-range-copy check

The check is only applied to loop variables of types that are
expensive to copy which means they are not trivially copyable or have
a non-trivial

clang-tidy: Enable performance-for-range-copy check

The check is only applied to loop variables of types that are
expensive to copy which means they are not trivially copyable or have
a non-trivial copy constructor or destructor.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I9643e396c6bd95bb9bef9037f018fbaf20d506d7

show more ...

clang-tidy: Add performance checks

The checks are valuable for improving the runtime efficiency and
resource utilization of your programs.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-

clang-tidy: Add performance checks

The checks are valuable for improving the runtime efficiency and
resource utilization of your programs.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I04d39729fb764044f7910de0b243974debf5f775

show more ...

clang-tidy: Enable modernize-use-nullptr check

This check converts the usage of null pointer constants
(e.g. NULL, 0) to use the new C++11 and C23 nullptr keyword.

Signed-off-by: George Liu <liuxiw

clang-tidy: Enable modernize-use-nullptr check

This check converts the usage of null pointer constants
(e.g. NULL, 0) to use the new C++11 and C23 nullptr keyword.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I10dccfd0513385c583ca07d13ed71edb04b58853

show more ...

clang-tidy: Enable modernize-use-override check

This check adds override (introduced in C++11) to overridden
virtual functions and removes virtual from those functions as it
is not required.

Signed

clang-tidy: Enable modernize-use-override check

This check adds override (introduced in C++11) to overridden
virtual functions and removes virtual from those functions as it
is not required.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I7ce6bf641dabf4d325a29a1b641e58beac6885bd

show more ...

clang-tidy: Enable modernize-use-emplace check

The check flags insertions to an STL-style container done by
calling the push_back, push, or push_front methods with an
explicitly-constructed temporar

clang-tidy: Enable modernize-use-emplace check

The check flags insertions to an STL-style container done by
calling the push_back, push, or push_front methods with an
explicitly-constructed temporary of the container element type.
In this case, the corresponding emplace equivalent methods result
in less verbose and potentially more efficient code.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I540c22d3d26195a9d1ead57a4322541951c9ff53

show more ...

clang-tidy: Enable modernize-avoid-bind check

The check finds uses of std::bind and boost::bind and replaces them
with lambdas.

Lambdas will use value-capture unless reference capture is explicitly

clang-tidy: Enable modernize-avoid-bind check

The check finds uses of std::bind and boost::bind and replaces them
with lambdas.

Lambdas will use value-capture unless reference capture is explicitly
requested with std::ref or boost::ref.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I4491650a46eaab1588474b26efc622e89232ef02

show more ...