Removed unused header files

Will cause symbol collisions when this repository's local
error yaml is copied out during building so phosphor-logging
includes it in its elog-errors.hpp.

Change-Id: Ic4

Removed unused header files

Will cause symbol collisions when this repository's local
error yaml is copied out during building so phosphor-logging
includes it in its elog-errors.hpp.

Change-Id: Ic467418106d45b6b49b6cabec304c4ae64a3d76b
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Fix fault-monitor interfacesAdded msg parsing

With the latest sdbusplus exception handling changes,
an exception was being thrown when trying to read a pair
out of the interfacesAdded signal message

Fix fault-monitor interfacesAdded msg parsing

With the latest sdbusplus exception handling changes,
an exception was being thrown when trying to read a pair
out of the interfacesAdded signal message.

Change the code to read the path and map separately.

Also modified the name of the data structures to match
what the message actually returned.

Tested: The exception journal entries went away and LEDs
will turn on and off again.

Change-Id: I2c72000e0da365743715da966a0c9e571efd33d5
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Add MAINTAINERS file

Change-Id: If812954f4c391555a17dbb033e4cf8f2c1ef4c77
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Add error handling to message parsing

Some of the messages we try and parse are not structured in the
format we expect when parsing. When error logging is enabled in
sdbusplus this causes the phosph

Add error handling to message parsing

Some of the messages we try and parse are not structured in the
format we expect when parsing. When error logging is enabled in
sdbusplus this causes the phosphor-fru-fault-manager to crash. Fix
this crashing by logging errors and ignoring the bad signals and
message responses.

Change-Id: Ie817beaae96961b33a343aabf1dbba9f31606d4b
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Hide debugging printouts regarding LED assertion

Change the printouts from cout to log<level::DEBUG>
The rest of led manager already logs to phosphor-logging
and only these assertion/deassertion mes

Hide debugging printouts regarding LED assertion

Change the printouts from cout to log<level::DEBUG>
The rest of led manager already logs to phosphor-logging
and only these assertion/deassertion messages were
going to cout.

Change-Id: I9b284221592ac6b48d749acd2f3dfe2d07d4e454
Signed-off-by: Alexander Soldatov <a.soldatov@yadro.com>
Signed-off-by: Alexander Amelkin <a.amelkin@yadro.com>

show more ...

Move down error entry trace

It's possible that multiple services can provide the
/xyz/openbmc_project/logging paths, which means the
interfaces added handler can get multiple callbacks
for a single

Move down error entry trace

It's possible that multiple services can provide the
/xyz/openbmc_project/logging paths, which means the
interfaces added handler can get multiple callbacks
for a single error.

That being the case, move down the trace that shows
the new error log object path until after the code
checks that the association interface is present, as
that interface will only be present on one object.

Another option would have been to remove the trace
completely, but it is fairly useful for debug.

Change-Id: I98659562ef024455762110e20109bf3079b96cbe
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Add .gitignore

Took a .gitignore from another repo and added a few repo
specific items.

Change-Id: I221f6af5662828be73fa1bbab9b9aa8ae24f2085
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Use interfaces-removed for association removes

The mapper will no longer emit properties-changed signals
when the last endpoints property is removed from the fault
association object. It will only e

Use interfaces-removed for association removes

The mapper will no longer emit properties-changed signals
when the last endpoints property is removed from the fault
association object. It will only emit an interfaces-removed
signal in that case, so change the code to subscribe to the
interfaces-removed signal instead.

Change-Id: I225376e550d21b82473015324cd9a261e16fe6db
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I30fd1

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I30fd1f3678a2e0fa1c24f6d5b2c0970903db4596
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Fix a bug in handling LED priority

Change-Id: Idbc2808136f1589e7e4340c336613ece2d069da1
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

Remove incorrect error log when no errors present.

An error was logged while starting the fru fault monitor
with no existing error logs, which is not correct.

Resolves openbmc/openbmc#2330

Change-

Remove incorrect error log when no errors present.

An error was logged while starting the fru fault monitor
with no existing error logs, which is not correct.

Resolves openbmc/openbmc#2330

Change-Id: I6b222b45dd99b653443c58d9982d6576f8af0bfa
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Assert LEDs for existing callouts while service starts

Resolves openbmc/openbmc#1631

Change-Id: I1639c84cbb180dfe7f6494b5e80ca45514a3e730
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.

Assert LEDs for existing callouts while service starts

Resolves openbmc/openbmc#1631

Change-Id: I1639c84cbb180dfe7f6494b5e80ca45514a3e730
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Fix for mapper errors during logging service restart

There was a race condition while calling mapper from led monitoring after
error logs started persisting, to avoid such errors the callout informa

Fix for mapper errors during logging service restart

There was a race condition while calling mapper from led monitoring after
error logs started persisting, to avoid such errors the callout information is
now extracted from the message received as part of interface added signal.

Resolves openbmc/openbmc#1853

Change-Id: Ie913992bdcb3b1cb93677d64331db34202f8ae72
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Throw error if priority of any LED is not same across all groups

An LED can be part of any number of groups. It is a requirement that
the priority of that particular LED is same in all the groups wh

Throw error if priority of any LED is not same across all groups

An LED can be part of any number of groups. It is a requirement that
the priority of that particular LED is same in all the groups where
that LED is a member.

If the input yaml file does not conform to this requirement, compilation
should fail.

Change-Id: I187730e835521d14564495cbe52eb139fc1bd264
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

LEDS: Provide support to override the default Blink priority

In some cases, it is needed that the Solid-ON action over rules
Blink and this patch adds that support.

Change-Id: Ib0a88b11142ccef3e39e

LEDS: Provide support to override the default Blink priority

In some cases, it is needed that the Solid-ON action over rules
Blink and this patch adds that support.

Change-Id: Ib0a88b11142ccef3e39ef0a7c6eb3a037c878bc2
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

parse_led.py: python3 fixes

* iteritems / iterkeys does not exist in python3, use
items / keys directly.
* Order of dicts cannot be relied on.

Change-Id: Ieaf5f58115d4015070d812814d98

parse_led.py: python3 fixes

* iteritems / iterkeys does not exist in python3, use
items / keys directly.
* Order of dicts cannot be relied on.

Change-Id: Ieaf5f58115d4015070d812814d98ca1e58d92ae2
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

use new sdbusplus match constructors

Change-Id: Id833073b9e45fae24d6bd0e7f9310ef0ba8658de
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

Implement led assert and deassert based on faults

Change-Id: I28378b155da15282b1b5bf0403075b55bda5b70d
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

Add class and stub for fru fault monitor application

This application waits for new fault entries and resolution of
exiting faults to assert or deassert LED for the corresponding FRUs,
respectively.

Add class and stub for fru fault monitor application

This application waits for new fault entries and resolution of
exiting faults to assert or deassert LED for the corresponding FRUs,
respectively.

Change-Id: I92ead0c8d3132dd7a6740b536231d6588ac42471
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Fix LED action priority inconsistency

When certain LED is first set to "Blink" and is set to
"ON" again, LED needs to stay "Blink" as opposed to
turning "ON". This is the default behavior needed on

Fix LED action priority inconsistency

When certain LED is first set to "Blink" and is set to
"ON" again, LED needs to stay "Blink" as opposed to
turning "ON". This is the default behavior needed on all
systems unless overridden.

Change-Id: Ied52bb60c538516802b05eb72c139a31499178f5
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

LEDS: Handle empty group

LED group consists of name and the associated LEDs that need to be
actioned on when the group is asserted or de-asserted.

However, its not a hard requirement that all the g

LEDS: Handle empty group

LED group consists of name and the associated LEDs that need to be
actioned on when the group is asserted or de-asserted.

However, its not a hard requirement that all the groups must have the
associated LEDs if the system does not have the usecase.

For example, it is required from the firmware standpoint that the
groups "bmc_booted" and "power_on" be present but not all systems
may have a mapping LED. So in those cases, the group itself can be
in asserted state but without doing anything underneath. Providing
this support will make sure that addition of LEDs into those groups
if needed in the future are handled seamlessly.

Change-Id: I345886a3edbabf11f1e9f5c9de4b9cf28a7c33f6
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

LEDS: Add default LED groups

Regardless of the machine type, there needs to be standard
set of LED groups that would get asserted / de-asserted under
these conditions:

1) BMC booted
2) Power On
3)

LEDS: Add default LED groups

Regardless of the machine type, there needs to be standard
set of LED groups that would get asserted / de-asserted under
these conditions:

1) BMC booted
2) Power On
3) Power Off

This makes sense on hardwares that have physical LEDs.
However, QEMU does not have physical LEDs associated with
the groups but the groups themselves can be in asserted state so
that if physical LEDs are implemented in future, they can be used.

Change-Id: Ie66f5ac59fcdbecb7ba79c4dbcbdc8fceaace42f
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

LEDS: Convert group and led names to lower_case_underscore

This converts the LED group names and LED names from all formats
to lower_case_underscore.

Example : fan0IdentifyTest will become fan0_ide

LEDS: Convert group and led names to lower_case_underscore

This converts the LED group names and LED names from all formats
to lower_case_underscore.

Example : fan0IdentifyTest will become fan0_identify_test

Fixes openbmc/openbmc#1312

Change-Id: Iffa458d593239eb1cb6be0bcda749260cb01c80d
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

LEDS: Get the service names for all physical LED dbus paths at once

Previous code made a call to get the service name for every physical
LED and that was a little costly. This patch changes it to ge

LEDS: Get the service names for all physical LED dbus paths at once

Previous code made a call to get the service name for every physical
LED and that was a little costly. This patch changes it to get the
service names of all the physical LED dbus paths and uses it.

This is done everytime a group of LEDs are to be manipulated.

Fixes openbmc/phosphor-led-manager#4

Change-Id: I5ce455f683a38eae7f9b383013f5729ec7dd7fae
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

Use physical LED actions from generated code

Today's code returned a hardcoded string for physical LED action
and this patch uses the generated string for the passed in action enum

Fixes openbmc/ph

Use physical LED actions from generated code

Today's code returned a hardcoded string for physical LED action
and this patch uses the generated string for the passed in action enum

Fixes openbmc/phosphor-led-manager#2

Change-Id: I960e2d4346966caee526e1a0e8713e18d34b428a
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...