Add a utility script to turn off/on all the indicator LEDs

the script will set Asserted property of all the D-Bus objects
under /xyz/openbmc_project/led/groups/ to true or false

One usecase: IBM ha

Add a utility script to turn off/on all the indicator LEDs

the script will set Asserted property of all the D-Bus objects
under /xyz/openbmc_project/led/groups/ to true or false

One usecase: IBM has a requirement to clean start each power-on
operation by clearing all indicator LEDs. This script will be
used in the power-on sequence.

Change-Id: I8e14d78f15f97094054a9864d5c4291b6814238b
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

configure: replace --enable-use_json by --enable-use-json

For consistency, use hyphen and not a mix of underscore and hyphen

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I106e03b1e00f

configure: replace --enable-use_json by --enable-use-json

For consistency, use hyphen and not a mix of underscore and hyphen

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I106e03b1e00f5b610ea4403b04533e63e8d39485

show more ...

Add storeGroups/restoreGroups method to LED Manager

Use CEREAL to storeGroup/restoreGroups the current state of
asserted groups.
Call storeGroups() when the request comes to add to(remove from)
asse

Add storeGroups/restoreGroups method to LED Manager

Use CEREAL to storeGroup/restoreGroups the current state of
asserted groups.
Call storeGroups() when the request comes to add to(remove from)
asserted group.
Call restoreGroups() as part of starting LED Manager daemon.

Tested: Manually set the Asserted property of each group to true,
after rebooting, all property values tested with the busctl command
are still true.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ibeb1de5f51e3d67e98eeea34764e9efc6d6d8b35

show more ...

Validate the priority of an LED is same

Need to make sure that the priority of a particular LED is the same
across all groups, it needs to throw the std::runtime_error if not
the same.

Tested: Manu

Validate the priority of an LED is same

Need to make sure that the priority of a particular LED is the same
across all groups, it needs to throw the std::runtime_error if not
the same.

Tested: Manually changed the JSON file to have priority of a particular
LED different across groups and saw ledManager throw a runtime exception
and failed to run.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I9d3e788dd86defb9a781dc958976b51ec7d3fd19

show more ...

Fix: Use YAML config by default

Sice the JSON config was added and default, that breaks the
original behavior of taking it from the YAML config, it should
be used by default.

Tested: When `--enable

Fix: Use YAML config by default

Sice the JSON config was added and default, that breaks the
original behavior of taking it from the YAML config, it should
be used by default.

Tested: When `--enable-use_json` was added in phosphor-led-manager_git.bbapped,
the JSON config was used, otherwise, the YAML config was used.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I599db99c132fbf402a262e0ee04b2ece5efb32da

show more ...

Change the key [name] to [Name] in members property

All the other keys start with Uppercase. Changing this to make it
consistent.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ic30f9c3

Change the key [name] to [Name] in members property

All the other keys start with Uppercase. Changing this to make it
consistent.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ic30f9c35ba2c3626e4f565ec166dcc810145eff2

show more ...

build: check for JSON header

Check for the JSON header during configuration.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I3cb85e6b7928ef181070aebfd0cff3ba442d15cb

Update led-manager to use JSON

Current LED manager uses compile time generated led-gen.hpp and creates
DBus objects for the groups.
We would need this changed to use the generated JSON.

Tested: JSO

Update led-manager to use JSON

Current LED manager uses compile time generated led-gen.hpp and creates
DBus objects for the groups.
We would need this changed to use the generated JSON.

Tested: JSON used at runtime when --enable-json given at configure time.
led-gen.hpp not created when using JSON and led-gen.hpp created by
default when using YAML at build time.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I781f8cb090ece8b87730e6c97795624282857c64

show more ...

clang-format: update to latest from docs repo

Since `Cpp11` is an alias for `Latest` and we should tend towards using the
latest C++ standard, udpate the C++ standard to Latest.

https://github.com/

clang-format: update to latest from docs repo

Since `Cpp11` is an alias for `Latest` and we should tend towards using the
latest C++ standard, udpate the C++ standard to Latest.

https://github.com/llvm/llvm-project/commit/e5032567903de19962333c4bf7d2edceaf4f9824#diff-b49a097415dff2837d9626d422c58ba8R82
https://github.com/openbmc/docs/blob/master/style/cpp/.clang-format

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Iaac09e3c11ead581114c4b7e45ff863ec56a63f6

show more ...

string: ensure string included when used

Latest upstream yocto appears to have removed a free include of string.
This is causing compile failures for files which do not include it
properly.

Signed-

string: ensure string included when used

Latest upstream yocto appears to have removed a free include of string.
This is causing compile failures for files which do not include it
properly.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I8df4c564af2c8e8294cdcb3e74f9d7cd106d4ec8

show more ...

sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7b04e16b91dbb6eb229cb2d0d528c56f6b2ea0ba

sdbusplus: remove deprecated variant_ns

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia4b7b6bd27bdcb68cb4ef6399f97966372bf4c2e

Add an example JSON file for LED

Update led-manager to use JSON instead of yaml.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia5b54189a63da71b3d76658f9458593eff735f07

Explicitly point to use python3

Change-Id: Ia2e4c11977cf2ed10958a0624344504ce54685e9
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

Make updates to conform to python3

Ran 2to3 to find the changes needed and consumed them.

Change-Id: I9ccaf94fe2807c65373fc3c4e5c6892ca149e818
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet

Make updates to conform to python3

Ran 2to3 to find the changes needed and consumed them.

Change-Id: I9ccaf94fe2807c65373fc3c4e5c6892ca149e818
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

Add vishwa as Maintainer

Change-Id: Ic59278cd030c1de6d72e6270f43d579e694f5c8f
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

Change to use new association interface

The phosphor-logging code moved from implementing
org.openbmc.Associations to now implementing
xyz.openbmc_project.Association.Definitions. The property name

Change to use new association interface

The phosphor-logging code moved from implementing
org.openbmc.Associations to now implementing
xyz.openbmc_project.Association.Definitions. The property name was also
changed from associations to Associations.

Tested:
Put on a system with existing error log and verified application did not
fail on start up

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I046244039dd8fe663185b981bce875691769a0d8

show more ...

Update the value of Period to D-bus obtained from configuration YAML.

Update the value of Period to D-bus obtained from configuration YAML
when the target group was asserted. The logical behavior
of

Update the value of Period to D-bus obtained from configuration YAML.

Update the value of Period to D-bus obtained from configuration YAML
when the target group was asserted. The logical behavior
of Period is as same as Dutyon.

Change-Id: I4b064f2f7321479cabc7deeaa57779b0a8cc3d21
Signed-off-by: tony lee <tony.lee@quantatw.com>

show more ...

build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ie7747c1a6581742b2256ba2ddaf985df303ec39f

Fix std::variant usage

We need to conform to the std::variant interface for sdbusplus to
eventually switch away from mapbox. The .get() interface is only
provided by mapbox and needs to be converted

Fix std::variant usage

We need to conform to the std::variant interface for sdbusplus to
eventually switch away from mapbox. The .get() interface is only
provided by mapbox and needs to be converted.

Change-Id: Ia41808d6bab73b097fc631fd9eff549be9a22415
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Add clang-format to repo

Add clang-format to repo.

Change-Id: Ib3f81524b66414df3e6c93d8a6df6e22c43841e0
Signed-off-by: Patrick Venture <venture@google.com>

phosphor-led-manager: use c++17

Update configure.ac to choose the c++17 standard

Change-Id: I805dd7d6de5d8be529d48646cec0c815574c281d
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

fault-monitor: Catch GetSubTree exceptions

The C++ implementation of the mapper will throw an exception
if the passed in interface was not found on any paths, which
is expected to happen when fru-f

fault-monitor: Catch GetSubTree exceptions

The C++ implementation of the mapper will throw an exception
if the passed in interface was not found on any paths, which
is expected to happen when fru-fault-monitor checks for error
logs on startup and there aren't any. Catch that exception
and just continue on the path of there being no error logs.

Note this is made slightly more complicated by the fact that the
default constructor for sdbusplus::message is deleted, so one
cannot just do:

sdbusplus::message reply;
try
{
auto method = bus.new_method_call(...);
reply = bus.call(method);
}
...
reply.read(...);

Change-Id: Ic15c7112cbfe0f3df974748f90828f12255ec29a
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Remove trailing slash on path in GetObject call

The upcoming C++ mapper implementation needs it this way.

Tested: With the new mapper and this fix, the call works.

Change-Id: I9b65cb8e12ff0369517

Remove trailing slash on path in GetObject call

The upcoming C++ mapper implementation needs it this way.

Tested: With the new mapper and this fix, the call works.

Change-Id: I9b65cb8e12ff0369517ab82dca0be0fae5ae281c
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Romulus: Handle SdBusError Exceptions

Handle exceptions from the sdbusplus method call_noreply API.

The phosphor-fru-fault-monitor app would fail with the following
message on Romulus with the late

Romulus: Handle SdBusError Exceptions

Handle exceptions from the sdbusplus method call_noreply API.

The phosphor-fru-fault-monitor app would fail with the following
message on Romulus with the latest sdbusplus changes:
sd_bus_call noreply: org.freedesktop.DBus.Error.UnknownObject:
Unknown object '/xyz/openbmc_project/led/groups/core1_fault'.
Add error handling.

Tested: The phosphor-fru-fault-monitor does not core dump on Romulus.

Change-Id: I2bec59c0e0f483e8bfc0cb20a343cb05670212b7
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...