Remove compilation using autotools

The intent behind this commit is build phosphor-led-manager with
meson, So need to remove files related to autotools.

Tested: built phosphor-led-manager successfu

Remove compilation using autotools

The intent behind this commit is build phosphor-led-manager with
meson, So need to remove files related to autotools.

Tested: built phosphor-led-manager successfully and worked.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ib2052b994070e4c913befdd884b6ec0462c639e5

show more ...

configs: rainier: Add cffps2 to group json config file

Some of the Rainier systems have power supply version-1 and hence
their LEDs are represented as /sys/class/leds/cffps1

Similarly, some systems

configs: rainier: Add cffps2 to group json config file

Some of the Rainier systems have power supply version-1 and hence
their LEDs are represented as /sys/class/leds/cffps1

Similarly, some systems have power supply version-2 and hence
their LEDs are represented as /sys/class/leds/cffps2

To patchset enables both configs

Change-Id: I6d8cd336af56734941b5ad307413d525e3e01dcc
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

fault-monitor: Add monitor-opertaional-status to meson.build

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I9ebe31773dc865b4ade9fbca985470d79d7dbe7a

configs: Add all groups configuration JSON through meson.build

Map all directories and JSON files under the configs folder to
/usr/share/phosphor-led-manager.

Currently, the configs file only conta

configs: Add all groups configuration JSON through meson.build

Map all directories and JSON files under the configs folder to
/usr/share/phosphor-led-manager.

Currently, the configs file only contains `rainier-2u` and
`rainier-4u` group configuration JSON files.

Tested: Switch to `meson` to compile ledManager and saw that
rainier-2u and rainier-4u files are mapped to
`/usr/share/phosphor-led-manager`.

~# ls /usr/share/phosphor-led-manager/ibm,rainier-2u
led-group-config.json

~# ls /usr/share/phosphor-led-manager/ibm,rainier-4u
led-group-config.json

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I35e86a911da7bf58825c70ce1e650c3bf0aba126

show more ...

enable shellcheck

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I724f250ab594034376341eff10166e1df1dc133a

led-set-all-groups-asserted: fix shellcheck issues

Fix various issues reported by shellcheck:
- Negative numbers are not valid shell return codes.
- Numorous variables needing quotes to prev

led-set-all-groups-asserted: fix shellcheck issues

Fix various issues reported by shellcheck:
- Negative numbers are not valid shell return codes.
- Numorous variables needing quotes to prevent wordsplits.
- Prefer (( expr )) over let syntax.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8f23138e969a49ee4951aedee5fda22cb19ce217

show more ...

bootstrap: copy latest from phosphor-hwmon

- Add a few Autoconf files created by newer autotools.
- Make minor modifications to file list from phosphor-hwmon
as requested by Vishwa.
- Clea

bootstrap: copy latest from phosphor-hwmon

- Add a few Autoconf files created by newer autotools.
- Make minor modifications to file list from phosphor-hwmon
as requested by Vishwa.
- Clean files recursively since autotools can create files
in subdirectories.
- Fix issues reported by shellcheck.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I74e294b44fc16e69d3d640752e4cdae3309578a1

show more ...

ledManager: Replace IRC with Discord

Discord has more users, IRC traffic has ground to a halt.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I1b32d709ab171c1cf067541bfe7a00e5ccfca935

fault-monitor: Add OperationalStatus Functional monitoring

Currently, the default way is to update the Asserted property of
the LedManager by monitoring the `/xyz/openbmc_project/logging`
object pat

fault-monitor: Add OperationalStatus Functional monitoring

Currently, the default way is to update the Asserted property of
the LedManager by monitoring the `/xyz/openbmc_project/logging`
object path.

The intent behind this commit is to add another way to monitor the
`xyz.openbmc_project.State.Decorator.OperationalStatus` interface
of the Inventory D-Bus object, and check whether the Inventory
D-Bus object is associated with the LED group D-Bus object, and
then update the Asserted property of the LedManager.

Since both these methods handle the faults differently,
Only ONE of these 2 methods can be enabled and NOT both.

The first way is supported by default. To turn OFF the default way
AND turn ON this second way, Enable monitor-operational-status.

Tested:
- enable `monitor-operational-status` in bbappend file, built successfully.

- Before changing the `OperationalStatus` interface:
busctl get-property xyz.openbmc_project.Inventory.Manager
/xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply1
xyz.openbmc_project.State.Decorator.OperationalStatus Functional
b true

busctl get-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/powersupply1_fault
xyz.openbmc_project.Led.Group Asserted
b false

busctl get-property xyz.openbmc_project.LED.Controller.front_psu
/xyz/openbmc_project/led/physical/front_psu xyz.openbmc_project.Led.Physical State
s "xyz.openbmc_project.Led.Physical.Action.Off"

- After changing the `OperationalStatus` interface:
busctl set-property xyz.openbmc_project.Inventory.
/xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply1
xyz.openbmc_project.State.Decorator.OperationalStatus Functional b false

busctl get-property xyz.openbmc_project.Inventory.Manager
/xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply1
xyz.openbmc_project.State.Decorator.OperationalStatus Functional
b false

(
If we have more than 1 LED Group D-Bus object:
Like: The system/chassis/motherboard/powersupply1 path contains
two sets of LEDGroup
{
"types":
{
"rType": "fru",
"fType": "fault_led_group"
},
"paths":
[
"/xyz/openbmc_project/led/groups/powersupply0_fault",
"/xyz/openbmc_project/led/groups/powersupply1_fault"
]
}
busctl get-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/powersupply0_fault xyz.openbmc_project.Led.Group Asserted
b true
)

busctl get-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/powersupply1_fault xyz.openbmc_project.Led.Group Asserted
b true

busctl get-property xyz.openbmc_project.LED.Controller.front_psu
/xyz/openbmc_project/led/physical/front_psu xyz.openbmc_project.Led.Physical State
s "xyz.openbmc_project.Led.Physical.Action.Blink"

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I36c47198168028ea2b55804cf66d0285847afbd4

show more ...

Remove setting Functional property of OperationalStatus interface

Current approach was doing this:
- Get the associated Inventory D-Bus object for the LED group D-Bus
object
- Set Functional

Remove setting Functional property of OperationalStatus interface

Current approach was doing this:
- Get the associated Inventory D-Bus object for the LED group D-Bus
object
- Set Functional property of State.Decorator.OperationalStatus
interface on the Inventory D-Bus object.

However, this approach would enforce the LED associations to be there
in order to set the Operational Status. There is a change in direction
now. With the new direction, LED Manager would :
- Watch for PropertyChanged signal from Inventory.Manager on the
xyz.openbmc_project.State.Decorator.OperationalStatus interface
- Look for the associated LED Group D-Bus object
- Set the asserted property mapping to Functional value.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Iee25acbba8262057a5b4e4f0d93c0b6629c8eb4b

show more ...

Add meson build

This commit is to add meson build.
And later, we will remove Autotools and replace it with meson build.

In addition, fixed Layout::LedAction construct parameter error in test
file.

Add meson build

This commit is to add meson build.
And later, we will remove Autotools and replace it with meson build.

In addition, fixed Layout::LedAction construct parameter error in test
file.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I58c9a2c9de928db288e77ca2d6aa807d36e70144

show more ...

configs: rainier: Add virtual physical LEDs to Fault and Identify groups

These virtual physical LEDs are a mirror of real enclosure fault
and enclosure Identify physical LEDs. However, these virtual

configs: rainier: Add virtual physical LEDs to Fault and Identify groups

These virtual physical LEDs are a mirror of real enclosure fault
and enclosure Identify physical LEDs. However, these virtual LEDs
are needed to be able to communicate the effective state of the
enclosure fault and enclosure identify LEDs during lamp test.

During lamp test, real physical enclosure fault and enclosure id
LEDs should not be updated and they must be updated only after
the lamp test finishes. However, Hypervisors would need to know
the effective state of enclosure level fault and identify
LEDs and that problem is resolved by these virtual LEDs.

Once the lamp test finishes, these virtual physical LEDs would again
be in sync with real enclosure fault and Identify LEDs.

Change-Id: If7b658aeff73e87fd9c176c612b01b41996af5d5
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

lamp test: Add vritual lamp test function

- This feature adds the functionality that enables force updating
certain physical LEDs and skip updating certain physical LEDs as
part of lamp test.

-

lamp test: Add vritual lamp test function

- This feature adds the functionality that enables force updating
certain physical LEDs and skip updating certain physical LEDs as
part of lamp test.

- This is a generic feature that gives more control over handing
physical LEDs.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I6f06ed103b1ceefdaa774b7a74a4a392609000ed

show more ...

lamptest: Add virtual LEDs to group definition

- During LampTest, if a physical LED state has to be changed, the
requirement is that we apply the states after the lamp test is
done. However, the

lamptest: Add virtual LEDs to group definition

- During LampTest, if a physical LED state has to be changed, the
requirement is that we apply the states after the lamp test is
done. However, there is another requirement that expects the
accurate state of LEDs to be reported. virtual physical LEDs
solves this problem.

- If the lamp test is not running, state of virtual_led will be equal
to real physical LED. However, during LampTest, virtual LED would
indicate the effective state of the LED as if there was no lamp
test. Once the lamp test finishes, state of virtual and physical
would be same.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I9489228725577d942dd469312e871c2ee712cd33

show more ...

LampTest: Notify PHYP to start the lamp test

- As part of the lamp test, when the lamp test is started / stoped,
the BMC needs to notify PHYP, so that PHYP can do lamp test on
externally connect

LampTest: Notify PHYP to start the lamp test

- As part of the lamp test, when the lamp test is started / stoped,
the BMC needs to notify PHYP, so that PHYP can do lamp test on
externally connected drawers.
For example: MEX IO drawers.

- Since the command to notify PHYP needs to be completed in the PLDM
daemon, ledManager only needs to update the corresponding D-Bus
interface property value.

Tested:
- Notify PHYP by the host-lamp-test path
busctl set-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/host_lamp_test
xyz.openbmc_project.Led.Group Asserted b true

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I0a0aad91c512183e457903bddb392ee56118f21c

show more ...

Add the restoreLedsAssert method for LED manager

- Logically, Since the physical LEDs states should not be operated
during the lamp test, all the physical LEDs states before and
during the lamp

Add the restoreLedsAssert method for LED manager

- Logically, Since the physical LEDs states should not be operated
during the lamp test, all the physical LEDs states before and
during the lamp test should be saved and restored after the lamp
test.

Tested:
- Store the state of all the physical LEDs before the lamp test,
and keep the state of all the physical LEDs consistent after
the lamp test.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I8b321bae2e38001ea33a80bda8badcf4c8a55040

show more ...

Update physical LEDs as part of Lamp test

- Add the getSubTreePaths method for utils and update all physical
LEDs.

- Uses GetSubTreePath on Physical LED paths and interfaces and
updates all the

Update physical LEDs as part of Lamp test

- Add the getSubTreePaths method for utils and update all physical
LEDs.

- Uses GetSubTreePath on Physical LED paths and interfaces and
updates all the LEDs to ON as part of start or restart of the test.

- When the lamp test is stopped or the timer expires, all the LEDs
are turned OFF.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I27727db62fe963a1a7c8b391d73801bcaf9efeec

show more ...

Add lampTest class for LED

- Add the framework of the lamp test class.

- For the lamp test path in led group, Initiate lamp test when the
Asserted property is true, Stop the lamp test when the As

Add lampTest class for LED

- Add the framework of the lamp test class.

- For the lamp test path in led group, Initiate lamp test when the
Asserted property is true, Stop the lamp test when the Asserted
property is false or the timer expires.

Tested:
- stat lamp test:
busctl set-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/lamp_test
xyz.openbmc_project.Led.Group Asserted b true

- stop lamp test:
busctl set-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/lamp_test
xyz.openbmc_project.Led.Group Asserted b false

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I7e6fe0ffc4679288ab90050742d2680051e61905

show more ...

led-use-json: Use specific config files

- When enabled `led-use-json`, it should use the JsonConfig class to
find the JSON file name, and do not start until JSON config is
found.

- If it has to

led-use-json: Use specific config files

- When enabled `led-use-json`, it should use the JsonConfig class to
find the JSON file name, and do not start until JSON config is
found.

- If it has to wait for the IBMCompatible interface to show up on
D-bus first, it will wait for that.

Tested:
- If there is a `/etc/phosphor-led-manager/led-group-config.json`
path, congfile=/etc/phosphor-led-manager/led-group-config.json
- If there is a `/usr/share/phosphor-led-manager/led-group-config.json`
path and there is not `/etc/phosphor-led-manager/`,
congfile=/usr/share/phosphor-led-manager/led-group-config.json
- If the above two paths do not exist, get the `Name` property of the
`xyz.openbmc_project.Configuration.IBMCompatibleSystem` interface,
congfile=/usr/share/phosphor-led-manager/${Name}/led-group-config.json

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I1528a3d3711ef6b604868387ad42cb3c0afde119

show more ...

config: Add rainier-2u and rainier-4u group configuration json

Change-Id: I072541583d200b5346783a00cc9cbecd3ef401d1
Signed-off-by: Vishwanatha Subbanna <vishwanath@in.ibm.com>

Add the LampTest option

Enable use-lamp-test configuration for LED lamp Test.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ie01eb3c68dbd5c5d30ed00b40a50217a4ec4c668

Add the method to set Functional property based on Group state

When a particular LED Group asserted property is set to true, then the
functional state of that FRU is false and vice-versa. This commi

Add the method to set Functional property based on Group state

When a particular LED Group asserted property is set to true, then the
functional state of that FRU is false and vice-versa. This commit adds
that behavior. Functional status is defined in
xyz.openbmc_project.State.Decorator.OperationalStatus interface.

Tested: When manually set the Asserted property to true by the D-Bus,
we can see that the Functional is updated to false.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I6fa7a4c41363263d345b6b5335056fad15efb78c

show more ...

Add utility for D-Bus

Putting all D-Bus related operation to the utils file.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I934e519bca43b73da01ed09fc73f6c7cdc795e1f

Performance: Ignore request if the group is already in requested state

The existing code did not check if the requested state is same as the
current state of group. However, it did not do any harm.

Performance: Ignore request if the group is already in requested state

The existing code did not check if the requested state is same as the
current state of group. However, it did not do any harm. Just some wasted
processing. This patch ignores such requests.

Change-Id: If4f02cb6d285fceedf1dc7ff45db3153d2ef3e72
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

Makefile: Install scripts/led-set-all-groups-asserted.sh to bindir

Change-Id: I6e349c77d5d94a75bf88f7aec8295ff5d2967eda
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>