yaml: add back support for empty LED groups

The old script had support for empty LED groups. I tried removing the
empty "bmc_booted" LED group, but that caused systemd to never "finish"
booting (sys

yaml: add back support for empty LED groups

The old script had support for empty LED groups. I tried removing the
empty "bmc_booted" LED group, but that caused systemd to never "finish"
booting (systemctl is-system-running returned "starting" because it was
blocked waiting for the "bmc_booted" LED service to start).

This adds back support for empty LED groups.

Tested:
Confirmed that with an empty "bmc_booted" LED group, the firmware will
build successfully and systemd doesn't get blocked waiting for the
"bmc_booted" LED service.

Change-Id: I11d7c50696cd50d989a4eaef28f8e5c43473ce6e
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

config: error on invalid configuration

Since the default led priority is no longer 'Blink', the priority now
has to be explicitly defined when using either group priority or led
priority.

If a conf

config: error on invalid configuration

Since the default led priority is no longer 'Blink', the priority now
has to be explicitly defined when using either group priority or led
priority.

If a configuration does not define the priority, the configuration is
invalid and in the yaml case, phosphor-led-manager should fail to build,
in the json case, the process should exit due to the configuration
error.

The config validation has been extracted into it's own file and made
separate from json config parsing.

So every config will go through the same validation even if its been
created via yaml.

Change-Id: Ifda65942b0768d6c0d3b25076f7a1236b46b3d9f
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

test: unit test parse_led.py

Providing a test for parse_led.py since it was refactored.

Testing that various keys in the yaml are available in the cpp literal.

Change-Id: I94d03eb2a4d2bd3129971c4a

test: unit test parse_led.py

Providing a test for parse_led.py since it was refactored.

Testing that various keys in the yaml are available in the cpp literal.

Change-Id: I94d03eb2a4d2bd3129971c4acbe75edd74449ed4
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

config: allow led priority to be Off

This makes the configuration more flexible and eliminates the edge case.

I don't see why this should not be possible.

Change-Id: I28e33535539b3214e18d781631465

config: allow led priority to be Off

This makes the configuration more flexible and eliminates the edge case.

I don't see why this should not be possible.

Change-Id: I28e33535539b3214e18d7816314656df5d3c370e
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts code
formatter.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If1a2f0afa88f7354f68989b435

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts code
formatter.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If1a2f0afa88f7354f68989b43593efec77d0a1d6

show more ...

Change the key [name] to [Name] in members property

All the other keys start with Uppercase. Changing this to make it
consistent.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ic30f9c3

Change the key [name] to [Name] in members property

All the other keys start with Uppercase. Changing this to make it
consistent.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ic30f9c35ba2c3626e4f565ec166dcc810145eff2

show more ...

Update led-manager to use JSON

Current LED manager uses compile time generated led-gen.hpp and creates
DBus objects for the groups.
We would need this changed to use the generated JSON.

Tested: JSO

Update led-manager to use JSON

Current LED manager uses compile time generated led-gen.hpp and creates
DBus objects for the groups.
We would need this changed to use the generated JSON.

Tested: JSON used at runtime when --enable-json given at configure time.
led-gen.hpp not created when using JSON and led-gen.hpp created by
default when using YAML at build time.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I781f8cb090ece8b87730e6c97795624282857c64

show more ...