yaml: add back support for empty LED groups

The old script had support for empty LED groups. I tried removing the
empty "bmc_booted" LED group, but that caused systemd to never "finish"
booting (sys

yaml: add back support for empty LED groups

The old script had support for empty LED groups. I tried removing the
empty "bmc_booted" LED group, but that caused systemd to never "finish"
booting (systemctl is-system-running returned "starting" because it was
blocked waiting for the "bmc_booted" LED service to start).

This adds back support for empty LED groups.

Tested:
Confirmed that with an empty "bmc_booted" LED group, the firmware will
build successfully and systemd doesn't get blocked waiting for the
"bmc_booted" LED service.

Change-Id: I11d7c50696cd50d989a4eaef28f8e5c43473ce6e
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

clang-tidy: Enable readability-qualified-auto check

This check aims to improve code readability by suggesting the use
of const auto * instead of auto for variables that are pointers
or iterators. Th

clang-tidy: Enable readability-qualified-auto check

This check aims to improve code readability by suggesting the use
of const auto * instead of auto for variables that are pointers
or iterators. This helps clarify the const-ness of the pointed-to
object or container elements.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia132b6dd8ae4e3c16809326f6055396666abc95a

show more ...

clang-tidy: Enable readability-static-accessed-through-instance check

Checks for member expressions that access static members through
instances, and replaces them with uses of the appropriate
quali

clang-tidy: Enable readability-static-accessed-through-instance check

Checks for member expressions that access static members through
instances, and replaces them with uses of the appropriate
qualified-id.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I24de8ac8897de839594c6c71319febd0209bbc2e

show more ...

clang-tidy: Enable modernize-use-override check

This check adds override (introduced in C++11) to overridden
virtual functions and removes virtual from those functions as it
is not required.

Signed

clang-tidy: Enable modernize-use-override check

This check adds override (introduced in C++11) to overridden
virtual functions and removes virtual from those functions as it
is not required.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I7ce6bf641dabf4d325a29a1b641e58beac6885bd

show more ...

clang-tidy: Enable modernize-use-equals-default check

This check replaces default bodies of special member functions
with = default;.

The explicitly defaulted function declarations enable more
oppo

clang-tidy: Enable modernize-use-equals-default check

This check replaces default bodies of special member functions
with = default;.

The explicitly defaulted function declarations enable more
opportunities in optimization, because the compiler might treat
explicitly defaulted functions as trivial.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I1860b4c1f416f892ae224f9fcd83170f1b63043a

show more ...

config: error on invalid configuration

Since the default led priority is no longer 'Blink', the priority now
has to be explicitly defined when using either group priority or led
priority.

If a conf

config: error on invalid configuration

Since the default led priority is no longer 'Blink', the priority now
has to be explicitly defined when using either group priority or led
priority.

If a configuration does not define the priority, the configuration is
invalid and in the yaml case, phosphor-led-manager should fail to build,
in the json case, the process should exit due to the configuration
error.

The config validation has been extracted into it's own file and made
separate from json config parsing.

So every config will go through the same validation even if its been
created via yaml.

Change-Id: Ifda65942b0768d6c0d3b25076f7a1236b46b3d9f
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

test: unit test parse_led.py

Providing a test for parse_led.py since it was refactored.

Testing that various keys in the yaml are available in the cpp literal.

Change-Id: I94d03eb2a4d2bd3129971c4a

test: unit test parse_led.py

Providing a test for parse_led.py since it was refactored.

Testing that various keys in the yaml are available in the cpp literal.

Change-Id: I94d03eb2a4d2bd3129971c4acbe75edd74449ed4
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

test: group priority

Test for the group priority feature. When configuring different groups,
they should overwrite each other based on their priority.

The examples are based on [1]

[1] OCP Panel I

test: group priority

Test for the group priority feature. When configuring different groups,
they should overwrite each other based on their priority.

The examples are based on [1]

[1] OCP Panel Indicator Specification_rev1.0.pdf

Change-Id: I91b96d9dc9307afb1a2abbde6278862045a28355
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

config: allow led priority to be Off

This makes the configuration more flexible and eliminates the edge case.

I don't see why this should not be possible.

Change-Id: I28e33535539b3214e18d781631465

config: allow led priority to be Off

This makes the configuration more flexible and eliminates the edge case.

I don't see why this should not be possible.

Change-Id: I28e33535539b3214e18d7816314656df5d3c370e
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

manager: led priority is optional

The default priority was "Blink" but now the priority is optional.

This helps to implement group priority.
So if someone wants to use group priority they can do so

manager: led priority is optional

The default priority was "Blink" but now the priority is optional.

This helps to implement group priority.
So if someone wants to use group priority they can do so, without the
default led priority getting in the way.

The led priority can still be assigned as "Blink" explicitly if needed.

Change-Id: I9336487bcc2edc0b3308ee76eb5330b8222b7f25
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

config: implement group priority

Enable group priority.

Change-Id: I1777906e60d07420835ede904785071ee308c307
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I47f3c815913ae34be19ce0d823fa233ed698d1a0
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: I4db060ea85cfae7be96693ec04a09829767351a1
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Persistence the led group asserted value by default

Currently, only IBM's P10 machine will persist the Asserted attribute
value of ledGroup by default. But for other systems, most do not need
to per

Persistence the led group asserted value by default

Currently, only IBM's P10 machine will persist the Asserted attribute
value of ledGroup by default. But for other systems, most do not need
to perform persistence actions.

The intent behind this commit is to add a switch to control the
persistence function, and it is enabled by default in CI and disabled
by default in Yocto.

Tested: Regardless of whether `persistent-led-asserted` is enabled or
disabled, the ledmanager process works fine.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I75b59a12dde417a9ccadaf25b2af07fc33186a01

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I918b0a2e9d18c9810ee2940dbe78072754c75a94
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts code
formatter.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If1a2f0afa88f7354f68989b435

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts code
formatter.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If1a2f0afa88f7354f68989b43593efec77d0a1d6

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I223d58649a21565678bd7ef78d955b30d3fd6d84

show more ...

led-layout: use common types everywhere

Rather than scattered map and set typedefs, centralize the two common
structures into 'ledlayout.hpp': ActionSet, GroupMap. Use them
everywhere where previou

led-layout: use common types everywhere

Rather than scattered map and set typedefs, centralize the two common
structures into 'ledlayout.hpp': ActionSet, GroupMap. Use them
everywhere where previous raw maps and sets were used.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0ed5203146a6486a49caf4000f545ded0088dc15

show more ...

switch map to unordered_map

Generally, unordered_maps should be preferred over map because they have
faster access times (O(1)) and tend to allocate less dynamic memory. We
do not rely on ordered i

switch map to unordered_map

Generally, unordered_maps should be preferred over map because they have
faster access times (O(1)) and tend to allocate less dynamic memory. We
do not rely on ordered iteration in any current use of maps, so it is
safe to do a full replace.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ieaa28ac7f70f9913d13d25142fea9861d49bb23f

show more ...

action: use PDI type

Rather than define our own enumeration for the LED Actions,
reuse the one from Led.Physical's dbus interface.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I46

action: use PDI type

Rather than define our own enumeration for the LED Actions,
reuse the one from Led.Physical's dbus interface.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4615bed9e87c61d2632fe790bd50892a7f51e2ab

show more ...

manager: move code to subdirectory

The root has become pretty cluttered. Move code for the primary
manager application to a subdirectory.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change

manager: move code to subdirectory

The root has become pretty cluttered. Move code for the primary
manager application to a subdirectory.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8503cf08c72750c88a5ce94a4d94671d6b59aafb

show more ...

Fix utest-led-json.cpp should not depend on use-json

- The intent behind this commit is to fix the utest-led-json.cpp
should not depend on use-json, because use-json is for production
code and i

Fix utest-led-json.cpp should not depend on use-json

- The intent behind this commit is to fix the utest-led-json.cpp
should not depend on use-json, because use-json is for production
code and it should not affect test code.

Tested: built phosphor-led-manager successfully and Unit Test passes.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia19b68d0167fd8c690ad1b15d29c266e9e77d90b

show more ...

Replace find method with contains method

- The intent behind of this commit is to replace the `find` method
with the `contains` method.

- `contains` is a new feature of C++20, it will check if th

Replace find method with contains method

- The intent behind of this commit is to replace the `find` method
with the `contains` method.

- `contains` is a new feature of C++20, it will check if there is an
element with key equivalent to key in the container and return
true or false.

Tested: built ledManager repo successfully and CI passed.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I09121154983defe051c48e6470a976c5b229a2e7

show more ...

build: Add wrapfiles for dependencies

- Update meson.build and add wrapfiles so that all dependencies are
handled as subprojects.

- This allows builds completely outside of bitbake or an SDK.
r

build: Add wrapfiles for dependencies

- Update meson.build and add wrapfiles so that all dependencies are
handled as subprojects.

- This allows builds completely outside of bitbake or an SDK.
refer: https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-virtual-sensor/+/42349

Tested: built ledManager repo successfully using `meson build`.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I35db603d4aa9c2eee41c3cfb27eba6953950fe44

show more ...

Remove compilation using autotools

The intent behind this commit is build phosphor-led-manager with
meson, So need to remove files related to autotools.

Tested: built phosphor-led-manager successfu

Remove compilation using autotools

The intent behind this commit is build phosphor-led-manager with
meson, So need to remove files related to autotools.

Tested: built phosphor-led-manager successfully and worked.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ib2052b994070e4c913befdd884b6ec0462c639e5

show more ...