yaml: add back support for empty LED groups

The old script had support for empty LED groups. I tried removing the
empty "bmc_booted" LED group, but that caused systemd to never "finish"
booting (sys

yaml: add back support for empty LED groups

The old script had support for empty LED groups. I tried removing the
empty "bmc_booted" LED group, but that caused systemd to never "finish"
booting (systemctl is-system-running returned "starting" because it was
blocked waiting for the "bmc_booted" LED service to start).

This adds back support for empty LED groups.

Tested:
Confirmed that with an empty "bmc_booted" LED group, the firmware will
build successfully and systemd doesn't get blocked waiting for the
"bmc_booted" LED service.

Change-Id: I11d7c50696cd50d989a4eaef28f8e5c43473ce6e
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

config: error on invalid configuration

Since the default led priority is no longer 'Blink', the priority now
has to be explicitly defined when using either group priority or led
priority.

If a conf

config: error on invalid configuration

Since the default led priority is no longer 'Blink', the priority now
has to be explicitly defined when using either group priority or led
priority.

If a configuration does not define the priority, the configuration is
invalid and in the yaml case, phosphor-led-manager should fail to build,
in the json case, the process should exit due to the configuration
error.

The config validation has been extracted into it's own file and made
separate from json config parsing.

So every config will go through the same validation even if its been
created via yaml.

Change-Id: Ifda65942b0768d6c0d3b25076f7a1236b46b3d9f
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

yaml: add --output-filename flag

This helps for testing the script with different yaml files.

Change-Id: I9b29f1159fbf1f38c59b54e28ba7820b0864d68f
Signed-off-by: Alexander Hansen <alexander.hansen@

yaml: add --output-filename flag

This helps for testing the script with different yaml files.

Change-Id: I9b29f1159fbf1f38c59b54e28ba7820b0864d68f
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

yaml: refactor cpp gen, update for group priority

The complete literal was generated in one function.

The cpp gen can be extracted into multiple functions which each
generate the literal for one st

yaml: refactor cpp gen, update for group priority

The complete literal was generated in one function.

The cpp gen can be extracted into multiple functions which each
generate the literal for one struct/object.

Which makes things more readable and easier to work on.

Also updated the script to generate the additional field for the group
priority.

Change-Id: I68b747afb26b76228184fe37f393db37d3f4a502
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I3a5360efb5b6a71d5eabb557accf939cd6abc864
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts code
formatter.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If1a2f0afa88f7354f68989b435

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts code
formatter.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If1a2f0afa88f7354f68989b43593efec77d0a1d6

show more ...

led-layout: use common types everywhere

Rather than scattered map and set typedefs, centralize the two common
structures into 'ledlayout.hpp': ActionSet, GroupMap. Use them
everywhere where previou

led-layout: use common types everywhere

Rather than scattered map and set typedefs, centralize the two common
structures into 'ledlayout.hpp': ActionSet, GroupMap. Use them
everywhere where previous raw maps and sets were used.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0ed5203146a6486a49caf4000f545ded0088dc15

show more ...

parse_led: format with black

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I979949f7f6b3ece3e5e66d0c1e63a351ea7246df

switch map to unordered_map

Generally, unordered_maps should be preferred over map because they have
faster access times (O(1)) and tend to allocate less dynamic memory. We
do not rely on ordered i

switch map to unordered_map

Generally, unordered_maps should be preferred over map because they have
faster access times (O(1)) and tend to allocate less dynamic memory. We
do not rely on ordered iteration in any current use of maps, so it is
safe to do a full replace.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ieaa28ac7f70f9913d13d25142fea9861d49bb23f

show more ...

action: use PDI type

Rather than define our own enumeration for the LED Actions,
reuse the one from Led.Physical's dbus interface.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I46

action: use PDI type

Rather than define our own enumeration for the LED Actions,
reuse the one from Led.Physical's dbus interface.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4615bed9e87c61d2632fe790bd50892a7f51e2ab

show more ...

parse_led: move to scripts subdir

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0607c4dfc90cd564857bba5399b80fbd9a18d996

led-set-all-groups-asserted: fix shellcheck issues

Fix various issues reported by shellcheck:
- Negative numbers are not valid shell return codes.
- Numorous variables needing quotes to prev

led-set-all-groups-asserted: fix shellcheck issues

Fix various issues reported by shellcheck:
- Negative numbers are not valid shell return codes.
- Numorous variables needing quotes to prevent wordsplits.
- Prefer (( expr )) over let syntax.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8f23138e969a49ee4951aedee5fda22cb19ce217

show more ...

Add a utility script to turn off/on all the indicator LEDs

the script will set Asserted property of all the D-Bus objects
under /xyz/openbmc_project/led/groups/ to true or false

One usecase: IBM ha

Add a utility script to turn off/on all the indicator LEDs

the script will set Asserted property of all the D-Bus objects
under /xyz/openbmc_project/led/groups/ to true or false

One usecase: IBM has a requirement to clean start each power-on
operation by clearing all indicator LEDs. This script will be
used in the power-on sequence.

Change-Id: I8e14d78f15f97094054a9864d5c4291b6814238b
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...