clang-tidy: Enable readability-implicit-bool-conversion check

This check can be used to find implicit conversions between
built-in types and booleans.
the following conversion types are checked:
- i

clang-tidy: Enable readability-implicit-bool-conversion check

This check can be used to find implicit conversions between
built-in types and booleans.
the following conversion types are checked:
- integer expression/literal to boolean
- floating expression/literal to boolean
- pointer/pointer to member/nullptr/NULL to boolean
- boolean expression/literal to integer
- boolean expression/literal to floating

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I3f4bc8902e255d1c85ec57f47d9532ee7326a442

show more ...

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers

clang-tidy: Enable readability-convert-member-functions-to-static

This check finds non-static member functions that can be made
static because the functions don’t use this.
This check also triggers readability-static-accessed-through
-instance check as we are trying to access a static member
function through an instance.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I6efe76666f75fb4f65621796466d9347cea25d01

show more ...

clang-tidy: Enable performance-move-const-arg check

The check warns:
- if std::move() is called with a constant argument.
- if std::move() is called with an argument of a trivially-copyable
type.

clang-tidy: Enable performance-move-const-arg check

The check warns:
- if std::move() is called with a constant argument.
- if std::move() is called with an argument of a trivially-copyable
type.
- if the result of std::move() is passed as a const reference
argument.

In all three cases, the check will suggest a fix that removes the
std::move().

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ibaf1050b39bbcaddd27473c6f2009adbfb96125f

show more ...

clang-tidy: Enable modernize-use-nullptr check

This check converts the usage of null pointer constants
(e.g. NULL, 0) to use the new C++11 and C23 nullptr keyword.

Signed-off-by: George Liu <liuxiw

clang-tidy: Enable modernize-use-nullptr check

This check converts the usage of null pointer constants
(e.g. NULL, 0) to use the new C++11 and C23 nullptr keyword.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I10dccfd0513385c583ca07d13ed71edb04b58853

show more ...

clang-tidy: Enable modernize-use-emplace check

The check flags insertions to an STL-style container done by
calling the push_back, push, or push_front methods with an
explicitly-constructed temporar

clang-tidy: Enable modernize-use-emplace check

The check flags insertions to an STL-style container done by
calling the push_back, push, or push_front methods with an
explicitly-constructed temporary of the container element type.
In this case, the corresponding emplace equivalent methods result
in less verbose and potentially more efficient code.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I540c22d3d26195a9d1ead57a4322541951c9ff53

show more ...

clang-tidy: Enable modernize-avoid-bind check

The check finds uses of std::bind and boost::bind and replaces them
with lambdas.

Lambdas will use value-capture unless reference capture is explicitly

clang-tidy: Enable modernize-avoid-bind check

The check finds uses of std::bind and boost::bind and replaces them
with lambdas.

Lambdas will use value-capture unless reference capture is explicitly
requested with std::ref or boost::ref.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I4491650a46eaab1588474b26efc622e89232ef02

show more ...

Add clang-tidy to phosphor-led-manager

This commit enables clang-tidy and adds few tidy checks.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I3a7b41545fef4c726b56aeab3e4b4000dfcac3

Add clang-tidy to phosphor-led-manager

This commit enables clang-tidy and adds few tidy checks.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I3a7b41545fef4c726b56aeab3e4b4000dfcac32f

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I3a5360efb5b6a71d5eabb557accf939cd6abc864
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Reset lamps after reboot

In case lamp test has been triggered and reboot takes place,
even after reboot the lamps are found to be in the on state.

The commit switches off the lamps in case such sit

Reset lamps after reboot

In case lamp test has been triggered and reboot takes place,
even after reboot the lamps are found to be in the on state.

The commit switches off the lamps in case such situation is
found and restores the LEDs to the state in which they were
before lamp test was triggered.

Change-Id: I3d199b7066751e89bd6faffc38af3e36877ca003
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>

show more ...

Resolve issues in lamp test feature

This commit implements the following changes in lamp test

1. Reset lamp test timer on assert to assert case
2. Reject stopping lamp test when there is a request

Resolve issues in lamp test feature

This commit implements the following changes in lamp test

1. Reset lamp test timer on assert to assert case
2. Reject stopping lamp test when there is a request to
deassert lamp test.

Test:
Case 1: Start lamp test (False to True).
Result: 4mins of lamp test execution and Asserted is set back to
false after 4mins.

Case 2: Stop lamp test (False to False).
Result: Lamp test is not performed and Asserted remains false.

Case 3: Stop request when lamp test is still on (True to false)
Result: Stop request not allowed and lamp test continues to execute.
Asserted stays true until the lamp test ends.

Case 4: Retrigger lamp test (True to True).
Result: 4mins timer restarts. Asserted should be back to false after
4mins.

Change-Id: Ib6086f223d5c5ce80b872ed5f35645893ce79cf9
Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ie509bd0c9f5a19db463c4bb51ede752e778439b3
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Use the lower camel case of the C++ standard

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ied901f0cc7cc6606e199dad0e31a35f838c32ab9

lamp test: Fix calling GetSubTreePaths method

The caller should catch the exception when calling the
GetSubTreePaths method to prevent the process coredump

Signed-off-by: George Liu <liuxiwei@inspu

lamp test: Fix calling GetSubTreePaths method

The caller should catch the exception when calling the
GetSubTreePaths method to prevent the process coredump

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I5bd8adb6191fa7f61dabd8be18b1753f4c65c2c5

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I918b0a2e9d18c9810ee2940dbe78072754c75a94
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I223d58649a21565678bd7ef78d955b30d3fd6d84

show more ...

led-layout: use common types everywhere

Rather than scattered map and set typedefs, centralize the two common
structures into 'ledlayout.hpp': ActionSet, GroupMap. Use them
everywhere where previou

led-layout: use common types everywhere

Rather than scattered map and set typedefs, centralize the two common
structures into 'ledlayout.hpp': ActionSet, GroupMap. Use them
everywhere where previous raw maps and sets were used.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0ed5203146a6486a49caf4000f545ded0088dc15

show more ...

action: use PDI type

Rather than define our own enumeration for the LED Actions,
reuse the one from Led.Physical's dbus interface.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I46

action: use PDI type

Rather than define our own enumeration for the LED Actions,
reuse the one from Led.Physical's dbus interface.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4615bed9e87c61d2632fe790bd50892a7f51e2ab

show more ...

manager: move code to subdirectory

The root has become pretty cluttered. Move code for the primary
manager application to a subdirectory.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change

manager: move code to subdirectory

The root has become pretty cluttered. Move code for the primary
manager application to a subdirectory.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8503cf08c72750c88a5ce94a4d94671d6b59aafb

show more ...