#
94e894cb |
| 17-Jun-2024 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Fix spelling mistakes using codespell
This commit corrects various spelling mistakes throughout the repository. The corrections were made automatically using `codespell`[1] tool.
[1]: https://githu
Fix spelling mistakes using codespell
This commit corrects various spelling mistakes throughout the repository. The corrections were made automatically using `codespell`[1] tool.
[1]: https://github.com/codespell-project/codespell
Change-Id: I3a5360efb5b6a71d5eabb557accf939cd6abc864 Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
#
fcf3a9d0 |
| 24-May-2023 |
Priyanga Ramasamy <priyanga24@in.ibm.com> |
LED:Invalid association for fault LED group
The LED fault association group name has been changed from fault_led_group to fault_identifying as a part of this change <https://github.com/openbmc/phosp
LED:Invalid association for fault LED group
The LED fault association group name has been changed from fault_led_group to fault_identifying as a part of this change <https://github.com/openbmc/phosphor-dbus-interfaces/commit /e7c10bd5cdab6cd898e5cad0daab8c1128adc0c8>.
The current code points to the invalid group name. This commit has the fix for it.
Test:
busctl set-property xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/vdd_vrm1 xyz.openbmc_project.State.Decorator.OperationalStatus Functional b false
busctl set-property xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/ebmc_card_bmc xyz.openbmc_project.State.Decorator.OperationalStatus Functional b true
Before the fix: Error traces are found when we try to set Functional property. phosphor-fru-fault-monitor[1180]: Failed to get endpoints property, ERROR = sd_bus_call: xyz.openbmc_project.Common.Error.ResourceNotFound: The resource is not found., PATH = /xyz/openbmc_project/inventory/system/chassis/motherboard/vdd_vrm1/fault_led_group May 31 02:17:32 rain127bmc phosphor-fru-fault-monitor[1180]: The inventory D-Bus object is not associated with the LED group D-Bus object. INVENTORY_PATH = /xyz/openbmc_project/inventory/system/chassis/motherboard/vdd_vrm1
After the fix: No error traces are found and Functional property has been updated.
Change-Id: Ib42c1b496b07ca238e2ba3573064d865e4911711 Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>
show more ...
|
#
3e073ba6 |
| 22-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types. Switch to using them to provide better code clarity and shorter lines. Possible replacements are
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types. Switch to using them to provide better code clarity and shorter lines. Possible replacements are for: * bus_t * exception_t * manager_t * match_t * message_t * object_t * slot_t
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I223d58649a21565678bd7ef78d955b30d3fd6d84
show more ...
|
#
f2044037 |
| 17-Mar-2022 |
Patrick Williams <patrick@stwcx.xyz> |
switch map to unordered_map
Generally, unordered_maps should be preferred over map because they have faster access times (O(1)) and tend to allocate less dynamic memory. We do not rely on ordered i
switch map to unordered_map
Generally, unordered_maps should be preferred over map because they have faster access times (O(1)) and tend to allocate less dynamic memory. We do not rely on ordered iteration in any current use of maps, so it is safe to do a full replace.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ieaa28ac7f70f9913d13d25142fea9861d49bb23f
show more ...
|
#
c5e0f31c |
| 27-Dec-2021 |
George Liu <liuxiwei@inspur.com> |
Fix some warnings by cppcheck
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: Icee0abe2e3130aa225db776efdcd47200eb38f8d
|
#
e9fb5c6a |
| 01-Jul-2021 |
George Liu <liuxiwei@inspur.com> |
logging: switch to lg2 After switching to C++20, it is recommended to use `phosphor::lg2` to format log, and the correct `CODE_LINE` and `CODE_FUNC` values can be used in log trackin
logging: switch to lg2 After switching to C++20, it is recommended to use `phosphor::lg2` to format log, and the correct `CODE_LINE` and `CODE_FUNC` values can be used in log tracking. Tested: built ledManager successfully and Unit Test passes. Before: The file does not exist or is empty After: The file does not exist or is empty, FILE_PATH = /usr/share/phosphor-led-manager/lamp-test-led-overrides.json MESSAGE=File does not exist, FILE_PATH = /var/lib/phosphor-led-manager/savedGroups LOG2_FMTMSG=File does not exist, FILE_PATH = {PATH} CODE_FILE=../../../../../../fp5280g2-workspace/sources/phosphor-led-manager/serialize.cpp CODE_LINE=63 CODE_FUNC=void phosphor::led::Serialize::restoreGroups() PATH=/var/lib/phosphor-led-manager/savedGroups SYSLOG_IDENTIFIER=phosphor-ledmanager _PID=298 _COMM=phosphor-ledman _EXE=/usr/bin/phosphor-ledmanager _CMDLINE=phosphor-ledmanager _SYSTEMD_CGROUP=/system.slice/xyz.openbmc_project.LED.GroupManager.service _SYSTEMD_UNIT=xyz.openbmc_project.LED.GroupManager.service _SYSTEMD_INVOCATION_ID=5ddd4960a3b04fe29c34e4ce03b6be06 Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I5ec8530e0b539bcf8d7d211c802430698aebd343
show more ...
|
#
7152edcf |
| 02-Sep-2021 |
Patrick Williams <patrick@stwcx.xyz> |
exception: switch to public sdbus exception SdBusError was intended to be a private error type inside sdbusplus. Switch all catch locations to use the general sdbusplus::exception type.
exception: switch to public sdbus exception SdBusError was intended to be a private error type inside sdbusplus. Switch all catch locations to use the general sdbusplus::exception type. Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I411acc5238da0ad3d14a963c0d1a3bb4791f23ff
show more ...
|
#
ee1c19e5 |
| 01-Apr-2021 |
George Liu <liuxiwei@inspur.com> |
fault-monitor: Add OperationalStatus Functional monitoring Currently, the default way is to update the Asserted property of the LedManager by monitoring the `/xyz/openbmc_project/logging
fault-monitor: Add OperationalStatus Functional monitoring Currently, the default way is to update the Asserted property of the LedManager by monitoring the `/xyz/openbmc_project/logging` object path. The intent behind this commit is to add another way to monitor the `xyz.openbmc_project.State.Decorator.OperationalStatus` interface of the Inventory D-Bus object, and check whether the Inventory D-Bus object is associated with the LED group D-Bus object, and then update the Asserted property of the LedManager. Since both these methods handle the faults differently, Only ONE of these 2 methods can be enabled and NOT both. The first way is supported by default. To turn OFF the default way AND turn ON this second way, Enable monitor-operational-status. Tested: - enable `monitor-operational-status` in bbappend file, built successfully. - Before changing the `OperationalStatus` interface: busctl get-property xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply1 xyz.openbmc_project.State.Decorator.OperationalStatus Functional b true busctl get-property xyz.openbmc_project.LED.GroupManager /xyz/openbmc_project/led/groups/powersupply1_fault xyz.openbmc_project.Led.Group Asserted b false busctl get-property xyz.openbmc_project.LED.Controller.front_psu /xyz/openbmc_project/led/physical/front_psu xyz.openbmc_project.Led.Physical State s "xyz.openbmc_project.Led.Physical.Action.Off" - After changing the `OperationalStatus` interface: busctl set-property xyz.openbmc_project.Inventory. /xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply1 xyz.openbmc_project.State.Decorator.OperationalStatus Functional b false busctl get-property xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/powersupply1 xyz.openbmc_project.State.Decorator.OperationalStatus Functional b false ( If we have more than 1 LED Group D-Bus object: Like: The system/chassis/motherboard/powersupply1 path contains two sets of LEDGroup { "types": { "rType": "fru", "fType": "fault_led_group" }, "paths": [ "/xyz/openbmc_project/led/groups/powersupply0_fault", "/xyz/openbmc_project/led/groups/powersupply1_fault" ] } busctl get-property xyz.openbmc_project.LED.GroupManager /xyz/openbmc_project/led/groups/powersupply0_fault xyz.openbmc_project.Led.Group Asserted b true ) busctl get-property xyz.openbmc_project.LED.GroupManager /xyz/openbmc_project/led/groups/powersupply1_fault xyz.openbmc_project.Led.Group Asserted b true busctl get-property xyz.openbmc_project.LED.Controller.front_psu /xyz/openbmc_project/led/physical/front_psu xyz.openbmc_project.Led.Physical State s "xyz.openbmc_project.Led.Physical.Action.Blink" Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I36c47198168028ea2b55804cf66d0285847afbd4
show more ...
|