clang-tidy: Enable readability-string-compare check

Finds string comparisons using the compare method.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I78c904bca4724e84aa3999d9f34ed66

clang-tidy: Enable readability-string-compare check

Finds string comparisons using the compare method.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I78c904bca4724e84aa3999d9f34ed66b567af984

show more ...

clang-tidy: Enable performance-faster-string-find check

Optimize calls to std::string::find() and friends when the needle
passed is a single character string literal. The character literal
overload

clang-tidy: Enable performance-faster-string-find check

Optimize calls to std::string::find() and friends when the needle
passed is a single character string literal. The character literal
overload is more efficient.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I7cfc50410d6b6c9057995df8db47084445119d7b

show more ...

readability: remove redundant check before iterate

There were some patterns like

if (collection.size()) {
for(auto& it : collection){
//...
}
}

which is redundant.

Change-Id: I10c

readability: remove redundant check before iterate

There were some patterns like

if (collection.size()) {
for(auto& it : collection){
//...
}
}

which is redundant.

Change-Id: I10c0ad1ecd0aa2e96b456dcf9c5ea4d8995ae016
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

Use the lower camel case of the C++ standard

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ied901f0cc7cc6606e199dad0e31a35f838c32ab9

support sdbusplus::message::object_path

Since lg2 already supports sdbusplus::message::object_path,
it needs to be updated synchronously.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id:

support sdbusplus::message::object_path

Since lg2 already supports sdbusplus::message::object_path,
it needs to be updated synchronously.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I4d81fac0d0acaf069381099e541ce2ac578d632e

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I223d58649a21565678bd7ef78d955b30d3fd6d84

show more ...

switch map to unordered_map

Generally, unordered_maps should be preferred over map because they have
faster access times (O(1)) and tend to allocate less dynamic memory. We
do not rely on ordered i

switch map to unordered_map

Generally, unordered_maps should be preferred over map because they have
faster access times (O(1)) and tend to allocate less dynamic memory. We
do not rely on ordered iteration in any current use of maps, so it is
safe to do a full replace.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ieaa28ac7f70f9913d13d25142fea9861d49bb23f

show more ...

fault-monitor: remove locally generated errors

Switch fault-monitor to use Common.Errors instead of locally defined
ones. This greatly simplifies the build structure and follows the
expected phosph

fault-monitor: remove locally generated errors

Switch fault-monitor to use Common.Errors instead of locally defined
ones. This greatly simplifies the build structure and follows the
expected phosphor-logging patterns better.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Idb3473989c86b3a505f3c0a238735db6f3a4349e

show more ...

Fix some warnings by cppcheck

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Icee0abe2e3130aa225db776efdcd47200eb38f8d

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id11e5c601ff495cd61abd3c35e6558e446e8a7d1

logging: switch to lg2

After switching to C++20, it is recommended to use `phosphor::lg2`
to format log, and the correct `CODE_LINE` and `CODE_FUNC` values
can be used in log trackin

logging: switch to lg2

After switching to C++20, it is recommended to use `phosphor::lg2`
to format log, and the correct `CODE_LINE` and `CODE_FUNC` values
can be used in log tracking.

Tested: built ledManager successfully and Unit Test passes.

Before: The file does not exist or is empty
After: The file does not exist or is empty, FILE_PATH = /usr/share/phosphor-led-manager/lamp-test-led-overrides.json

MESSAGE=File does not exist, FILE_PATH = /var/lib/phosphor-led-manager/savedGroups
LOG2_FMTMSG=File does not exist, FILE_PATH = {PATH}
CODE_FILE=../../../../../../fp5280g2-workspace/sources/phosphor-led-manager/serialize.cpp
CODE_LINE=63
CODE_FUNC=void phosphor::led::Serialize::restoreGroups()
PATH=/var/lib/phosphor-led-manager/savedGroups
SYSLOG_IDENTIFIER=phosphor-ledmanager
_PID=298
_COMM=phosphor-ledman
_EXE=/usr/bin/phosphor-ledmanager
_CMDLINE=phosphor-ledmanager
_SYSTEMD_CGROUP=/system.slice/xyz.openbmc_project.LED.GroupManager.service
_SYSTEMD_UNIT=xyz.openbmc_project.LED.GroupManager.service
_SYSTEMD_INVOCATION_ID=5ddd4960a3b04fe29c34e4ce03b6be06

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I5ec8530e0b539bcf8d7d211c802430698aebd343

show more ...

Handle D-Bus exceptions

Remove the usage of is_method_error()[1].

Also, add try-catch to handle D-Bus exceptions around mapper call.

[1]https://github.com/openbmc/sdbusplus

Handle D-Bus exceptions

Remove the usage of is_method_error()[1].

Also, add try-catch to handle D-Bus exceptions around mapper call.

[1]https://github.com/openbmc/sdbusplus/blob/master/include/sdbusplus/bus.hpp#L282-L286

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Id2b5234009e62e6c003f24a25c726317646b582b

show more ...

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I411acc5238da0ad3d14a963c0d1a3bb4791f23ff

show more ...

Add meson build

This commit is to add meson build.
And later, we will remove Autotools and replace it with meson build.

In addition, fixed Layout::LedAction construct parameter

Add meson build

This commit is to add meson build.
And later, we will remove Autotools and replace it with meson build.

In addition, fixed Layout::LedAction construct parameter error in test
file.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I58c9a2c9de928db288e77ca2d6aa807d36e70144

show more ...

sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7b04e16b91dbb6eb229cb2d0d528c56f6b2ea0ba

sdbusplus: remove deprecated variant_ns

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia4b7b6bd27bdcb68cb4ef6399f97966372bf4c2e

Change to use new association interface

The phosphor-logging code moved from implementing
org.openbmc.Associations to now implementing
xyz.openbmc_project.Association.Definitions. Th

Change to use new association interface

The phosphor-logging code moved from implementing
org.openbmc.Associations to now implementing
xyz.openbmc_project.Association.Definitions. The property name was also
changed from associations to Associations.

Tested:
Put on a system with existing error log and verified application did not
fail on start up

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I046244039dd8fe663185b981bce875691769a0d8

show more ...

Fix std::variant usage

We need to conform to the std::variant interface for sdbusplus to
eventually switch away from mapbox. The .get() interface is only
provided by mapbox and needs

Fix std::variant usage

We need to conform to the std::variant interface for sdbusplus to
eventually switch away from mapbox. The .get() interface is only
provided by mapbox and needs to be converted.

Change-Id: Ia41808d6bab73b097fc631fd9eff549be9a22415
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Add clang-format to repo

Add clang-format to repo.

Change-Id: Ib3f81524b66414df3e6c93d8a6df6e22c43841e0
Signed-off-by: Patrick Venture <venture@google.com>

fault-monitor: Catch GetSubTree exceptions

The C++ implementation of the mapper will throw an exception
if the passed in interface was not found on any paths, which
is expected to h

fault-monitor: Catch GetSubTree exceptions

The C++ implementation of the mapper will throw an exception
if the passed in interface was not found on any paths, which
is expected to happen when fru-fault-monitor checks for error
logs on startup and there aren't any. Catch that exception
and just continue on the path of there being no error logs.

Note this is made slightly more complicated by the fact that the
default constructor for sdbusplus::message is deleted, so one
cannot just do:

sdbusplus::message reply;
try
{
auto method = bus.new_method_call(...);
reply = bus.call(method);
}
...
reply.read(...);

Change-Id: Ic15c7112cbfe0f3df974748f90828f12255ec29a
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Remove trailing slash on path in GetObject call

The upcoming C++ mapper implementation needs it this way.

Tested: With the new mapper and this fix, the call works.

Change-

Remove trailing slash on path in GetObject call

The upcoming C++ mapper implementation needs it this way.

Tested: With the new mapper and this fix, the call works.

Change-Id: I9b65cb8e12ff0369517ab82dca0be0fae5ae281c
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Romulus: Handle SdBusError Exceptions

Handle exceptions from the sdbusplus method call_noreply API.

The phosphor-fru-fault-monitor app would fail with the following
message on R

Romulus: Handle SdBusError Exceptions

Handle exceptions from the sdbusplus method call_noreply API.

The phosphor-fru-fault-monitor app would fail with the following
message on Romulus with the latest sdbusplus changes:
sd_bus_call noreply: org.freedesktop.DBus.Error.UnknownObject:
Unknown object '/xyz/openbmc_project/led/groups/core1_fault'.
Add error handling.

Tested: The phosphor-fru-fault-monitor does not core dump on Romulus.

Change-Id: I2bec59c0e0f483e8bfc0cb20a343cb05670212b7
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Removed unused header files

Will cause symbol collisions when this repository's local
error yaml is copied out during building so phosphor-logging
includes it in its elog-errors.hpp.

Removed unused header files

Will cause symbol collisions when this repository's local
error yaml is copied out during building so phosphor-logging
includes it in its elog-errors.hpp.

Change-Id: Ic467418106d45b6b49b6cabec304c4ae64a3d76b
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Fix fault-monitor interfacesAdded msg parsing

With the latest sdbusplus exception handling changes,
an exception was being thrown when trying to read a pair
out of the interfacesAdde

Fix fault-monitor interfacesAdded msg parsing

With the latest sdbusplus exception handling changes,
an exception was being thrown when trying to read a pair
out of the interfacesAdded signal message.

Change the code to read the path and map separately.

Also modified the name of the data structures to match
what the message actually returned.

Tested: The exception journal entries went away and LEDs
will turn on and off again.

Change-Id: I2c72000e0da365743715da966a0c9e571efd33d5
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Add error handling to message parsing

Some of the messages we try and parse are not structured in the
format we expect when parsing. When error logging is enabled in
sdbusplus this c

Add error handling to message parsing

Some of the messages we try and parse are not structured in the
format we expect when parsing. When error logging is enabled in
sdbusplus this causes the phosphor-fru-fault-manager to crash. Fix
this crashing by logging errors and ignoring the bad signals and
message responses.

Change-Id: Ie817beaae96961b33a343aabf1dbba9f31606d4b
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...