bmc/fs: Replace regex with fs functions

Change-Id: I4a5105ffb587dd1d5532d536c32aab1c933d0968
Signed-off-by: William A. Kennington III <wak@google.com>

bmc/fs: Ignore missing directories

We shouldn't error out for a missing directory, just ignore it as they
don't have to be present.

Change-Id: I00bd66ca079059753480c73587e0ee41941cd7e6
Signed-off-b

bmc/fs: Ignore missing directories

We shouldn't error out for a missing directory, just ignore it as they
don't have to be present.

Change-Id: I00bd66ca079059753480c73587e0ee41941cd7e6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

tools: Fix missing FD close()

Change-Id: Ia244931d2bf634d037e2319e11b477a77898826a
Signed-off-by: William A. Kennington III <wak@google.com>

tools: Make progress bar starting more consistent

Change-Id: I0bfa967efa1c350551dd7b68f9fd72695db638c7
Signed-off-by: William A. Kennington III <wak@google.com>

version-handler/test: Remove unused declarations

Change-Id: If9bc7dd4c58bd9ba3430ffee6319da5ed194cb9f
Signed-off-by: William A. Kennington III <wak@google.com>

handler_config: Split out from buildjson

This allows us to build the version-handler without the json
infrastructure.

Change-Id: I8c0a5715cb66f6cbb3e72cb714759f6e11e3f409
Signed-off-by: William A.

handler_config: Split out from buildjson

This allows us to build the version-handler without the json
infrastructure.

Change-Id: I8c0a5715cb66f6cbb3e72cb714759f6e11e3f409
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

buildjson: Reduce include scope as needed

Change-Id: I8dfa600680fb253cd828f284ff217f35f76c0b46
Signed-off-by: William A. Kennington III <wak@google.com>

util: Fix missing header

Change-Id: Ie4b02a8626195f3147305b6934b763a2090a5f04
Signed-off-by: William A. Kennington III <wak@google.com>

tools/progress: Add finish and abort functions

We have external progress handlers which would like to implement these
functions, in order to update the screen upon completion or error.

Change-Id: I

tools/progress: Add finish and abort functions

We have external progress handlers which would like to implement these
functions, in order to update the screen upon completion or error.

Change-Id: I2df4654d5e2092407a83d2c8bbb020dcce84ac50
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Produce errors for unavailable data

We want to make it clear to the reader that the data is actually
unavailable vs reading outside the bounds of the data space.

Change-Id: Ifb63df

version-handler: Produce errors for unavailable data

We want to make it clear to the reader that the data is actually
unavailable vs reading outside the bounds of the data space.

Change-Id: Ifb63dfe600c268af9e7df24397c28e20316dbb8f
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Add session stat

We need to be able to inform the blob user of the readiness of blob data
and how large the contents are.

Change-Id: Ic90f6e344160b48e7e58cb009558586c7c2fab9b
Signe

version-handler: Add session stat

We need to be able to inform the blob user of the readiness of blob data
and how large the contents are.

Change-Id: Ic90f6e344160b48e7e58cb009558586c7c2fab9b
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version_handler: Support multiple sessions

We want to be able to support multiple concurrent readers of version
information. Otherwise, upstream version checks might fail if they end
up being sequen

version_handler: Support multiple sessions

We want to be able to support multiple concurrent readers of version
information. Otherwise, upstream version checks might fail if they end
up being sequenced concurrently.

Change-Id: I5420ad667622b7906e633562a5373e0be042c0c1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Add callback support to triggerable actions

Change-Id: Icc27fbe9403eda418f41e12c76af7f3216f4b72a
Signed-off-by: William A. Kennington III <wak@google.com>

version_handler: Read doesn't need to catch missing sessions

The read() interface from phosphor-ipmi-blobs will never call read with
an invalid session, so we don't need to catch the exception if th

version_handler: Read doesn't need to catch missing sessions

The read() interface from phosphor-ipmi-blobs will never call read with
an invalid session, so we don't need to catch the exception if the
session doesn't exist.

Change-Id: I2ccb351b85d18a6eb96d4f92cfb3167a95f0509e
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version_handler: Expire shouldn't fail

We want to make sure any sessions which expire are successfully removed,
even if we don't have the session in our map.

Change-Id: I50c7f74509945e29ab3c04ecbcf

version_handler: Expire shouldn't fail

We want to make sure any sessions which expire are successfully removed,
even if we don't have the session in our map.

Change-Id: I50c7f74509945e29ab3c04ecbcf583a1a9ce0c92
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version_handler: Don't store session information immediately

This can cause spurious trigger aborts when open's fail and cleanup is
called on the failed session.

Change-Id: I1c49f248b6f56bbecc0d51f

version_handler: Don't store session information immediately

This can cause spurious trigger aborts when open's fail and cleanup is
called on the failed session.

Change-Id: I1c49f248b6f56bbecc0d51fafaabe871d23b1d7d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

general_systemd: Don't print missing job

It should be safe and not print superfluous error messages when calling
about at any time on a triggerable action.

Change-Id: I966c6a1a7df318fb79ac9695912bd

general_systemd: Don't print missing job

It should be safe and not print superfluous error messages when calling
about at any time on a triggerable action.

Change-Id: I966c6a1a7df318fb79ac9695912bd9c37e59b8af
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Remove superfluous open session check

The phosphor-ipmi-flash API guarantees that calls to open() will not
happen with duplicate session IDs.

Change-Id: Ife88b2743322387e5cc6ebe2b3

version-handler: Remove superfluous open session check

The phosphor-ipmi-flash API guarantees that calls to open() will not
happen with duplicate session IDs.

Change-Id: Ife88b2743322387e5cc6ebe2b34567c3d2d2957a
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Refactor maps to simplify accesses

This reduces the number of map lookups needed for read() and close()
operations and the number of stored strings by referencing the pinned
blobId.

version-handler: Refactor maps to simplify accesses

This reduces the number of map lookups needed for read() and close()
operations and the number of stored strings by referencing the pinned
blobId.

Change-Id: I8c6af5749b8cc8415eedeba484bf4a39a98f0286
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Refactor handler construction

Instead of requiring callers to build maps and info blobs, take the
minimal required amount of information about the blob configuration and
build requi

version-handler: Refactor handler construction

Instead of requiring callers to build maps and info blobs, take the
minimal required amount of information about the blob configuration and
build required datastructures internally.

This reduces the amount of code, and nearly eliminates all of the
untested code in main.cpp.

Change-Id: Iaa398eb404814e9263e6707b71b38a9831d96697
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

buildjson: Remove arbitrary restrictions on HandlerConfig

Don't impose arbitrary restrictions on class construction. Copy
constructors are already deleted due to unique_ptrs being used as
members. T

buildjson: Remove arbitrary restrictions on HandlerConfig

Don't impose arbitrary restrictions on class construction. Copy
constructors are already deleted due to unique_ptrs being used as
members. This allows us to use the implicit initializer list style
constructor.

Change-Id: I306857ac906433d309978f6be94e1b29cbaa9ebc
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Makefile: Consistently use tabs

Change-Id: I312c81a2ceba88c925ef268ca3bc8d74f264768e
Signed-off-by: William A. Kennington III <wak@google.com>

Makefile: Fix code coverage flags

We need to apply CFLAGS and CXXFLAGS to all objects being built, or else
the coverage information will not be complete and correct.

Change-Id: I73b639b2a67037ffa01

Makefile: Fix code coverage flags

We need to apply CFLAGS and CXXFLAGS to all objects being built, or else
the coverage information will not be complete and correct.

Change-Id: I73b639b2a67037ffa01bbc4b50492d8f52d7beab
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version-handler: Remove create special cases

Our builder is validated to not pass invalid configurations to the
handler. Since we can guarantee the invariant that we will never
construct handlers wi

version-handler: Remove create special cases

Our builder is validated to not pass invalid configurations to the
handler. Since we can guarantee the invariant that we will never
construct handlers with null paramemters, we don't need have extra
checks.

Change-Id: I48d24874298c1c5ead74724921c86ea0a022a53c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

version_handlers_builder: Use string references

Change-Id: Iefa4b09c2952eb5f6e7da4509c1a7a39dead9ed7
Signed-off-by: William A. Kennington III <wak@google.com>