handler: Support more retry logic

Add retry logic for more methods that may fail due to unstable
ipmi interfaces. Also added one seconds sleep in between retries to
allow some time for the interface

handler: Support more retry logic

Add retry logic for more methods that may fail due to unstable
ipmi interfaces. Also added one seconds sleep in between retries to
allow some time for the interface to be initialized.

Tested: Updated BMC firmware with the new tool and didn't have any
regression.

Change-Id: Ifc4155dd895f1a654da9e03f17e4c1e8613c9133
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

meson: adjust nlohmann-json dependency

Simplify the dependency logic and align wrap file directives with
other repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I61209bcd

meson: adjust nlohmann-json dependency

Simplify the dependency logic and align wrap file directives with
other repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I61209bcd25995ef447c790e59ad717c1192acbc2

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ie6154ef3394b8e652a8cb1ac33d68e3c3cec8cd8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

tools/pci: refactor did variable for NuvotonPciBridge

Symptom:
Host tool "burn_my_bmc" for in-band firmware update didn't work
and exception is about PCI device cannot find in NPCM8xx platform.

roo

tools/pci: refactor did variable for NuvotonPciBridge

Symptom:
Host tool "burn_my_bmc" for in-band firmware update didn't work
and exception is about PCI device cannot find in NPCM8xx platform.

root@localhost:~#
burn_my_bmc --command update --interface ipmipci --image test.sig
--sig test.sig --type dummy

Sending over the firmware image.
Opening the cleanup blob
Committing to the cleanup blob
Closing cleanup blob
Exception received: Couldn't find supported PCI device

Root cause:
There are new Nuvoton PCI device-id in NPCM8xx platform.
The previous device-id 0x0750 is hardcode for NPCM7xx platform.
However, NPCM8xx PCI device is using new device-id 0x0850.
Thus, host tool will throw the exception from NotFoundException().

Solution:
We need to refactor this "did" variable to make host tool
"burn_my_bmc" can work well for these two kinds of PCI devices.

Tested:
In-band firmware update can work well in NPCM8xx with did change to 0x0850.
Here is the result of "lspci" from host side for refer it.
root@localhost:~# lspci -v | grep d7:
d7:01.0 Unassigned class [ff00]: Winbond Electronics Corp Device 0850 (rev 08)
d7:02.0 Unassigned class [ff00]: Winbond Electronics Corp Device 0850 (rev 08)

Change-Id: I2917298f13b0bcd7de3b2ff71173c546ea3cb02b
Signed-off-by: Tim Lee <timlee660101@gmail.com>

show more ...

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I3393b174da5c6898d10c3948ecdd3e8875b77586

show more ...

README: remove stale reference to span-lite

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I390f4abd653fa1e67f715fc39e2d4695ad18071a

use std::format

Remove use of fmt and replace with the std::format version.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib89de0b3d10866276964db7b3fa8d97991df410d

use std::move_only_function

C++23 has a replacement for function2 in std::move_only_function.
Leverage that and remove the extra dependency.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Chan

use std::move_only_function

C++23 has a replacement for function2 in std::move_only_function.
Leverage that and remove the extra dependency.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I69fa59627b91fc1f640f7a688926bed7f138ca19

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I2abf95de6076e750c0862

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I2abf95de6076e750c086241161edefcd29f298a4
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I2ee8cbc4581d0c3ccdc130b646357c45fa0373db
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: I9d6c273f740a62fdbea64cb29ae6db29b8af19da
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Add retry to sendFile handler

In cases where the ipmi interface is interrupted, we want to be able to
recover automatically without having to retrigger it again. For example,
this may happen if the

Add retry to sendFile handler

In cases where the ipmi interface is interrupted, we want to be able to
recover automatically without having to retrigger it again. For example,
this may happen if the ipminet interface gets reconfigure in the middle
of transfering an image.

The inital goal was to have the retry for ipminet only with and restart
at the remaining data instead of from the beginning. The issue there is
that we needed to restart the ipmi blob session to write again and doing
so will clear out the existing written data. When trying to write to
existing session will caused the update to be stalled and required a
ipmi restart to recover.

Tested:
images is able to be tranfered fully and validated after we interrupted
the ipminet interface in the middle.

Change-Id: Id734f6a92625bc6a1256fea010fb4b068f7bf1d5
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Use 'type' of delete action in the log_handler builder

This was a bug where the 'type' of the open action was being used rather
than using the 'type' in the delete action config.

Tested:
- Created

Use 'type' of delete action in the log_handler builder

This was a bug where the 'type' of the open action was being used rather
than using the 'type' in the delete action config.

Tested:
- Created LogHandler with the following config.
```
{
"blob": "/log/log-blob-name",
"handler": {
"type": "file",
"path": "/var/run/log-blob-file.log"
},
"actions": {
"open": {
"type": "skip"
},
"delete": {
"type": "systemd",
"unit": "log-blob-delete.service"
}
},
```
- Checked log-blob-delete.service was run when blob was deleted

Change-Id: I2e4c783d9b159ad269ef06721d872bb8052af81c
Signed-off-by: Brennan Swanton <brennanswanton@google.com>

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: I5a9a4baad65867173cddcd86872e33ab5fb29128
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: Fix meson builds

When building the project from scratch (from a new workstation without
docker) I found that there were dependencies missing. Fixed them up.

Tested: Was able to build " tools

meson: Fix meson builds

When building the project from scratch (from a new workstation without
docker) I found that there were dependencies missing. Fixed them up.

Tested: Was able to build " tools/" and "bmc/"

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: Id2250c481a37d3cd4ed6915b1b2b0978df6e4649

show more ...

Fix check of onDeleteType in log_handler builder

its a bug in current check, even for delete type we
are checking for `onOpenType`

Signed-off-by: Gaurav Gandhi <gauravgandhi@google.com>
Change-Id:

Fix check of onDeleteType in log_handler builder

its a bug in current check, even for delete type we
are checking for `onOpenType`

Signed-off-by: Gaurav Gandhi <gauravgandhi@google.com>
Change-Id: I8d7b4291d3e2ab9028f3d2f52c1b2ac9e1210b3d

show more ...

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I24e085dcce11a62d70d1dc943c7cf6bcd774a3a2

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie8ecdadfa03f1f7a4a369b6981a360009fe71420

show more ...

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4bf8e2d4d4b5d56fbd778debce0985a61d3b81c0

show more ...

Fix double free issue with global+static variable

Setting defaultConfigPaths as constexpr and std::array allow it to be
destructed cleaning with no issue. Without this the ipmid will triggered
doubl

Fix double free issue with global+static variable

Setting defaultConfigPaths as constexpr and std::array allow it to be
destructed cleaning with no issue. Without this the ipmid will triggered
double free error on cleanups.

Change-Id: I689ce51ecb9a051891e31c50d44d15d74add47ab
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

tools/net: Fix missing include

Change-Id: If8bba23866e6f129f8e9ecdb704f4b06e33a50ec
Signed-off-by: William A. Kennington III <wak@google.com>

tools/net: Handle files which don't support sendfile

This adds a fallback read / write model.

Tested: ran against non-sendfile compatible file and it sent to the BMC successfully.

Change-Id: I6fd7

tools/net: Handle files which don't support sendfile

This adds a fallback read / write model.

Tested: ran against non-sendfile compatible file and it sent to the BMC successfully.

Change-Id: I6fd781ad19cd37376ca90743f799988e50ed460e
Signed-off-by: William A. Kennington III <wak@google.com>
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

span: switch to std

Reduce the dependency on stdplus' version of span now that we are using
C++20 and use the one out of the STL instead.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-

span: switch to std

Reduce the dependency on stdplus' version of span now that we are using
C++20 and use the one out of the STL instead.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I040ba1796d6f278353fbc990ea6b62314927951e

show more ...

phosphor-ipmi-flash: Code Health Cleanup

Removed the following warning.
- using decl '*' is unused
- 'push_back' is called inside a loop; consider pre-allocating the
container capacity before th

phosphor-ipmi-flash: Code Health Cleanup

Removed the following warning.
- using decl '*' is unused
- 'push_back' is called inside a loop; consider pre-allocating the
container capacity before the loop
- function '*' defined in a header file; function
definitions in header files can lead to ODR violations

Change-Id: I44e4b0f8056a853fb45b690394be1a8ebec45b20
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

phosphor-ipmi-flash: remove venture as reviewer

Change-Id: Ic58c5ed65c299a331a1d1009c64a5cd1d01c3cb4
Signed-off-by: Willy Tu <wltu@google.com>