History log of /openbmc/phosphor-ipmi-flash/ (Results 51 – 75 of 631)
Revision Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
b487eb4716-Sep-2021 Willy Tu <wltu@google.com>

phosphor-ipmi-flash: Fix all C++ warnings

Change-Id: I89236b2dab88ca725e269bb8f5b2cbfd271e807a
Signed-off-by: Willy Tu <wltu@google.com>


bmc/firmware-handler/firmware_handler.cpp
bmc/firmware-handler/net_handler.cpp
bmc/firmware-handler/pci_handler.cpp
bmc/firmware-handler/pci_nuvoton_handler.cpp
bmc/firmware-handler/test/firmware_close_unittest.cpp
bmc/firmware-handler/test/firmware_commit_unittest.cpp
bmc/firmware-handler/test/firmware_json_unittest.cpp
bmc/firmware-handler/test/firmware_multiplebundle_unittest.cpp
bmc/firmware-handler/test/firmware_open_unittest.cpp
bmc/firmware-handler/test/firmware_sessionstat_unittest.cpp
bmc/firmware-handler/test/firmware_state_notyetstarted_tarball_unittest.cpp
bmc/firmware-handler/test/firmware_state_uploadinprogress_unittest.cpp
bmc/firmware-handler/test/firmware_unittest.hpp
bmc/firmware-handler/test/firmware_write_unittest.cpp
bmc/firmware-handler/test/firmware_writemeta_unittest.cpp
bmc/version-handler/version_handler.cpp
bmc/version-handler/version_handler.hpp
cleanup/cleanup.cpp
cleanup/cleanup.hpp
tools/pci.hpp
tools/test/tools_bt_unittest.cpp
tools/test/tools_lpc_unittest.cpp
tools/test/tools_pci_unittest.cpp
fd16f6db16-Sep-2021 Willy Tu <wltu@google.com>

helper: Remove alignof for memcpyAligned()

The alignof() is not used properly in memcpyAligned().

It was looking for memcpyAligned(void*) == alignof(std::uint64_t), which
will always be true and do

helper: Remove alignof for memcpyAligned()

The alignof() is not used properly in memcpyAligned().

It was looking for memcpyAligned(void*) == alignof(std::uint64_t), which
will always be true and does not do anything. Replace it with a simple
check instead. Mod the pointer address with the size of uint16_t.

Change-Id: Ia6e8a26ad7cf2dc04510f857965003319aba269a
Signed-off-by: Willy Tu <wltu@google.com>

show more ...


tools/helper.cpp
203ad80409-Sep-2021 Willy Tu <wltu@google.com>

updater: Cleanup Active blob to support multiple stages

Without the change, the update will fail due to existing active blob.
```
./burn_my_bmc --command update --interface ipmipci \
--image test

updater: Cleanup Active blob to support multiple stages

Without the change, the update will fail due to existing active blob.
```
./burn_my_bmc --command update --interface ipmipci \
--image test.txt --sig test.txt --type bios
Sending over the firmware image.
sendFile with /flash/bios and test.txt
Opening the cleanup blob
Committing to the cleanup blob
Closing cleanup blob
Exception received: blob exception received: Received IPMI_CC: 255
```

With the Change, it will delete the active blob to continue the update.
```
./burn_my_bmc --command update --interface ipmipci \
--image test.txt --sig test.txt --type bios
Found an active blob, deleting /flash/active/image
Opening the cleanup blob
Committing to the cleanup blob
Closing cleanup blob
Committing to the cleanup blob
Closing cleanup blob
Sending over the firmware image.
sendFile with /flash/bios and test.txt
000Find [0x1050 0x750]
bar0[0x90100000]
Progress: 100.00%
001Sending over the hash file.
sendFile with /flash/hash and test.txt
000Find [0x1050 0x750]
bar0[0x90100000]
Progress: 100.00%
001Opening the verification file
Committing to /flash/verify to trigger service
Calling stat on /flash/verify session to check status
running
running
failed
Returned non-success (could still be running (unlikely))
failed
Opening the cleanup blob
Committing to the cleanup blob
Closing cleanup blob
Exception received: Verification failed
```

Signed-off-by: Willy Tu <wltu@google.com>
Change-Id: I46a802c7faece60a9b5354db47860e796af99107

show more ...


tools/main.cpp
tools/test/tools_updater_unittest.cpp
tools/updater.cpp
tools/updater.hpp
1c0fe13402-Sep-2021 Patrick Williams <patrick@stwcx.xyz>

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1737844b9bcf1956ae508b149f0c70b4f1ebca52

show more ...


bmc/general_systemd.cpp
4bb6bdf331-Aug-2021 Vivekanand Veeracholan <vveerach@google.com>

tools: Use ipmi-blob-tool definition of blob states

Using phosphor-ipmi-blobs definition for blob states causes dependency
of multiple phosphor packages that are not needed for host side tool.
Defin

tools: Use ipmi-blob-tool definition of blob states

Using phosphor-ipmi-blobs definition for blob states causes dependency
of multiple phosphor packages that are not needed for host side tool.
Definitions are added to ipmi-blob-tool,
https://gerrit.openbmc-project.xyz/c/openbmc/ipmi-blob-tool/+/46240
We can now move to using this.

Signed-off-by: Vivekanand Veeracholan <vveerach@google.com>
Change-Id: If05dbfd740179ab731f9acfc422596b6442fe68d

show more ...


tools/helper.cpp
c620190926-Aug-2021 Vivekanand Veeracholan <vveerach@google.com>

Fix configuration error due to undefined conditionals

If AM_CONDITIONAL is run conditionally, it needs to be run for every
condition. If not, it will cause errors.

Issue: https://github.com/openbmc

Fix configuration error due to undefined conditionals

If AM_CONDITIONAL is run conditionally, it needs to be run for every
condition. If not, it will cause errors.

Issue: https://github.com/openbmc/phosphor-ipmi-flash/issues/8

Signed-off-by: Vivekanand Veeracholan <vveerach@google.com>
Change-Id: I015686e795cb8d4491c839d822e9748cbac0dacb

show more ...


configure.ac
0077e34c07-Jun-2021 Patrik Tesarik <patrik.tesarik@rub.de>

Fix hyperlink typo in README.md

Signed-off-by: Patrik Tesarik <patrik.tesarik@rub.de>
Change-Id: Ia7968ad018e3d9170ac5b99eca16079e5a2dd3ee


README.md
f450486f25-Apr-2021 Willy Tu <wltu@google.com>

test: Replace the C++ MOCK_METHOD<n> macros with the new MOCK_METHOD

Change-Id: I5099c727e9e918f19fa61acc91ef75250ebc6fa6
Signed-off-by: Willy Tu <wltu@google.com>


bmc/firmware-handler/test/crc_mock.hpp
bmc/firmware-handler/test/data_mock.hpp
bmc/firmware-handler/test/window_mapper_mock.hpp
bmc/test/image_mock.hpp
bmc/test/triggerable_mock.hpp
cleanup/test/filesystem_mock.hpp
tools/test/data_interface_mock.hpp
tools/test/internal_sys_mock.hpp
tools/test/io_mock.hpp
tools/test/pciaccess_mock.hpp
tools/test/updater_mock.hpp
a3f6569813-Apr-2021 Patrick Williams <patrick@stwcx.xyz>

bootstrap: fix shellcheck warnings

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I86ef079c9632e5563a1a56d6a2e23aad59ecbc57


bootstrap.sh
2290033d16-Apr-2021 Patrick Venture <venture@google.com>

tools: size_t defined in cstdlib

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I7bac75f4c781038fc8355541a15b469018de9a5a


tools/io_interface.hpp
d6b337e616-Apr-2021 Patrick Venture <venture@google.com>

tools: split io interface out

Splits the io interface out into its own file to decouple the
internal/sys from it.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I65860e32152ef49cd98

tools: split io interface out

Splits the io interface out into its own file to decouple the
internal/sys from it.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I65860e32152ef49cd987c11eb408516e13fadb29

show more ...


tools/io.hpp
tools/io_interface.hpp
tools/test/io_mock.hpp
328f520f16-Mar-2021 Jie Yang <jjy@google.com>

tools/handler: Read the running version

A host tool would read the running firmware version through polling the
version blob state.

Signed-off-by: Jie Yang <jjy@google.com>
Change-Id: I0d68fff6527c

tools/handler: Read the running version

A host tool would read the running firmware version through polling the
version blob state.

Signed-off-by: Jie Yang <jjy@google.com>
Change-Id: I0d68fff6527cd52360abee1cb225a8f228d68392

show more ...


tools/handler.cpp
tools/handler.hpp
tools/helper.cpp
tools/helper.hpp
tools/test/tools_helper_unittest.cpp
tools/test/tools_updater_unittest.cpp
tools/test/updater_mock.hpp
util.hpp
c8b456e019-Mar-2021 Jie Yang <jjy@google.com>

version-handler: remove unused tests

Those tests are repeated in "version_json_unittest.cpp" and never built.

Signed-off-by: Jie Yang <jjy@google.com>
Change-Id: I004237307ef0581f47e8517d5988b755f7

version-handler: remove unused tests

Those tests are repeated in "version_json_unittest.cpp" and never built.

Signed-off-by: Jie Yang <jjy@google.com>
Change-Id: I004237307ef0581f47e8517d5988b755f7d56935

show more ...


c7fa2c2818-Feb-2021 Vivekanand Veeracholan <vveerach@google.com>

tools/pci: Replace memcpy on pci write with aligned copy

memcpy() does unaligned access. Using it for device memory causes
exception (SIGBUS).
Replace the memcpy in PciAccessBridge::write with align

tools/pci: Replace memcpy on pci write with aligned copy

memcpy() does unaligned access. Using it for device memory causes
exception (SIGBUS).
Replace the memcpy in PciAccessBridge::write with aligned copy.

Signed-off-by: Vivekanand Veeracholan <vveerach@google.com>
Change-Id: I8e573715dc8971be547d882ce3cb6de31b2620e4

show more ...


tools/helper.cpp
tools/helper.hpp
tools/pci.cpp
tools/test/tools_helper_unittest.cpp
55b1a71d18-Feb-2021 Vivekanand Veeracholan <vveerach@google.com>

tools/pci: Use pci_device_enable() to enable bridge

Enabling the bridge by writing to the PCI config space does not enable
all the host resources required.
Use pci_device_enable api.

Signed-off-by:

tools/pci: Use pci_device_enable() to enable bridge

Enabling the bridge by writing to the PCI config space does not enable
all the host resources required.
Use pci_device_enable api.

Signed-off-by: Vivekanand Veeracholan <vveerach@google.com>
Change-Id: I159a132b76eadc569efb8fb47488a4abd4c27404

show more ...


tools/pci.cpp
tools/pciaccess.cpp
tools/pciaccess.hpp
tools/test/pciaccess_mock.hpp
tools/test/tools_pci_unittest.cpp
7d39eb0416-Feb-2021 Patrick Venture <venture@google.com>

bmc/ver.../test/.close_unittest: add missing header

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I836986ee7108caa651a374c3f08e96029d01cd9c


bmc/version-handler/test/version_close_unittest.cpp
99b5455910-Feb-2021 Patrick Venture <venture@google.com>

MAINTAINERS: M->R for Venture

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ic04435cc6e9896d704858c815987d75a825a01b3


MAINTAINERS
ab1dfddb09-Feb-2021 Patrick Venture <venture@google.com>

MAINTAINERS: Add William to maintainers

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I1d4a052c111ff49b7029cca7c7afc8f88ba089d8


MAINTAINERS
43344a1b29-Jan-2021 William A. Kennington III <wak@google.com>

bmc: Create runtime directory for non-persistent configs

Change-Id: I32012e7e798bae5a1c5b02e39b32dc40ba3b580a
Signed-off-by: William A. Kennington III <wak@google.com>


bmc/firmware-handler/Makefile.am
bmc/firmware-handler/phosphor-ipmi-flash.conf
configure.ac
22f8bf3329-Jan-2021 William A. Kennington III <wak@google.com>

configure: Refactor systemunitdir expression to use PKG_CHECK_VAR

Change-Id: Ia78044b47d2e01ec2629ba2bc7d8033c0107afb9
Signed-off-by: William A. Kennington III <wak@google.com>


bmc/firmware-handler/Makefile.am
configure.ac
cf11fa6628-Jan-2021 William A. Kennington III <wak@google.com>

buildjson: Add a non-persistent path

This allows users to generate configuration that don't persist to the
SPI or conflict with configs shipped as part of the firmware.

Change-Id: I7de362565387e273

buildjson: Add a non-persistent path

This allows users to generate configuration that don't persist to the
SPI or conflict with configs shipped as part of the firmware.

Change-Id: I7de362565387e2739c09fa4c60ecedd8a7dea5d8
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...


bmc/buildjson.cpp
d0dc723d28-Jan-2021 William A. Kennington III <wak@google.com>

buildjson: Support multiple configuration paths

This will allow us to parse configurations from multiple paths in the
filesystem when they are added.

Right now this does not enable new behavior, bu

buildjson: Support multiple configuration paths

This will allow us to parse configurations from multiple paths in the
filesystem when they are added.

Right now this does not enable new behavior, but a future change will
enable a non-persistent configuration location.

Change-Id: Ifa9bc5eff9cfca84c923be381ec9927c62c2a2e5
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...


bmc/buildjson.cpp
bmc/buildjson.hpp
bmc/firmware-handler/main.cpp
bmc/version-handler/main.cpp
7f16570229-Jan-2021 William A. Kennington III <wak@google.com>

bmc/fs: Replace regex with fs functions

Change-Id: I4a5105ffb587dd1d5532d536c32aab1c933d0968
Signed-off-by: William A. Kennington III <wak@google.com>


bmc/fs.cpp
bfcf132629-Jan-2021 William A. Kennington III <wak@google.com>

bmc/fs: Ignore missing directories

We shouldn't error out for a missing directory, just ignore it as they
don't have to be present.

Change-Id: I00bd66ca079059753480c73587e0ee41941cd7e6
Signed-off-b

bmc/fs: Ignore missing directories

We shouldn't error out for a missing directory, just ignore it as they
don't have to be present.

Change-Id: I00bd66ca079059753480c73587e0ee41941cd7e6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...


bmc/firmware-handler/test/firmware_json_unittest.cpp
bmc/fs.cpp
ebccf63225-Jan-2021 William A. Kennington III <wak@google.com>

tools: Fix missing FD close()

Change-Id: Ia244931d2bf634d037e2319e11b477a77898826a
Signed-off-by: William A. Kennington III <wak@google.com>


tools/bt.cpp
tools/lpc.cpp

12345678910>>...26