meson: Fix meson builds

When building the project from scratch (from a new workstation without
docker) I found that there were dependencies missing. Fixed them up.

Tested: Was able to build " tools

meson: Fix meson builds

When building the project from scratch (from a new workstation without
docker) I found that there were dependencies missing. Fixed them up.

Tested: Was able to build " tools/" and "bmc/"

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: Id2250c481a37d3cd4ed6915b1b2b0978df6e4649

show more ...

Fix check of onDeleteType in log_handler builder

its a bug in current check, even for delete type we
are checking for `onOpenType`

Signed-off-by: Gaurav Gandhi <gauravgandhi@google.com>
Change-Id:

Fix check of onDeleteType in log_handler builder

its a bug in current check, even for delete type we
are checking for `onOpenType`

Signed-off-by: Gaurav Gandhi <gauravgandhi@google.com>
Change-Id: I8d7b4291d3e2ab9028f3d2f52c1b2ac9e1210b3d

show more ...

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I24e085dcce11a62d70d1dc943c7cf6bcd774a3a2

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie8ecdadfa03f1f7a4a369b6981a360009fe71420

show more ...

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4bf8e2d4d4b5d56fbd778debce0985a61d3b81c0

show more ...

Fix double free issue with global+static variable

Setting defaultConfigPaths as constexpr and std::array allow it to be
destructed cleaning with no issue. Without this the ipmid will triggered
doubl

Fix double free issue with global+static variable

Setting defaultConfigPaths as constexpr and std::array allow it to be
destructed cleaning with no issue. Without this the ipmid will triggered
double free error on cleanups.

Change-Id: I689ce51ecb9a051891e31c50d44d15d74add47ab
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

tools/net: Fix missing include

Change-Id: If8bba23866e6f129f8e9ecdb704f4b06e33a50ec
Signed-off-by: William A. Kennington III <wak@google.com>

tools/net: Handle files which don't support sendfile

This adds a fallback read / write model.

Tested: ran against non-sendfile compatible file and it sent to the BMC successfully.

Change-Id: I6fd7

tools/net: Handle files which don't support sendfile

This adds a fallback read / write model.

Tested: ran against non-sendfile compatible file and it sent to the BMC successfully.

Change-Id: I6fd781ad19cd37376ca90743f799988e50ed460e
Signed-off-by: William A. Kennington III <wak@google.com>
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

span: switch to std

Reduce the dependency on stdplus' version of span now that we are using
C++20 and use the one out of the STL instead.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-

span: switch to std

Reduce the dependency on stdplus' version of span now that we are using
C++20 and use the one out of the STL instead.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I040ba1796d6f278353fbc990ea6b62314927951e

show more ...

phosphor-ipmi-flash: Code Health Cleanup

Removed the following warning.
- using decl '*' is unused
- 'push_back' is called inside a loop; consider pre-allocating the
container capacity before th

phosphor-ipmi-flash: Code Health Cleanup

Removed the following warning.
- using decl '*' is unused
- 'push_back' is called inside a loop; consider pre-allocating the
container capacity before the loop
- function '*' defined in a header file; function
definitions in header files can lead to ODR violations

Change-Id: I44e4b0f8056a853fb45b690394be1a8ebec45b20
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

phosphor-ipmi-flash: remove venture as reviewer

Change-Id: Ic58c5ed65c299a331a1d1009c64a5cd1d01c3cb4
Signed-off-by: Willy Tu <wltu@google.com>

Add support for log-handler

This handler is based off of version handler with major differences in
handler_builder

Tested:
created the blackbox blob successfully using this lib.
Read the data from

Add support for log-handler

This handler is based off of version handler with major differences in
handler_builder

Tested:
created the blackbox blob successfully using this lib.
Read the data from the blob using a host side tool

Signed-off-by: Gaurav Gandhi <gauravgandhi@google.com>
Change-Id: I9ef775af752156a1647453ff3831ef4c0449d546

show more ...

bmc: version: Skip version if it does not exist in the config

Change-Id: I1ea876183ff12dab8fc479c45f7b3a9eba50b56f
Signed-off-by: Willy Tu <wltu@google.com>

tools/test: delete now returns a boolean

Updates the test mock expectation to return a boolean.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I8f10a1b561900295b2613317c09de688a4d9d

tools/test: delete now returns a boolean

Updates the test mock expectation to return a boolean.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I8f10a1b561900295b2613317c09de688a4d9d944

show more ...

updater: remove find() and use std::string::starts_with()

Use std::string::starts_with to check for active blob prefix.

Change-Id: I03271c5f19781b522287d09ed8e2882baf68d3e0
Signed-off-by: Willy Tu

updater: remove find() and use std::string::starts_with()

Use std::string::starts_with to check for active blob prefix.

Change-Id: I03271c5f19781b522287d09ed8e2882baf68d3e0
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

build: remove autotool

Change-Id: I662c8a5d29453622744f44c1984416f1303354e6
Signed-off-by: Willy Tu <wltu@google.com>

build: Remove unused phosphor-logging dependency

Change-Id: I4f4e5efc998ed9738a548a353a6bd315ebe5f47c
Signed-off-by: William A. Kennington III <wak@google.com>

build: nuvoton-lpc: Add `NUVOTON_LPC` project_arguments

The `NUVOTON_LPC` is not defined when building for `nuvoton-lpc`
which resulted in the blob loading to fail on the BMC.

Change-Id: I5833855ee

build: nuvoton-lpc: Add `NUVOTON_LPC` project_arguments

The `NUVOTON_LPC` is not defined when building for `nuvoton-lpc`
which resulted in the blob loading to fail on the BMC.

Change-Id: I5833855ee696860ce41b3f136c20060c7638f8df
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

build: Add meson build

Changes to note,
- `with_systemdsystemunitdir` and `with_tmpfilesdir` is removed since it
is not being documented nor used in OpenBMC.
- Removed the Code coverage feature wi

build: Add meson build

Changes to note,
- `with_systemdsystemunitdir` and `with_tmpfilesdir` is removed since it
is not being documented nor used in OpenBMC.
- Removed the Code coverage feature with `-DDHAVE_GCOV`, since it is not
used and meson covers it.
- Removed `--enable-oe-sdk` for using the OpenBMC SDK. It should work
directly with no change required.

Tested:
```
Jan 01 00:01:54 ipmid[709]: Try loading blob from persistent data
Jan 01 00:01:54 ipmid[709]: Stale blob data, resetting internals...
Jan 01 00:01:56 ipmid[709]: config loaded: /flash/bios
Jan 01 00:01:56 ipmid[709]: config loaded: /flash/image
Jan 01 00:01:56 ipmid[709]: config loaded: /flash/dummy
...
```

```
$ ls /usr/lib/blob-ipmid/
libfirmwareblob.so
libfirmwarecleanupblob.so libversionblob.so
```

Testing the service,
```
$ echo "hello" > /tmp/test.txt
$ burn_my_bmc -command update -layout dummy -image /tmp/test.txt
Sending over the firmware image.
Opening the verification file
Committing to /flash/verify to trigger service
Calling stat on /flash/verify session to check status
running
success
Returned success
succeeded
```

On the BMC.
```
/run/initramfs$ cat dummy
hello
```

Change-Id: I21c7c33bd62c0ee40681cb40da90125c125bea2f
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Add OWNERS file

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: If4e599eb7c3a0afb67cabd8a52437f2f693296c3

bmc: remove redundant ‘std::move’ call

```
../bmc/file_handler.cpp:70:21: error: redundant move in return statement [-Werror=redundant-move]
70 | return std::move(ret);
| ~~~

bmc: remove redundant ‘std::move’ call

```
../bmc/file_handler.cpp:70:21: error: redundant move in return statement [-Werror=redundant-move]
70 | return std::move(ret);
| ~~~~~~~~~^~~~~
../bmc/file_handler.cpp:70:21: note: remove ‘std::move’ call
cc1plus: all warnings being treated as errors
```

Change-Id: I07b7ac5c715a53fc5d78cba5dba4aa5b7407304c
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

bmc: Simplify file handler

This greatly reduces the number of checks made against file operations
and fixes an issue with reading 0 length files.

Change-Id: I3d63ad0a3a49d6efbd047baadff3c0fe363b417

bmc: Simplify file handler

This greatly reduces the number of checks made against file operations
and fixes an issue with reading 0 length files.

Change-Id: I3d63ad0a3a49d6efbd047baadff3c0fe363b4174
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

tools: Support more frequent status checks

This changes the check logic to query the BMC more frequently at the
beginning and exponentially back off if the BMC is not yet ready. This
makes short upd

tools: Support more frequent status checks

This changes the check logic to query the BMC more frequently at the
beginning and exponentially back off if the BMC is not yet ready. This
makes short updates significantly faster.

Change-Id: Icfcc1d0c9ef20aa04de754bfe2da04add6ee51e6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

tools/helper: Streamline return types

These functions can already return exceptions, so make better use of
them for reporting failures.

Change-Id: I572e9e3ee44bbd5add601f3246bb4f95cb9308bf
Signed-o

tools/helper: Streamline return types

These functions can already return exceptions, so make better use of
them for reporting failures.

Change-Id: I572e9e3ee44bbd5add601f3246bb4f95cb9308bf
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

tools: Reduce cleanup logging output

We don't need all 3 lines to print, 1 should be sufficient information.

Change-Id: I8034d3a90eee0e2e06377527abd176bd3249a942
Signed-off-by: William A. Kenningto

tools: Reduce cleanup logging output

We don't need all 3 lines to print, 1 should be sufficient information.

Change-Id: I8034d3a90eee0e2e06377527abd176bd3249a942
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...